Skip to contentSkip to conversation

dt-bindings: vendor-prefixes: Add Anvo-Systems

PATCH Superseded Krzysztof Kozlowski 2 participants 12 messages Aug 20, 2019 – Aug 22, 2019

Subsystems (3)

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH v6 1/4 dt-bindings: vendor-prefixes: Add Anvo-Systems

Add vendor prefix for Anvo-Systems Dresden GmbH.

---

Changes since v4:
None

Changes since v3:
1. Add Rob's tag,
2. Remove Admatec (not needed anymore).

Changes since v2:
1. Use admatecde vendor prefix.
2. Add Anvo-Systems Dresden GmbH.

Changes since v1:
New patch

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 6992bbbbffab..519889f5aec8 100644
@@ -81,6 +81,8 @@ patternProperties:
     description: Analogix Semiconductor, Inc.
   "^andestech,.*":
     description: Andes Technology Corporation
+  "^anvo,.*":
+    description: Anvo-Systems Dresden GmbH
   "^apm,.*":
     description: Applied Micro Circuits Corporation (APM)
   "^aptina,.*":
Signature · 1 line
2.7.4
author maintainer
#1 lore raw

PATCH v6 2/4 dt-bindings: eeprom: at25: Add Anvo ANV32E61W

Document the compatible for ANV32E61W 64kb Serial SPI non-volatile SRAM. Although it is a SRAM device, it can be accessed through EEPROM interface. At least until there is no proper SRAM driver support for it.

---

Changes since v4:
1. Update commit msg.

---
 Documentation/devicetree/bindings/eeprom/at25.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/eeprom/at25.txt +1 -0
index b3bde97dc199..42577dd113dd 100644
@@ -3,6 +3,7 @@ EEPROMs (SPI) compatible with Atmel at25.
 Required properties:
 - compatible : Should be "<vendor>,<type>", and generic value "atmel,at25".
   Example "<vendor>,<type>" values:
+    "anvo,anv32e61w"
     "microchip,25lc040"
     "st,m95m02"
     "st,m95256"
Signature · 1 line
2.7.4
author maintainer
#2 lore raw

PATCH v6 3/4 dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

In reply to Krzysztof Kozlowski

Add the compatibles for Kontron i.MX6UL N6310 SoM and boards.

---

Changes since v5:
New patch

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +3 -0
index 7294ac36f4c0..d07b3c06d7cf 100644
@@ -161,6 +161,9 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
+              - kontron,imx6ul-n6310-s    # Kontron N6310 S Board
+              - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board
           - const: fsl,imx6ul
 
       - description: i.MX6ULL based Boards
Signature · 1 line
2.7.4
#3 lore raw

Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

Quoted 18 lines · Krzysztof Kozlowski

Add the compatibles for Kontron i.MX6UL N6310 SoM and boards.

---

Changes since v5:
New patch

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -0
index 7294ac36f4c0..d07b3c06d7cf 100644

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 166

Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +3 -0
@@ -161,6 +161,9 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
+              - kontron,imx6ul-n6310-s    # Kontron N6310 S Board
+              - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board

This doesn't match what is in your dts files. Run 'make dtbs_check' and see.

Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +0 -1
           - const: fsl,imx6ul
 
       - description: i.MX6ULL based Boards
--

2.7.4

author maintainer
#4 lore raw

Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

Quoted 15 lines · Rob Herring
Quoted 13 lines · Krzysztof Kozlowski

Add the compatibles for Kontron i.MX6UL N6310 SoM and boards.

---

Changes since v5:
New patch

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 166

Quoted 11 lines
Documentation/devicetree/bindings/arm/fsl.yaml +3 -0
index 7294ac36f4c0..d07b3c06d7cf 100644
@@ -161,6 +161,9 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
+              - kontron,imx6ul-n6310-s    # Kontron N6310 S Board
+              - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board

This doesn't match what is in your dts files. Run 'make dtbs_check' and see.

You mean the name does not match? I thought that '#' is a comment in YAML...

The dtbs_check fail on missing dt-mk-schema. Any reason why it is not in the scripts?

Best regards,
Krzysztof

#5 lore raw

Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

Quoted 31 lines · Krzysztof Kozlowski
Quoted 15 lines · Rob Herring
Quoted 13 lines · Krzysztof Kozlowski

Add the compatibles for Kontron i.MX6UL N6310 SoM and boards.

---

Changes since v5:
New patch

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 166

Quoted 11 lines
Documentation/devicetree/bindings/arm/fsl.yaml +3 -0
index 7294ac36f4c0..d07b3c06d7cf 100644
@@ -161,6 +161,9 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
+              - kontron,imx6ul-n6310-s    # Kontron N6310 S Board
+              - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board

This doesn't match what is in your dts files. Run 'make dtbs_check' and see.

Quoted 1 line

You mean the name does not match? I thought that '#' is a comment in YAML...

No, the number of compatible strings is the problem.

Quoted 2 lines

The dtbs_check fail on missing dt-mk-schema. Any reason why it is not in the scripts?

Because it is not just that script, but the whole project of scripts, schemas and meta-schemas. Read the instructions in Documentation/devicetree/writing-schema.md(.rst in next).

Rob

author maintainer
#6 lore raw

Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

Quoted 32 lines · Rob Herring
Quoted 31 lines · Krzysztof Kozlowski
Quoted 28 lines · Rob Herring
Quoted 18 lines · Krzysztof Kozlowski

Add the compatibles for Kontron i.MX6UL N6310 SoM and boards.

---

Changes since v5:
New patch

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -0
index 7294ac36f4c0..d07b3c06d7cf 100644

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 166

Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +3 -0
@@ -161,6 +161,9 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
+              - kontron,imx6ul-n6310-s    # Kontron N6310 S Board
+              - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board

This doesn't match what is in your dts files. Run 'make dtbs_check' and see.

Quoted 3 lines
Quoted 1 line

You mean the name does not match? I thought that '#' is a comment in YAML...

No, the number of compatible strings is the problem.

I see. If I understand the schema correctly, this should look like:

Documentation/devicetree/bindings/arm/fsl.yaml +16 -0
index 7294ac36f4c0..eb263d1ccf13 100644
@@ -161,6 +161,22 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
+          - const: fsl,imx6ul
+
+      - description: Kontron N6310 S Board
+        items:
+          - enum:
+              - kontron,imx6ul-n6310-s
+          - const: kontron,imx6ul-n6310-som
+          - const: fsl,imx6ul
+
+      - description: Kontron N6310 S 43 Board
+        items:
+          - enum:
+              - kontron,imx6ul-n6310-s-43
+          - const: kontron,imx6ul-n6310-s
+          - const: kontron,imx6ul-n6310-som
           - const: fsl,imx6ul
 
       - description: i.MX6ULL based Boards

It passes the dtbs_check. Is it correct?

Best regards,
Krzysztof

#7 lore raw

Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

Quoted 34 lines · Krzysztof Kozlowski
Quoted 32 lines · Rob Herring
Quoted 31 lines · Krzysztof Kozlowski
Quoted 28 lines · Rob Herring
Quoted 18 lines · Krzysztof Kozlowski

Add the compatibles for Kontron i.MX6UL N6310 SoM and boards.

---

Changes since v5:
New patch

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -0
index 7294ac36f4c0..d07b3c06d7cf 100644

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 166

Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +3 -0
@@ -161,6 +161,9 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
+              - kontron,imx6ul-n6310-s    # Kontron N6310 S Board
+              - kontron,imx6ul-n6310-s-43 # Kontron N6310 S 43 Board

This doesn't match what is in your dts files. Run 'make dtbs_check' and see.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

You mean the name does not match? I thought that '#' is a comment in YAML...

No, the number of compatible strings is the problem.

I see. If I understand the schema correctly, this should look like:

Looks correct, but a couple of comments.

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 164

Quoted 9 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 7294ac36f4c0..eb263d1ccf13 100644
@@ -161,6 +161,22 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM

Is the SOM ever used alone? If not, then no point in listing this here.

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 170

Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6 -0
+          - const: fsl,imx6ul
+
+      - description: Kontron N6310 S Board
+        items:
+          - enum:
+              - kontron,imx6ul-n6310-s

This could be a 'const' instead. It depends if you think there will ever be more than one entry.

Quoted 19 lines
Documentation/devicetree/bindings/arm/fsl.yaml +9 -0
+          - const: kontron,imx6ul-n6310-som
+          - const: fsl,imx6ul
+
+      - description: Kontron N6310 S 43 Board
+        items:
+          - enum:
+              - kontron,imx6ul-n6310-s-43
+          - const: kontron,imx6ul-n6310-s
+          - const: kontron,imx6ul-n6310-som
           - const: fsl,imx6ul
 
       - description: i.MX6ULL based Boards

It passes the dtbs_check. Is it correct?

Best regards,
Krzysztof

author maintainer
#8 lore raw

Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

Quoted 4 lines · Rob Herring
Quoted 1 line

I see. If I understand the schema correctly, this should look like:

Looks correct, but a couple of comments.

Quoted 11 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 164

Quoted 9 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 7294ac36f4c0..eb263d1ccf13 100644
@@ -161,6 +161,22 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM

Is the SOM ever used alone? If not, then no point in listing this here.

SoM alone: no, because it requires some type of base board. However it will be used by some customer designs with some amount of changes/addons.

Looking at other aproaches, usually SoMs have their own compatible. In such case - I should document it somewhere.

Quoted 10 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 170

Quoted 7 lines
Documentation/devicetree/bindings/arm/fsl.yaml +6 -0
+          - const: fsl,imx6ul
+
+      - description: Kontron N6310 S Board
+        items:
+          - enum:
+              - kontron,imx6ul-n6310-s

This could be a 'const' instead. It depends if you think there will ever be more than one entry.

Indeed, I'll make this and entry below for S 43 board const.

Best regards,
Krzysztof

#9 lore raw

Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

Quoted 18 lines · Krzysztof Kozlowski
Quoted 4 lines · Rob Herring
Quoted 1 line

I see. If I understand the schema correctly, this should look like:

Looks correct, but a couple of comments.

Quoted 11 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 164

Quoted 9 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 7294ac36f4c0..eb263d1ccf13 100644
@@ -161,6 +161,22 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM

Is the SOM ever used alone? If not, then no point in listing this here.

Quoted 6 lines

SoM alone: no, because it requires some type of base board. However it will be used by some customer designs with some amount of changes/addons.

Looking at other aproaches, usually SoMs have their own compatible. In such case - I should document it somewhere.

I wasn't suggesting not having the compatible for it, but you don't need it in this list because that is not valid. You have to list it with the base board compatibles.

Rob

author maintainer
#10 lore raw

Re: [PATCH v6 3/4] dt-bindings: arm: fsl: Add Kontron i.MX6UL N6310 compatibles

Quoted 24 lines · Rob Herring
Quoted 22 lines · Krzysztof Kozlowski
Quoted 4 lines · Rob Herring
Quoted 1 line

I see. If I understand the schema correctly, this should look like:

Looks correct, but a couple of comments.

Quoted 11 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 164

Quoted 9 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 7294ac36f4c0..eb263d1ccf13 100644
@@ -161,6 +161,22 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
+              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM

Is the SOM ever used alone? If not, then no point in listing this here.

SoM alone: no, because it requires some type of base board. However it will be used by some customer designs with some amount of changes/addons.

Quoted 6 lines
Quoted 2 lines

Looking at other aproaches, usually SoMs have their own compatible. In such case - I should document it somewhere.

I wasn't suggesting not having the compatible for it, but you don't need it in this list because that is not valid. You have to list it with the base board compatibles.

The diff against v7 would be like this then:
---

(quoted diff) +0 -0

b/Documentation/devicetree/bindings/arm/fsl.yaml
index 1f440817fc03..7219c15f6185 100644

Documentation/devicetree/bindings/arm/fsl.yaml +0 -1
@@ -161,7 +161,6 @@ properties:
         items:
           - enum:
               - fsl,imx6ul-14x14-evk      # i.MX6 UltraLite 14x14 EVK Board
-              - kontron,imx6ul-n6310-som  # Kontron N6310 SOM
           - const: fsl,imx6ul
 
       - description: Kontron N6310 S Board

---

This passes the dtbs_check.

I'll send v8

author maintainer
#11 lore raw

PATCH v6 4/4 ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards

In reply to Krzysztof Kozlowski

Add support for i.MX6UL modules from Kontron Electronics GmbH (before
acquisition: Exceet Electronics) and evalkit boards based on it:

1. N6310 SOM: i.MX6 UL System-on-Module, a 25x25 mm solderable module (LGA pads and pin castellations) with 256 MB RAM, 1 MB NOR-Flash, 256 MB NAND and other interfaces,
2. N6310 S: evalkit, w/wo eMMC, without display,
3. N6310 S 43: evalkit with 4.3" display,

The work is based on Exceet/Kontron source code (GPLv2) with numerous changes:
1. Reorganize files,
2. Rename Exceet -> Kontron,
3. Rename models/compatibles to match newest Kontron product naming,
4. Fix coding style errors and adjust to device tree coding guidelines,
5. Fix DTC warnings,
6. Extend compatibles so eval boards inherit the SoM compatible,
7. Use defines instead of GPIO and interrupt flag values,
8. Use proper vendor compatible for Macronix SPI NOR,
9. Replace deprecated bindings with proper ones,
10. Sort nodes alphabetically,
11. Remove Admatec display nodes (not yet supported).

---

Changes since v5:
1. Split Documentation/devicetree/bindings/arm/fsl.yaml update to separate patch.

Changes since v4:
1. Split Documentation/devicetree/bindings/eeprom/at25.txt update to separate patch.

Changes since v3, after Shawn's review:
1. Split bindings update to patch 2/3,
2. Remove unsupported displays from (Admatec),
3. Remove N6310 S 50 board (same as N6310 S 43 since there is no Admatec display),
4. Order iomux nodes by name, minor cleanup,
5. Use wakeup-source instead of enable-sdio-wakeup,
6. Add review tags.

Changes since v2, after Fabio's review:
1. Add "imx6ul" compatible to board name (that's what I understood from review),
2. Add vendor/device prefix to eeprom and document the compatible,
3. Use "admatecde" as vendor compatible to avoid confusion with Admatec AG in Switzerland (also making LCD panels),
4. Use generic names for nodes,
5. Use IRQ_TYPE_LEVEL_LOW,
6. Move iomux to the end of files,
7. Remove regulators node (include regulators in top level),
8. Remove cpu clock-frequency,
9. Other minor fixes pointed by Fabio.

Changes since v1, after Frieder's review:
1. Remove unneeded license notes,
2. Add Kontron copyright (2018),
3. Rename the files/models/compatibles to new naming - N6310,
4. Remove unneeded CPU operating points override,
5. Switch regulator nodes into simple children nodes without addresses (so not simple bus),
6. Use proper vendor compatible for Macronix SPI NOR.

---
 arch/arm/boot/dts/Makefile                      |   2 +
 arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts | 102 ++++++
 arch/arm/boot/dts/imx6ul-kontron-n6310-s.dts    | 420 ++++++++++++++++++++++++
 arch/arm/boot/dts/imx6ul-kontron-n6310-som.dtsi | 134 ++++++++
 4 files changed, 658 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
 create mode 100644 arch/arm/boot/dts/imx6ul-kontron-n6310-s.dts
 create mode 100644 arch/arm/boot/dts/imx6ul-kontron-n6310-som.dtsi
arch/arm/boot/dts/Makefile +2 -0
index 9159fa2cea90..747eef501f95 100644
@@ -569,6 +569,8 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
 	imx6ul-geam.dtb \
 	imx6ul-isiot-emmc.dtb \
 	imx6ul-isiot-nand.dtb \
+	imx6ul-kontron-n6310-s.dtb \
+	imx6ul-kontron-n6310-s-43.dtb \
 	imx6ul-liteboard.dtb \
 	imx6ul-opos6uldev.dtb \
 	imx6ul-pico-hobbit.dtb \
arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts new file +102 -0

102 lines not on this page · raw message

arch/arm/boot/dts/imx6ul-kontron-n6310-s.dts new file +420 -0

420 lines not on this page · raw message

arch/arm/boot/dts/imx6ul-kontron-n6310-som.dtsi new file +134 -0

134 lines not on this page · raw message

Signature · 1 line
2.7.4