Skip to contentSkip to conversation

drm/amd/amdgpu: Modify sdma instance number

PATCH NAK Gang Ba 2 participants 2 messages Aug 21, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Gang Ba

author
#0 lore raw

PATCH 1/1 drm/amd/amdgpu: Modify sdma instance number

To upgrade performance in small bar mode, set sdma buffer function ring and pte function ring to use different instance.

Change-Id Ida6377914eb68a188f745e63409f344f0ce1a8c4
---
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +1 -1
index 071d6c9..5aca9bb4a 100644
@@ -2500,7 +2500,7 @@ static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
 {
 	adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
 	if (adev->sdma.has_page_queue && adev->sdma.num_instances > 1)
-		adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
+		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
 	else
 		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
 }
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1566397966-4357-1-git-send-email-gaba-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 21.08.19 um 16:32 schrieb Gang Ba:

Quoted 2 lines

To upgrade performance in small bar mode, set sdma buffer function ring and pte function ring to use different instance.

NAK, we intentionally reserved the first paging queue here.

I wanted to revert that as well, but in this case you would need to revert the whole patch and not just this change.

Just look for the patch adding that line and completely revert it instead.

Regards,
Christian.

Quoted 12 lines
Change-Id Ida6377914eb68a188f745e63409f344f0ce1a8c4
---
  drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +0 -0
index 071d6c9..5aca9bb4a 100644

drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev) · line 2506

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +1 -1
@@ -2500,7 +2500,7 @@ static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
  {
  	adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
  	if (adev->sdma.has_page_queue && adev->sdma.num_instances > 1)
-		adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
+		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
  	else
  		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
  }

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx