Skip to contentSkip to conversation

iio: imu: st_lsm6dsx: Fix FIFO diff mask for tagged fifo

PATCH In review Mario Tesi 3 participants 4 messages Aug 22, 2019 – Aug 26, 2019

Subsystems (2)
lore
Share & tools
lore

Mario Tesi

author
#0 lore raw

PATCH 1/1 iio: imu: st_lsm6dsx: Fix FIFO diff mask for tagged fifo

From: mario tesi <[email protected]>

According to the latest version of datasheet the mask for number of unread sensor data in FIFO_STATUS registers has been extended to 10 bits

The devices involved are:
- LSM6DSO
- LSM6DSOX
- ASM330LHH
- LSM6DSR
- ISM330DHCX

---
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +3 -3
index 85824d6..47b77d0 100644
@@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
@@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
@@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 6 lines · On Thu, 22 Aug 2019 15:22:19 +0200 Mario Tesi <[email protected]> wrote:

From: mario tesi <[email protected]>

According to the latest version of datasheet the mask for number of unread sensor data in FIFO_STATUS registers has been extended to 10 bits

Quoted 8 lines

The devices involved are:
- LSM6DSO
- LSM6DSOX
- ASM330LHH
- LSM6DSR
- ISM330DHCX

Seems straight forward and should be side effect free I think. Hence I won't wait for Lorenzo to take a look (though there is still a small window for comments whilst the autobuilders poke at it!)

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to take a look.

Thanks,

Jonathan

Quoted 35 lines
---
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +3 -3
index 85824d6..47b77d0 100644
@@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
@@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
@@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
maintainer Acked-by
#2 lore raw
Quoted 23 lines
Quoted 6 lines · On Thu, 22 Aug 2019 15:22:19 +0200 Mario Tesi <[email protected]> wrote:

From: mario tesi <[email protected]>

According to the latest version of datasheet the mask for number of unread sensor data in FIFO_STATUS registers has been extended to 10 bits

Quoted 8 lines

The devices involved are:
- LSM6DSO
- LSM6DSOX
- ASM330LHH
- LSM6DSR
- ISM330DHCX

Seems straight forward and should be side effect free I think. Hence I won't wait for Lorenzo to take a look (though there is still a small window for comments whilst the autobuilders poke at it!)

Quoted 4 lines

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to take a look.

Thanks,

Quoted 39 lines

Jonathan

Quoted 35 lines
---
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +3 -3
index 85824d6..47b77d0 100644
@@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
@@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
@@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
maintainer
#3 lore raw
Quoted 23 lines · On Mon, 26 Aug 2019 10:22:20 +0200 Lorenzo Bianconi <[email protected]> wrote:
Quoted 23 lines
Quoted 6 lines · On Thu, 22 Aug 2019 15:22:19 +0200 Mario Tesi <[email protected]> wrote:

From: mario tesi <[email protected]>

According to the latest version of datasheet the mask for number of unread sensor data in FIFO_STATUS registers has been extended to 10 bits

Quoted 8 lines

The devices involved are:
- LSM6DSO
- LSM6DSOX
- ASM330LHH
- LSM6DSR
- ISM330DHCX

Seems straight forward and should be side effect free I think. Hence I won't wait for Lorenzo to take a look (though there is still a small window for comments whilst the autobuilders poke at it!)

Quoted 6 lines
Quoted 4 lines

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to take a look.

Thanks,

Nice. That was fast enough that I haven't applied any patches on top of Mario's yet so a quick git --amend job ;)

Thanks,

Jonathan

Quoted 40 lines
Quoted 40 lines

Jonathan

Quoted 35 lines
---
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +3 -3
index 85824d6..47b77d0 100644
@@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
@@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},
@@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
 			},
 			.fifo_diff = {
 				.addr = 0x3a,
-				.mask = GENMASK(8, 0),
+				.mask = GENMASK(9, 0),
 			},
 			.th_wl = 1,
 		},