Skip to contentSkip to conversation

media: platform: Add support for Digital Image Processing (DIP) on mt8183 SoC

RFC PATCH Superseded frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected] 5 participants 14 messages Jul 8, 2019 – Sep 10, 2019 3 messages not in the archive

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover media: platform: Add support for Digital Image Processing (DIP) on mt8183 SoC

Hello,

This RFC patch series added Digital Image Processing (DIP) driver on Mediatek mt8183 SoC. It belongs to the Mediatek's ISP driver series based on V4L2 and media controller framework. I posted the main part of the DIP driver as RFC to discuss first and would like some review comments.

I appreciate the helpful comment of Tomasz, Rob and Shik in RFC V1. The RFC V2 patch addressed on the review issues in V1. There are 2 V4L2 compliance test issues still under discussion and I will do the corresponding modification in the next patch after we come to the conclusion.

1. Request API test doesn't know which buffers of the video devices are required so we got failed in testRequests()

2. V4L2 compliance test check if the driver return error when passing an invalid image size, but in vb2_create_bufs() case, we don't know if the size check is required or not.

Please see the following URL for the detail.
http://lists.infradead.org/pipermail/linux-mediatek/2019-June/020884.html

==============
Introduction
==============

Digital Image Processing (DIP) unit can accept the tuning parameters and adjust the image content in Mediatek ISP system. Furthermore, it performs demosaicing and noise reduction on the image to support the advanced camera features of the application. The DIP driver also support image format conversion, resizing and rotation with its hardware path.

The driver is implemented with V4L2 and media controller framework. We have the following entities describing the DIP path. Since a DIP frame has multiple buffers, the driver uses Request API to control the multiple buffer's enqueue flow.

1. Meta (output video device): connects to DIP sub device. It accepts the input tuning buffer from userspace. The metadata interface used currently is only a temporary solution to kick off driver development and is not ready for reviewed yet.

2. RAW (output video device): connects to DIP sub device. It accepts input image buffer from userspace.

3. DIP (sub device): connects to MDP-0 and MDP-1. When processing an image, DIP hardware support multiple output images with different size and format so it needs two capture video devices to return the streaming data to the user.

4. MDP-0 (capture video device): return the processed image data.

5. MDP-1 (capture video device): return the processed image data, the image size and format can be different from the ones of MDP-0.

The overall file structure of the DIP driver is as following:

* mtk_dip-v4l2.c: implements DIP platform driver, V4L2 and vb2 operations.

* mtk_dip-sys.c: implements the hardware job handling flow including the part of interaction with the SCP and MDP.

* mtk_dip-dev.c: implements dip pipe utilities. DIP driver supports 3 software pipes (preview, capture and reprocessing) at the same time. All the pipes share the same DIP hardware to process the images.

==================
Changes in v2
==================
* mtk_dip-smem.c
1. Removed mtk_dip-smem.c and the custom code of SCP and DIP's share memory operation, and uses SCP device as the allocation device instead. (SCP creates the shared DMA pool of DMA buffers and can hook to DMA mapping APIs)

* mtk_dip-ctrl.c
1. Merged mtk_dip-ctrl.c into mtk_dip-v4l2.c since we only have a HW ctrl. (V4L2_CID_ROTATE)

* mtk_dip-sys.c:
1. Removed struct mtk_dip_hw_work, mtk_dip_hw_submit_work and the related memory management flow (use mtk_dip_request instead)

2. Uses workqueue mdp_wq instead of dip_runner_thread kthread to simplify the design

3. Removed dip_gcejoblist and use mtk_dip_job_info list instead

4. Removed framejob and mtk_dip_hw_mdpcb_work and the related alloc and free since it already embedded in the new struct mtk_dip_request

5. Integrated struct mtk_dip_hw_user_id and struct with mtk_dip_pipe, and removed dip_hw->dip_useridlist

6. Pass mtk_dip_request to mdp_cmdq_sendtask() as cb data

7. Use spinlock instead of mutex as struct mtk_dip_hw_queue's queuelock so that we can use direct function call instead of mdpcb_workqueue works

8. Removed dip_send() and use scp_ipi_send() directly

9. Removed composing_wq and the related macro, we use semaphore instead

10. Use array to keep constant number of working buffer pointers in dip_hw instead a list

11. Allocates the SCP working buffer before scheduling the job into SCP. When there is no free buffer, we hold the job until there are any working buffers available.

12. Re-designed the request handling flow. We implement mtk_dip_vb2_request_validate() to collect the job data including buffers and check if we got minimum required buffers. mtk_dip_pipe_try_enqueue() is added to simplify the job scheduling flow in both streamon() case with buffers already in queues and .buf_queue() during streaming. In streamon() function, we call mtk_dip_pipe_try_enqueue() to execute as many as jobs in the pending list

13. Fixed the issue about passing the kernel pointer to SCP

14. Re-designed mtk_dip_hw_flush_by_id() to remove the unnecessary loop and interrupt abort

15. Added codes to wait for pending jobs already in SCP during suspend flow. In mtk_dip_suspend() and dip_submit_worker(), we get mutex hw_op_lock before read and update the SCP job number to avoid the race condition when system suspend happens and DIP driver is sending ipi command to trigger the firmware job.

16. Removed struct mtk_dip_hw's dip_user_cnt and dip_state, and uses dip_stream_cnt instead

17. Uses dma_alloc_coherent() instead of scp_get_reserve_mem_phys()/ scp_get_reserve_mem_size() to allocate DIP working buffers

* mtk_dip-v4l2.c:
1. Call mtk_dip_hw_stream{on, off} in mtk_dip_subdev_s_stream() directly instead mtk_dip_pipe_stream_on and mtk_dip_pipe_stream_off

2. Removed buf usage HW ctrl and uses dma port configured in node's description instead

3. Moved platform driver ops to mtk_dip-v4l2.c (which includes the V4L2/media ops implementation)

4. Moved hardware related operation in sub-device open/close to streamon()/streamoff() ops

5. Uses dip_pipe->lock to synchronize streamon, streamoff and link setup flow

6. Added a counter dip_pipe->cnt_nodes_not_streaming to check if the pipe can be streamon or not (instead of the mtk_dip_all_nodes_streaming())

7. Moved the buffer size checking code from .queue_setup() to .buf_prepare()

8. Added multiple-plane formats support

9. Created interfaces and interface links for input and output video nodes

10. Added error handling and improved the cleanup codes in mtk_dip_dev_v4l2_init() and mtk_dip_pipe_v4l2_register()

11. Added mtk_dip_video_device_v4l2_register() to simplify mtk_dip_pipe_v4l2_register()'s implementation

12. Added mtk_dip_video_device.flags instead of enable, dynamic and immutable fields in struct mtk_dip_video_device.

13. Added a list to mtk_dip_video_device to hold queued buffers instead of accessing vbq.bufs directly.

14. Merged struct mtk_dip_dev_meta_format and struct mtk_dip_dev_mdp_format into struct mtk_dip_dev_format

15. Changed the try_fmt() implementation. If the pixelformat is not supported, we use the default one but keep the valid fields.

16. Moved the mtk_dip_hw_connect()/mtk_dip_hw_disconnect() call from mtk_dip_subdev_s_stream() to mtk_dip_hw_streamon()/mtk_dip_hw_streamoff() and removed some redundant check about stream count.

17. Re-implemented dev_pm_ops

* mtk_dip-dev.c:
1. Added mtk_dip_request extending media_request and embedded pipe_job_info in it.

2. Removed mtk_dip_pipe_stream{on, off} and move the content to mtk_dip_hw_stream{on, off}

3. Removed fill_ipi_img_param() and extends fill_ipi_img_param_mp() so that it can support both multiple non-contiguous and multiple contiguous planes buffers.

4. Added mtk_dip_pipe_get_stride() to reduce redundant codes.

5. Removed call_mtk_dip_pipe_finish() and merged its content into its callers

6. Removed unused ctrl handler from struct mtk_dip_pipe.

==================
Changes in v1
==================
1. Uses Request API instead of DIP's buffer collection design

2. Removed unnecessary abstraction structurally, including mtk_dip_ctx and related ops

3. Removed the dip_smem node from device tree

4. Improved the dip_work list's management flow

5. Fixed the common issues Tomasz commented on Mediatek ISP Pass 1's RFC v0 patch series

==================
Dependent patch
==================

DIP driver depends on MDP 3 driver and SCP driver. The patches are as following:

[1]. support mdp3 on mt8183 platform
https://patchwork.kernel.org/cover/10945585/

[2]. Add support for mt8183 SCP
https://patchwork.kernel.org/cover/11027245/

==================
Compliance test
==================

* Test command: v4l2-compliance -m /dev/media0
* test output:

v4l2-compliance SHA: not available, 32 bits

Compliance test for camera-dip device /dev/media0:

Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56

Required ioctls:
test MEDIA_IOC_DEVICE_INFO: OK

Allow for multiple opens:
test second /dev/media0 open: OK
test MEDIA_IOC_DEVICE_INFO: OK
test for unlimited opens: OK

Media Controller ioctls:
test MEDIA_IOC_G_TOPOLOGY: OK
Entities: 15 Interfaces: 27 Pads: 24 Links: 39 test MEDIA_IOC_ENUM_ENTITIES/LINKS: OK test MEDIA_IOC_SETUP_LINK: OK

Total for camera-dip device /dev/media0: 7, Succeeded: 7, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for camera-dip device /dev/v4l-subdev0:

Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000006
	Type             : V4L Sub-Device
Entity Info:
	ID               : 0x00000001 (1)
	Name             : MTK-ISP-DIP-V4L2
	Function         : Video Pixel Formatter
	Pad 0x01000002   : 0: Sink
	  Link 0x0200000c: from remote pad 0x1000009 of entity 'MTK-ISP-DIP-V4L2 Raw Input': Data, Enabled
	Pad 0x01000003   : 1: Sink
	  Link 0x02000014: from remote pad 0x1000011 of entity 'MTK-ISP-DIP-V4L2 Tuning': Data
	Pad 0x01000004   : 2: Source
	  Link 0x0200001c: to remote pad 0x1000019 of entity 'MTK-ISP-DIP-V4L2 MDP0': Data, Enabled, Dynamic
	Pad 0x01000005   : 3: Source
	  Link 0x02000024: to remote pad 0x1000021 of entity 'MTK-ISP-DIP-V4L2 MDP1': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK

Allow for multiple opens:
test second /dev/v4l-subdev0 open: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Sub-Device ioctls (Sink Pad 0):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Sink Pad 1):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 2):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 3):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) test VIDIOC_QUERYCTRL: OK (Not Supported)
test VIDIOC_G/S_CTRL: OK (Not Supported)
test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported) test VIDIOC_G/S_PARM: OK (Not Supported)
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK (Not Supported)
test VIDIOC_TRY_FMT: OK (Not Supported)
test VIDIOC_S_FMT: OK (Not Supported)
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported) test VIDIOC_EXPBUF: OK (Not Supported)
test Requests: OK (Not Supported)

Total for camera-dip device /dev/v4l-subdev0: 69, Succeeded: 69, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video0:

Driver Info:

	Driver name      : MTK-ISP-DIP-V4L
	Card type        : MTK-ISP-DIP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x0300000a
	Type             : V4L Video
Entity Info:
	ID               : 0x00000008 (8)
	Name             : MTK-ISP-DIP-V4L2 Raw Input
	Function         : V4L2 I/O
	Pad 0x01000009   : 0: Source
	  Link 0x0200000c: to remote pad 0x1000002 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video0 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video0:

Driver Info:

	Driver name      : MTK-ISP-DIP-V4L
	Card type        : MTK-ISP-DIP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x0300000a
	Type             : V4L Video
Entity Info:
	ID               : 0x00000008 (8)
	Name             : MTK-ISP-DIP-V4L2 Raw Input
	Function         : V4L2 I/O
	Pad 0x01000009   : 0: Source
	  Link 0x0200000c: to remote pad 0x1000002 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video0 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video1:

Driver Info:

	Driver name      : MTK-ISP-DIP-V4L
	Card type        : MTK-ISP-DIP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000012
	Type             : V4L Video
Entity Info:
	ID               : 0x00000010 (16)
	Name             : MTK-ISP-DIP-V4L2 Tuning
	Function         : V4L2 I/O
	Pad 0x01000011   : 0: Source
	  Link 0x02000014: to remote pad 0x1000003 of entity 'MTK-ISP-DIP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video1 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video1: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video1:

Driver Info:

	Driver name      : MTK-ISP-DIP-V4L
	Card type        : MTK-ISP-DIP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000012
	Type             : V4L Video
Entity Info:
	ID               : 0x00000010 (16)
	Name             : MTK-ISP-DIP-V4L2 Tuning
	Function         : V4L2 I/O
	Pad 0x01000011   : 0: Source
	  Link 0x02000014: to remote pad 0x1000003 of entity 'MTK-ISP-DIP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video1 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video1: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video2:

Driver Info:

	Driver name      : MTK-ISP-DIP-V4L
	Card type        : MTK-ISP-DIP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x0300001a
	Type             : V4L Video
Entity Info:
	ID               : 0x00000018 (24)
	Name             : MTK-ISP-DIP-V4L2 MDP0
	Function         : V4L2 I/O
	Pad 0x01000019   : 0: Sink
	  Link 0x0200001c: from remote pad 0x1000004 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video2 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video2: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video2:

Driver Info:

	Driver name      : MTK-ISP-DIP-V4L
	Card type        : MTK-ISP-DIP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x0300001a
	Type             : V4L Video
Entity Info:
	ID               : 0x00000018 (24)
	Name             : MTK-ISP-DIP-V4L2 MDP0
	Function         : V4L2 I/O
	Pad 0x01000019   : 0: Sink
	  Link 0x0200001c: from remote pad 0x1000004 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video2 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video2: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video3:

Driver Info:

	Driver name      : MTK-ISP-DIP-V4L
	Card type        : MTK-ISP-DIP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000022
	Type             : V4L Video
Entity Info:
	ID               : 0x00000020 (32)
	Name             : MTK-ISP-DIP-V4L2 MDP1
	Function         : V4L2 I/O
	Pad 0x01000021   : 0: Sink
	  Link 0x02000024: from remote pad 0x1000005 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video3 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video3: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video3:

Driver Info:

	Driver name      : MTK-ISP-DIP-V4L
	Card type        : MTK-ISP-DIP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000022
	Type             : V4L Video
Entity Info:
	ID               : 0x00000020 (32)
	Name             : MTK-ISP-DIP-V4L2 MDP1
	Function         : V4L2 I/O
	Pad 0x01000021   : 0: Sink
	  Link 0x02000024: from remote pad 0x1000005 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video3 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video3: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for camera-dip device /dev/v4l-subdev1:

Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x0300002d
	Type             : V4L Sub-Device
Entity Info:
	ID               : 0x00000028 (40)
	Name             : MTK-ISP-DIP-CAP-V4L2
	Function         : Video Pixel Formatter
	Pad 0x01000029   : 0: Sink
	  Link 0x02000033: from remote pad 0x1000030 of entity 'MTK-ISP-DIP-CAP-V4L2 Raw Input': Data, Enabled
	Pad 0x0100002a   : 1: Sink
	  Link 0x0200003b: from remote pad 0x1000038 of entity 'MTK-ISP-DIP-CAP-V4L2 Tuning': Data
	Pad 0x0100002b   : 2: Source
	  Link 0x02000043: to remote pad 0x1000040 of entity 'MTK-ISP-DIP-CAP-V4L2 MDP0': Data, Enabled, Dynamic
	Pad 0x0100002c   : 3: Source
	  Link 0x0200004b: to remote pad 0x1000048 of entity 'MTK-ISP-DIP-CAP-V4L2 MDP1': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK

Allow for multiple opens:
test second /dev/v4l-subdev1 open: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Sub-Device ioctls (Sink Pad 0):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Sink Pad 1):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 2):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 3):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) test VIDIOC_QUERYCTRL: OK (Not Supported)
test VIDIOC_G/S_CTRL: OK (Not Supported)
test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported) test VIDIOC_G/S_PARM: OK (Not Supported)
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK (Not Supported)
test VIDIOC_TRY_FMT: OK (Not Supported)
test VIDIOC_S_FMT: OK (Not Supported)
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported) test VIDIOC_EXPBUF: OK (Not Supported)
test Requests: OK (Not Supported)

Total for camera-dip device /dev/v4l-subdev1: 69, Succeeded: 69, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video4:

Driver Info:

	Driver name      : MTK-ISP-DIP-CAP
	Card type        : MTK-ISP-DIP-CAP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000031
	Type             : V4L Video
Entity Info:
	ID               : 0x0000002f (47)
	Name             : MTK-ISP-DIP-CAP-V4L2 Raw Input
	Function         : V4L2 I/O
	Pad 0x01000030   : 0: Source
	  Link 0x02000033: to remote pad 0x1000029 of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video4 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video4: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video4:

Driver Info:

	Driver name      : MTK-ISP-DIP-CAP
	Card type        : MTK-ISP-DIP-CAP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000031
	Type             : V4L Video
Entity Info:
	ID               : 0x0000002f (47)
	Name             : MTK-ISP-DIP-CAP-V4L2 Raw Input
	Function         : V4L2 I/O
	Pad 0x01000030   : 0: Source
	  Link 0x02000033: to remote pad 0x1000029 of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video4 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video4: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video5:

Driver Info:

	Driver name      : MTK-ISP-DIP-CAP
	Card type        : MTK-ISP-DIP-CAP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000039
	Type             : V4L Video
Entity Info:
	ID               : 0x00000037 (55)
	Name             : MTK-ISP-DIP-CAP-V4L2 Tuning
	Function         : V4L2 I/O
	Pad 0x01000038   : 0: Source
	  Link 0x0200003b: to remote pad 0x100002a of entity 'MTK-ISP-DIP-CAP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video5 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video5: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video5:

Driver Info:

	Driver name      : MTK-ISP-DIP-CAP
	Card type        : MTK-ISP-DIP-CAP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000039
	Type             : V4L Video
Entity Info:
	ID               : 0x00000037 (55)
	Name             : MTK-ISP-DIP-CAP-V4L2 Tuning
	Function         : V4L2 I/O
	Pad 0x01000038   : 0: Source
	  Link 0x0200003b: to remote pad 0x100002a of entity 'MTK-ISP-DIP-CAP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video5 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video5: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video6:

Driver Info:

	Driver name      : MTK-ISP-DIP-CAP
	Card type        : MTK-ISP-DIP-CAP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000041
	Type             : V4L Video
Entity Info:
	ID               : 0x0000003f (63)
	Name             : MTK-ISP-DIP-CAP-V4L2 MDP0
	Function         : V4L2 I/O
	Pad 0x01000040   : 0: Sink
	  Link 0x02000043: from remote pad 0x100002b of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video6 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video6: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video6:

Driver Info:

	Driver name      : MTK-ISP-DIP-CAP
	Card type        : MTK-ISP-DIP-CAP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000041
	Type             : V4L Video
Entity Info:
	ID               : 0x0000003f (63)
	Name             : MTK-ISP-DIP-CAP-V4L2 MDP0
	Function         : V4L2 I/O
	Pad 0x01000040   : 0: Sink
	  Link 0x02000043: from remote pad 0x100002b of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video6 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video6: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video7:

Driver Info:

	Driver name      : MTK-ISP-DIP-CAP
	Card type        : MTK-ISP-DIP-CAP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000049
	Type             : V4L Video
Entity Info:
	ID               : 0x00000047 (71)
	Name             : MTK-ISP-DIP-CAP-V4L2 MDP1
	Function         : V4L2 I/O
	Pad 0x01000048   : 0: Sink
	  Link 0x0200004b: from remote pad 0x100002c of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video7 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video7: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video7:

Driver Info:

	Driver name      : MTK-ISP-DIP-CAP
	Card type        : MTK-ISP-DIP-CAP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000049
	Type             : V4L Video
Entity Info:
	ID               : 0x00000047 (71)
	Name             : MTK-ISP-DIP-CAP-V4L2 MDP1
	Function         : V4L2 I/O
	Pad 0x01000048   : 0: Sink
	  Link 0x0200004b: from remote pad 0x100002c of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video7 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video7: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for camera-dip device /dev/v4l-subdev2:

Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000054
	Type             : V4L Sub-Device
Entity Info:
	ID               : 0x0000004f (79)
	Name             : MTK-ISP-DIP-REP-V4L2
	Function         : Video Pixel Formatter
	Pad 0x01000050   : 0: Sink
	  Link 0x0200005a: from remote pad 0x1000057 of entity 'MTK-ISP-DIP-REP-V4L2 Raw Input': Data, Enabled
	Pad 0x01000051   : 1: Sink
	  Link 0x02000062: from remote pad 0x100005f of entity 'MTK-ISP-DIP-REP-V4L2 Tuning': Data
	Pad 0x01000052   : 2: Source
	  Link 0x0200006a: to remote pad 0x1000067 of entity 'MTK-ISP-DIP-REP-V4L2 MDP0': Data, Enabled, Dynamic
	Pad 0x01000053   : 3: Source
	  Link 0x02000072: to remote pad 0x100006f of entity 'MTK-ISP-DIP-REP-V4L2 MDP1': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK

Allow for multiple opens:
test second /dev/v4l-subdev2 open: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Sub-Device ioctls (Sink Pad 0):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Sink Pad 1):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 2):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 3):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) test VIDIOC_QUERYCTRL: OK (Not Supported)
test VIDIOC_G/S_CTRL: OK (Not Supported)
test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported) test VIDIOC_G/S_PARM: OK (Not Supported)
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK (Not Supported)
test VIDIOC_TRY_FMT: OK (Not Supported)
test VIDIOC_S_FMT: OK (Not Supported)
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported) test VIDIOC_EXPBUF: OK (Not Supported)
test Requests: OK (Not Supported)

Total for camera-dip device /dev/v4l-subdev2: 69, Succeeded: 69, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video8:

Driver Info:

	Driver name      : MTK-ISP-DIP-REP
	Card type        : MTK-ISP-DIP-REP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000058
	Type             : V4L Video
Entity Info:
	ID               : 0x00000056 (86)
	Name             : MTK-ISP-DIP-REP-V4L2 Raw Input
	Function         : V4L2 I/O
	Pad 0x01000057   : 0: Source
	  Link 0x0200005a: to remote pad 0x1000050 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video8 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video8: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video8:

Driver Info:

	Driver name      : MTK-ISP-DIP-REP
	Card type        : MTK-ISP-DIP-REP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000058
	Type             : V4L Video
Entity Info:
	ID               : 0x00000056 (86)
	Name             : MTK-ISP-DIP-REP-V4L2 Raw Input
	Function         : V4L2 I/O
	Pad 0x01000057   : 0: Source
	  Link 0x0200005a: to remote pad 0x1000050 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video8 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video8: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video9:

Driver Info:

	Driver name      : MTK-ISP-DIP-REP
	Card type        : MTK-ISP-DIP-REP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000060
	Type             : V4L Video
Entity Info:
	ID               : 0x0000005e (94)
	Name             : MTK-ISP-DIP-REP-V4L2 Tuning
	Function         : V4L2 I/O
	Pad 0x0100005f   : 0: Source
	  Link 0x02000062: to remote pad 0x1000051 of entity 'MTK-ISP-DIP-REP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video9 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video9: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video9:

Driver Info:

	Driver name      : MTK-ISP-DIP-REP
	Card type        : MTK-ISP-DIP-REP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000060
	Type             : V4L Video
Entity Info:
	ID               : 0x0000005e (94)
	Name             : MTK-ISP-DIP-REP-V4L2 Tuning
	Function         : V4L2 I/O
	Pad 0x0100005f   : 0: Source
	  Link 0x02000062: to remote pad 0x1000051 of entity 'MTK-ISP-DIP-REP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video9 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video9: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video10:

Driver Info:

	Driver name      : MTK-ISP-DIP-REP
	Card type        : MTK-ISP-DIP-REP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000068
	Type             : V4L Video
Entity Info:
	ID               : 0x00000066 (102)
	Name             : MTK-ISP-DIP-REP-V4L2 MDP0
	Function         : V4L2 I/O
	Pad 0x01000067   : 0: Sink
	  Link 0x0200006a: from remote pad 0x1000052 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video10 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video10: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video10:

Driver Info:

	Driver name      : MTK-ISP-DIP-REP
	Card type        : MTK-ISP-DIP-REP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000068
	Type             : V4L Video
Entity Info:
	ID               : 0x00000066 (102)
	Name             : MTK-ISP-DIP-REP-V4L2 MDP0
	Function         : V4L2 I/O
	Pad 0x01000067   : 0: Sink
	  Link 0x0200006a: from remote pad 0x1000052 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video10 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video10: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video11:

Driver Info:

	Driver name      : MTK-ISP-DIP-REP
	Card type        : MTK-ISP-DIP-REP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000070
	Type             : V4L Video
Entity Info:
	ID               : 0x0000006e (110)
	Name             : MTK-ISP-DIP-REP-V4L2 MDP1
	Function         : V4L2 I/O
	Pad 0x0100006f   : 0: Sink
	  Link 0x02000072: from remote pad 0x1000053 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video11 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video11: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video11:

Driver Info:

	Driver name      : MTK-ISP-DIP-REP
	Card type        : MTK-ISP-DIP-REP-V4L2
	Bus info         : platform:15022000.dip
	Driver version   : 4.19.56
	Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

	Driver name      : camera-dip
	Model            : MTK-ISP-DIP-V4L2
	Serial           : 
	Bus info         : platform:15022000.dip
	Media version    : 4.19.56
	Hardware revision: 0x00000000 (0)
	Driver version   : 4.19.56
Interface Info:
	ID               : 0x03000070
	Type             : V4L Video
Entity Info:
	ID               : 0x0000006e (110)
	Name             : MTK-ISP-DIP-REP-V4L2 MDP1
	Function         : V4L2 I/O
	Pad 0x0100006f   : 0: Sink
	  Link 0x02000072: from remote pad 0x1000053 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video11 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video11: 45, Succeeded: 45, Failed: 0, Warnings: 0

Grand Total for camera-dip device /dev/media0: 1294, Succeeded: 1294, Failed: 0, Warnings: 0

Frederic Chen (6):
dt-bindings: mt8183: Added DIP dt-bindings
dts: arm64: mt8183: Add DIP nodes
media: platform: Add Mediatek DIP driver KConfig
platform: mtk-isp: Add Mediatek DIP driver remoteproc/mediatek: add SCP's shared dma pool support for mt8183
media: platform: mtk-mdp3: Added struct tuning_addr

 .../bindings/media/mediatek,mt8183-dip.txt    |   40 +
 arch/arm64/boot/dts/mediatek/mt8183.dtsi      |   16 +
 drivers/media/platform/Kconfig                |    2 +
 drivers/media/platform/mtk-isp/Kconfig        |   21 +
 drivers/media/platform/mtk-isp/Makefile       |   18 +
 .../media/platform/mtk-isp/isp_50/Makefile    |    4 +
 .../platform/mtk-isp/isp_50/dip/Makefile      |   18 +
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.c |  769 +++++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.h |  337 ++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-hw.h  |  155 ++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-sys.c |  794 ++++++++
 .../mtk-isp/isp_50/dip/mtk_dip-v4l2.c         | 1786 +++++++++++++++++
 drivers/media/platform/mtk-mdp3/mtk-img-ipi.h |    8 +-
 drivers/remoteproc/mtk_scp.c                  |   54 +-
 14 files changed, 4000 insertions(+), 22 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt
 create mode 100644 drivers/media/platform/mtk-isp/Kconfig
 create mode 100644 drivers/media/platform/mtk-isp/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c
Signature · 1 line
2.18.0
#1 lore raw

RFC PATCH v2 1/6 dt-bindings: mt8183: Added DIP dt-bindings

From: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>

This patch adds DT binding documentation for the Digital Image Processing (DIP) unit of camera ISP system on Mediatek's SoCs.

It depends on the SCP and MDP 3 patch as following:

1. dt-bindings: Add a binding for Mediatek SCP
https://patchwork.kernel.org/patch/11027247/
2. dt-binding: mt8183: Add Mediatek MDP3 dt-bindings
https://patchwork.kernel.org/patch/10945603/

---
 .../bindings/media/mediatek,mt8183-dip.txt    | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt
Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt new file +40 -0
new file mode 100644
index 000000000000..3a0435513089
@@ -0,0 +1,40 @@
+* Mediatek Digital Image Processor (DIP)
+
+Digital Image Processor (DIP) unit in Mediatek ISP system is responsible for
+image content adjustment according to the tuning parameters. DIP can process
+the image form memory buffer and output the processed image to multiple output
+buffers. Furthermore, it can support demosaicing and noise reduction on the
+images.
+
+Required properties:
+- compatible: "mediatek,mt8183-dip"
+- reg: Physical base address and length of the function block register space
+- interrupts: interrupt number to the cpu
+- iommus: should point to the respective IOMMU block with master port as
+  argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
+  for details.
+- mediatek,mdp3: should point to the respective mdp block. DIP hardware
+  connects to MDP and we can get the processed image with both effect of the
+  two blocks.
+- mediatek,larb: must contain the local arbiters in the current SoCs, see
+  Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
+  for details.
+- mediatek,scp: should point to the scp node since the we use SCP
+  coprocessor to control DIP hardware
+- clocks: must contain the local arbiters 5 (LARB5) and DIP clock
+- clock-names: must contain "larb5" and "dip"
+
+Example:
+	dip: dip@15022000 {
+		compatible = "mediatek,mt8183-dip";
+		mediatek,larb = <&larb5>;
+		mediatek,mdp3 = <&mdp_rdma0>;
+		mediatek,scp = <&scp>;
+		iommus = <&iommu M4U_PORT_CAM_IMGI>;
+		reg = <0 0x15022000 0 0x6000>;
+		interrupts = <GIC_SPI 268 IRQ_TYPE_LEVEL_LOW>;
+		clocks = <&imgsys CLK_IMG_LARB5>,
+			 <&imgsys CLK_IMG_DIP>;
+		clock-names = "larb5",
+			      "dip";
+		};
Signature · 1 line
2.18.0
maintainer Reviewed-by on v2 1/6
#2 lore raw

Re: [RFC PATCH V2 1/6] dt-bindings: mt8183: Added DIP dt-bindings

Quoted 12 lines · On Mon, 8 Jul 2019 19:04:55 +0800, <[email protected]> wrote:

From: Frederic Chen <[email protected]>

This patch adds DT binding documentation for the Digital Image Processing (DIP) unit of camera ISP system on Mediatek's SoCs.

It depends on the SCP and MDP 3 patch as following:

1. dt-bindings: Add a binding for Mediatek SCP
https://patchwork.kernel.org/patch/11027247/
2. dt-binding: mt8183: Add Mediatek MDP3 dt-bindings
https://patchwork.kernel.org/patch/10945603/

Quoted 6 lines
---
 .../bindings/media/mediatek,mt8183-dip.txt    | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt
#3 lore raw

RFC PATCH v2 2/6 dts: arm64: mt8183: Add DIP nodes

In reply to frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]

From: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>

This patch adds nodes for Digital Image Processing (DIP). DIP is embedded in Mediatek SoCs and works with the co-processor to adjust image content according to tuning input data. It also provides image format conversion, resizing, and rotation features.

---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/mediatek/mt8183.dtsi +16 -0
index 0f2646c9eb65..d7b0fb8230f0 100644
@@ -513,6 +513,22 @@
 			#clock-cells = <1>;
 		};
 
+		dip: dip@15022000 {
+			compatible = "mediatek,mt8183-dip";
+			mediatek,larb = <&larb5>;
+			mediatek,mdp3 = <&mdp_rdma0>;
+			mediatek,scp = <&scp>;
+			iommus = <&iommu M4U_PORT_CAM_IMGI>;
+			reg = <0 0x15022000 0 0x6000>;
+			interrupts = <GIC_SPI 268 IRQ_TYPE_LEVEL_LOW>;
+			clocks =
+					<&imgsys CLK_IMG_LARB5>,
+					<&imgsys CLK_IMG_DIP>;
+			clock-names =
+					"larb5",
+					"dip";
+		};
+
 		vdecsys: syscon@16000000 {
 			compatible = "mediatek,mt8183-vdecsys", "syscon";
 			reg = <0 0x16000000 0 0x1000>;
Signature · 1 line
2.18.0
#4 lore raw

RFC PATCH v2 3/6 media: platform: Add Mediatek DIP driver KConfig

In reply to frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]

From: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>

This patch adds KConfig for Mediatek Digital Image Processing driver(DIP). DIP is embedded in Mediatek SoCs. It provides image format conversion, resizing, and rotation function.

---
 drivers/media/platform/Kconfig         |  2 ++
 drivers/media/platform/mtk-isp/Kconfig | 21 +++++++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100644 drivers/media/platform/mtk-isp/Kconfig
drivers/media/platform/Kconfig +2 -0
index 0c725d4dcf80..b8501e1b134f 100644
@@ -32,6 +32,8 @@ source "drivers/media/platform/davinci/Kconfig"
 
 source "drivers/media/platform/omap/Kconfig"
 
+source "drivers/media/platform/mtk-isp/Kconfig"
+
 config VIDEO_ASPEED
 	tristate "Aspeed AST2400 and AST2500 Video Engine driver"
 	depends on VIDEO_V4L2
drivers/media/platform/mtk-isp/Kconfig new file +21 -0
new file mode 100644
index 000000000000..24a592022dd5
@@ -0,0 +1,21 @@
+config VIDEO_MEDIATEK_ISP_DIP
+	bool "Mediatek Digital Image Processing function"
+	select DMA_SHARED_BUFFER
+	select VIDEO_V4L2_SUBDEV_API
+	select VIDEOBUF2_DMA_CONTIG
+	select VIDEOBUF2_CORE
+	select VIDEOBUF2_V4L2
+	select VIDEOBUF2_MEMOPS
+	select VIDEOBUF2_VMALLOC
+	select MEDIA_CONTROLLER
+
+	default n
+	help
+	    Support the basic Digital Image Processing (DIP) driver.
+
+	    DIP driver provides image format conversion, resizing,
+	    and rotation function through the low power hardware.
+	    DIP also supports multiple output feature. It can
+	    generate two or more output image with different effect
+	    based on a single input image at the same time.
+
Signature · 1 line
2.18.0

A message that is not in the archive (sent off-list or not yet received): 20190708110500.7242-1-frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]

#6 lore raw

RFC PATCH v2 4/6 platform: mtk-isp: Add Mediatek DIP driver

From: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>

This patch adds the driver of Digital Image Processing (DIP) unit in Mediatek ISP system, providing image format conversion, resizing, and rotation features.

The mtk-isp directory will contain drivers for multiple IP blocks found in Mediatek ISP system. It will include ISP Pass 1 driver(CAM), sensor interface driver, DIP driver and face detection driver.

---
 drivers/media/platform/mtk-isp/Makefile       |    7 +
 .../media/platform/mtk-isp/isp_50/Makefile    |    7 +
 .../platform/mtk-isp/isp_50/dip/Makefile      |   18 +
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.c |  769 +++++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.h |  337 ++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-hw.h  |  155 ++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-sys.c |  794 ++++++++
 .../mtk-isp/isp_50/dip/mtk_dip-v4l2.c         | 1786 +++++++++++++++++
 8 files changed, 3873 insertions(+)
 create mode 100644 drivers/media/platform/mtk-isp/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c
drivers/media/platform/mtk-isp/Makefile new file +7 -0
new file mode 100644
index 000000000000..b08d3bdf2800
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (C) 2019 MediaTek Inc.
+#
+
+obj-y += isp_50/
+
drivers/media/platform/mtk-isp/isp_50/Makefile new file +7 -0
new file mode 100644
index 000000000000..564c3889c34c
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (C) 2019 MediaTek Inc.
+#
+
+obj-$(CONFIG_VIDEO_MEDIATEK_ISP_DIP) += dip/
+
drivers/media/platform/mtk-isp/isp_50/dip/Makefile new file +18 -0
new file mode 100644
index 000000000000..99e760d7d5a9
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (C) 2019 MediaTek Inc.
+#
+
+$(info $(srctree))
+ccflags-y += -I$(srctree)/drivers/media/platform/mtk-mdp3
+
+obj-$(CONFIG_VIDEO_MEDIATEK_ISP_DIP) += mtk_dip-v4l2.o
+
+# Utilities to provide frame-based streaming model
+# with v4l2 user interfaces and alloc context managing
+# memory shared between ISP and coprocessor
+mtk_dip_util-objs := \
+mtk_dip-dev.o \
+mtk_dip-sys.o
+
+obj-$(CONFIG_VIDEO_MEDIATEK_ISP_DIP) += mtk_dip_util.o
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +769 -0

769 lines not on this page · raw message

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +337 -0

337 lines not on this page · raw message

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +155 -0

155 lines not on this page · raw message

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +794 -0

794 lines not on this page · raw message

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +1786 -0

913 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.18.0

Part of the diff is not shown here. View the raw message.

A message that is not in the archive (sent off-list or not yet received): 20190708110500.7242-5-frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]

#8 lore raw

Re: [RFC PATCH V2 4/6] platform: mtk-isp: Add Mediatek DIP driver

Hi Frederic,

Quoted 22 lines · On Mon, Jul 08, 2019 at 07:04:58PM +0800…

From: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>

This patch adds the driver of Digital Image Processing (DIP) unit in Mediatek ISP system, providing image format conversion, resizing, and rotation features.

The mtk-isp directory will contain drivers for multiple IP blocks found in Mediatek ISP system. It will include ISP Pass 1 driver(CAM), sensor interface driver, DIP driver and face detection driver.

---
 drivers/media/platform/mtk-isp/Makefile       |    7 +
 .../media/platform/mtk-isp/isp_50/Makefile    |    7 +
 .../platform/mtk-isp/isp_50/dip/Makefile      |   18 +
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.c |  769 +++++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.h |  337 ++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-hw.h  |  155 ++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-sys.c |  794 ++++++++
 .../mtk-isp/isp_50/dip/mtk_dip-v4l2.c         | 1786 +++++++++++++++++
 8 files changed, 3873 insertions(+)
Quoted 9 lines
 create mode 100644 drivers/media/platform/mtk-isp/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Thanks for v2! The code is getting better, but there are still problems. Please check my comments inline.

Note that it would be really good if you could collaborate more closely with Jungo working on the P1 driver, as I noticed similar problems in both drivers, with some being addressed only in one of the drivers, but not the other.

Quoted 73 lines
drivers/media/platform/mtk-isp/Makefile new file +7 -0
new file mode 100644
index 000000000000..b08d3bdf2800
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (C) 2019 MediaTek Inc.
+#
+
+obj-y += isp_50/
+
drivers/media/platform/mtk-isp/isp_50/Makefile new file +7 -0
new file mode 100644
index 000000000000..564c3889c34c
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (C) 2019 MediaTek Inc.
+#
+
+obj-$(CONFIG_VIDEO_MEDIATEK_ISP_DIP) += dip/
+
drivers/media/platform/mtk-isp/isp_50/dip/Makefile new file +18 -0
new file mode 100644
index 000000000000..99e760d7d5a9
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (C) 2019 MediaTek Inc.
+#
+
+$(info $(srctree))
+ccflags-y += -I$(srctree)/drivers/media/platform/mtk-mdp3
+
+obj-$(CONFIG_VIDEO_MEDIATEK_ISP_DIP) += mtk_dip-v4l2.o
+
+# Utilities to provide frame-based streaming model
+# with v4l2 user interfaces and alloc context managing
+# memory shared between ISP and coprocessor
+mtk_dip_util-objs := \
+mtk_dip-dev.o \
+mtk_dip-sys.o
+
+obj-$(CONFIG_VIDEO_MEDIATEK_ISP_DIP) += mtk_dip_util.o
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +17 -0
new file mode 100644
index 000000000000..63256fa27428
@@ -0,0 +1,769 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *
+ */
+
+#include <linux/dma-mapping.h>
+#include <linux/platform_device.h>
+#include <media/videobuf2-dma-contig.h>
+#include <media/v4l2-event.h>
+#include "mtk_dip-dev.h"
+#include "mtk-mdp3-regs.h"
+#include "mtk-img-ipi.h"
+
+int mtk_dip_pipe_init(struct mtk_dip_pipe *pipe,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 27

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+		      struct mtk_dip_dev *dip_dev,
+		      const struct mtk_dip_pipe_desc *setting,
+		      struct media_device *media_dev,
+		      struct v4l2_device *v4l2_dev)
+{
+	int ret, i, count = 0;
+
+	pipe->dip_dev = dip_dev;
+	pipe->desc = setting;
+	pipe->num_nodes = MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM;

Rather than hardcoding the number, could we just pass ARRAY_SIZE(desc) to this function from the caller?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 35

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +8 -0
+
+	atomic_set(&pipe->pipe_job_sequence, 0);
+	INIT_LIST_HEAD(&pipe->pipe_job_running_list);
+	INIT_LIST_HEAD(&pipe->pipe_job_pending_list);
+	spin_lock_init(&pipe->job_lock);
+	mutex_init(&pipe->lock);
+
+	for (i = 0; i < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM; i++) {

i < pipe->num_nodes

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 44

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+		if (i < MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM) {
+			pipe->nodes[i].desc =
+			&pipe->desc->output_queue_descs[i];
+		} else {
+			int cap_idx = i - MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM;
+
+			pipe->nodes[i].desc =
+				&pipe->desc->capture_queue_descs[cap_idx];
+		}

We shouldn't need this if/else block if we put all the descriptors in one array.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 47

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+
+		pipe->nodes[i].flags =
+			pipe->nodes[i].desc->flags;

No need to wrap the line here.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 48

Quoted 1 line
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +1 -0
+		atomic_set(&pipe->nodes[i].sequence, 0);

I don't see this sequence used anywhere else in the driver.

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+		spin_lock_init(&pipe->nodes[i].buf_list_lock);
+		INIT_LIST_HEAD(&pipe->nodes[i].buf_list);
+
+		if (pipe->nodes[i].flags & MEDIA_LNK_FL_ENABLED)
+			count++;
+	}

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 64

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+
+	if (pipe->desc->master >= 0 &&
+	    pipe->desc->master < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM) {
+		if (!(pipe->nodes[pipe->desc->master].flags &
+		    MEDIA_LNK_FL_ENABLED))
+			count++;
+
+		pipe->nodes[pipe->desc->master].flags |=
+			MEDIA_LNK_FL_ENABLED | MEDIA_LNK_FL_IMMUTABLE;
+	}

All the pipes seem to have master set to MTK_DIP_VIDEO_NODE_ID_NO_MASTER, so this seems to be dead code.

Quoted 58 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +58 -0
+
+	atomic_set(&pipe->cnt_nodes_not_streaming, count);
+
+	ret = mtk_dip_pipe_v4l2_register(pipe, media_dev, v4l2_dev);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s: failed(%d) to create V4L2 devices\n",
+			pipe->desc->name, ret);
+
+		goto err_destroy_pipe_lock;
+	}
+
+	return 0;
+
+err_destroy_pipe_lock:
+	mutex_destroy(&pipe->lock);
+
+	return ret;
+}
+
+int mtk_dip_pipe_release(struct mtk_dip_pipe *pipe)
+{
+	mtk_dip_pipe_v4l2_unregister(pipe);
+	mutex_destroy(&pipe->lock);
+
+	return 0;
+}
+
+int mtk_dip_pipe_next_job_id(struct mtk_dip_pipe *pipe)
+{
+	int global_job_id = atomic_inc_return(&pipe->pipe_job_sequence);
+
+	return (global_job_id & 0x0000FFFF) | (pipe->desc->id << 16);
+}
+
+struct mtk_dip_pipe_job_info*
+mtk_dip_pipe_get_running_job_info(struct mtk_dip_pipe *pipe, int pipe_job_id)
+{
+	struct mtk_dip_pipe_job_info *job_info;
+
+	spin_lock(&pipe->job_lock);
+	list_for_each_entry(job_info,
+			    &pipe->pipe_job_running_list, list) {
+		if (job_info->id == pipe_job_id) {
+			spin_unlock(&pipe->job_lock);
+			return job_info;
+		}
+	}
+	spin_unlock(&pipe->job_lock);
+
+	return NULL;
+}
+
+void mtk_dip_pipe_debug_job(struct mtk_dip_pipe *pipe,
+			    struct mtk_dip_pipe_job_info *job_info)
+{
+	int i;
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 132

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+	dev_dbg(&pipe->dip_dev->pdev->dev, "%s: pipe-job(%p),id(%d)\n",
+		pipe->desc->name, job_info, job_info->id);
+
+	for (i = 0; i < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM ; i++) {
+		if (job_info->buf_map[i])
+			dev_dbg(&pipe->dip_dev->pdev->dev, "%s:%s:buf(%p)\n",
+				pipe->desc->name, pipe->nodes[i].desc->name, i,
+				job_info->buf_map[i]);
+	}
+}

We should remove this kind of excessive debugging code. I'd recommend keeping it as a local test-only patch on top of the driver.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 136

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +4 -0
+
+int mtk_dip_pipe_job_finish(struct mtk_dip_pipe *pipe,
+			    unsigned int pipe_job_info_id,
+			    enum vb2_buffer_state vbf_state)

This function only returns 0. Should it be made void?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 142

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+{
+	struct mtk_dip_pipe_job_info *job_info;
+	struct mtk_dip_dev_buffer *in_buf;
+	int i, num_running_jobs;
+
+	job_info = mtk_dip_pipe_get_running_job_info(pipe, pipe_job_info_id);

Why don't we just pass mtk_dip_request as an argument ot this function? I can see that the both callers already have them.

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +8 -0
+	in_buf = job_info->buf_map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT];
+
+	spin_lock(&pipe->job_lock);
+	list_del(&job_info->list);
+	num_running_jobs = --pipe->num_jobs;
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s: num of running jobs(%d)\n",
+		__func__, pipe->desc->name, pipe->num_jobs);

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 160

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+	spin_unlock(&pipe->job_lock);
+
+	for (i = 0; i < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM; i++) {
+		struct mtk_dip_dev_buffer *dev_buf = job_info->buf_map[i];
+		struct mtk_dip_video_device *node;
+
+		if (!dev_buf)
+			continue;
+
+		if (in_buf && dev_buf != in_buf)

Is it possible that in_buf is NULL?

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+			dev_buf->vbb.vb2_buf.timestamp =
+				in_buf->vbb.vb2_buf.timestamp;
+
+		vb2_buffer_done(&dev_buf->vbb.vb2_buf, vbf_state);
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 175

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+		node = mtk_dip_vbq_to_node(dev_buf->vbb.vb2_buf.vb2_queue);
+		spin_lock(&node->buf_list_lock);
+		list_del(&dev_buf->list);
+		spin_unlock(&node->buf_list_lock);
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: return buf, idx(%d), state(%d)\n",
+			pipe->desc->name, node->desc->name,
+			dev_buf->vbb.vb2_buf.index, vbf_state);
+	}

This looks almost the same as what's being done inside mtk_dip_hw_streamoff(). Could we just call this function from the loop there?

Quoted 29 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +28 -0
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s: finished job id(%d), vbf_state(%d), running jobs(%d)\n",
+		__func__, pipe->desc->name, pipe_job_info_id, vbf_state,
+		num_running_jobs);
+
+	return 0;
+}
+
+static __u32 get_pixel_byte_by_fmt(__u32 pix_fmt)
+{
+	switch (pix_fmt) {
+	case V4L2_PIX_FMT_MTISP_B8:
+	case V4L2_PIX_FMT_MTISP_F8:
+		return 8;
+	case V4L2_PIX_FMT_MTISP_B10:
+	case V4L2_PIX_FMT_MTISP_F10:
+		return 10;
+	case V4L2_PIX_FMT_MTISP_B12:
+	case V4L2_PIX_FMT_MTISP_F12:
+		return 12;
+	case V4L2_PIX_FMT_MTISP_B14:
+	case V4L2_PIX_FMT_MTISP_F14:
+		return 14;
+	case V4L2_PIX_FMT_MTISP_U8:
+	case V4L2_PIX_FMT_MTISP_U10:
+	case V4L2_PIX_FMT_MTISP_U12:
+	case V4L2_PIX_FMT_MTISP_U14:
Quoted 1 line

From all the formats above, we only have B10 and F10 in in_fmts[]. Are they

all supported by DIP? If so, are they only missing in in_fmts[] or the driver needs more changes to support them?

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +13 -0
+		return 16;
+	default:
+		return 0;
+	}
+}
+
+static __u32
+mtk_dip_pass1_cal_main_stride(__u32 width, __u32 pix_fmt)
+{
+	__u32 stride;
+	__u32 pixel_byte = get_pixel_byte_by_fmt(pix_fmt);
+
+	width = ALIGN(width, 4);

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 226

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+	stride = ALIGN(DIV_ROUND_UP(width * pixel_byte, 8), 2);
+
+	return ALIGN(stride, 4);
+}
+
+static __u32
+mtk_dip_pass1_cal_pack_stride(__u32 width, __u32 pix_fmt)
+{
+	__u32 stride;
+	__u32 pixel_byte = get_pixel_byte_by_fmt(pix_fmt);

The __ types are only for UAPI structures. Please use the types without the prefix.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 235

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+
+	width = ALIGN(width, 4);
+	stride = DIV_ROUND_UP(width * 3, 2);
+	stride = DIV_ROUND_UP(stride * pixel_byte, 8);
+
+	if (pix_fmt == V4L2_PIX_FMT_MTISP_F10)
+		stride =  ALIGN(stride, 4);
+	else
+		stride =  ALIGN(stride, 8);

Could you explain all the calculations done above?

Quoted 62 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +62 -0
+
+	return stride;
+}
+
+static int is_stride_need_to_align(u32 format, u32 *need_aligned_fmts,
+				   int length)
+{
+	int i;
+
+	for (i = 0; i < length; i++) {
+		if (format == need_aligned_fmts[i])
+			return true;
+	}
+
+	return false;
+}
+
+/* Stride that is accepted by MDP HW */
+static u32 dip_mdp_fmt_get_stride(struct v4l2_pix_format_mplane *mfmt,
+				  const struct mtk_dip_dev_format *fmt,
+				  unsigned int plane)
+{
+	enum mdp_color c = fmt->mdp_color;
+	u32 bytesperline = (mfmt->width * fmt->row_depth[plane]) / 8;
+	u32 stride = (bytesperline * MDP_COLOR_BITS_PER_PIXEL(c))
+		/ fmt->row_depth[0];
+
+	if (plane == 0)
+		return stride;
+
+	if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+		if (MDP_COLOR_IS_BLOCK_MODE(c))
+			stride = stride / 2;
+		return stride;
+	}
+
+	return 0;
+}
+
+/* Stride that is accepted by MDP HW of format with contiguous planes */
+static u32
+dip_mdp_fmt_get_stride_contig(const struct mtk_dip_dev_format *fmt,
+			      u32 pix_stride,
+			      unsigned int plane)
+{
+	enum mdp_color c = fmt->mdp_color;
+	u32 stride = pix_stride;
+
+	if (plane == 0)
+		return stride;
+
+	if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+		stride = stride >> MDP_COLOR_GET_H_SUBSAMPLE(c);
+		if (MDP_COLOR_IS_UV_COPLANE(c) && !MDP_COLOR_IS_BLOCK_MODE(c))
+			stride = stride * 2;
+		return stride;
+	}
+
+	return 0;
+}
+
+/* Plane size that is accepted by MDP HW */

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 307

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+static u32
+dip_mdp_fmt_get_plane_size(const struct mtk_dip_dev_format *fmt,
+			   u32 stride, u32 height,
+			   unsigned int plane)
+{
+	enum mdp_color c = fmt->mdp_color;
+	u32 bytesperline;
+
+	bytesperline = (stride * fmt->row_depth[0])
+		/ MDP_COLOR_BITS_PER_PIXEL(c);

Hmm, stride and bytesperline should be exactly the same thing. Could you explain what's happening here?

Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +17 -0
+	if (plane == 0)
+		return bytesperline * height;
+	if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+		height = height >> MDP_COLOR_GET_V_SUBSAMPLE(c);
+		if (MDP_COLOR_IS_BLOCK_MODE(c))
+			bytesperline = bytesperline * 2;
+		return bytesperline * height;
+	}
+
+	return 0;
+}
+
+static int mtk_dip_pipe_get_stride(struct mtk_dip_pipe *pipe,
+				   struct v4l2_pix_format_mplane *mfmt,
+				   const struct mtk_dip_dev_format *dfmt,
+				   int plane,
+				   char *buf_name)

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 334

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+{
+	int bpl;
+	u32 fmts_pass1_main[] = {
+		V4L2_PIX_FMT_MTISP_B8,
+		V4L2_PIX_FMT_MTISP_B10
+	};
+	u32 fmts_pass1_pack[] = {
+		V4L2_PIX_FMT_MTISP_F8,
+		V4L2_PIX_FMT_MTISP_F10
+	};

We don't seem to have B8 and F8 formats in in_fmts[]. Are they just missing there or there is something else missing too?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 345

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +11 -0
+
+	if (is_stride_need_to_align(mfmt->pixelformat, fmts_pass1_main,
+				    ARRAY_SIZE(fmts_pass1_main)))
+		bpl = mtk_dip_pass1_cal_main_stride(mfmt->width,
+						    mfmt->pixelformat);
+	else if (is_stride_need_to_align(mfmt->pixelformat, fmts_pass1_pack,
+					 ARRAY_SIZE(fmts_pass1_pack)))
+		bpl = mtk_dip_pass1_cal_pack_stride(mfmt->width,
+						    mfmt->pixelformat);
+	else
+		bpl = dip_mdp_fmt_get_stride(mfmt, dfmt, plane);

Please add the information about necessary alignment to struct mtk_dip_dev_format instead of hardcoding in the local arrays above.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 355

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s:%s: plane(%d), pixelformat(%x) width(%d), stride(%d)",
+		__func__, pipe->desc->name, buf_name, plane,
+		mfmt->pixelformat, mfmt->width, bpl);
+
+	return bpl;
+}
+
+void mtk_dip_pipe_set_img_fmt(struct mtk_dip_pipe *pipe,

The function name is confusing. "Set" in V4L2 sounds like changing the active format. How about mtk_dip_pipe_try_fmt()?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +2 -0
+			      struct mtk_dip_video_device *node,
+			      struct v4l2_pix_format_mplane *mfmt_to_fill,

This is quite a long name. It should be evident that this argument is an output, so "fmt" should be good enough.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 369

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +12 -0
+			      const struct mtk_dip_dev_format *dev_fmt)
+{
+	int i;
+
+	mfmt_to_fill->pixelformat = dev_fmt->format;
+	mfmt_to_fill->num_planes = dev_fmt->num_planes;
+	mfmt_to_fill->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
+	mfmt_to_fill->quantization = V4L2_QUANTIZATION_DEFAULT;
+	mfmt_to_fill->colorspace = dev_fmt->colorspace;
+	mfmt_to_fill->field = V4L2_FIELD_NONE;
+
+	memset(mfmt_to_fill->reserved, 0, sizeof(mfmt_to_fill->reserved));

The core already takes care of zeroing the reserved fields.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 379

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s:%s: Fmt(%c%c%c%c),  w(%d),h(%d), f(%d)\n",
+		__func__, pipe->desc->name, node->desc->name,
+		mfmt_to_fill->pixelformat & 0xff,
+		mfmt_to_fill->pixelformat >> 8 & 0xff,
+		mfmt_to_fill->pixelformat >> 16 & 0xff,
+		mfmt_to_fill->pixelformat >> 24 & 0xff,
+		mfmt_to_fill->width, mfmt_to_fill->height,
+		mfmt_to_fill->field);

No need for this print. There is already built in printing of formats in the core when format-related ioctls are called.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 382

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+
+	for (i = 0; i < mfmt_to_fill->num_planes; ++i) {
+		u32 min_bpl = (mfmt_to_fill->width * dev_fmt->row_depth[i]) / 8;

Shouldn't this use DIV_ROUND_UP()? I can see some row_depth not being a multiple of 8.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 383

Quoted 1 line
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +1 -0
+		u32 bpl = mfmt_to_fill->plane_fmt[i].bytesperline;

In current V4L2 API, bytesperline is always set by the driver, so no need to preserve what came from the userspace.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 390

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +7 -0
+		u32 sizeimage;
+
+		if (bpl < min_bpl)
+			bpl = min_bpl;
+
+		sizeimage = (bpl * mfmt_to_fill->height * dev_fmt->depth[i])
+			/ dev_fmt->row_depth[i];

Shouldn't this be bpl * fmt->height?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 393

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+		mfmt_to_fill->plane_fmt[i].bytesperline = bpl;
+		if (mfmt_to_fill->plane_fmt[i].sizeimage < sizeimage)
+			mfmt_to_fill->plane_fmt[i].sizeimage = sizeimage;

Same with sizeimage. It's defined to be always written by the driver.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 396

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+
+		memset(mfmt_to_fill->plane_fmt[i].reserved,
+		       0, sizeof(mfmt_to_fill->plane_fmt[i].reserved));

The core takes care of this already.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 401

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s:%s: plane(%d): bpl(%u), min_bpl(%u), s(%u)\n",
+			__func__, pipe->desc->name, node->desc->name,
+			i, bpl, min_bpl, mfmt_to_fill->plane_fmt[i].sizeimage);

The core already has an appropriate debug message.

Quoted 25 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +25 -0
+	}
+}
+
+static void set_meta_fmt(struct mtk_dip_pipe *pipe,
+			 struct v4l2_meta_format *metafmt_to_fill,
+			 const struct mtk_dip_dev_format *dev_fmt)
+{
+	metafmt_to_fill->dataformat = dev_fmt->format;
+
+	if (dev_fmt->buffer_size <= 0) {
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s: Invalid meta buf size(%u), use default(%u)\n",
+			pipe->desc->name, dev_fmt->buffer_size,
+			MTK_DIP_DEV_META_BUF_DEFAULT_SIZE);
+
+		metafmt_to_fill->buffersize =
+			MTK_DIP_DEV_META_BUF_DEFAULT_SIZE;
+	} else {
+		metafmt_to_fill->buffersize = dev_fmt->buffer_size;
+	}
+}
+
+void mtk_dip_pipe_load_default_fmt(struct mtk_dip_pipe *pipe,
+				   struct mtk_dip_video_device *node,
+				   struct v4l2_format *fmt_to_fill)

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 436

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+{
+	int idx = node->desc->default_fmt_idx;
+
+	if (node->desc->num_fmts == 0) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: desc->num_fmts is 0, no format support list\n",
+		       __func__, node->desc->name);
+
+		return;
+	}

Is this even possible?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 444

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +8 -0
+
+	if (idx >= node->desc->num_fmts) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: invalid idx(%d), must < num_fmts(%d)\n",
+			__func__, node->desc->name, idx, node->desc->num_fmts);
+
+		idx = 0;
+	}

Is this possible too?

Quoted 23 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +23 -0
+
+	fmt_to_fill->type = node->desc->buf_type;
+	if (mtk_dip_buf_is_meta(node->desc->buf_type)) {
+		set_meta_fmt(pipe, &fmt_to_fill->fmt.meta,
+			     &node->desc->fmts[idx]);
+	} else {
+		fmt_to_fill->fmt.pix_mp.width = node->desc->default_width;
+		fmt_to_fill->fmt.pix_mp.height = node->desc->default_height;
+		mtk_dip_pipe_set_img_fmt(pipe, node, &fmt_to_fill->fmt.pix_mp,
+					 &node->desc->fmts[idx]);
+	}
+}
+
+const struct mtk_dip_dev_format*
+mtk_dip_pipe_find_fmt(struct mtk_dip_pipe *pipe,
+		      struct mtk_dip_video_device *node,
+		      u32 format)
+{
+	int i;
+
+	for (i = 0; i < node->desc->num_fmts; i++) {
+		if (node->desc->fmts[i].format == format)
+			return &node->desc->fmts[i];

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 477

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+	}
+
+	return NULL;
+}
+
+static enum mdp_ycbcr_profile
+map_ycbcr_prof_mplane(struct v4l2_pix_format_mplane *pix_mp, u32 mdp_color)
+{
+	if (MDP_COLOR_IS_RGB(mdp_color))
+		return MDP_YCBCR_PROFILE_FULL_BT601;

Similar comment as below.

Quoted 20 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +20 -0
+
+	switch (pix_mp->colorspace) {
+	case V4L2_COLORSPACE_JPEG:
+		return MDP_YCBCR_PROFILE_JPEG;
+	case V4L2_COLORSPACE_REC709:
+	case V4L2_COLORSPACE_DCI_P3:
+		if (pix_mp->quantization == V4L2_QUANTIZATION_FULL_RANGE)
+			return MDP_YCBCR_PROFILE_FULL_BT709;
+		return MDP_YCBCR_PROFILE_BT709;
+	case V4L2_COLORSPACE_BT2020:
+		if (pix_mp->quantization == V4L2_QUANTIZATION_FULL_RANGE)
+			return MDP_YCBCR_PROFILE_FULL_BT2020;
+		return MDP_YCBCR_PROFILE_BT2020;
+	}
+	/* V4L2_COLORSPACE_SRGB or else */
+	if (pix_mp->quantization == V4L2_QUANTIZATION_FULL_RANGE)
+		return MDP_YCBCR_PROFILE_FULL_BT601;
+
+	return MDP_YCBCR_PROFILE_BT601;
+}

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 507

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+
+static inline int is_contig_mp_buffer(struct mtk_dip_dev_buffer *dev_buf)
+{
+	return !(MDP_COLOR_GET_PLANE_COUNT(dev_buf->dev_fmt->mdp_color) == 1);
+}
+
+static int fill_ipi_img_param_mp(struct mtk_dip_pipe *pipe,
+				 struct img_image_buffer *b,
+				 struct mtk_dip_dev_buffer *dev_buf,
+				 char *buf_name)

Please prefix the functions with mtk_dip_.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 519

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +12 -0
+{
+	struct v4l2_pix_format_mplane *pix_mp;
+	const struct mtk_dip_dev_format *mdp_fmt;
+	unsigned int i;
+	unsigned int total_plane_size = 0;
+
+	if (!dev_buf->dev_fmt) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s: %s's dev format not set\n",
+			__func__, buf_name);
+		return -EINVAL;
+	}

Is this even possible?

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +12 -0
+
+	pix_mp = &dev_buf->fmt.fmt.pix_mp;
+	mdp_fmt = dev_buf->dev_fmt;
+
+	b->usage = dev_buf->dma_port;
+	b->format.colorformat = dev_buf->dev_fmt->mdp_color;
+	b->format.width = dev_buf->fmt.fmt.pix_mp.width;
+	b->format.height = dev_buf->fmt.fmt.pix_mp.height;
+	b->format.ycbcr_prof =
+		map_ycbcr_prof_mplane(pix_mp,
+				      dev_buf->dev_fmt->mdp_color);
+	dev_dbg(&pipe->dip_dev->pdev->dev,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 541

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+		"%s: buf(%s), IPI: w(%d),h(%d),c(0x%x)\n",
+		pipe->desc->name,
+		buf_name,
+		b->format.width,
+		b->format.height,
+		b->format.colorformat);
+
+	for (i = 0; i < pix_mp->num_planes; ++i) {
+		u32 stride = mtk_dip_pipe_get_stride(pipe, pix_mp, mdp_fmt,
+						     i, buf_name);

Shouldn't stride be just equal to pix_mp.plane[i].bytesperline?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 544

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+
+		b->format.plane_fmt[i].stride = stride;
+		b->format.plane_fmt[i].size =

Shouldn't size be just equal to pix_mp.plane[i].sizeimage?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 557

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +13 -0
+			dip_mdp_fmt_get_plane_size(mdp_fmt, stride,
+						   pix_mp->height, i);
+		b->iova[i] = dev_buf->isp_daddr[i];
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"Non-contiguous-mp-buf:plane(%i),stride(%d),size(%d),iova(%lx)",
+			i,
+			b->format.plane_fmt[i].stride,
+			b->format.plane_fmt[i].size,
+			b->iova[i]);
+		total_plane_size += b->format.plane_fmt[i].size;
+	}
+
+	if (!is_contig_mp_buffer(dev_buf)) {

Shouldn't this be just (pix_mp->num_planes > 1)?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 566

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"Non-contiguous-mp-buf(%s),total-plane-size(%d),dma_port(%d)\n",
+			buf_name,
+			total_plane_size,
+			b->usage);
+		return 0;
+	}
+
+	for (; i < MDP_COLOR_GET_PLANE_COUNT(b->format.colorformat); ++i) {

I don't see these MDP_ macros defined anywhere. Please don't use macros defined from other drivers. We can embed this information in the mtk_dip_dev_format struct. One would normally call it num_cplanes (color planes).

However, I would just make this driver support M formats only and forget about formats with only memory planes count != color planes count.

Quoted 46 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +46 -0
+		u32 stride = dip_mdp_fmt_get_stride_contig
+				(mdp_fmt, b->format.plane_fmt[0].stride, i);
+
+		b->format.plane_fmt[i].stride = stride;
+		b->format.plane_fmt[i].size =
+			dip_mdp_fmt_get_plane_size(mdp_fmt, stride,
+						   pix_mp->height, i);
+		b->iova[i] = b->iova[i - 1] + b->format.plane_fmt[i - 1].size;
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"Contiguous-mp-buf:plane(%i),stride(%d),size(%d),iova(%lx)",
+			i,
+			b->format.plane_fmt[i].stride,
+			b->format.plane_fmt[i].size,
+			b->iova[i]);
+		total_plane_size += b->format.plane_fmt[i].size;
+	}
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"Contiguous-mp-buf(%s),v4l2-sizeimage(%d),total-plane-size(%d)\n",
+		buf_name,
+		pix_mp->plane_fmt[0].sizeimage,
+		total_plane_size);
+
+	return 0;
+}
+
+static int fill_input_ipi_param(struct mtk_dip_pipe *pipe,
+				struct img_input *iin,
+				struct mtk_dip_dev_buffer *dev_buf,
+				char *buf_name)
+{
+	struct img_image_buffer *img = &iin->buffer;
+
+	return fill_ipi_img_param_mp(pipe, img, dev_buf,
+				     buf_name);
+}
+
+static int fill_output_ipi_param(struct mtk_dip_pipe *pipe,
+				 struct img_output *iout,
+				 struct mtk_dip_dev_buffer *dev_buf_out,
+				 struct mtk_dip_dev_buffer *dev_buf_in,
+				 char *buf_name)
+{
+	int ret;
+	struct img_image_buffer *img = &iout->buffer;
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 622

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+	ret = fill_ipi_img_param_mp(pipe, img, dev_buf_out,
+				    buf_name);
+	iout->crop.left = 0;
+	iout->crop.top = 0;
+	iout->crop.width = dev_buf_in->fmt.fmt.pix_mp.width;
+	iout->crop.height = dev_buf_in->fmt.fmt.pix_mp.height;
+	iout->crop.left_subpix = 0;
+	iout->crop.top_subpix = 0;
+	iout->crop.width_subpix = 0;
+	iout->crop.height_subpix = 0;

So we don't support cropping?

Quoted 51 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +51 -0
+	iout->rotation = dev_buf_out->rotation;
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s: buf(%s) IPI-ext:c_l(%d),c_t(%d),c_w(%d),c_h(%d)\n",
+		pipe->desc->name,
+		buf_name,
+		iout->crop.left,
+		iout->crop.top,
+		iout->crop.width,
+		iout->crop.height);
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"c_ls(%d),c_ts(%d),c_ws(%d),c_hs(%d),rot(%d)\n",
+		iout->crop.left_subpix,
+		iout->crop.top_subpix,
+		iout->crop.width_subpix,
+		iout->crop.height_subpix,
+		iout->rotation);
+
+	return ret;
+}
+
+void mtk_dip_pipe_ipi_params_config(struct mtk_dip_request *req)
+{
+	struct mtk_dip_pipe *pipe = req->dip_pipe;
+	struct platform_device *pdev = pipe->dip_dev->pdev;
+	struct mtk_dip_pipe_job_info *pipe_job_info = &req->job_info;
+	int out_img_buf_idx;
+	int in_img_buf_idx;
+	struct img_ipi_frameparam *dip_param = &req->img_fparam.frameparam;
+	struct mtk_dip_dev_buffer *dev_buf_in;
+	struct mtk_dip_dev_buffer *dev_buf_out;
+	struct mtk_dip_dev_buffer *dev_buf_tuning;
+	int i = 0;
+	int mdp_ids[2] = {MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE,
+			  MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE};
+	char *mdp_names[2] = {"mdp0", "mdp1"};
+
+	dev_dbg(&pdev->dev,
+		"%s:%s: pipe-job id(%d)\n",
+		__func__, pipe->desc->name,
+		pipe_job_info->id);
+
+	/* Fill ipi params for DIP driver */
+	memset(dip_param, 0, sizeof(*dip_param));
+	dip_param->index = pipe_job_info->id;
+	dip_param->type = STREAM_ISP_IC;
+
+	/* Tuning buffer */
+	dev_buf_tuning =
+		pipe_job_info->buf_map[MTK_DIP_VIDEO_NODE_ID_TUNING_OUT];

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 683

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+	if (dev_buf_tuning) {
+		dev_dbg(&pdev->dev,
+			"Tuning buf queued: scp_daddr(%pad),isp_daddr(%pad)\n",
+			&dev_buf_tuning->scp_daddr[0],
+			&dev_buf_tuning->isp_daddr[0]);
+		dip_param->tuning_data.pa =
+			(uint32_t)dev_buf_tuning->scp_daddr[0];
+		dip_param->tuning_data.present = true;
+		dip_param->tuning_data.iova =
+			(uint32_t)dev_buf_tuning->isp_daddr[0];

Why are these casts needed?

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+	} else {
+		dev_dbg(&pdev->dev,
+			"No enqueued tuning buffer: scp_daddr(%llx),present(%llx),isp_daddr(%llx\n",
+			dip_param->tuning_data.pa,
+			dip_param->tuning_data.present,
+			dip_param->tuning_data.iova);
+	}
+
+	in_img_buf_idx = 0;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 702

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+
+	/* Raw-in buffer */
+	dev_buf_in =
+		pipe_job_info->buf_map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT];
+	if (dev_buf_in) {
+		struct img_input *iin = &dip_param->inputs[in_img_buf_idx];
+
+		fill_input_ipi_param(pipe, iin, dev_buf_in, "RAW");
+		in_img_buf_idx++;
+	}

Is it possible that we don't have an input buffer?

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+
+	/* Array of MDP buffers */
+	out_img_buf_idx = 0;
+
+	for (i = 0; i < ARRAY_SIZE(mdp_ids); i++) {
+		dev_buf_out =
+			pipe_job_info->buf_map[mdp_ids[i]];
+		if (dev_buf_out) {
+			struct img_output *iout =

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 721

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+				&dip_param->outputs[out_img_buf_idx];
+
+			fill_output_ipi_param(pipe, iout, dev_buf_out,
+					      dev_buf_in, mdp_names[i]);
+			out_img_buf_idx++;
+		}
+	}
+
+	dip_param->num_outputs = out_img_buf_idx;
+	dip_param->num_inputs = in_img_buf_idx;

Wouldn't this be always 1?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 730

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+}
+
+void mtk_dip_pipe_try_enqueue(struct mtk_dip_pipe *pipe)
+{
+	struct mtk_dip_pipe_job_info *job_info;
+	struct mtk_dip_pipe_job_info *tmp_job_info;
+	struct list_head enqueue_job_list;
+
+	INIT_LIST_HEAD(&enqueue_job_list);

You can merge this with the declaration by using

Quoted 28 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +28 -0
+	if (!pipe->streaming)
+		return;
+
+	spin_lock(&pipe->job_lock);
+	list_for_each_entry_safe(job_info, tmp_job_info,
+				 &pipe->pipe_job_pending_list,
+				 list) {
+		list_del(&job_info->list);
+		pipe->num_pending_jobs--;
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: current num of pending jobs(%d)\n",
+			__func__, pipe->desc->name,
+			pipe->num_pending_jobs);
+		list_add_tail(&job_info->list,
+			      &enqueue_job_list);
+	}
+	spin_unlock(&pipe->job_lock);
+
+	list_for_each_entry_safe(job_info, tmp_job_info,
+				 &enqueue_job_list,
+				 list) {
+		struct mtk_dip_request *req =
+				mtk_dip_pipe_job_info_to_req(job_info);
+
+		list_del(&job_info->list);
+
+		spin_lock(&pipe->job_lock);
+		list_add_tail(&job_info->list,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 768

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+			      &pipe->pipe_job_running_list);
+			pipe->num_jobs++;
+			dev_dbg(&pipe->dip_dev->pdev->dev,
+				"%s:%s: current num of running jobs(%d)\n",
+				__func__, pipe->desc->name,
+				pipe->num_jobs);
+		spin_unlock(&pipe->job_lock);
+
+		mtk_dip_hw_enqueue(&pipe->dip_dev->dip_hw, req);
+	}

Please check my comments to the P1 RFCv3 for a similar block of code.

Quoted 50 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +1 -0
+}
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +43 -0
new file mode 100644
index 000000000000..e3372c291f9a
@@ -0,0 +1,337 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *
+ */
+
+#ifndef _MTK_DIP_DEV_H_
+#define _MTK_DIP_DEV_H_
+
+#include <linux/types.h>
+#include <linux/platform_device.h>
+#include <media/v4l2-ctrls.h>
+#include <media/v4l2-subdev.h>
+#include <media/v4l2-device.h>
+#include <linux/videodev2.h>
+#include <media/videobuf2-core.h>
+#include <media/videobuf2-v4l2.h>
+
+#include "mtk_dip-hw.h"
+
+#define MTK_DIP_PIPE_ID_PREVIEW				0
+#define MTK_DIP_PIPE_ID_CAPTURE				1
+#define MTK_DIP_PIPE_ID_REPROCESS			2
+#define MTK_DIP_PIPE_ID_TOTAL_NUM			3
+
+#define MTK_DIP_VIDEO_NODE_ID_RAW_OUT			0
+#define MTK_DIP_VIDEO_NODE_ID_TUNING_OUT		1
+#define MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM		2
+#define MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE		2
+#define MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE		3
+#define MTK_DIP_VIDEO_NODE_ID_CAPTURE_TOTAL_NUM		2
+#define MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM \
+	(MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM + \
+	MTK_DIP_VIDEO_NODE_ID_CAPTURE_TOTAL_NUM)
+
+#define MTK_DIP_VIDEO_NODE_ID_NO_MASTER			-1
+
+#define MTK_DIP_OUTPUT_MIN_WIDTH		2U
+#define MTK_DIP_OUTPUT_MIN_HEIGHT		2U
+#define MTK_DIP_OUTPUT_MAX_WIDTH		5376U
+#define MTK_DIP_OUTPUT_MAX_HEIGHT		4032U

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 53

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +10 -0
+#define MTK_DIP_CAPTURE_MIN_WIDTH		2U
+#define MTK_DIP_CAPTURE_MIN_HEIGHT		2U
+#define MTK_DIP_CAPTURE_MAX_WIDTH		5376U
+#define MTK_DIP_CAPTURE_MAX_HEIGHT		4032U
+
+#define MTK_DIP_DEV_DIP_MEDIA_MODEL_NAME	"MTK-ISP-DIP-V4L2"
+#define MTK_DIP_DEV_DIP_PREVIEW_NAME \
+	MTK_DIP_DEV_DIP_MEDIA_MODEL_NAME
+#define MTK_DIP_DEV_DIP_CAPTURE_NAME		"MTK-ISP-DIP-CAP-V4L2"
+#define MTK_DIP_DEV_DIP_REPROCESS_NAME		"MTK-ISP-DIP-REP-V4L2"

Could we have a bit more user friendly names here? For example:

Driver name: "mtk-cam-dip"
Preview pipe: "%s %s", dev_driver_string(), "preview" Capture pipe: "%s %s", dev_driver_string(), "capture" Preview pipe: "%s %s", dev_driver_string(), "reprocess"

(For reference, I suggested "mtk-cam-p1" for P1, so that would be consistent with the above.)

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 58

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +5 -0
+
+#define MTK_DIP_DEV_META_BUF_DEFAULT_SIZE	(1024 * 128)
+#define MTK_DIP_DEV_META_BUF_POOL_MAX_SIZE	(1024 * 1024 * 6)
+
+#define V4L2_CID_MTK_DIP_MAX			100

Why 100? I think we just have 1 rotation control. Please just use 1 explicitly in the code, without this intermediate constant.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 66

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +8 -0
+
+enum mtk_dip_pixel_mode {
+	mtk_dip_pixel_mode_default = 0,
+	mtk_dip_pixel_mode_1,
+	mtk_dip_pixel_mode_2,
+	mtk_dip_pixel_mode_4,
+	mtk_dip_pixel_mode_num,
+};

This doesn't seem to be used anywhere.

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +4 -0
+
+struct mtk_dip_dev_format {
+	u32 format;
+	u32 mdp_color;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 80

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +10 -0
+	u32 colorspace;
+	u8 depth[VIDEO_MAX_PLANES];
+	u8 row_depth[VIDEO_MAX_PLANES];
+	u8 num_planes;
+	u8 walign;
+	u8 halign;
+	u8 salign;
+	u32 flags;
+	u32 buffer_size;
+};

Please document all the structures defined in the driver using kerneldoc.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 87

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +7 -0
+
+struct mtk_dip_pipe_job_info {
+	int id;
+	struct mtk_dip_dev_buffer*
+		buf_map[MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM];
+	struct list_head list;
+};

Is there any reason to separate this from mtk_dip_request?

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +5 -0
+
+struct mtk_dip_dev_buffer {
+	struct vb2_v4l2_buffer vbb;
+	struct v4l2_format fmt;
+	const struct mtk_dip_dev_format *dev_fmt;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 102

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +10 -0
+	int pipe_job_id;
+	dma_addr_t isp_daddr[VB2_MAX_PLANES];
+	dma_addr_t scp_daddr[VB2_MAX_PLANES];
+	unsigned int dma_port;
+	int rotation;
+	struct list_head list;
+};
+
+struct mtk_dip_pipe_desc {
+	char *name;

Shouldn't this be const char *?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 113

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +11 -0
+	int master;
+	int id;
+	const struct mtk_dip_video_device_desc *output_queue_descs;
+	int total_output_queues;
+	const struct mtk_dip_video_device_desc *capture_queue_descs;
+	int total_capture_queues;
+};
+
+struct mtk_dip_video_device_desc {
+	int id;
+	char *name;

Shouldn't this be const char *?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 119

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +6 -0
+	u32 buf_type;
+	u32 cap;
+	int smem_alloc;
+	const struct mtk_dip_dev_format *fmts;
+	int num_fmts;
+	char *description;

Shouldn't this be const char *?

Quoted 49 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +49 -0
+	int default_width;
+	int default_height;
+	unsigned int dma_port;
+	const struct v4l2_frmsizeenum *frmsizeenum;
+	const struct v4l2_ioctl_ops *ops;
+	u32 flags;
+	int default_fmt_idx;
+};
+
+struct mtk_dip_dev_queue {
+	struct vb2_queue vbq;
+	/* Serializes vb2 queue and video device operations */
+	struct mutex lock;
+	const struct mtk_dip_dev_format *dev_fmt;
+	int rotation;
+};
+
+struct mtk_dip_video_device {
+	struct video_device vdev;
+	struct mtk_dip_dev_queue dev_q;
+	struct v4l2_format vdev_fmt;
+	struct media_pad vdev_pad;
+	struct v4l2_mbus_framefmt pad_fmt;
+	struct v4l2_ctrl_handler ctrl_handler;
+	u32 flags;
+	const struct mtk_dip_video_device_desc *desc;
+	atomic_t sequence;
+	struct list_head buf_list;
+	/* protect the in-device buffer list */
+	spinlock_t buf_list_lock;
+};
+
+struct mtk_dip_pipe {
+	struct mtk_dip_dev *dip_dev;
+	struct mtk_dip_video_device nodes[MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM];
+	int num_nodes;
+	atomic_t cnt_nodes_not_streaming;
+	int streaming;
+	struct media_pad *subdev_pads;
+	struct media_pipeline pipeline;
+	struct v4l2_subdev subdev;
+	struct v4l2_subdev_fh *fh;
+	atomic_t pipe_job_sequence;
+	struct list_head pipe_job_pending_list;
+	int num_pending_jobs;
+	struct list_head pipe_job_running_list;
+	int num_jobs;
+	/* Serializes pipe's stream on/off and buffers enqueue operations */
+	struct mutex lock;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 178

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +10 -0
+	spinlock_t job_lock; /* protect the pipe job list */
+	const struct mtk_dip_pipe_desc *desc;
+};
+
+struct mtk_dip_dev {
+	struct platform_device *pdev;
+	struct media_device mdev;
+	struct v4l2_device v4l2_dev;
+	struct mtk_dip_pipe dip_pipe[MTK_DIP_PIPE_ID_TOTAL_NUM];
+	struct mtk_dip_hw dip_hw;

nit: There isn't much benefit from having the separate mtk_dip_hw struct here. On the contrary it causes long dereference chains, which only clutter the code, e.g. "&pipe->dip_dev->dip_hw.scp_pdev->dev".

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 184

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +6 -0
+};
+
+struct mtk_dip_request {
+	struct media_request req;
+	struct mtk_dip_pipe *dip_pipe;
+	struct mtk_dip_pipe_job_info job_info;

Is there a need to have mtk_dip_pipe_job_info as a separate struct rather than just having the fields here?

Quoted 140 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +140 -0
+	struct img_frameparam img_fparam;
+	struct work_struct fw_work;
+	struct work_struct mdp_work;
+	/* It is used only in timeout handling flow */
+	struct work_struct mdpcb_work;
+	struct mtk_dip_hw_subframe *working_buf;
+	atomic_t buf_count;
+};
+
+int mtk_dip_dev_media_register(struct device *dev,
+			       struct media_device *media_dev,
+			       const char *model);
+
+void mtk_dip_dev_v4l2_release(struct mtk_dip_dev *dip_dev);
+
+int mtk_dip_dev_v4l2_register(struct device *dev,
+			      struct media_device *media_dev,
+			      struct v4l2_device *v4l2_dev);
+
+int mtk_dip_pipe_v4l2_register(struct mtk_dip_pipe *pipe,
+			       struct media_device *media_dev,
+			       struct v4l2_device *v4l2_dev);
+
+void mtk_dip_pipe_v4l2_unregister(struct mtk_dip_pipe *pipe);
+
+int mtk_dip_pipe_queue_buffers(struct media_request *req, int initial);
+
+int mtk_dip_pipe_init(struct mtk_dip_pipe *pipe,
+		      struct mtk_dip_dev *dip_dev,
+		      const struct mtk_dip_pipe_desc *setting,
+		      struct media_device *media_dev,
+		      struct v4l2_device *v4l2_dev);
+
+void mtk_dip_pipe_ipi_params_config(struct mtk_dip_request *req);
+
+int mtk_dip_pipe_release(struct mtk_dip_pipe *pipe);
+
+struct mtk_dip_pipe_job_info *
+mtk_dip_pipe_get_running_job_info(struct mtk_dip_pipe *pipe,
+				  int pipe_job_id);
+
+int mtk_dip_pipe_next_job_id(struct mtk_dip_pipe *pipe);
+
+void mtk_dip_pipe_debug_job(struct mtk_dip_pipe *pipe,
+			    struct mtk_dip_pipe_job_info *pipe_job_info);
+
+int mtk_dip_pipe_job_finish(struct mtk_dip_pipe *pipe,
+			    unsigned int pipe_job_info_id,
+			    enum vb2_buffer_state state);
+
+const struct mtk_dip_dev_format *
+mtk_dip_pipe_find_fmt(struct mtk_dip_pipe *pipe,
+		      struct mtk_dip_video_device *node,
+		      u32 format);
+
+void mtk_dip_pipe_set_img_fmt(struct mtk_dip_pipe *pipe,
+			      struct mtk_dip_video_device *node,
+			      struct v4l2_pix_format_mplane *mfmt_to_fill,
+			      const struct mtk_dip_dev_format *dev_fmt);
+
+void mtk_dip_pipe_load_default_fmt(struct mtk_dip_pipe *pipe,
+				   struct mtk_dip_video_device *node,
+				   struct v4l2_format *fmt_to_fill);
+
+void mtk_dip_pipe_try_enqueue(struct mtk_dip_pipe *pipe);
+
+void mtk_dip_hw_enqueue(struct mtk_dip_hw *dip_hw, struct mtk_dip_request *req);
+
+int mtk_dip_hw_streamoff(struct mtk_dip_pipe *pipe);
+
+int mtk_dip_hw_streamon(struct mtk_dip_pipe *pipe);
+
+static inline struct mtk_dip_pipe*
+mtk_dip_dev_get_pipe(struct mtk_dip_dev *dip_dev, unsigned int pipe_id)
+{
+	if (pipe_id < 0 && pipe_id >= MTK_DIP_PIPE_ID_TOTAL_NUM)
+		return NULL;
+
+	return &dip_dev->dip_pipe[pipe_id];
+}
+
+static inline struct mtk_dip_video_device*
+mtk_dip_file_to_node(struct file *file)
+{
+	return container_of(video_devdata(file),
+			    struct mtk_dip_video_device, vdev);
+}
+
+static inline struct mtk_dip_pipe*
+mtk_dip_subdev_to_pipe(struct v4l2_subdev *sd)
+{
+	return container_of(sd, struct mtk_dip_pipe, subdev);
+}
+
+static inline struct mtk_dip_dev*
+mtk_dip_mdev_to_dev(struct media_device *mdev)
+{
+	return container_of(mdev, struct mtk_dip_dev, mdev);
+}
+
+static inline struct mtk_dip_video_device*
+mtk_dip_vbq_to_node(struct vb2_queue *vq)
+{
+	return container_of(vq, struct mtk_dip_video_device, dev_q.vbq);
+}
+
+static inline struct mtk_dip_dev_buffer*
+mtk_dip_vb2_buf_to_dev_buf(struct vb2_buffer *vb)
+{
+	return container_of(vb, struct mtk_dip_dev_buffer, vbb.vb2_buf);
+}
+
+static inline struct mtk_dip_dev *mtk_dip_hw_to_dev(struct mtk_dip_hw *dip_hw)
+{
+	return container_of(dip_hw, struct mtk_dip_dev, dip_hw);
+}
+
+static inline struct mtk_dip_request*
+mtk_dip_pipe_job_info_to_req(struct mtk_dip_pipe_job_info *job_info)
+{
+	return container_of(job_info, struct mtk_dip_request, job_info);
+}
+
+static inline struct mtk_dip_request*
+mtk_dip_hw_fw_work_to_req(struct work_struct *fw_work)
+{
+	return container_of(fw_work, struct mtk_dip_request, fw_work);
+}
+
+static inline struct mtk_dip_request*
+mtk_dip_hw_mdp_work_to_req(struct work_struct *mdp_work)
+{
+	return container_of(mdp_work, struct mtk_dip_request, mdp_work);
+}
+
+static inline struct mtk_dip_request *
+mtk_dip_hw_mdpcb_work_to_req(struct work_struct *mdpcb_work)
+{
+	return container_of(mdpcb_work, struct mtk_dip_request, mdpcb_work);
+}

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 334

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +10 -0
+
+static inline int mtk_dip_buf_is_meta(u32 type)
+{
+	return type == V4L2_BUF_TYPE_META_CAPTURE ||
+		type == V4L2_BUF_TYPE_META_OUTPUT;
+}
+
+static inline int mtk_dip_pipe_get_pipe_from_job_id(int pipe_job_id)
+{
+	return (pipe_job_id >> 16) & 0x0000FFFF;

Please use lowercase for hex numbers.

Quoted 15 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +3 -0
+}
+
+#endif /* _MTK_DIP_DEV_H_ */
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +6 -0
new file mode 100644
index 000000000000..2dd4dae4336c
@@ -0,0 +1,155 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *         Holmes Chiou <holmes.chiou-NuS5LvNUpcJWk0Htik3J/[email protected]>

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 16

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +10 -0
+ *
+ */
+
+#ifndef _MTK_DIP_HW_H_
+#define _MTK_DIP_HW_H_
+
+#include <linux/clk.h>
+#include "mtk-img-ipi.h"
+
+#define DIP_COMPOSER_THREAD_TIMEOUT	16U

Unused.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 19

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +3 -0
+#define DIP_COMPOSING_MAX_NUM		3
+#define DIP_MAX_ERR_COUNT		188U
+#define DIP_FLUSHING_WQ_TIMEOUT		(16U * DIP_MAX_ERR_COUNT)

Any rationale behind this particular numbers? Please add comments explaining them.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 31

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +12 -0
+
+#define DIP_FRM_SZ			(76 * 1024)
+#define DIP_SUB_FRM_SZ			(16 * 1024)
+#define DIP_TUNING_SZ			(32 * 1024)
+#define DIP_COMP_SZ			(24 * 1024)
+#define DIP_FRAMEPARAM_SZ		(4 * 1024)
+
+#define DIP_TUNING_OFFSET		DIP_SUB_FRM_SZ
+#define DIP_COMP_OFFSET			(DIP_TUNING_OFFSET + DIP_TUNING_SZ)
+#define DIP_FRAMEPARAM_OFFSET		(DIP_COMP_OFFSET + DIP_COMP_SZ)
+#define DIP_SUB_FRM_DATA_NUM		32
+#define DIP_SCP_WORKINGBUF_OFFSET	(5 * 1024 * 1024)

What is this offset? It's 5 MB, which is 2x bigger than the total frame data (32 * 76 * 1024).

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 32

Quoted 1 line
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +1 -0
+#define DIP_V4l2_META_BUF_OFFSET	(DIP_SCP_WORKINGBUF_OFFSET + \

Please use only uppsercase in macro names. That said, this macro isn't used anywhere.

Quoted 16 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +16 -0
+					 DIP_SUB_FRM_DATA_NUM * DIP_FRM_SZ)
+
+#define MTK_DIP_CLK_NUM 2
+
+enum STREAM_TYPE_ENUM {
+	STREAM_UNKNOWN,
+	STREAM_BITBLT,
+	STREAM_GPU_BITBLT,
+	STREAM_DUAL_BITBLT,
+	STREAM_2ND_BITBLT,
+	STREAM_ISP_IC,
+	STREAM_ISP_VR,
+	STREAM_ISP_ZSD,
+	STREAM_ISP_IP,
+	STREAM_ISP_VSS,
+	STREAM_ISP_ZSD_SLOW,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 58

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +10 -0
+	STREAM_WPE,
+	STREAM_WPE2,
+};
+
+enum mtk_dip_hw_user_state {
+	DIP_STATE_INIT	= 0,
+	DIP_STATE_OPENED,
+	DIP_STATE_STREAMON,
+	DIP_STATE_STREAMOFF
+};

Are these 2 enums above a part of the firmware ABI?

Quoted 15 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +15 -0
+
+struct mtk_dip_hw_working_buf {
+	dma_addr_t scp_daddr;
+	void *vaddr;
+	dma_addr_t isp_daddr;
+};
+
+struct mtk_dip_hw_subframe {
+	struct mtk_dip_hw_working_buf buffer;
+	int size;
+	struct mtk_dip_hw_working_buf config_data;
+	struct mtk_dip_hw_working_buf tuning_buf;
+	struct mtk_dip_hw_working_buf frameparam;
+	struct list_head list_entry;
+};

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 83

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +10 -0
+
+enum frame_state {
+	FRAME_STATE_INIT = 0,
+	FRAME_STATE_COMPOSING,
+	FRAME_STATE_RUNNING,
+	FRAME_STATE_DONE,
+	FRAME_STATE_STREAMOFF,
+	FRAME_STATE_ERROR,
+	FRAME_STATE_HW_TIMEOUT
+};

Are these values a part of the firmware ABI? If so, they should be defined as macros, with explicit values assigned.

Quoted 37 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +37 -0
+
+struct mtk_dip_hw_working_buf_list {
+	struct list_head list;
+	u32 cnt;
+	spinlock_t lock; /* protect the list and cnt */
+
+};
+
+struct mtk_dip_hw {
+	struct clk_bulk_data clks[MTK_DIP_CLK_NUM];
+	struct workqueue_struct *composer_wq;
+	struct workqueue_struct *mdp_wq;
+	wait_queue_head_t working_buf_wq;
+	wait_queue_head_t flushing_wq;
+	wait_queue_head_t flushing_hw_wq;
+	atomic_t num_composing;	/* increase after ipi */
+	/* increase after calling MDP driver */
+	atomic_t num_running;
+	/*MDP/GCE callback workqueue */
+	struct workqueue_struct *mdpcb_workqueue;
+	/* for MDP driver  */
+	struct platform_device *mdp_pdev;
+	/* for SCP driver  */
+	struct platform_device *scp_pdev;
+	struct rproc *rproc_handle;
+	struct mtk_dip_hw_working_buf_list dip_freebufferlist;
+	struct mtk_dip_hw_working_buf_list dip_usedbufferlist;
+	dma_addr_t working_buf_mem_scp_daddr;
+	void *working_buf_mem_vaddr;
+	dma_addr_t working_buf_mem_isp_daddr;
+	int working_buf_mem_size;
+	struct mtk_dip_hw_subframe working_buf[DIP_SUB_FRM_DATA_NUM];
+	/* increase after enqueue */
+	atomic_t dip_enque_cnt;
+	/* increase after stream on, decrease when stream off */
+	atomic_t dip_stream_cnt;
+	/* To serialize request opertion to DIP co-procrosser and hadrware */

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 130

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +10 -0
+	struct mutex hw_op_lock;
+	/* To restrict the max number of request be send to SCP */
+	struct semaphore sem;
+};
+
+static inline void
+mtk_dip_wbuf_to_ipi_img_sw_addr(struct img_sw_addr *ipi_addr,
+				struct mtk_dip_hw_working_buf *wbuf)
+{
+	ipi_addr->va = (u64)wbuf->vaddr;

Why would IPI need VA? Actually, we shouldn't even pass kernel pointers to the firmware for security reasons.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 138

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +8 -0
+	ipi_addr->pa = (u32)wbuf->scp_daddr;
+}
+
+static inline void
+mtk_dip_wbuf_to_ipi_img_addr(struct img_addr *ipi_addr,
+			     struct mtk_dip_hw_working_buf *wbuf)
+{
+	ipi_addr->va = (u64)wbuf->vaddr;

Ditto.

Quoted 116 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +17 -0
+	ipi_addr->pa = (u32)wbuf->scp_daddr;
+	ipi_addr->iova = (u32)wbuf->isp_daddr;
+}
+
+static inline void
+mtk_dip_wbuf_to_ipi_tuning_addr(struct tuning_addr *ipi_addr,
+				struct mtk_dip_hw_working_buf *wbuf)
+{
+	ipi_addr->pa = (u32)wbuf->scp_daddr;
+	ipi_addr->iova = (u32)wbuf->isp_daddr;
+}
+
+int mtk_dip_hw_working_buf_pool_init(struct mtk_dip_hw *dip_hw);
+void mtk_dip_hw_working_buf_pool_release(struct mtk_dip_hw *dip_hw);
+
+#endif /* _MTK_DIP_HW_H_ */
+
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +93 -0
new file mode 100644
index 000000000000..603be116b03f
@@ -0,0 +1,794 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *         Holmes Chiou <holmes.chiou-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *
+ */
+
+#include <linux/device.h>
+#include <linux/dma-iommu.h>
+#include <linux/freezer.h>
+#include <linux/platform_data/mtk_scp.h>
+#include <linux/pm_runtime.h>
+#include <linux/remoteproc.h>
+#include <linux/slab.h>
+#include <linux/spinlock.h>
+#include <linux/wait.h>
+#include "mtk-mdp3-cmdq.h"
+#include "mtk_dip-dev.h"
+#include "mtk_dip-hw.h"
+
+int mtk_dip_hw_working_buf_pool_init(struct mtk_dip_hw *dip_hw)
+{
+	int i;
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+	const int working_buf_size = round_up(DIP_FRM_SZ, PAGE_SIZE);
+	phys_addr_t working_buf_paddr;
+
+	INIT_LIST_HEAD(&dip_hw->dip_freebufferlist.list);
+	spin_lock_init(&dip_hw->dip_freebufferlist.lock);
+	dip_hw->dip_freebufferlist.cnt = 0;
+
+	INIT_LIST_HEAD(&dip_hw->dip_usedbufferlist.list);
+	spin_lock_init(&dip_hw->dip_usedbufferlist.lock);
+	dip_hw->dip_usedbufferlist.cnt = 0;
+
+	init_waitqueue_head(&dip_hw->working_buf_wq);
+
+	dip_hw->working_buf_mem_size = DIP_SUB_FRM_DATA_NUM * working_buf_size +
+		DIP_SCP_WORKINGBUF_OFFSET;
+	dip_hw->working_buf_mem_vaddr =
+		dma_alloc_coherent(&dip_hw->scp_pdev->dev,
+				   dip_hw->working_buf_mem_size,
+				   &dip_hw->working_buf_mem_scp_daddr,
+				   GFP_KERNEL);
+	if (!dip_hw->working_buf_mem_vaddr) {
+		dev_err(&dip_dev->pdev->dev,
+			"memory alloc size %ld failed\n",
+			dip_hw->working_buf_mem_size);
+		return -ENOMEM;
+	}
+
+	/*
+	 * We got the incorrect physical address mapped when
+	 * using dma_map_single() so I used dma_map_page_attrs()
+	 * directly to workaround here.
+	 *
+	 * When I use dma_map_single() to map the address, the
+	 * physical address retrieved back with iommu_get_domain_for_dev()
+	 * and iommu_iova_to_phys() was not equal to the
+	 * SCP dma address (it should be the same as the physical address
+	 * since we don't have iommu), and was shifted by 0x4000000.
+	 */
+	working_buf_paddr = dip_hw->working_buf_mem_scp_daddr;
+	dip_hw->working_buf_mem_isp_daddr =
+		dma_map_page_attrs(&dip_dev->pdev->dev,
+				   phys_to_page(working_buf_paddr),
+				   0, dip_hw->working_buf_mem_size,
+				   DMA_BIDIRECTIONAL,
+				   DMA_ATTR_SKIP_CPU_SYNC);
+	if (dma_mapping_error(&dip_dev->pdev->dev,
+			      dip_hw->working_buf_mem_isp_daddr)) {
+		dev_err(&dip_dev->pdev->dev,
+			"failed to map buffer: s_daddr(%pad)\n",
+			&dip_hw->working_buf_mem_scp_daddr);
+		dma_free_coherent(&dip_hw->scp_pdev->dev,
+				  dip_hw->working_buf_mem_size,
+				  dip_hw->working_buf_mem_vaddr,
+				  dip_hw->working_buf_mem_scp_daddr);
+
+		return -ENOMEM;
+	}
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: working_buf_mem: vaddr(%p), scp_daddr(%pad)\n",
+		__func__,
+		dip_hw->working_buf_mem_vaddr,
+		&dip_hw->working_buf_mem_scp_daddr);
+
+	for (i = 0; i < DIP_SUB_FRM_DATA_NUM; i++) {
+		struct mtk_dip_hw_subframe *buf = &dip_hw->working_buf[i];
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 103

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+		/*
+		 * Total: 0 ~ 72 KB
+		 * SubFrame: 0 ~ 16 KB
+		 */
+		buf->buffer.scp_daddr = dip_hw->working_buf_mem_scp_daddr +
+			DIP_SCP_WORKINGBUF_OFFSET + i * working_buf_size;
+		buf->buffer.vaddr = dip_hw->working_buf_mem_vaddr +
+			DIP_SCP_WORKINGBUF_OFFSET + i * working_buf_size;
+		buf->buffer.isp_daddr = dip_hw->working_buf_mem_isp_daddr +
+			DIP_SCP_WORKINGBUF_OFFSET + i * working_buf_size;

Could you move out the offset to a local variable so that we don't duplicate the same calculation 3 times?

Quoted 105 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +105 -0
+		buf->size = working_buf_size;
+
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: buf(%d), scp_daddr(%pad), isp_daddr(%pad)\n",
+			__func__, i, &buf->buffer.scp_daddr,
+			&buf->buffer.isp_daddr);
+
+		/* Tuning: 16 ~ 48 KB */
+		buf->tuning_buf.scp_daddr =
+			buf->buffer.scp_daddr + DIP_TUNING_OFFSET;
+		buf->tuning_buf.vaddr =
+			buf->buffer.vaddr + DIP_TUNING_OFFSET;
+		buf->tuning_buf.isp_daddr =
+			buf->buffer.isp_daddr + DIP_TUNING_OFFSET;
+
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: tuning_buf(%d), scp_daddr(%pad), isp_daddr(%pad)\n",
+			__func__, i, &buf->tuning_buf.scp_daddr,
+			&buf->tuning_buf.isp_daddr);
+
+		/* Config_data: 48 ~ 72 KB */
+		buf->config_data.scp_daddr =
+			buf->buffer.scp_daddr + DIP_COMP_OFFSET;
+		buf->config_data.vaddr = buf->buffer.vaddr + DIP_COMP_OFFSET;
+
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: config_data(%d), scp_daddr(%pad), vaddr(%p)\n",
+			__func__, i, &buf->config_data.scp_daddr,
+			buf->config_data.vaddr);
+
+		/* Frame parameters: 72 ~ 76 KB */
+		buf->frameparam.scp_daddr =
+			buf->buffer.scp_daddr + DIP_FRAMEPARAM_OFFSET;
+		buf->frameparam.vaddr =
+			buf->buffer.vaddr + DIP_FRAMEPARAM_OFFSET;
+
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: frameparam(%d), scp_daddr(%pad), vaddr(%p)\n",
+			__func__, i, &buf->frameparam.scp_daddr,
+			buf->frameparam.vaddr);
+
+		list_add_tail(&buf->list_entry,
+			      &dip_hw->dip_freebufferlist.list);
+		dip_hw->dip_freebufferlist.cnt++;
+	}
+
+	return 0;
+}
+
+void mtk_dip_hw_working_buf_pool_release(struct mtk_dip_hw *dip_hw)
+{
+	/* All the buffer should be in the freebufferlist when release */
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+	u32 i;
+
+	if (dip_hw->dip_usedbufferlist.cnt)
+		dev_warn(&dip_dev->pdev->dev,
+			 "%s: dip_usedbufferlist is not empty (%d/%d)\n",
+			__func__, dip_hw->dip_usedbufferlist.cnt, i);
+
+	dma_unmap_page_attrs(&dip_dev->pdev->dev,
+			     dip_hw->working_buf_mem_isp_daddr,
+			     dip_hw->working_buf_mem_size, DMA_BIDIRECTIONAL,
+			     DMA_ATTR_SKIP_CPU_SYNC);
+
+	dma_free_coherent(&dip_hw->scp_pdev->dev, dip_hw->working_buf_mem_size,
+			  dip_hw->working_buf_mem_vaddr,
+			  dip_hw->working_buf_mem_scp_daddr);
+}
+
+static void mtk_dip_hw_working_buf_free(struct mtk_dip_hw *dip_hw,
+					struct mtk_dip_hw_subframe *working_buf)
+{
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+
+	if (!working_buf)
+		return;
+
+	spin_lock(&dip_hw->dip_usedbufferlist.lock);
+	list_del(&working_buf->list_entry);
+			dip_hw->dip_usedbufferlist.cnt--;
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: Free used buffer(%pad)\n",
+		__func__, &working_buf->buffer.scp_daddr);
+	spin_unlock(&dip_hw->dip_usedbufferlist.lock);
+
+	spin_lock(&dip_hw->dip_freebufferlist.lock);
+	list_add_tail(&working_buf->list_entry,
+		      &dip_hw->dip_freebufferlist.list);
+	dip_hw->dip_freebufferlist.cnt++;
+	spin_unlock(&dip_hw->dip_freebufferlist.lock);
+}
+
+static struct mtk_dip_hw_subframe*
+mtk_dip_hw_working_buf_alloc(struct mtk_dip_hw *dip_hw)
+{
+	struct mtk_dip_hw_subframe *working_buf;
+
+	spin_lock(&dip_hw->dip_freebufferlist.lock);
+	if (list_empty(&dip_hw->dip_freebufferlist.list)) {
+		spin_unlock(&dip_hw->dip_freebufferlist.lock);
+		return NULL;
+	}
+
+	working_buf = list_first_entry(&dip_hw->dip_freebufferlist.list,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 218

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+				       struct mtk_dip_hw_subframe, list_entry);
+	list_del(&working_buf->list_entry);
+	dip_hw->dip_freebufferlist.cnt--;
+	spin_unlock(&dip_hw->dip_freebufferlist.lock);
+
+	spin_lock(&dip_hw->dip_usedbufferlist.lock);
+	list_add_tail(&working_buf->list_entry,
+		      &dip_hw->dip_usedbufferlist.list);
+	dip_hw->dip_usedbufferlist.cnt++;
+	spin_unlock(&dip_hw->dip_usedbufferlist.lock);

Do we really need this usedbufferlist?

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +12 -0
+
+	return working_buf;
+}
+
+static void mtk_dip_notify(struct mtk_dip_request *req)
+{
+	struct mtk_dip_hw *dip_hw = &req->dip_pipe->dip_dev->dip_hw;
+	struct mtk_dip_dev *dip_dev = req->dip_pipe->dip_dev;
+	struct mtk_dip_pipe *pipe = req->dip_pipe;
+	struct img_ipi_frameparam *iparam = &req->img_fparam.frameparam;
+	enum vb2_buffer_state vbf_state;
+	int ret;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 240

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+
+	if (iparam->state != FRAME_STATE_HW_TIMEOUT)
+		vbf_state = VB2_BUF_STATE_DONE;
+	else
+		vbf_state = VB2_BUF_STATE_ERROR;
+
+	ret = mtk_dip_pipe_job_finish(pipe, iparam->index, vbf_state);
+	if (ret)
+		dev_dbg(&dip_dev->pdev->dev, "%s: finish CB failed(%d)\n",
+			__func__, ret);

I can see that function only returns 0.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 242

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +2 -0
+
+	pm_runtime_put_autosuspend(&pipe->dip_dev->pdev->dev);

It's necessary to call pm_runtime_mask_last_busy() before this for autosuspend to work in any useful way.

Quoted 27 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +27 -0
+
+	mtk_dip_hw_working_buf_free(dip_hw, req->working_buf);
+	req->working_buf = NULL;
+	wake_up(&dip_hw->working_buf_wq);
+	wake_up(&dip_hw->flushing_wq);
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s:%s: job id(%d), frame_no(%d) finished\n",
+		__func__, pipe->desc->name, iparam->index, iparam->frame_no);
+}
+
+static void mdp_cb_timeout_worker(struct work_struct *work)
+{
+	struct mtk_dip_request *req = mtk_dip_hw_mdpcb_work_to_req(work);
+	struct img_ipi_param ipi_param;
+
+	dev_dbg(&req->dip_pipe->dip_dev->pdev->dev,
+		"%s: send frame no(%d) HW timeout dbg IPI\n",
+		__func__, req->img_fparam.frameparam.frame_no);
+
+	ipi_param.usage = IMG_IPI_DEBUG;
+	scp_ipi_send(req->dip_pipe->dip_dev->dip_hw.scp_pdev, SCP_IPI_DIP,
+		     (void *)&ipi_param, sizeof(ipi_param), 0);
+	mtk_dip_notify(req);
+}
+
+/* Maybe in IRQ context of cmdq */

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 279

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+static void dip_mdp_cb_func(struct cmdq_cb_data data)
+{
+	struct mtk_dip_request *req;
+	struct mtk_dip_dev *dip_dev;
+
+	if (!data.data) {
+		pr_err("%s: data->data is NULL\n",
+		       __func__);
+		return;
+	}

I'd just make this:

if (WARN_ON(!data.data))

	return;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 281

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +2 -0
+
+	req = data.data;

We could just assign this in the declaration and also make the check above test for !req instead.

Quoted 19 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +19 -0
+	dip_dev = req->dip_pipe->dip_dev;
+
+	dev_dbg(&dip_dev->pdev->dev, "%s: req(%p), idx(%d), no(%d), s(%d), n_in(%d), n_out(%d)\n",
+		__func__,
+		req,
+		req->img_fparam.frameparam.index,
+		req->img_fparam.frameparam.frame_no,
+		req->img_fparam.frameparam.state,
+		req->img_fparam.frameparam.num_inputs,
+		req->img_fparam.frameparam.num_outputs);
+
+	if (data.sta != CMDQ_CB_NORMAL) {
+		dev_err(&dip_dev->pdev->dev, "%s: frame no(%d) HW timeout\n",
+			__func__, req->img_fparam.frameparam.frame_no);
+		req->img_fparam.frameparam.state = FRAME_STATE_HW_TIMEOUT;
+		INIT_WORK(&req->mdpcb_work, mdp_cb_timeout_worker);
+		queue_work(req->dip_pipe->dip_dev->dip_hw.mdpcb_workqueue,
+			   &req->mdpcb_work);
+	} else {

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 310

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+		mtk_dip_notify(req);
+	}
+}
+
+static void dip_runner_func(struct work_struct *work)
+{
+	struct mtk_dip_request *req = mtk_dip_hw_mdp_work_to_req(work);
+	struct mtk_dip_dev *dip_dev = req->dip_pipe->dip_dev;
+	struct img_config *config_data =
+		(struct img_config *)req->img_fparam.frameparam.config_data.va;

Could we get a proper pointer from the driver (not IPI) structures? I think that should be req->working_buf->config_data?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 317

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +7 -0
+	u32 num;
+
+	/*
+	 * Call MDP/GCE API to do HW excecution
+	 * Pass the framejob to MDP driver
+	 */
+	req->img_fparam.frameparam.state = FRAME_STATE_COMPOSING;

Should this be really composing? I thought we just finished composing at this point.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 318

Quoted 1 line
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +1 -0
+	num = atomic_inc_return(&dip_dev->dip_hw.num_running);

I don't see where this counter is decremented. Could we just remove it?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 327

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s,MDP running num(%d)\n", __func__, num);
+	mdp_cmdq_sendtask(dip_dev->dip_hw.mdp_pdev,
+			  config_data,
+			  &req->img_fparam.frameparam,
+			  NULL,
+			  false,
+			  dip_mdp_cb_func,
+			  req);

It's not a regular convention in the kernel coding style to wrap the lines for each single argument.

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +11 -0
+}
+
+static void dip_scp_handler(void *data, unsigned int len, void *priv)
+{
+	struct mtk_dip_pipe_job_info *pipe_job_info;
+	struct mtk_dip_pipe *pipe;
+	int pipe_id;
+	struct mtk_dip_request *req;
+	struct img_ipi_frameparam *frameparam;
+	struct mtk_dip_dev *dip_dev = (struct mtk_dip_dev *)priv;
+	struct mtk_dip_hw *dip_hw = &dip_dev->dip_hw;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 348

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+	struct img_ipi_param *ipi_param;
+	u32 num;
+	int ret;
+
+	if (WARN_ONCE(!data, "%s: failed due to NULL data\n", __func__))
+		return;
+
+	ipi_param = (struct img_ipi_param *)data;
+
+	if (ipi_param->usage != IMG_IPI_FRAME) {

Should we check len before dereferencing the pointer?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 351

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +3 -0
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: recevied SCP_IPI_DIP ACK, ipi_param.usage(%d)\n",
+			__func__, ipi_param->usage);

Is this an expected situation? If not, perhaps we should at least print a warning here?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 355

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+		return;
+	}
+
+	frameparam = (struct img_ipi_frameparam *)ipi_param->frm_param.va;

Are we getting a kernel virtual address from the firmware here? That's a recipe for a disaster. What if there is a bug (or a security hole) there and the address ends up accidentally (or deliberately) pointing to some critical kernel data?

We should get some kind of job identifier from the firmware and then try to find a matching request in our request list. Then any buffer addresses should be retrieved from the request struct itself.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 358

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +3 -0
+	pipe_id = mtk_dip_pipe_get_pipe_from_job_id(frameparam->index);
+	pipe = mtk_dip_dev_get_pipe(dip_dev, pipe_id);
+

nit: The next line is directly related to previous, so no need for the blank line.

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+	if (!pipe) {
+		dev_warn(&dip_dev->pdev->dev,
+			 "%s: get invalid img_ipi_frameparam index(%d) from firmware\n",
+			 __func__, frameparam->frame_no);
+		return;
+	}
+
+	pipe_job_info =	mtk_dip_pipe_get_running_job_info(pipe,
+							  frameparam->index);

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 377

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+
+	if (WARN_ONCE(!pipe_job_info, "%s: frame_no(%d) is lost\n",
+		      __func__, frameparam->frame_no))
+		return;
+
+	req = mtk_dip_pipe_job_info_to_req(pipe_job_info);
+	memcpy(&req->img_fparam.frameparam, frameparam,
+	       sizeof(req->img_fparam.frameparam));
+	num = atomic_dec_return(&dip_hw->num_composing);
+	down(&dip_hw->sem);

I think this should be up()?

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: frame_no(%d) is back, composing num(%d)\n",
+		__func__, frameparam->frame_no, num);

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 391

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+
+	wake_up(&dip_dev->dip_hw.flushing_hw_wq);
+
+	INIT_WORK(&req->mdp_work, dip_runner_func);
+	ret = queue_work(dip_hw->mdp_wq, &req->mdp_work);
+	if (!ret) {
+		dev_dbg(&dip_dev->pdev->dev,
+			"frame_no(%d) queue_work failed to mdp_wq: %d\n",
+			frameparam->frame_no, ret);
+	}

It shouldn't be possible for this to fail given that it's a new request and the work was just initialized above.

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+}
+
+static bool
+mtk_dip_hw_is_working_buf_allocated(struct mtk_dip_request *req)
+{
+	req->working_buf =
+		mtk_dip_hw_working_buf_alloc(&req->dip_pipe->dip_dev->dip_hw);
+
+	if (!req->working_buf) {

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 410

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+		dev_dbg(&req->dip_pipe->dip_dev->pdev->dev,
+			"%s:%s:req(%p): no free working buffer available\n",
+			__func__, req->dip_pipe->desc->name, req);
+		return false;
+	}
+
+	return true;
+}
+
+static void dip_submit_worker(struct work_struct *work)

Shouldn't this be called dip_composer_workfunc()?

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +6 -0
+{
+	struct mtk_dip_request *req = mtk_dip_hw_fw_work_to_req(work);
+	struct mtk_dip_hw *dip_hw = &req->dip_pipe->dip_dev->dip_hw;
+	struct mtk_dip_dev *dip_dev = req->dip_pipe->dip_dev;
+	struct img_ipi_param ipi_param;
+	struct mtk_dip_hw_subframe *buf;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 426

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+	int ret;
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: to send frame_no(%d),num(%d)\n",
+		__func__, req->img_fparam.frameparam.frame_no,
+		atomic_read(&dip_hw->num_composing));
+
+	wait_event_freezable(dip_hw->working_buf_wq,
+			     mtk_dip_hw_is_working_buf_allocated(req));
+	up(&dip_hw->sem);

Shouldn't this be down_freezable()? The idea to use semaphores was to avoid such custom wait_event() calls like above.

Basically the semaphore should be initialized with the total number of composer buffers and once down() is called that number of times, any further down() would block until some up() is called.

Quoted 24 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +24 -0
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: wakeup frame_no(%d),num(%d)\n",
+		__func__, req->img_fparam.frameparam.frame_no,
+		atomic_read(&dip_hw->num_composing));
+
+	buf = req->working_buf;
+	mtk_dip_wbuf_to_ipi_img_addr(&req->img_fparam.frameparam.subfrm_data,
+				     &buf->buffer);
+	memset(buf->buffer.vaddr, 0, DIP_SUB_FRM_SZ);
+	mtk_dip_wbuf_to_ipi_img_sw_addr(&req->img_fparam.frameparam.config_data,
+					&buf->config_data);
+	memset(buf->config_data.vaddr, 0, DIP_COMP_SZ);
+
+	if (!req->img_fparam.frameparam.tuning_data.present) {
+		/*
+		 * When user enqueued without tuning buffer,
+		 * it would use driver internal buffer.
+		 */
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: frame_no(%d) has no tuning_data\n",
+			__func__, req->img_fparam.frameparam.frame_no);
+
+		mtk_dip_wbuf_to_ipi_tuning_addr

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 460

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+				(&req->img_fparam.frameparam.tuning_data,
+				 &buf->tuning_buf);
+		memset(buf->tuning_buf.vaddr, 0, DIP_TUNING_SZ);
+	}
+
+	req->img_fparam.frameparam.state = FRAME_STATE_COMPOSING;
+	mtk_dip_wbuf_to_ipi_img_sw_addr(&req->img_fparam.frameparam.self_data,
+					&buf->frameparam);
+	memcpy(buf->frameparam.vaddr, &req->img_fparam.frameparam,
+	       sizeof(req->img_fparam.frameparam));

Is img_fparam really used at this stage? I can only see ipi_param passed to the IPI.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 467

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +7 -0
+
+	ipi_param.usage = IMG_IPI_FRAME;
+	mtk_dip_wbuf_to_ipi_img_sw_addr(&ipi_param.frm_param,
+					&buf->frameparam);
+
+	mutex_lock(&dip_hw->hw_op_lock);
+	atomic_inc(&dip_hw->num_composing);

Do we still need this num_composing counter once we have the semaphore?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 472

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	ret = scp_ipi_send(dip_hw->scp_pdev, SCP_IPI_DIP, &ipi_param,
+			   sizeof(ipi_param), 0);
+	if (ret)
+		dev_dbg(&dip_dev->pdev->dev, "%s: send SCP_IPI_DIP_FRAME failed %d\n",
+			__func__, ret);

This is an error, isn't it? We need to have proper error handling here, which at this stage would mean completing the request with buffers returned with ERROR state.

Quoted 50 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +50 -0
+	mutex_unlock(&dip_hw->hw_op_lock);
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: frame_no(%d),idx(0x%x), composing num(%d)\n",
+		__func__, req->img_fparam.frameparam.frame_no,
+		req->img_fparam.frameparam.index,
+		atomic_read(&dip_hw->num_composing));
+}
+
+static int mtk_dip_hw_res_init(struct mtk_dip_hw *dip_hw)
+{
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+	int ret;
+
+	dip_hw->mdp_pdev = mdp_get_plat_device(dip_dev->pdev);
+	if (!dip_hw->mdp_pdev) {
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: failed to get MDP device\n",
+			__func__);
+		return -EINVAL;
+	}
+
+	dip_hw->mdpcb_workqueue =
+		alloc_ordered_workqueue("%s",
+					__WQ_LEGACY | WQ_MEM_RECLAIM |
+					WQ_FREEZABLE,
+					"mdp_callback");
+	if (!dip_hw->mdpcb_workqueue) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s: unable to alloc mdpcb workqueue\n", __func__);
+		ret = -ENOMEM;
+		goto destroy_mdpcb_wq;
+	}
+
+	dip_hw->composer_wq =
+		alloc_ordered_workqueue("%s",
+					__WQ_LEGACY | WQ_MEM_RECLAIM |
+					WQ_FREEZABLE,
+					"dip_composer");
+	if (!dip_hw->composer_wq) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s: unable to alloc composer workqueue\n", __func__);
+		ret = -ENOMEM;
+		goto destroy_dip_composer_wq;
+	}
+
+	dip_hw->mdp_wq =
+		alloc_ordered_workqueue("%s",
+					__WQ_LEGACY | WQ_MEM_RECLAIM |
+					WQ_FREEZABLE,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 532

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+					"dip_runner");
+	if (!dip_hw->mdp_wq) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s: unable to alloc dip_runner\n", __func__);
+		ret = -ENOMEM;
+		goto destroy_dip_runner_wq;
+	}
+
+	init_waitqueue_head(&dip_hw->flushing_wq);
+	init_waitqueue_head(&dip_hw->flushing_hw_wq);

nit: To avoid confusing workqueues with waitqueues, I'd suggest using _waitq suffix, which seems to be quite common in the kernel code. (And _workq or _workqueue for workqueues are not common at all.)

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 543

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +11 -0
+
+	return 0;
+
+destroy_dip_runner_wq:
+	destroy_workqueue(dip_hw->mdp_wq);
+
+destroy_dip_composer_wq:
+	destroy_workqueue(dip_hw->composer_wq);
+
+destroy_mdpcb_wq:
+	destroy_workqueue(dip_hw->mdpcb_workqueue);

Let's use consistent naming, i.e. mdpcb_wq.

Quoted 20 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +20 -0
+
+	return ret;
+}
+
+static int mtk_dip_hw_res_release(struct mtk_dip_dev *dip_dev)
+{
+	flush_workqueue(dip_dev->dip_hw.mdp_wq);
+	destroy_workqueue(dip_dev->dip_hw.mdp_wq);
+	dip_dev->dip_hw.mdp_wq = NULL;
+
+	flush_workqueue(dip_dev->dip_hw.mdpcb_workqueue);
+	destroy_workqueue(dip_dev->dip_hw.mdpcb_workqueue);
+	dip_dev->dip_hw.mdpcb_workqueue = NULL;
+
+	flush_workqueue(dip_dev->dip_hw.composer_wq);
+	destroy_workqueue(dip_dev->dip_hw.composer_wq);
+	dip_dev->dip_hw.composer_wq = NULL;
+
+	atomic_set(&dip_dev->dip_hw.num_composing, 0);
+	atomic_set(&dip_dev->dip_hw.num_running, 0);

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 573

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+	atomic_set(&dip_dev->dip_hw.dip_enque_cnt, 0);
+
+	return 0;
+}
+
+static bool mtk_dip_pipe_running_job_list_empty(struct mtk_dip_pipe *pipe,
+						int *num)
+{
+	spin_lock(&pipe->job_lock);
+	*num = pipe->num_jobs;

We can just check list_empty(&pipe->pipe_job_running_list) here and remove pipe->num_jobs completely.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 582

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+	spin_unlock(&pipe->job_lock);
+
+	return !(*num);
+}
+
+static int mtk_dip_hw_flush_pipe_jobs(struct mtk_dip_pipe *pipe)
+{
+	int num;
+	int ret = wait_event_freezable_timeout

nit: Could we avoid mixing non-trivial code with declarations?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 585

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +3 -0
+		(pipe->dip_dev->dip_hw.flushing_wq,
+		 mtk_dip_pipe_running_job_list_empty(pipe, &num),
+		 msecs_to_jiffies(DIP_FLUSHING_WQ_TIMEOUT));

We shouldn't wait here for all the jobs to complete, just those that are already queued to hardware. The stop operation should be as instant as possible.

This should basically be done like this:
- remove any pending jobs not queued to the hardware yet,
- wait for the hardware to finish anything that can't be cancelled - possibly the same wait as done in mtk_dip_suspend().

Quoted 25 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +25 -0
+
+	if (!ret && num) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s: flushing is aborted, num(%d)\n",
+			__func__, num);
+		return -EINVAL;
+	}
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s: wakeup num(%d)\n", __func__, num);
+	return 0;
+}
+
+static int mtk_dip_hw_connect(struct mtk_dip_dev *dip_dev)
+{
+	int ret;
+	struct img_ipi_param ipi_param;
+
+	pm_runtime_get_sync(&dip_dev->pdev->dev);
+
+	scp_ipi_register(dip_dev->dip_hw.scp_pdev, SCP_IPI_DIP, dip_scp_handler,
+			 dip_dev);
+	memset(&ipi_param, 0, sizeof(ipi_param));
+	ipi_param.usage = IMG_IPI_INIT;
+	ret = scp_ipi_send(dip_dev->dip_hw.scp_pdev, SCP_IPI_DIP, &ipi_param,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 620

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+			   sizeof(ipi_param), 200);
+	if (ret) {
+		dev_dbg(&dip_dev->pdev->dev, "%s: send SCP_IPI_DIP_FRAME failed %d\n",
+			__func__, ret);
+		return -EBUSY;
+	}
+
+	pm_runtime_put_autosuspend(&dip_dev->pdev->dev);
+
+	ret = mtk_dip_hw_res_init(&dip_dev->dip_hw);

There isn't anything in that function that couldn't be just done once in probe. Could we just move it there?

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+	if (ret) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s: mtk_dip_hw_res_init failed(%d)\n", __func__, ret);
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 634

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+		return -EBUSY;
+	}
+
+	return 0;
+}
+
+static void mtk_dip_hw_disconnect(struct mtk_dip_dev *dip_dev)
+{
+	int ret;
+

No need to send IMG_IPI_DEINIT?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 639

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	ret = mtk_dip_hw_res_release(dip_dev);
+	if (ret)
+		dev_err(&dip_dev->pdev->dev,
+			"%s: mtk_dip_hw_res_release failed ret(%d)\n",
+			__func__, ret);

No need to call scp_ipi_unregister()?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 648

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+}
+
+int mtk_dip_hw_streamon(struct mtk_dip_pipe *pipe)
+{
+	struct mtk_dip_dev *dip_dev = pipe->dip_dev;
+	int count, ret;
+
+	mutex_lock(&dip_dev->dip_hw.hw_op_lock);
+	count = atomic_read(&dip_dev->dip_hw.dip_stream_cnt);

No need to use atomics if this is already protected with a mutex.

Quoted 26 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +26 -0
+	if (!count) {
+		ret = mtk_dip_hw_connect(pipe->dip_dev);
+		if (ret) {
+			dev_err(&pipe->dip_dev->pdev->dev,
+				"%s:%s: pipe(%d) connect to dip_hw failed\n",
+				__func__, pipe->desc->name, pipe->desc->id);
+
+			mutex_unlock(&dip_dev->dip_hw.hw_op_lock);
+
+			return ret;
+		}
+
+		count = atomic_inc_return(&dip_dev->dip_hw.dip_stream_cnt);
+	}
+	mutex_unlock(&dip_dev->dip_hw.hw_op_lock);
+
+	mutex_lock(&pipe->lock);
+	pipe->streaming = 1;
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s: started stream, id(%d), stream cnt(%d)\n",
+		__func__, pipe->desc->name, pipe->desc->id, count);
+	mtk_dip_pipe_try_enqueue(pipe);
+	mutex_unlock(&pipe->lock);
+
+	return 0;
+}

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 684

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+
+int mtk_dip_hw_streamoff(struct mtk_dip_pipe *pipe)
+{
+	struct mtk_dip_dev *dip_dev = pipe->dip_dev;
+	struct mtk_dip_pipe_job_info *job_info;
+	struct mtk_dip_pipe_job_info *tmp_job_info;
+	s32 count;
+	int ret;
+
+	mutex_lock(&pipe->lock);

Given that we end up calling this from mtk_dip_vb2_stop_streaming(), after the locking changes I suggested, this function will be called with this lock acquired already.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 689

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s:%s: streamoff, removing all running jobs\n",
+		__func__, pipe->desc->name);
+
+	spin_lock(&pipe->job_lock);

The loop below is quite heavy weight as for something that runs under a spinlock (that by definition should only protect short critical sections). Could we just splice the list into a local list_head under the spinlock and then just iterate over the local list after releasing the spinlock?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 691

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +2 -0
+	list_for_each_entry_safe(job_info, tmp_job_info,
+				 &pipe->pipe_job_running_list, list) {

Don't we need to stop the hardware first?

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +12 -0
+		struct mtk_dip_request *req =
+			mtk_dip_pipe_job_info_to_req(job_info);
+		int i;
+
+		for (i = 0; i < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM; i++) {
+			struct mtk_dip_dev_buffer *dev_buf =
+				job_info->buf_map[i];
+			struct mtk_dip_video_device *node;
+
+			if (!dev_buf)
+				continue;
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 713

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+			node = mtk_dip_vbq_to_node
+				(dev_buf->vbb.vb2_buf.vb2_queue);
+			vb2_buffer_done(&dev_buf->vbb.vb2_buf,
+					VB2_BUF_STATE_ERROR);
+			dev_dbg(&dip_dev->pdev->dev,
+				"%s:%s: return buf, idx(%d), state(%d)\n",
+				pipe->desc->name, node->desc->name,
+				dev_buf->vbb.vb2_buf.index,
+				VB2_BUF_STATE_ERROR);
+		}

I can see that there is an existing mtk_dip_return_all_buffers() function that would return all the buffers of given video node when it's being stopped. How does this code interfere with that code?

Actually, I'm not fully sure anymore what's the expected behavior here. I've asked on #v4l and will let you know once we figure out.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 716

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +3 -0
+
+		pipe->num_jobs--;
+		list_del(&job_info->list);

We don't need to delete and decrement here. Just set to 0 and init list head after the loop. (The latter wouldn't be needed if we splice the list into a local list head.)

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: not run job, id(%d), no(%d), state(%d), job cnt(%d)\n",
+			__func__, pipe->desc->name, job_info->id,
+			req->img_fparam.frameparam.frame_no,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 731

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+			VB2_BUF_STATE_ERROR, pipe->num_jobs);
+	}
+	spin_unlock(&pipe->job_lock);
+
+	ret = mtk_dip_hw_flush_pipe_jobs(pipe);
+	if (WARN_ON(ret != 0)) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s:%s: mtk_dip_hw_flush_pipe_jobs, ret(%d)\n",
+			__func__, pipe->desc->name, ret);
+	}

I suppose this should be the very first thing to do in this function.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 738

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +7 -0
+
+	pipe->streaming = 0;
+	mutex_unlock(&pipe->lock);
+
+	mutex_lock(&dip_dev->dip_hw.hw_op_lock);
+	count = atomic_read(&dip_dev->dip_hw.dip_stream_cnt);
+	if (count > 0 && atomic_dec_and_test(&dip_dev->dip_hw.dip_stream_cnt)) {

It shouldn't be possible for count to be <= 0 at this point. Are you seeing cases like that when running the code?

Quoted 29 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +29 -0
+		mtk_dip_hw_disconnect(dip_dev);
+
+		dev_dbg(&dip_dev->pdev->dev, "%s: dip_hw disconnected, stream cnt(%d)\n",
+			__func__, atomic_read(&dip_dev->dip_hw.dip_stream_cnt));
+	}
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s: stopped stream id(%d), stream cnt(%d)\n",
+		__func__, pipe->desc->name, pipe->desc->id, count);
+
+	mutex_unlock(&dip_dev->dip_hw.hw_op_lock);
+
+	return 0;
+}
+
+void mtk_dip_hw_enqueue(struct mtk_dip_hw *dip_hw,
+			struct mtk_dip_request *req)
+{
+	struct img_ipi_frameparam *frameparams = &req->img_fparam.frameparam;
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+	int ret;
+	struct mtk_dip_dev_buffer **map = req->job_info.buf_map;
+
+	/*
+	 * Workaround to pass v4l2 compliance test when it pass only one buffer
+	 * to DIP. The check is already done in request_validate().
+	 */
+	if (!map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT] ||
+	    (!map[MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE] &&
+	     !map[MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE])){

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 777

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+		dev_dbg(&dip_dev->pdev->dev,
+			"won't trigger hw job: raw(%p), mdp0(%p), mdp1(%p)\n",
+			map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT],
+			map[MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE],
+			map[MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE]);
+
+		mtk_dip_pipe_job_finish(req->dip_pipe, req->job_info.id,
+					VB2_BUF_STATE_DONE);
+		return;
+	}

Please remove the workarounds. There is no value in passing the test if there is a workaround for it. If it keeps failing we at least know that we need to fix something.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 781

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+
+	mtk_dip_pipe_ipi_params_config(req);
+	frameparams->state = FRAME_STATE_INIT;
+	frameparams->frame_no = atomic_inc_return(&dip_hw->dip_enque_cnt);

typo: enqueue

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 788

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +7 -0
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: hw job id(%d), frame_no(%d) into worklist\n",
+		__func__, frameparams->index, frameparams->frame_no);
+
+	INIT_WORK(&req->fw_work, dip_submit_worker);
+	pm_runtime_get_sync(&dip_dev->pdev->dev);

Aren't we still just only composing the job? Should we wait with this call until we actually queue the job to the ISP hardware?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 793

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	ret = queue_work(dip_hw->composer_wq, &req->fw_work);
+	if (!ret)
+		dev_dbg(&dip_dev->pdev->dev,
+			"frame_no(%d) queue_work failed, already on a queue\n",
+			frameparams->frame_no, ret);

How is this possible? (I recall seeing this somewhere already. Was it the P1 driver?)

Quoted 29 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +1 -0
+}
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +22 -0
new file mode 100644
index 000000000000..7b454952566f
@@ -0,0 +1,1786 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *
+ */
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/platform_data/mtk_scp.h>
+#include <linux/pm_runtime.h>
+#include <linux/remoteproc.h>
+#include <linux/videodev2.h>
+#include <media/videobuf2-dma-contig.h>
+#include <media/v4l2-ioctl.h>
+#include <media/v4l2-subdev.h>
+#include <media/v4l2-event.h>
+#include "mtk_dip-dev.h"
+#include "mtk_dip-hw.h"
+#include "mtk-mdp3-regs.h"

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 32

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+
+static int mtk_dip_subdev_open(struct v4l2_subdev *sd,
+			       struct v4l2_subdev_fh *fh)
+{
+	struct mtk_dip_pipe *pipe = mtk_dip_subdev_to_pipe(sd);
+
+	dev_dbg(&pipe->dip_dev->pdev->dev, "%s:%s: pipe(%d) open\n",
+		__func__, pipe->desc->name, pipe->desc->id);
+
+	pipe->fh = fh;

What is this needed for?

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+
+	return 0;
+}
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 46

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+static int mtk_dip_subdev_close(struct v4l2_subdev *sd,
+				struct v4l2_subdev_fh *fh)
+{
+	struct mtk_dip_pipe *pipe = mtk_dip_subdev_to_pipe(sd);
+
+	dev_dbg(&pipe->dip_dev->pdev->dev, "%s:%s: pipe(%d) close\n",
+		__func__, pipe->desc->name, pipe->desc->id);
+
+	return 0;
+}

Do we need to implement this?

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+
+static int mtk_dip_subdev_s_stream(struct v4l2_subdev *sd,
+				   int enable)
+{

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 60

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	struct mtk_dip_pipe *pipe = mtk_dip_subdev_to_pipe(sd);
+	int ret;
+
+	if (enable) {
+		ret = mtk_dip_hw_streamon(pipe);
+		if (ret) {
+			dev_err(&pipe->dip_dev->pdev->dev,
+				"%s:%s: pipe(%d) streamon failed\n",
+				__func__, pipe->desc->name, pipe->desc->id);
+		}

CodingStyle: No brackets needed for only 1 statement.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 63

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +3 -0
+
+		return ret;
+	}

nit: Since the 2 cases are symmetrical (as opposed to success and failure), I would put them in if/else.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 70

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +7 -0
+
+	ret = mtk_dip_hw_streamoff(pipe);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: pipe(%d) streamon off with errors\n",
+			__func__, pipe->desc->name, pipe->desc->id);
+	}

CodingStyle: No brackets needed for only 1 statement.

Quoted 18 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +18 -0
+
+	return ret;
+}
+
+static int mtk_dip_link_setup(struct media_entity *entity,
+			      const struct media_pad *local,
+			      const struct media_pad *remote,
+			      u32 flags)
+{
+	struct mtk_dip_pipe *pipe =
+		container_of(entity, struct mtk_dip_pipe, subdev.entity);
+	u32 pad = local->index;
+	int count;
+
+	WARN_ON(entity->obj_type != MEDIA_ENTITY_TYPE_V4L2_SUBDEV);
+	WARN_ON(pad >= pipe->num_nodes);
+
+	mutex_lock(&pipe->lock);

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 98

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	if (!vb2_start_streaming_called(&pipe->nodes[pad].dev_q.vbq)) {
+		int enable = flags & MEDIA_LNK_FL_ENABLED;
+		int node_enabled =
+			pipe->nodes[pad].flags & MEDIA_LNK_FL_ENABLED;
+
+		if (enable && !node_enabled)
+			atomic_inc_return(&pipe->cnt_nodes_not_streaming);
+
+		if (!enable && node_enabled)
+			atomic_dec_return(&pipe->cnt_nodes_not_streaming);

Given that we need to acquire the big pipe mutex anyway, there is probably no need to be too smart here anyway.

I suggested this method with counter
with hope that we could simplify the locking, but apparently that didn't have such effect.

Let's just make this simple:
1) serialize full link_setup, start_streaming and stop_streaming with pipe->lock,
2) keep two bitmasks, pipe->nodes_streaming and pipe->nodes_enabled,
3) use media_pipeline_start/stop() to lock the enabled state, as suggested in my comment for mtk_dip_vb2_start_streaming(), so that we don't need to think about streaming state here in this function.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 100

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +2 -0
+	}
+	pipe->nodes[pad].flags &= ~(MEDIA_LNK_FL_ENABLED);

No need for the parentheses.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 101

Quoted 1 line
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +1 -0
+	pipe->nodes[pad].flags |= MEDIA_LNK_FL_ENABLED & flags;

The typical convention is to have the constants on the right.

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +13 -0
+	count = atomic_read(&pipe->cnt_nodes_not_streaming);
+	mutex_unlock(&pipe->lock);
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s: link setup, flags(0x%x), (%s)%d -->(%s)%d, cnt_nodes_ns(%d)\n",
+		pipe->desc->name, flags, local->entity->name, local->index,
+		remote->entity->name, remote->index, count);
+
+	return 0;
+}
+
+static int mtk_dip_vb2_buf_prepare(struct vb2_buffer *vb)
+{

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 124

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vb->vb2_queue);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vb->vb2_queue);
+	struct device *dev = &pipe->dip_dev->pdev->dev;
+	const struct v4l2_format *fmt = &node->vdev_fmt;
+	unsigned int size;
+	int i;
+
+	if (vb->vb2_queue->type == V4L2_BUF_TYPE_META_CAPTURE ||
+	    vb->vb2_queue->type == V4L2_BUF_TYPE_META_OUTPUT){
+		if (vb->planes[0].length < fmt->fmt.meta.buffersize) {

For OUTPUT we need to check bytesused and also it must be equal to the metadata size in that case.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 132

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0
+			dev_dbg(dev,
+				"%s:%s:%s: size error(user:%d, required:%d)\n",
+				__func__, pipe->desc->name, node->desc->name,
+				vb->planes[0].length, fmt->fmt.meta.buffersize);
+			return -EINVAL;
+		} else {
+			return 0;
+		}

This comment will not apply anymore if we split to separate vb2 ops for meta queues, but normally one would put tis return 0 outside of the if block.

Quoted 29 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +29 -0
+	}
+
+	for (i = 0; i < vb->num_planes; i++) {
+		size = fmt->fmt.pix_mp.plane_fmt[i].sizeimage;
+		if (vb->planes[i].length < size) {
+			dev_dbg(dev,
+				"%s:%s:%s: size error(user:%d, max:%d)\n",
+				__func__, pipe->desc->name, node->desc->name,
+				vb->planes[i].length, size);
+			return -EINVAL;
+		}
+	}
+
+	return 0;
+}
+
+static int mtk_dip_vb2_buf_out_validate(struct vb2_buffer *vb)
+{
+	struct vb2_v4l2_buffer *v4l2_buf = to_vb2_v4l2_buffer(vb);
+
+	if (v4l2_buf->field == V4L2_FIELD_ANY)
+		v4l2_buf->field = V4L2_FIELD_NONE;
+
+	if (v4l2_buf->field != V4L2_FIELD_NONE)
+		return -EINVAL;
+
+	return 0;
+}
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 171

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+static int mtk_dip_vb2_queue_buf_init(struct vb2_buffer *vb)
+{
+	struct vb2_v4l2_buffer *b = to_vb2_v4l2_buffer(vb);
+	struct mtk_dip_dev_buffer *dev_buf = mtk_dip_vb2_buf_to_dev_buf(vb);
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vb->vb2_queue);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vb->vb2_queue);
+	int i;
+
+	for (i = 0; i < vb->num_planes; i++) {
+		if (node->desc->smem_alloc) {

Rather than having two completely different conditional blocks, could we have different vb2 ops for video and meta queues?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 184

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +13 -0
+			void *cpu_addr;
+			phys_addr_t buf_paddr;
+
+			dev_buf->scp_daddr[i] =
+				vb2_dma_contig_plane_dma_addr(vb, i);
+			cpu_addr = vb2_plane_vaddr(vb, i);
+			if (!cpu_addr) {
+				dev_err(&pipe->dip_dev->pdev->dev,
+					"%s:%s: vb2_plane_vaddr NULL: s_daddr(%pad)\n",
+					pipe->desc->name, node->desc->name,
+					&dev_buf->scp_daddr[i]);
+				return -EINVAL;
+			}

Why do we need cpu_addr here? It's not used any further.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 197

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +13 -0
+
+			/*
+			 * We got the incorrect physical address mapped when
+			 * using dma_map_single() so I used dma_map_page_attrs()
+			 * directly to workaround here. Please see the detail in
+			 * mtk_dip-sys.c
+			 */
+			buf_paddr = dev_buf->scp_daddr[i];
+			dev_buf->isp_daddr[i] =
+				dma_map_page_attrs(&pipe->dip_dev->pdev->dev,
+						   phys_to_page(buf_paddr),
+						   0, vb->planes[i].length,
+						   DMA_BIDIRECTIONAL,

Is it really bidirectional? I think this would depend on whether it's OUTPUT or CAPTURE.

Quoted 27 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +27 -0
+						   DMA_ATTR_SKIP_CPU_SYNC);
+			if (dma_mapping_error(&pipe->dip_dev->pdev->dev,
+					      dev_buf->isp_daddr[i])) {
+				dev_err(&pipe->dip_dev->pdev->dev,
+					"%s:%s: failed to map buffer: s_daddr(%pad)\n",
+					pipe->desc->name, node->desc->name,
+					&dev_buf->scp_daddr[i]);
+				return -EINVAL;
+			}
+		} else {
+			dev_buf->scp_daddr[i] = 0;
+			dev_buf->isp_daddr[i] =
+				vb2_dma_contig_plane_dma_addr(vb, i);
+		}
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: buf type(%d), idx(%d), mem(%d), p(%d) i_daddr(%pad), s_daddr(%pad)\n",
+			pipe->desc->name, node->desc->name, b->vb2_buf.type,
+			b->vb2_buf.index, b->vb2_buf.memory, i,
+			&dev_buf->isp_daddr[i], &dev_buf->scp_daddr[i]);
+	}
+
+	return 0;
+}
+
+static void mtk_dip_vb2_queue_buf_cleanup(struct vb2_buffer *vb)
+{

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 234

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	struct mtk_dip_dev_buffer *dev_buf = mtk_dip_vb2_buf_to_dev_buf(vb);
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vb->vb2_queue);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vb->vb2_queue);
+	int i;
+
+	if (!node->desc->smem_alloc)
+		return;
+
+	for (i = 0; i < vb->num_planes; i++) {
+		if (node->desc->smem_alloc)

This was already checked few lines above.

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +13 -0
+			dma_unmap_page_attrs(&pipe->dip_dev->pdev->dev,
+					     dev_buf->isp_daddr[i],
+					     vb->planes[i].length,
+					     DMA_BIDIRECTIONAL,
+					     DMA_ATTR_SKIP_CPU_SYNC);
+	}
+}
+
+static void mtk_dip_vb2_buf_queue(struct vb2_buffer *vb)
+{
+	struct vb2_v4l2_buffer *b = to_vb2_v4l2_buffer(vb);
+	struct mtk_dip_dev_buffer *dev_buf = mtk_dip_vb2_buf_to_dev_buf(vb);
+	struct mtk_dip_request *req = (struct mtk_dip_request *)vb->request;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 257

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	struct mtk_dip_video_device *node =
+		mtk_dip_vbq_to_node(vb->vb2_queue);
+	int buf_count;
+
+	dev_buf->fmt = node->vdev_fmt;
+	dev_buf->dev_fmt = node->dev_q.dev_fmt;
+	dev_buf->dma_port = node->desc->dma_port;
+	dev_buf->rotation = node->dev_q.rotation;
+
+	dev_dbg(&req->dip_pipe->dip_dev->pdev->dev,

Sounds like it might be beneficial to have a local variable for dip_dev.

Quoted 25 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +25 -0
+		"%s:%s: buf type(%d), idx(%d), mem(%d), i_daddr(%pad), s_daddr(%pad)\n",
+		req->dip_pipe->desc->name, node->desc->name, b->vb2_buf.type,
+		b->vb2_buf.index, b->vb2_buf.memory, &dev_buf->isp_daddr,
+		&dev_buf->scp_daddr);
+
+	spin_lock(&node->buf_list_lock);
+	list_add_tail(&dev_buf->list, &node->buf_list);
+	spin_unlock(&node->buf_list_lock);
+
+	buf_count = atomic_dec_return(&req->buf_count);
+	if (!buf_count) {
+		mutex_lock(&req->dip_pipe->lock);
+		mtk_dip_pipe_try_enqueue(req->dip_pipe);
+		mutex_unlock(&req->dip_pipe->lock);
+	}
+
+	dev_dbg(&req->dip_pipe->dip_dev->pdev->dev,
+		"%s:%s:%s:%s:buf_count(%d)\n",
+		__func__, req->dip_pipe->desc->name, node->desc->name,
+		req->req.debug_str, buf_count);
+}
+
+static int mtk_dip_vb2_queue_setup(struct vb2_queue *vq,
+				   unsigned int *num_buffers,
+				   unsigned int *num_planes,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 292

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+				   unsigned int sizes[],
+				   struct device *alloc_devs[])
+{
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vq);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vq);
+	const struct v4l2_format *fmt = &node->vdev_fmt;
+	unsigned int size;
+	int i;
+
+	vq->dma_attrs |= DMA_ATTR_NON_CONSISTENT;

Please keep this a downstream patch added on top of the driver patches.

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +12 -0
+
+	if (!*num_planes) {
+		*num_planes = 1;
+		sizes[0] = fmt->fmt.pix_mp.plane_fmt[0].sizeimage;
+	}
+
+	if (node->desc->id == MTK_DIP_VIDEO_NODE_ID_TUNING_OUT) {
+		int max_meta_bufs_per_pipe;
+
+		size = fmt->fmt.meta.buffersize;
+		max_meta_bufs_per_pipe =
+			MTK_DIP_DEV_META_BUF_POOL_MAX_SIZE /

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 314

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+			round_up(size, PAGE_SIZE) / MTK_DIP_PIPE_ID_TOTAL_NUM;
+		*num_buffers = clamp_val(*num_buffers, 1,
+					 max_meta_bufs_per_pipe);
+		sizes[0] = size;
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s:%s: n_p(%d), n_b(%d), s[%d](%u)\n",
+			__func__, pipe->desc->name, node->desc->name,
+			*num_planes, *num_buffers, 0, sizes[0]);
+

nit: Stray blank line.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 324

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	} else {
+		for (i = 0; i < *num_planes; i++) {
+			if (sizes[i] < fmt->fmt.pix_mp.plane_fmt[i].sizeimage) {
+				dev_dbg(&pipe->dip_dev->pdev->dev,
+					"%s:%s:%s: invalid buf: %u < %u\n",
+					__func__, pipe->desc->name,
+					node->desc->name, sizes[0], size);
+					return -EINVAL;
+			}
+			sizes[i] = fmt->fmt.pix_mp.plane_fmt[i].sizeimage;

For VIDIOC_CREATEBUFS we also need to handle the case when *num_planes > 0 and then we need to honor the values already present in sizes[]. (Note that the code above overrides *num_planes to 1, so we lose the information. The code needs to be restructured to handle that.)

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+			dev_dbg(&pipe->dip_dev->pdev->dev,
+				"%s:%s:%s: n_p(%d), n_b(%d), s[%d](%u)\n",
+				__func__, pipe->desc->name, node->desc->name,
+				*num_planes, *num_buffers, i, sizes[i]);
+		}
+	}
+
+	return 0;
+}
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 344

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+static void mtk_dip_return_all_buffers(struct mtk_dip_pipe *pipe,
+				       struct mtk_dip_video_device *node,
+				       enum vb2_buffer_state state)
+{
+	struct mtk_dip_dev_buffer *b, *b0;
+
+	spin_lock(&node->buf_list_lock);
+	list_for_each_entry_safe(b, b0, &node->buf_list, list) {
+		list_del(&b->list);
+		if (b->vbb.vb2_buf.state == VB2_BUF_STATE_ACTIVE)

Are you seeing some buffers with state other than ACTIVE here? If so, that's a bug somewhere else in the driver, which needs to be fixed. This check shouldn't be here.

Quoted 14 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +14 -0
+			vb2_buffer_done(&b->vbb.vb2_buf, state);
+	}
+	spin_unlock(&node->buf_list_lock);
+}
+
+static int mtk_dip_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
+{
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vq);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vq);
+	int cnt_node_ns;
+	int ret;
+
+	if (!(node->flags & MEDIA_LNK_FL_ENABLED)) {
+		dev_err(&pipe->dip_dev->pdev->dev,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 368

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+			"%s:%s: stream on failed, node is not enabled\n",
+			pipe->desc->name, node->desc->name);
+
+		ret = -ENOLINK;
+		goto fail_return_bufs;
+	}
+
+	mutex_lock(&pipe->lock);
+	cnt_node_ns = atomic_dec_return(&pipe->cnt_nodes_not_streaming);
+	mutex_unlock(&pipe->lock);

This still isn't really synchronized. One could disable the link at this point. I believe that in the previous round of the review I suggested checking the enable state after calling media_pipeline_start(), because it locks the enable status for links that don't have the DYNAMIC flag. That would solve the problem.

Quoted 43 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +43 -0
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s:%s cnt_nodes_not_streaming(%d)\n",
+		__func__, pipe->desc->name, node->desc->name, cnt_node_ns);
+
+	if (cnt_node_ns)
+		return 0;
+
+	ret = media_pipeline_start(&node->vdev.entity, &pipe->pipeline);
+	if (ret < 0) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: media_pipeline_start failed(%d)\n",
+			pipe->desc->name, node->desc->name, ret);
+
+		goto fail_return_bufs;
+	}
+
+	/* Start streaming of the whole pipeline */
+	ret = v4l2_subdev_call(&pipe->subdev, video, s_stream, 1);
+	if (ret < 0) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: sub dev s_stream(1) failed(%d)\n",
+			pipe->desc->name, node->desc->name, ret);
+
+		goto fail_stop_pipeline;
+	}
+
+	return 0;
+
+fail_stop_pipeline:
+	media_pipeline_stop(&node->vdev.entity);
+
+fail_return_bufs:
+	mtk_dip_return_all_buffers(pipe, node, VB2_BUF_STATE_QUEUED);
+
+	return ret;
+}
+
+static void mtk_dip_vb2_stop_streaming(struct vb2_queue *vq)
+{
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vq);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vq);
+	int ret;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 421

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	int count;
+	int is_pipe_streamon;
+
+	WARN_ON(!(node->flags & MEDIA_LNK_FL_ENABLED));
+
+	mutex_lock(&pipe->lock);
+	count = atomic_inc_return(&pipe->cnt_nodes_not_streaming);
+	is_pipe_streamon = pipe->streaming;
+	mutex_unlock(&pipe->lock);
+

We protect the access to pipe->streaming with the mutex above, but do we have any guarantee that after we release the mutex the value doesn't change?

We should likely do the whole stop operation holding the pipe lock.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 427

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s:%s cnt_nodes_not_streaming(%d), is_pipe_streamon(%d)\n",
+		__func__, pipe->desc->name, node->desc->name, count,
+		is_pipe_streamon);
+
+	if (count && is_pipe_streamon) {

For v4l2_subdev_call() shouldn't this be !count && is_pipe_streamon?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 433

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+		ret = v4l2_subdev_call(&pipe->subdev, video, s_stream, 0);
+		if (ret)
+			dev_err(&pipe->dip_dev->pdev->dev,
+				"%s:%s: sub dev s_stream(0) failed(%d)\n",
+				pipe->desc->name, node->desc->name, ret);
+		media_pipeline_stop(&node->vdev.entity);

We should do this one when the last node stops streaming to solve the enable state locking issue as described in my comment to _start_streaming().

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +12 -0
+	}
+
+	mtk_dip_return_all_buffers(pipe, node, VB2_BUF_STATE_ERROR);
+}
+
+static int mtk_dip_videoc_querycap(struct file *file, void *fh,
+				   struct v4l2_capability *cap)
+{
+	struct mtk_dip_pipe *pipe = video_drvdata(file);
+
+	strlcpy(cap->driver, pipe->desc->name,
+		sizeof(cap->driver));

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 455

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	strlcpy(cap->card, pipe->desc->name,
+		sizeof(cap->card));
+	snprintf(cap->bus_info, sizeof(cap->bus_info),
+		 "platform:%s", dev_name(pipe->dip_dev->mdev.dev));
+
+	return 0;
+}
+
+static int mtk_dip_videoc_try_fmt(struct file *file, void *fh,
+				  struct v4l2_format *f)

I don't see this function returning any error codes. Please make it void.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 463

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0
+{
+	struct mtk_dip_pipe *pipe = video_drvdata(file);
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+	const struct mtk_dip_dev_format *dev_fmt;
+	struct v4l2_format try_fmt;
+
+	memset(&try_fmt, 0, sizeof(try_fmt));
+	try_fmt.type = node->dev_q.vbq.type;

This should come from f.type and should have been already validated by the core.

Actually, why don't we use f directly?

Quoted 18 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +18 -0
+	dev_fmt = mtk_dip_pipe_find_fmt(pipe, node,
+					f->fmt.pix_mp.pixelformat);
+
+	if (!dev_fmt) {
+		dev_fmt = &node->desc->fmts[node->desc->default_fmt_idx];
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s:%s: dev_fmt(%d) not found, use default(%d)\n",
+			__func__, pipe->desc->name, node->desc->name,
+			f->fmt.pix_mp.pixelformat, dev_fmt->format);
+	}
+
+	if (V4L2_TYPE_IS_OUTPUT(node->desc->buf_type)) {
+		try_fmt.fmt.pix_mp.width = clamp_val(f->fmt.pix_mp.width,
+						     MTK_DIP_OUTPUT_MIN_WIDTH,
+						     MTK_DIP_OUTPUT_MAX_WIDTH);
+		try_fmt.fmt.pix_mp.height =
+			clamp_val(f->fmt.pix_mp.height,
+				  MTK_DIP_OUTPUT_MIN_HEIGHT,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 491

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+				  MTK_DIP_OUTPUT_MAX_HEIGHT);
+	} else {
+		try_fmt.fmt.pix_mp.width = clamp_val(f->fmt.pix_mp.width,
+						     MTK_DIP_CAPTURE_MIN_WIDTH,
+						     MTK_DIP_CAPTURE_MAX_WIDTH);
+		try_fmt.fmt.pix_mp.height =
+			clamp_val(f->fmt.pix_mp.height,
+				  MTK_DIP_CAPTURE_MIN_HEIGHT,
+				  MTK_DIP_CAPTURE_MAX_HEIGHT);
+	}

We have these limits already as a part of the frmsizeenum field of the mtk_dip_video_device_desc struct. Could we just use that and remove the conditional handling?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 493

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +2 -0
+
+	node->dev_q.dev_fmt = dev_fmt;

Why are we changing the format on the node inside TRY_FMT?

Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +17 -0
+	try_fmt.fmt.pix_mp.field = V4L2_FIELD_NONE;
+	mtk_dip_pipe_set_img_fmt(pipe, node, &try_fmt.fmt.pix_mp, dev_fmt);
+
+	*f = try_fmt;
+
+	return 0;
+}
+
+static int mtk_dip_videoc_g_fmt(struct file *file, void *fh,
+				struct v4l2_format *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+
+	*f = node->vdev_fmt;
+
+	return 0;
+}

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 520

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+
+static int mtk_dip_videoc_s_fmt(struct file *file, void *fh,
+				struct v4l2_format *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+	struct mtk_dip_pipe *pipe = video_drvdata(file);
+	int ret;
+
+	if (pipe->streaming)
+		return -EBUSY;

We should use vb2_is_busy() here, because it's not allowed to change formats after allocating buffers.

Quoted 81 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +81 -0
+
+	ret = mtk_dip_videoc_try_fmt(file, fh, f);
+	if (!ret)
+		node->vdev_fmt = *f;
+
+	return ret;
+}
+
+static int mtk_dip_videoc_enum_framesizes(struct file *file, void *priv,
+					  struct v4l2_frmsizeenum *sizes)
+{
+	struct mtk_dip_pipe *pipe = video_drvdata(file);
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+	const struct mtk_dip_dev_format *dev_fmt;
+
+	dev_fmt = mtk_dip_pipe_find_fmt(pipe, node, sizes->pixel_format);
+
+	if (!dev_fmt || sizes->index)
+		return -EINVAL;
+
+	sizes->type = node->desc->frmsizeenum->type;
+	sizes->stepwise.max_width =
+		node->desc->frmsizeenum->stepwise.max_width;
+	sizes->stepwise.min_width =
+		node->desc->frmsizeenum->stepwise.min_width;
+	sizes->stepwise.max_height =
+		node->desc->frmsizeenum->stepwise.max_height;
+	sizes->stepwise.min_height =
+		node->desc->frmsizeenum->stepwise.min_height;
+	sizes->stepwise.step_height =
+		node->desc->frmsizeenum->stepwise.step_height;
+	sizes->stepwise.step_width =
+		node->desc->frmsizeenum->stepwise.step_width;
+
+	return 0;
+}
+
+static int mtk_dip_videoc_enum_fmt(struct file *file, void *fh,
+				   struct v4l2_fmtdesc *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+
+	if (f->index >= node->desc->num_fmts)
+		return -EINVAL;
+
+	strscpy(f->description, node->desc->description,
+		sizeof(f->description));
+	f->pixelformat = node->desc->fmts[f->index].format;
+	f->flags = 0;
+
+	return 0;
+}
+
+static int mtk_dip_meta_enum_format(struct file *file, void *fh,
+				    struct v4l2_fmtdesc *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+
+	if (f->index > 0)
+		return -EINVAL;
+
+	strscpy(f->description, node->desc->description,
+		sizeof(f->description));
+
+	f->pixelformat = node->vdev_fmt.fmt.meta.dataformat;
+	f->flags = 0;
+
+	return 0;
+}
+
+static int mtk_dip_videoc_g_meta_fmt(struct file *file, void *fh,
+				     struct v4l2_format *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+	*f = node->vdev_fmt;
+
+	return 0;
+}
+
+static int handle_buf_rotate_config(struct v4l2_ctrl *ctrl)
+{

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 611

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	struct mtk_dip_video_device *node =
+		container_of(ctrl->handler, struct mtk_dip_video_device,
+			     ctrl_handler);
+
+	if (ctrl->val != 0 && ctrl->val != 90 &&
+	    ctrl->val != 180 && ctrl->val != 270) {
+		pr_err("%s: Invalid buffer rotation %d", node->desc->name,
+		       ctrl->val);
+		return -EINVAL;
+	}

There is no need to check this here, because the framework already ensures the values are valid.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 613

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +2 -0
+
+	node->dev_q.rotation = ctrl->val;

Given the above, this could be just put directly into mtk_dip_video_device_s_ctrl().

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 624

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0
+
+	return 0;
+}
+
+static int mtk_dip_video_device_s_ctrl(struct v4l2_ctrl *ctrl)
+{
+	int ret = 0;
+
+	switch (ctrl->id) {
+	case V4L2_CID_ROTATE:
+		ret = handle_buf_rotate_config(ctrl);

nit: We can just return directly from here.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 627

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +3 -0
+		break;
+	default:
+		break;

There should be no need to handle default here, as the control framework will not call us with any settable controls we haven't explicitly registered.

Quoted 18 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +18 -0
+	}
+
+	return ret;
+}
+
+/******************** function pointers ********************/
+
+static const struct v4l2_subdev_internal_ops mtk_dip_subdev_internal_ops = {
+	.open = mtk_dip_subdev_open,
+	.close = mtk_dip_subdev_close,
+};
+
+static const struct v4l2_subdev_video_ops mtk_dip_subdev_video_ops = {
+	.s_stream = mtk_dip_subdev_s_stream,
+};
+
+static const struct v4l2_subdev_ops mtk_dip_subdev_ops = {
+	.video = &mtk_dip_subdev_video_ops,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 655

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+};
+
+static const struct media_entity_operations mtk_dip_media_ops = {
+	.link_setup = mtk_dip_link_setup,
+	.link_validate = v4l2_subdev_link_validate,
+};
+
+static struct media_request *mtk_dip_request_alloc(struct media_device *mdev)
+{
+	return kzalloc(sizeof(struct mtk_dip_request), GFP_KERNEL);

That's potentially error-prone. I'd add a properly typed local variable, let's say mtk_req, allocate with sizeof(*mtk_req) and then return &mtk_dev->req.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 659

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+}
+
+static void mtk_dip_request_free(struct media_request *req)
+{

A similar comment her. Please retrieve mtk_dip_request pointer properly using a helper (with container_of() inside) to a local variable and then free it.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 667

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0
+	kfree(req);
+}
+
+static int mtk_dip_vb2_request_validate(struct media_request *req)
+{
+	struct media_request_object *obj;
+	struct mtk_dip_dev *dip_dev = mtk_dip_mdev_to_dev(req->mdev);
+	struct mtk_dip_request *dip_req = (struct mtk_dip_request *)req;

Please avoid such direct casts and use properly typed helpers instead, using container_of() if needed.

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +13 -0
+	struct mtk_dip_pipe *pipe = NULL;
+	struct mtk_dip_pipe *pipe_prev = NULL;
+	struct mtk_dip_dev_buffer **map = dip_req->job_info.buf_map;
+	int buf_count = 0;
+
+	memset(map, 0, sizeof(dip_req->job_info.buf_map));
+
+	list_for_each_entry(obj, &req->objects, list) {
+		struct vb2_buffer *vb;
+		struct mtk_dip_dev_buffer *dev_buf;
+		struct mtk_dip_video_device *node;
+
+		if (!vb2_request_object_is_buffer(obj))

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 690

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+			continue;
+
+		vb = container_of(obj, struct vb2_buffer, req_obj);
+		node = mtk_dip_vbq_to_node(vb->vb2_queue);
+		pipe = vb2_get_drv_priv(vb->vb2_queue);
+		if (pipe_prev && pipe != pipe_prev) {
+			dev_warn(&dip_dev->pdev->dev,
+				 "%s:%s:%s:found buf of different pipes(%p,%p)\n",
+				__func__, node->desc->name,
+				req->debug_str, pipe, pipe_prev);

Userspace misbehavior should not trigger kernel warnings. Please make this dev_dbg().

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+			return -EINVAL;
+		}
+
+		pipe_prev = pipe;
+		dev_buf = mtk_dip_vb2_buf_to_dev_buf(vb);
+		dip_req->job_info.buf_map[node->desc->id] = dev_buf;
+		buf_count++;
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: added buf(%p) to pipe-job(%p), buf_count(%d)\n",

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 710

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+			pipe->desc->name, node->desc->name, dev_buf,
+			dip_req->job_info, buf_count);
+	}
+
+	if (!pipe) {
+		dev_warn(&dip_dev->pdev->dev,
+			 "%s: no buffer in the request(%p)\n",
+			 req->debug_str, req);
+
+		return vb2_request_validate(req);

Shouldn't this be an error?

Quoted 16 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +16 -0
+	}
+
+	/*
+	 * Workaround to pass V4L2 comliance test since it can't know
+	 * which buffer is required and may enqueue only 1 buffer.
+	 * It seems that we should return an error here and let the
+	 * user to enqueue required buffer instead of showing a debug
+	 * message only.
+	 */
+	if (!map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT] ||
+	    (!map[MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE] &&
+	     !map[MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE]))
+		dev_dbg(&dip_dev->pdev->dev,
+			"won't trigger hw job: raw(%p), mdp0(%p), mdp1(%p)\n",
+			map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT],
+			map[MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE],

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 736

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+			map[MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE]);
+
+	atomic_set(&dip_req->buf_count, buf_count);
+	dip_req->job_info.id = mtk_dip_pipe_next_job_id(pipe);
+	dip_req->dip_pipe = pipe;
+	mtk_dip_pipe_debug_job(pipe, &dip_req->job_info);
+
+	spin_lock(&pipe->job_lock);
+	list_add_tail(&dip_req->job_info.list, &pipe->pipe_job_pending_list);
+	pipe->num_pending_jobs++;

.req_validate() must not change any driver state (e.g. internal queues). It should only validate the request itself. The proper place do to this is .req_queue().

Quoted 41 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +41 -0
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s:%s: current num of pending jobs(%d)\n",
+		__func__, pipe->desc->name, pipe->num_pending_jobs);
+	spin_unlock(&pipe->job_lock);
+
+	return vb2_request_validate(req);
+}
+
+static const struct media_device_ops mtk_dip_media_req_ops = {
+	.req_validate = mtk_dip_vb2_request_validate,
+	.req_queue = vb2_request_queue,
+	.req_alloc = mtk_dip_request_alloc,
+	.req_free = mtk_dip_request_free,
+};
+
+static const struct v4l2_ctrl_ops mtk_dip_video_device_ctrl_ops = {
+	.s_ctrl = mtk_dip_video_device_s_ctrl,
+};
+
+static const struct vb2_ops mtk_dip_vb2_ops = {
+	.buf_queue = mtk_dip_vb2_buf_queue,
+	.queue_setup = mtk_dip_vb2_queue_setup,
+	.buf_init = mtk_dip_vb2_queue_buf_init,
+	.buf_prepare  = mtk_dip_vb2_buf_prepare,
+	.buf_out_validate = mtk_dip_vb2_buf_out_validate,
+	.buf_cleanup = mtk_dip_vb2_queue_buf_cleanup,
+	.start_streaming = mtk_dip_vb2_start_streaming,
+	.stop_streaming = mtk_dip_vb2_stop_streaming,
+	.wait_prepare = vb2_ops_wait_prepare,
+	.wait_finish = vb2_ops_wait_finish,
+};
+
+static const struct v4l2_file_operations mtk_dip_v4l2_fops = {
+	.unlocked_ioctl = video_ioctl2,
+	.open = v4l2_fh_open,
+	.release = vb2_fop_release,
+	.poll = vb2_fop_poll,
+	.mmap = vb2_fop_mmap,
+#ifdef CONFIG_COMPAT
+	.compat_ioctl32 = v4l2_compat_ioctl32,
+#endif

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 787

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+};
+
+int mtk_dip_dev_media_register(struct device *dev,
+			       struct media_device *media_dev,
+			       const char *model)
+{
+	int ret;
+
+	media_dev->dev = dev;
+	strlcpy(media_dev->model, model, sizeof(media_dev->model));

Could we just use dev_driver_string() instead?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 798

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0
+	snprintf(media_dev->bus_info, sizeof(media_dev->bus_info),
+		 "platform:%s", dev_name(dev));
+	media_dev->hw_revision = 0;
+	media_dev->ops = &mtk_dip_media_req_ops;
+	media_device_init(media_dev);
+
+	ret = media_device_register(media_dev);
+	if (ret) {
+		dev_err(dev, "failed to register media device (%d)\n", ret);
+		media_device_unregister(media_dev);
+		media_device_cleanup(media_dev);

Please return from here to make it clear which code is for failure and which for success.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 804

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+	}
+
+	dev_dbg(dev, "Registered media device: %s, %p", media_dev->model,
+		media_dev);
+
+	return ret;

And return 0 here.

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0
+}
+
+int mtk_dip_dev_v4l2_register(struct device *dev,
+			      struct media_device *media_dev,
+			      struct v4l2_device *v4l2_dev)
+{
+	int ret;
+
+	v4l2_dev->mdev = media_dev;
+	v4l2_dev->ctrl_handler = NULL;
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 825

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	ret = v4l2_device_register(dev, v4l2_dev);
+	if (ret) {
+		dev_err(dev, "failed to register V4L2 device (%d)\n", ret);
+		v4l2_device_unregister(v4l2_dev);
+	}
+
+	dev_dbg(dev, "Registered v4l2 device: %p", v4l2_dev);
+
+	return ret;
+}

There is only 1 function call inside of this function, so there is not much point in having a separate function for this. Please just move back to the caller.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 835

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+
+static int mtk_dip_video_device_v4l2_register(struct mtk_dip_pipe *pipe,
+					      struct mtk_dip_video_device *node)
+{
+	struct vb2_queue *vbq = &node->dev_q.vbq;
+	struct video_device *vdev = &node->vdev;
+	struct media_link *link;
+	int ret;
+
+	/* Initialize miscellaneous variables */

I'd remove comments like this, because this is obvious from reading the code alone.

Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +17 -0
+	mutex_init(&node->dev_q.lock);
+
+	/* Initialize formats to default values */
+	vdev->device_caps = node->desc->cap;
+	vdev->ioctl_ops = node->desc->ops;
+	node->vdev_fmt.type = node->desc->buf_type;
+	mtk_dip_pipe_load_default_fmt(pipe, node, &node->vdev_fmt);
+
+	/* Initialize media entities */
+	ret = media_entity_pads_init(&vdev->entity, 1, &node->vdev_pad);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"failed initialize media entity (%d)\n", ret);
+		goto err_mutex_destroy;
+	}
+
+	node->vdev_pad.flags = V4L2_TYPE_IS_OUTPUT(node->desc->buf_type) ?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 862

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+		MEDIA_PAD_FL_SOURCE : MEDIA_PAD_FL_SINK;
+
+	/* Initialize vbq */
+	vbq->type = node->vdev_fmt.type;
+	vbq->io_modes = VB2_MMAP | VB2_DMABUF;
+	vbq->ops = &mtk_dip_vb2_ops;
+	vbq->mem_ops = &vb2_dma_contig_memops;
+	vbq->supports_requests = true;
+	vbq->buf_struct_size = sizeof(struct mtk_dip_dev_buffer);
+	vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;

This is a memory to memory device so this should be TIMESTAMP_COPY and the driver should copy the time stamp from the input frame buffer to the output buffers.

Quoted 102 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +102 -0
+	vbq->min_buffers_needed = 0;
+	vbq->drv_priv = pipe;
+	vbq->lock = &node->dev_q.lock;
+
+	ret = vb2_queue_init(vbq);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s:%s: failed to init vb2 queue(%d)\n",
+			__func__, pipe->desc->name, node->desc->name,
+			ret);
+		goto err_media_entity_cleanup;
+	}
+
+	/* Initialize vdev */
+	snprintf(vdev->name, sizeof(vdev->name), "%s %s", pipe->desc->name,
+		 node->desc->name);
+	vdev->entity.name = vdev->name;
+	vdev->entity.function = MEDIA_ENT_F_IO_V4L;
+	vdev->entity.ops = NULL;
+	vdev->release = video_device_release_empty;
+	vdev->fops = &mtk_dip_v4l2_fops;
+	vdev->lock = &node->dev_q.lock;
+	vdev->ctrl_handler = &node->ctrl_handler;
+	vdev->v4l2_dev = &pipe->dip_dev->v4l2_dev;
+	vdev->queue = &node->dev_q.vbq;
+	vdev->vfl_dir = V4L2_TYPE_IS_OUTPUT(node->desc->buf_type) ?
+		VFL_DIR_TX : VFL_DIR_RX;
+
+	if (node->desc->smem_alloc) {
+		vdev->queue->dev = &pipe->dip_dev->dip_hw.scp_pdev->dev;
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: select smem_vb2_alloc_ctx(%p)\n",
+			pipe->desc->name, node->desc->name,
+			vdev->queue->dev);
+	} else {
+		vdev->queue->dev = &pipe->dip_dev->pdev->dev;
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: select default_vb2_alloc_ctx(%p)\n",
+			pipe->desc->name, node->desc->name,
+			&pipe->dip_dev->pdev->dev);
+	}
[… more lines in the raw message]

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 913

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+
+	video_set_drvdata(vdev, pipe);
+
+	ret = video_register_device(vdev, VFL_TYPE_GRABBER, -1);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"failed to register video device (%d)\n", ret);
+		goto err_vb2_queue_release;
+	}
+	dev_dbg(&pipe->dip_dev->pdev->dev, "registered vdev: %s\n",
[… more lines in the raw message]

Do we need to init the handler for nodes that don't expose any controls?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Why defer here? Isn't this just a critical error?

Also, the proper way to check for control registration error is to check the control handler error rather than the control pointer.

An example registration code:
https://elixir.bootlin.com/linux/v5.3-rc2/source/drivers/media/platform/qcom/venus/vdec_ctrls.c#L79

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 65 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +65 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Isn't this the other way around?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 23 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +23 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

This should be only called once for the v4l2_dev, but the code here would end up calling this once per each pipe.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 40 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +40 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Wouldn't this end up unregistering the same v4l2_dev more than 1 time? Please make sure that the driver works when compiled as a module and then unloaded and reloaded again.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +17 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

No need for cap ioctls on an out node.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 33 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +33 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

No need for out ioctls on a cap node.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 67 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +67 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Is the color space tied to particular pixel format on hardware level?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 50 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +50 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

What is depth and what is row_depth? They both seem to not match NV12, which should have 16 bits per sample in the CbCr plane.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 49 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +49 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Is this correct? The other entries above use MDP_YCBCR_PROFILE_ macros, while this and further entries use V4L2_COLORSPACE_.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 16 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +16 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Why does NV12M have a different colorspace than NV12?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 54 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +54 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Please still use ARRAY_SIZE() even if the array has just 1 entry.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 44 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +44 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

The entries here seem to be almost the same to output_queues_setting[], the only difference seems to be default_fmt_idx and description.

What's the difference between the capture and reprocess pipes?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 44 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +44 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

This string macro is only used here. Please just explicitly put the string here. Also, as per my other comment, this should probably be just a suffix that's added to dev_driver_string().

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Why do we need this split into output and capture descriptors? They have the same type.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +3 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Ditto.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +9 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Ditto.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +17 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Do we need to store pdev in dip_dev? Wouldn't storing just dev there simplify things?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +2 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Do we need to pass a constant to this function? Could we just use it directly from there?

Also, why not just pass dip_dev instead of the 2 first arguments?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 20 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +20 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

nit: The usual convention is to pass the arguments from the "broadest" datastructures, e.g. the main driver structure - dip_dev, to the most specific ones, so dip_dev should be made the first argument.

There isn't much point in passing media_dev and v4l2_dev here, because we already have them in dip_dev.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +13 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

nit: The initial decrement could be just written as i--.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +7 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Could we move this two into a function called mtk_dip_dev_media_unregister() to be consistent with the initialization?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 44 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +44 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

We shouldn't need this custom larb handling anymore.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Could we use ARRAY_SIZE(clks) instead?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 49 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +49 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Don't we need to clean up the buffer pool initialization if we fail here?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 1 line
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +1 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

It's also necessary to initialize autosuspend here by calling pm_runtime_use_autosuspend() and pm_runtime_set_autosuspend_delay().

The delay should be something around 2-3 times the time it takes to suspend and resume the device.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

There might be already something running at this point and we would free the buffers here. Generally the order of remove should be the opposite to the probe.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Perhaps mtk_dip_runtime_suspend()?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

mtk_dip_runtime_resume()?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 15 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +15 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

nit: Please return ret from here and keep the path below only for success.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 14 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +14 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

It's not allowed to use sleeping operations in a wait_event condition, because the condition could be evaluated while the current process already enters the UNINTERRUPTIBLE state.

Given that this is already an atomic_t, there shouldn't be any special synchronization needed here. Please just use atomic_read() in the wait_event_timeout() call directly.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 18 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +18 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Is 200 milliseconds a reasonable timeout here, i.e. for any potential use case it would always take less than 200 ms to wait for all the tasks running in the ISP?

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

We should call pm_runtime_force_suspend() instead, so that it also handles any device dependencies or power domains.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

pm_runtime_force_resume()

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

I think you meant mtk_dip_pm_suspend/resume for the runtime PM ops?

Best regards,
Tomasz

Part of the diff is not shown here. View the raw message.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#10 lore raw

Re: [RFC PATCH V2 4/6] platform: mtk-isp: Add Mediatek DIP driver

Dear Tomasz,

I appreciate your comment. I will collaborate more closely with Jungo to solve the common issues in DIP and Pass 1(CAM) drivers.

Quoted 121 lines · Tomasz Figa

Hi Frederic,

Quoted 22 lines · On Mon, Jul 08, 2019 at 07:04:58PM +0800…

From: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>

This patch adds the driver of Digital Image Processing (DIP) unit in Mediatek ISP system, providing image format conversion, resizing, and rotation features.

The mtk-isp directory will contain drivers for multiple IP blocks found in Mediatek ISP system. It will include ISP Pass 1 driver(CAM), sensor interface driver, DIP driver and face detection driver.

---
 drivers/media/platform/mtk-isp/Makefile       |    7 +
 .../media/platform/mtk-isp/isp_50/Makefile    |    7 +
 .../platform/mtk-isp/isp_50/dip/Makefile      |   18 +
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.c |  769 +++++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.h |  337 ++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-hw.h  |  155 ++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-sys.c |  794 ++++++++
 .../mtk-isp/isp_50/dip/mtk_dip-v4l2.c         | 1786 +++++++++++++++++
 8 files changed, 3873 insertions(+)
Quoted 9 lines
 create mode 100644 drivers/media/platform/mtk-isp/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Thanks for v2! The code is getting better, but there are still problems. Please check my comments inline.

Note that it would be really good if you could collaborate more closely with Jungo working on the P1 driver, as I noticed similar problems in both drivers, with some being addressed only in one of the drivers, but not the other.

Quoted 78 lines
drivers/media/platform/mtk-isp/Makefile new file +7 -0
new file mode 100644
index 000000000000..b08d3bdf2800
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (C) 2019 MediaTek Inc.
+#
+
+obj-y += isp_50/
+
drivers/media/platform/mtk-isp/isp_50/Makefile new file +7 -0
new file mode 100644
index 000000000000..564c3889c34c
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (C) 2019 MediaTek Inc.
+#
+
+obj-$(CONFIG_VIDEO_MEDIATEK_ISP_DIP) += dip/
+
drivers/media/platform/mtk-isp/isp_50/dip/Makefile new file +18 -0
new file mode 100644
index 000000000000..99e760d7d5a9
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (C) 2019 MediaTek Inc.
+#
+
+$(info $(srctree))
+ccflags-y += -I$(srctree)/drivers/media/platform/mtk-mdp3
+
+obj-$(CONFIG_VIDEO_MEDIATEK_ISP_DIP) += mtk_dip-v4l2.o
+
+# Utilities to provide frame-based streaming model
+# with v4l2 user interfaces and alloc context managing
+# memory shared between ISP and coprocessor
+mtk_dip_util-objs := \
+mtk_dip-dev.o \
+mtk_dip-sys.o
+
+obj-$(CONFIG_VIDEO_MEDIATEK_ISP_DIP) += mtk_dip_util.o
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +22 -0
new file mode 100644
index 000000000000..63256fa27428
@@ -0,0 +1,769 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *
+ */
+
+#include <linux/dma-mapping.h>
+#include <linux/platform_device.h>
+#include <media/videobuf2-dma-contig.h>
+#include <media/v4l2-event.h>
+#include "mtk_dip-dev.h"
+#include "mtk-mdp3-regs.h"
+#include "mtk-img-ipi.h"
+
+int mtk_dip_pipe_init(struct mtk_dip_pipe *pipe,
+		      struct mtk_dip_dev *dip_dev,
+		      const struct mtk_dip_pipe_desc *setting,
+		      struct media_device *media_dev,
+		      struct v4l2_device *v4l2_dev)
+{
Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 27

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+	int ret, i, count = 0;
+
+	pipe->dip_dev = dip_dev;
+	pipe->desc = setting;
+	pipe->num_nodes = MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM;

Rather than hardcoding the number, could we just pass ARRAY_SIZE(desc) to this function from the caller?

Yes, I will use ARRAY_SIZE instead.

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 35

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +8 -0
+
+	atomic_set(&pipe->pipe_job_sequence, 0);
+	INIT_LIST_HEAD(&pipe->pipe_job_running_list);
+	INIT_LIST_HEAD(&pipe->pipe_job_pending_list);
+	spin_lock_init(&pipe->job_lock);
+	mutex_init(&pipe->lock);
+
+	for (i = 0; i < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM; i++) {

i < pipe->num_nodes

I got it.

Quoted 14 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 44

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+		if (i < MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM) {
+			pipe->nodes[i].desc =
+			&pipe->desc->output_queue_descs[i];
+		} else {
+			int cap_idx = i - MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM;
+
+			pipe->nodes[i].desc =
+				&pipe->desc->capture_queue_descs[cap_idx];
+		}

We shouldn't need this if/else block if we put all the descriptors in one array.

I will merge capture_queue_descs and output_queue_descs.

Quoted 5 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 47

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+
+		pipe->nodes[i].flags =
+			pipe->nodes[i].desc->flags;

No need to wrap the line here.

I got it.

Quoted 4 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 48

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +1 -0
+		atomic_set(&pipe->nodes[i].sequence, 0);

I don't see this sequence used anywhere else in the driver.

I will remove it.

Quoted 12 lines
Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +11 -0
+		spin_lock_init(&pipe->nodes[i].buf_list_lock);
+		INIT_LIST_HEAD(&pipe->nodes[i].buf_list);
+
+		if (pipe->nodes[i].flags & MEDIA_LNK_FL_ENABLED)
+			count++;
+	}
+
+	if (pipe->desc->master >= 0 &&
+	    pipe->desc->master < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM) {
+		if (!(pipe->nodes[pipe->desc->master].flags &
+		    MEDIA_LNK_FL_ENABLED))
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 64

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+			count++;
+
+		pipe->nodes[pipe->desc->master].flags |=
+			MEDIA_LNK_FL_ENABLED | MEDIA_LNK_FL_IMMUTABLE;
+	}

All the pipes seem to have master set to MTK_DIP_VIDEO_NODE_ID_NO_MASTER, so this seems to be dead code.

I will remove MTK_DIP_VIDEO_NODE_ID_NO_MASTER and the dead codes.

Quoted 64 lines
Quoted 64 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +63 -0
+
+	atomic_set(&pipe->cnt_nodes_not_streaming, count);
+
+	ret = mtk_dip_pipe_v4l2_register(pipe, media_dev, v4l2_dev);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s: failed(%d) to create V4L2 devices\n",
+			pipe->desc->name, ret);
+
+		goto err_destroy_pipe_lock;
+	}
+
+	return 0;
+
+err_destroy_pipe_lock:
+	mutex_destroy(&pipe->lock);
+
+	return ret;
+}
+
+int mtk_dip_pipe_release(struct mtk_dip_pipe *pipe)
+{
+	mtk_dip_pipe_v4l2_unregister(pipe);
+	mutex_destroy(&pipe->lock);
+
+	return 0;
+}
+
+int mtk_dip_pipe_next_job_id(struct mtk_dip_pipe *pipe)
+{
+	int global_job_id = atomic_inc_return(&pipe->pipe_job_sequence);
+
+	return (global_job_id & 0x0000FFFF) | (pipe->desc->id << 16);
+}
+
+struct mtk_dip_pipe_job_info*
+mtk_dip_pipe_get_running_job_info(struct mtk_dip_pipe *pipe, int pipe_job_id)
+{
+	struct mtk_dip_pipe_job_info *job_info;
+
+	spin_lock(&pipe->job_lock);
+	list_for_each_entry(job_info,
+			    &pipe->pipe_job_running_list, list) {
+		if (job_info->id == pipe_job_id) {
+			spin_unlock(&pipe->job_lock);
+			return job_info;
+		}
+	}
+	spin_unlock(&pipe->job_lock);
+
+	return NULL;
+}
+
+void mtk_dip_pipe_debug_job(struct mtk_dip_pipe *pipe,
+			    struct mtk_dip_pipe_job_info *job_info)
+{
+	int i;
+
+	dev_dbg(&pipe->dip_dev->pdev->dev, "%s: pipe-job(%p),id(%d)\n",
+		pipe->desc->name, job_info, job_info->id);
+
+	for (i = 0; i < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM ; i++) {
+		if (job_info->buf_map[i])
Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 132

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+			dev_dbg(&pipe->dip_dev->pdev->dev, "%s:%s:buf(%p)\n",
+				pipe->desc->name, pipe->nodes[i].desc->name, i,
+				job_info->buf_map[i]);
+	}
+}

We should remove this kind of excessive debugging code. I'd recommend keeping it as a local test-only patch on top of the driver.

I got it.

Quoted 6 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 136

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +4 -0
+
+int mtk_dip_pipe_job_finish(struct mtk_dip_pipe *pipe,
+			    unsigned int pipe_job_info_id,
+			    enum vb2_buffer_state vbf_state)

This function only returns 0. Should it be made void?

I will change it to a void one.

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 142

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+{
+	struct mtk_dip_pipe_job_info *job_info;
+	struct mtk_dip_dev_buffer *in_buf;
+	int i, num_running_jobs;
+
+	job_info = mtk_dip_pipe_get_running_job_info(pipe, pipe_job_info_id);

Why don't we just pass mtk_dip_request as an argument ot this function? I can see that the both callers already have them.

Yes, we will pass mtk_dip_request instead.

Quoted 13 lines
Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +12 -0
+	in_buf = job_info->buf_map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT];
+
+	spin_lock(&pipe->job_lock);
+	list_del(&job_info->list);
+	num_running_jobs = --pipe->num_jobs;
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s: num of running jobs(%d)\n",
+		__func__, pipe->desc->name, pipe->num_jobs);
+	spin_unlock(&pipe->job_lock);
+
+	for (i = 0; i < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM; i++) {
+		struct mtk_dip_dev_buffer *dev_buf = job_info->buf_map[i];
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 160

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+		struct mtk_dip_video_device *node;
+
+		if (!dev_buf)
+			continue;
+
+		if (in_buf && dev_buf != in_buf)

Is it possible that in_buf is NULL?

in_buf is always not NULL. I will remove the check.

Quoted 12 lines
Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +11 -0
+			dev_buf->vbb.vb2_buf.timestamp =
+				in_buf->vbb.vb2_buf.timestamp;
+
+		vb2_buffer_done(&dev_buf->vbb.vb2_buf, vbf_state);
+
+		node = mtk_dip_vbq_to_node(dev_buf->vbb.vb2_buf.vb2_queue);
+		spin_lock(&node->buf_list_lock);
+		list_del(&dev_buf->list);
+		spin_unlock(&node->buf_list_lock);
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 175

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +4 -0
+			"%s:%s: return buf, idx(%d), state(%d)\n",
+			pipe->desc->name, node->desc->name,
+			dev_buf->vbb.vb2_buf.index, vbf_state);
+	}

This looks almost the same as what's being done inside mtk_dip_hw_streamoff(). Could we just call this function from the loop there?

I would like to call the function from mtk_dip_hw_streamoff(). The only difference is mtk_dip_pipe_job_finish() also remove the buffer from the node's internal list.

Quoted 25 lines
Quoted 25 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +24 -0
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s: finished job id(%d), vbf_state(%d), running jobs(%d)\n",
+		__func__, pipe->desc->name, pipe_job_info_id, vbf_state,
+		num_running_jobs);
+
+	return 0;
+}
+
+static __u32 get_pixel_byte_by_fmt(__u32 pix_fmt)
+{
+	switch (pix_fmt) {
+	case V4L2_PIX_FMT_MTISP_B8:
+	case V4L2_PIX_FMT_MTISP_F8:
+		return 8;
+	case V4L2_PIX_FMT_MTISP_B10:
+	case V4L2_PIX_FMT_MTISP_F10:
+		return 10;
+	case V4L2_PIX_FMT_MTISP_B12:
+	case V4L2_PIX_FMT_MTISP_F12:
+		return 12;
+	case V4L2_PIX_FMT_MTISP_B14:
+	case V4L2_PIX_FMT_MTISP_F14:
+		return 14;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 203

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +4 -0
+	case V4L2_PIX_FMT_MTISP_U8:
+	case V4L2_PIX_FMT_MTISP_U10:
+	case V4L2_PIX_FMT_MTISP_U12:
+	case V4L2_PIX_FMT_MTISP_U14:

From all the formats above, we only have B10 and F10 in in_fmts[]. Are they all supported by DIP? If so, are they only missing in in_fmts[] or the driver needs more changes to support them?

DIP supports the formats except V4L2_PIX_FMT_MTISP_UXX. I will add them to in_fmts[].

Quoted 19 lines
Quoted 19 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +18 -0
+		return 16;
+	default:
+		return 0;
+	}
+}
+
+static __u32
+mtk_dip_pass1_cal_main_stride(__u32 width, __u32 pix_fmt)
+{
+	__u32 stride;
+	__u32 pixel_byte = get_pixel_byte_by_fmt(pix_fmt);
+
+	width = ALIGN(width, 4);
+	stride = ALIGN(DIV_ROUND_UP(width * pixel_byte, 8), 2);
+
+	return ALIGN(stride, 4);
+}
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 226

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+static __u32
+mtk_dip_pass1_cal_pack_stride(__u32 width, __u32 pix_fmt)
+{
+	__u32 stride;
+	__u32 pixel_byte = get_pixel_byte_by_fmt(pix_fmt);

The __ types are only for UAPI structures. Please use the types without the prefix.

I got it.

Quoted 12 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 235

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+
+	width = ALIGN(width, 4);
+	stride = DIV_ROUND_UP(width * 3, 2);
+	stride = DIV_ROUND_UP(stride * pixel_byte, 8);
+
+	if (pix_fmt == V4L2_PIX_FMT_MTISP_F10)
+		stride =  ALIGN(stride, 4);
+	else
+		stride =  ALIGN(stride, 8);

Could you explain all the calculations done above?

If the buffer comes from mtk-cam-p1, the stride setting must be the same as p1. I would like to re-implement the codes following p1's design in v4 patch as following:

static u32

mtk_dip_pass1_cal_pack_stride(u32 width, u32 pix_fmt) {
	unsigned int bpl;
	unsigned int pixel_bits =
		get_pixel_byte_by_fmt(mp->pixelformat);
	
	/* Bayer encoding format, P1 HW needs 2 bytes alignment */
	bpl = ALIGN(DIV_ROUND_UP(width * pixel_bits, 8), 2);

	/* The setting also needs 4 bytes alignment for DIP HW */
	return ALIGN(bpl, 4);;
}

static __u32 mtk_dip_pass1_cal_main_stride(u32 width, u32 pix_fmt)

{
	unsigned int bpl, ppl;
	unsigned int pixel_bits =
		get_pixel_byte_by_fmt(mp->pixelformat);

	/*
	 * The FULL-G encoding format
	 * 1 G component per pixel
	 * 1 R component per 4 pixel
	 * 1 B component per 4 pixel
	 * Total 4G/1R/1B in 4 pixel (pixel per line:ppl)
	 */
	ppl = DIV_ROUND_UP(width * 6, 4);
	bpl = DIV_ROUND_UP(ppl * pixel_bits, 8);

	/* 4 bytes alignment for 10 bit & others are 8 bytes */
	if (pixel_bits == 10)
		bpl = ALIGN(bpl, 4);
	else
		bpl = ALIGN(bpl, 8);
	}

	return bpl;
}
Quoted 68 lines
Quoted 68 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +67 -0
+
+	return stride;
+}
+
+static int is_stride_need_to_align(u32 format, u32 *need_aligned_fmts,
+				   int length)
+{
+	int i;
+
+	for (i = 0; i < length; i++) {
+		if (format == need_aligned_fmts[i])
+			return true;
+	}
+
+	return false;
+}
+
+/* Stride that is accepted by MDP HW */
+static u32 dip_mdp_fmt_get_stride(struct v4l2_pix_format_mplane *mfmt,
+				  const struct mtk_dip_dev_format *fmt,
+				  unsigned int plane)
+{
+	enum mdp_color c = fmt->mdp_color;
+	u32 bytesperline = (mfmt->width * fmt->row_depth[plane]) / 8;
+	u32 stride = (bytesperline * MDP_COLOR_BITS_PER_PIXEL(c))
+		/ fmt->row_depth[0];
+
+	if (plane == 0)
+		return stride;
+
+	if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+		if (MDP_COLOR_IS_BLOCK_MODE(c))
+			stride = stride / 2;
+		return stride;
+	}
+
+	return 0;
+}
+
+/* Stride that is accepted by MDP HW of format with contiguous planes */
+static u32
+dip_mdp_fmt_get_stride_contig(const struct mtk_dip_dev_format *fmt,
+			      u32 pix_stride,
+			      unsigned int plane)
+{
+	enum mdp_color c = fmt->mdp_color;
+	u32 stride = pix_stride;
+
+	if (plane == 0)
+		return stride;
+
+	if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+		stride = stride >> MDP_COLOR_GET_H_SUBSAMPLE(c);
+		if (MDP_COLOR_IS_UV_COPLANE(c) && !MDP_COLOR_IS_BLOCK_MODE(c))
+			stride = stride * 2;
+		return stride;
+	}
+
+	return 0;
+}
+
+/* Plane size that is accepted by MDP HW */
+static u32
+dip_mdp_fmt_get_plane_size(const struct mtk_dip_dev_format *fmt,
+			   u32 stride, u32 height,
+			   unsigned int plane)
+{
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 307

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+	enum mdp_color c = fmt->mdp_color;
+	u32 bytesperline;
+
+	bytesperline = (stride * fmt->row_depth[0])
+		/ MDP_COLOR_BITS_PER_PIXEL(c);

Hmm, stride and bytesperline should be exactly the same thing. Could you explain what's happening here?

The stride here is specific for MDP hardware (which uses the same MDP stride setting for NV12 and NV12M):

bytesperline = width * row_depth / 8
MDP stride = width * MDP_COLOR_BITS_PER_PIXEL /8

Therfore,

bytesperline = MDP stride * row_depth / MDP_COLOR_BITS_PER_PIXEL
MDP stride = bytesperline * MDP_COLOR_BITS_PER_PIXEL/ row_depth

Quoted 23 lines
Quoted 23 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +22 -0
+	if (plane == 0)
+		return bytesperline * height;
+	if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+		height = height >> MDP_COLOR_GET_V_SUBSAMPLE(c);
+		if (MDP_COLOR_IS_BLOCK_MODE(c))
+			bytesperline = bytesperline * 2;
+		return bytesperline * height;
+	}
+
+	return 0;
+}
+
+static int mtk_dip_pipe_get_stride(struct mtk_dip_pipe *pipe,
+				   struct v4l2_pix_format_mplane *mfmt,
+				   const struct mtk_dip_dev_format *dfmt,
+				   int plane,
+				   char *buf_name)
+{
+	int bpl;
+	u32 fmts_pass1_main[] = {
+		V4L2_PIX_FMT_MTISP_B8,
+		V4L2_PIX_FMT_MTISP_B10
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 334

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+	};
+	u32 fmts_pass1_pack[] = {
+		V4L2_PIX_FMT_MTISP_F8,
+		V4L2_PIX_FMT_MTISP_F10
+	};

We don't seem to have B8 and F8 formats in in_fmts[]. Are they just missing there or there is something else missing too?

I will add B8 and F8 support in in_fmts[].

Quoted 15 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 345

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +11 -0
+
+	if (is_stride_need_to_align(mfmt->pixelformat, fmts_pass1_main,
+				    ARRAY_SIZE(fmts_pass1_main)))
+		bpl = mtk_dip_pass1_cal_main_stride(mfmt->width,
+						    mfmt->pixelformat);
+	else if (is_stride_need_to_align(mfmt->pixelformat, fmts_pass1_pack,
+					 ARRAY_SIZE(fmts_pass1_pack)))
+		bpl = mtk_dip_pass1_cal_pack_stride(mfmt->width,
+						    mfmt->pixelformat);
+	else
+		bpl = dip_mdp_fmt_get_stride(mfmt, dfmt, plane);

Please add the information about necessary alignment to struct mtk_dip_dev_format instead of hardcoding in the local arrays above.

I got it.

Quoted 14 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 355

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s:%s: plane(%d), pixelformat(%x) width(%d), stride(%d)",
+		__func__, pipe->desc->name, buf_name, plane,
+		mfmt->pixelformat, mfmt->width, bpl);
+
+	return bpl;
+}
+
+void mtk_dip_pipe_set_img_fmt(struct mtk_dip_pipe *pipe,

The function name is confusing. "Set" in V4L2 sounds like changing the active format. How about mtk_dip_pipe_try_fmt()?

Yes. I will change it to mtk_dip_pipe_try_fmt().

Quoted 6 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 357

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +2 -0
+			      struct mtk_dip_video_device *node,
+			      struct v4l2_pix_format_mplane *mfmt_to_fill,

This is quite a long name. It should be evident that this argument is an output, so "fmt" should be good enough.

I got it.

Quoted 15 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 369

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +12 -0
+			      const struct mtk_dip_dev_format *dev_fmt)
+{
+	int i;
+
+	mfmt_to_fill->pixelformat = dev_fmt->format;
+	mfmt_to_fill->num_planes = dev_fmt->num_planes;
+	mfmt_to_fill->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
+	mfmt_to_fill->quantization = V4L2_QUANTIZATION_DEFAULT;
+	mfmt_to_fill->colorspace = dev_fmt->colorspace;
+	mfmt_to_fill->field = V4L2_FIELD_NONE;
+
+	memset(mfmt_to_fill->reserved, 0, sizeof(mfmt_to_fill->reserved));

The core already takes care of zeroing the reserved fields.

I got it.

Quoted 14 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 379

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s:%s: Fmt(%c%c%c%c),  w(%d),h(%d), f(%d)\n",
+		__func__, pipe->desc->name, node->desc->name,
+		mfmt_to_fill->pixelformat & 0xff,
+		mfmt_to_fill->pixelformat >> 8 & 0xff,
+		mfmt_to_fill->pixelformat >> 16 & 0xff,
+		mfmt_to_fill->pixelformat >> 24 & 0xff,
+		mfmt_to_fill->width, mfmt_to_fill->height,
+		mfmt_to_fill->field);

No need for this print. There is already built in printing of formats in the core when format-related ioctls are called.

I got it.

Quoted 7 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 382

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+
+	for (i = 0; i < mfmt_to_fill->num_planes; ++i) {
+		u32 min_bpl = (mfmt_to_fill->width * dev_fmt->row_depth[i]) / 8;

Shouldn't this use DIV_ROUND_UP()? I can see some row_depth not being a multiple of 8.

I will use DIV_ROUND_UP() here.

Quoted 5 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 383

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +1 -0
+		u32 bpl = mfmt_to_fill->plane_fmt[i].bytesperline;

In current V4L2 API, bytesperline is always set by the driver, so no need to preserve what came from the userspace.

I got it.

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 390

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +7 -0
+		u32 sizeimage;
+
+		if (bpl < min_bpl)
+			bpl = min_bpl;
+
+		sizeimage = (bpl * mfmt_to_fill->height * dev_fmt->depth[i])
+			/ dev_fmt->row_depth[i];

Shouldn't this be bpl * fmt->height?

Row_depth is the bits of the pixel.
Depth means the bytes per pixel of the image format.

For example,
Image: 640 * 480
YV12: row_depth = 8, depth = 12
Bytes per line = width * row_depth / 8 = 640 * 8/ 8 = 640 Image size = Bytes per line * height * (depth/ row_depth)

	   = 640 * 480 * 1.5
Quoted 7 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 393

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+		mfmt_to_fill->plane_fmt[i].bytesperline = bpl;
+		if (mfmt_to_fill->plane_fmt[i].sizeimage < sizeimage)
+			mfmt_to_fill->plane_fmt[i].sizeimage = sizeimage;

Same with sizeimage. It's defined to be always written by the driver.

Quoted 5 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 396

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+
+		memset(mfmt_to_fill->plane_fmt[i].reserved,
+		       0, sizeof(mfmt_to_fill->plane_fmt[i].reserved));

The core takes care of this already.

I got it.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 401

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s:%s: plane(%d): bpl(%u), min_bpl(%u), s(%u)\n",
+			__func__, pipe->desc->name, node->desc->name,
+			i, bpl, min_bpl, mfmt_to_fill->plane_fmt[i].sizeimage);

The core already has an appropriate debug message.

I got it.

Quoted 30 lines
Quoted 30 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +29 -0
+	}
+}
+
+static void set_meta_fmt(struct mtk_dip_pipe *pipe,
+			 struct v4l2_meta_format *metafmt_to_fill,
+			 const struct mtk_dip_dev_format *dev_fmt)
+{
+	metafmt_to_fill->dataformat = dev_fmt->format;
+
+	if (dev_fmt->buffer_size <= 0) {
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s: Invalid meta buf size(%u), use default(%u)\n",
+			pipe->desc->name, dev_fmt->buffer_size,
+			MTK_DIP_DEV_META_BUF_DEFAULT_SIZE);
+
+		metafmt_to_fill->buffersize =
+			MTK_DIP_DEV_META_BUF_DEFAULT_SIZE;
+	} else {
+		metafmt_to_fill->buffersize = dev_fmt->buffer_size;
+	}
+}
+
+void mtk_dip_pipe_load_default_fmt(struct mtk_dip_pipe *pipe,
+				   struct mtk_dip_video_device *node,
+				   struct v4l2_format *fmt_to_fill)
+{
+	int idx = node->desc->default_fmt_idx;
+
+	if (node->desc->num_fmts == 0) {
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 436

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: desc->num_fmts is 0, no format support list\n",
+		       __func__, node->desc->name);
+
+		return;
+	}

Is this even possible?

No. I will remove the check.

Quoted 11 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 444

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +8 -0
+
+	if (idx >= node->desc->num_fmts) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: invalid idx(%d), must < num_fmts(%d)\n",
+			__func__, node->desc->name, idx, node->desc->num_fmts);
+
+		idx = 0;
+	}

Is this possible too?

No. I will remove the check.

Quoted 61 lines
Quoted 24 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +23 -0
+
+	fmt_to_fill->type = node->desc->buf_type;
+	if (mtk_dip_buf_is_meta(node->desc->buf_type)) {
+		set_meta_fmt(pipe, &fmt_to_fill->fmt.meta,
+			     &node->desc->fmts[idx]);
+	} else {
+		fmt_to_fill->fmt.pix_mp.width = node->desc->default_width;
+		fmt_to_fill->fmt.pix_mp.height = node->desc->default_height;
+		mtk_dip_pipe_set_img_fmt(pipe, node, &fmt_to_fill->fmt.pix_mp,
+					 &node->desc->fmts[idx]);
+	}
+}
+
+const struct mtk_dip_dev_format*
+mtk_dip_pipe_find_fmt(struct mtk_dip_pipe *pipe,
+		      struct mtk_dip_video_device *node,
+		      u32 format)
+{
+	int i;
+
+	for (i = 0; i < node->desc->num_fmts; i++) {
+		if (node->desc->fmts[i].format == format)
+			return &node->desc->fmts[i];

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 477

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+	}
+
+	return NULL;
+}
+
+static enum mdp_ycbcr_profile
+map_ycbcr_prof_mplane(struct v4l2_pix_format_mplane *pix_mp, u32 mdp_color)
+{
+	if (MDP_COLOR_IS_RGB(mdp_color))
+		return MDP_YCBCR_PROFILE_FULL_BT601;

Similar comment as below.

Quoted 24 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +24 -0
+
+	switch (pix_mp->colorspace) {
+	case V4L2_COLORSPACE_JPEG:
+		return MDP_YCBCR_PROFILE_JPEG;
+	case V4L2_COLORSPACE_REC709:
+	case V4L2_COLORSPACE_DCI_P3:
+		if (pix_mp->quantization == V4L2_QUANTIZATION_FULL_RANGE)
+			return MDP_YCBCR_PROFILE_FULL_BT709;
+		return MDP_YCBCR_PROFILE_BT709;
+	case V4L2_COLORSPACE_BT2020:
+		if (pix_mp->quantization == V4L2_QUANTIZATION_FULL_RANGE)
+			return MDP_YCBCR_PROFILE_FULL_BT2020;
+		return MDP_YCBCR_PROFILE_BT2020;
+	}
+	/* V4L2_COLORSPACE_SRGB or else */
+	if (pix_mp->quantization == V4L2_QUANTIZATION_FULL_RANGE)
+		return MDP_YCBCR_PROFILE_FULL_BT601;
+
+	return MDP_YCBCR_PROFILE_BT601;
+}
+
+static inline int is_contig_mp_buffer(struct mtk_dip_dev_buffer *dev_buf)
+{
+	return !(MDP_COLOR_GET_PLANE_COUNT(dev_buf->dev_fmt->mdp_color) == 1);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 507

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+}
+
+static int fill_ipi_img_param_mp(struct mtk_dip_pipe *pipe,
+				 struct img_image_buffer *b,
+				 struct mtk_dip_dev_buffer *dev_buf,
+				 char *buf_name)

Please prefix the functions with mtk_dip_.

I got it.

Quoted 15 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 519

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +12 -0
+{
+	struct v4l2_pix_format_mplane *pix_mp;
+	const struct mtk_dip_dev_format *mdp_fmt;
+	unsigned int i;
+	unsigned int total_plane_size = 0;
+
+	if (!dev_buf->dev_fmt) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s: %s's dev format not set\n",
+			__func__, buf_name);
+		return -EINVAL;
+	}

Is this even possible?

No. I will remove the check.

Quoted 17 lines
Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +16 -0
+
+	pix_mp = &dev_buf->fmt.fmt.pix_mp;
+	mdp_fmt = dev_buf->dev_fmt;
+
+	b->usage = dev_buf->dma_port;
+	b->format.colorformat = dev_buf->dev_fmt->mdp_color;
+	b->format.width = dev_buf->fmt.fmt.pix_mp.width;
+	b->format.height = dev_buf->fmt.fmt.pix_mp.height;
+	b->format.ycbcr_prof =
+		map_ycbcr_prof_mplane(pix_mp,
+				      dev_buf->dev_fmt->mdp_color);
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s: buf(%s), IPI: w(%d),h(%d),c(0x%x)\n",
+		pipe->desc->name,
+		buf_name,
+		b->format.width,
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 541

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+		b->format.height,
+		b->format.colorformat);
+
+	for (i = 0; i < pix_mp->num_planes; ++i) {
+		u32 stride = mtk_dip_pipe_get_stride(pipe, pix_mp, mdp_fmt,
+						     i, buf_name);

Shouldn't stride be just equal to pix_mp.plane[i].bytesperline?

The stride here is specific for MDP hardware (which uses the same MDP stride setting for NV12 and NV12M):

bytesperline = width * row_depth / 8
MDP stride = width * MDP_COLOR_BITS_PER_PIXEL /8

Quoted 6 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 544

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+
+		b->format.plane_fmt[i].stride = stride;
+		b->format.plane_fmt[i].size =

Shouldn't size be just equal to pix_mp.plane[i].sizeimage?

Yes. I will move the actual size calculation codes to set/try format.

Quoted 16 lines
Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +3 -0
+			dip_mdp_fmt_get_plane_size(mdp_fmt, stride,
+						   pix_mp->height, i);
+		b->iova[i] = dev_buf->isp_daddr[i];

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 557

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"Non-contiguous-mp-buf:plane(%i),stride(%d),size(%d),iova(%lx)",
+			i,
+			b->format.plane_fmt[i].stride,
+			b->format.plane_fmt[i].size,
+			b->iova[i]);
+		total_plane_size += b->format.plane_fmt[i].size;
+	}
+
+	if (!is_contig_mp_buffer(dev_buf)) {

Shouldn't this be just (pix_mp->num_planes > 1)?

is_contig_mp_buffer is use to check color planes count so I can't use pix_mp->num_planes here. I will add num_cplanes feild to mtk_dip_dev_format and to check num_cplanes instead.

Quoted 16 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 566

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"Non-contiguous-mp-buf(%s),total-plane-size(%d),dma_port(%d)\n",
+			buf_name,
+			total_plane_size,
+			b->usage);
+		return 0;
+	}
+
+	for (; i < MDP_COLOR_GET_PLANE_COUNT(b->format.colorformat); ++i) {

I don't see these MDP_ macros defined anywhere. Please don't use macros defined from other drivers. We can embed this information in the mtk_dip_dev_format struct. One would normally call it num_cplanes (color planes).

Quoted 2 lines

However, I would just make this driver support M formats only and forget about formats with only memory planes count != color planes count.

Since the non-M formats are still used by 8183's user lib now, may I add num_cplanes and support the both formats?

Quoted 51 lines
Quoted 51 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +50 -0
+		u32 stride = dip_mdp_fmt_get_stride_contig
+				(mdp_fmt, b->format.plane_fmt[0].stride, i);
+
+		b->format.plane_fmt[i].stride = stride;
+		b->format.plane_fmt[i].size =
+			dip_mdp_fmt_get_plane_size(mdp_fmt, stride,
+						   pix_mp->height, i);
+		b->iova[i] = b->iova[i - 1] + b->format.plane_fmt[i - 1].size;
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"Contiguous-mp-buf:plane(%i),stride(%d),size(%d),iova(%lx)",
+			i,
+			b->format.plane_fmt[i].stride,
+			b->format.plane_fmt[i].size,
+			b->iova[i]);
+		total_plane_size += b->format.plane_fmt[i].size;
+	}
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"Contiguous-mp-buf(%s),v4l2-sizeimage(%d),total-plane-size(%d)\n",
+		buf_name,
+		pix_mp->plane_fmt[0].sizeimage,
+		total_plane_size);
+
+	return 0;
+}
+
+static int fill_input_ipi_param(struct mtk_dip_pipe *pipe,
+				struct img_input *iin,
+				struct mtk_dip_dev_buffer *dev_buf,
+				char *buf_name)
+{
+	struct img_image_buffer *img = &iin->buffer;
+
+	return fill_ipi_img_param_mp(pipe, img, dev_buf,
+				     buf_name);
+}
+
+static int fill_output_ipi_param(struct mtk_dip_pipe *pipe,
+				 struct img_output *iout,
+				 struct mtk_dip_dev_buffer *dev_buf_out,
+				 struct mtk_dip_dev_buffer *dev_buf_in,
+				 char *buf_name)
+{
+	int ret;
+	struct img_image_buffer *img = &iout->buffer;
+
+	ret = fill_ipi_img_param_mp(pipe, img, dev_buf_out,
+				    buf_name);
+	iout->crop.left = 0;
+	iout->crop.top = 0;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 622

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+	iout->crop.width = dev_buf_in->fmt.fmt.pix_mp.width;
+	iout->crop.height = dev_buf_in->fmt.fmt.pix_mp.height;
+	iout->crop.left_subpix = 0;
+	iout->crop.top_subpix = 0;
+	iout->crop.width_subpix = 0;
+	iout->crop.height_subpix = 0;

So we don't support cropping?

DIP support cropping, I will add the support in the next patch.

Quoted 56 lines
Quoted 56 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +55 -0
+	iout->rotation = dev_buf_out->rotation;
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s: buf(%s) IPI-ext:c_l(%d),c_t(%d),c_w(%d),c_h(%d)\n",
+		pipe->desc->name,
+		buf_name,
+		iout->crop.left,
+		iout->crop.top,
+		iout->crop.width,
+		iout->crop.height);
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"c_ls(%d),c_ts(%d),c_ws(%d),c_hs(%d),rot(%d)\n",
+		iout->crop.left_subpix,
+		iout->crop.top_subpix,
+		iout->crop.width_subpix,
+		iout->crop.height_subpix,
+		iout->rotation);
+
+	return ret;
+}
+
+void mtk_dip_pipe_ipi_params_config(struct mtk_dip_request *req)
+{
+	struct mtk_dip_pipe *pipe = req->dip_pipe;
+	struct platform_device *pdev = pipe->dip_dev->pdev;
+	struct mtk_dip_pipe_job_info *pipe_job_info = &req->job_info;
+	int out_img_buf_idx;
+	int in_img_buf_idx;
+	struct img_ipi_frameparam *dip_param = &req->img_fparam.frameparam;
+	struct mtk_dip_dev_buffer *dev_buf_in;
+	struct mtk_dip_dev_buffer *dev_buf_out;
+	struct mtk_dip_dev_buffer *dev_buf_tuning;
+	int i = 0;
+	int mdp_ids[2] = {MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE,
+			  MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE};
+	char *mdp_names[2] = {"mdp0", "mdp1"};
+
+	dev_dbg(&pdev->dev,
+		"%s:%s: pipe-job id(%d)\n",
+		__func__, pipe->desc->name,
+		pipe_job_info->id);
+
+	/* Fill ipi params for DIP driver */
+	memset(dip_param, 0, sizeof(*dip_param));
+	dip_param->index = pipe_job_info->id;
+	dip_param->type = STREAM_ISP_IC;
+
+	/* Tuning buffer */
+	dev_buf_tuning =
+		pipe_job_info->buf_map[MTK_DIP_VIDEO_NODE_ID_TUNING_OUT];
+	if (dev_buf_tuning) {
+		dev_dbg(&pdev->dev,
+			"Tuning buf queued: scp_daddr(%pad),isp_daddr(%pad)\n",
+			&dev_buf_tuning->scp_daddr[0],
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 683

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+			&dev_buf_tuning->isp_daddr[0]);
+		dip_param->tuning_data.pa =
+			(uint32_t)dev_buf_tuning->scp_daddr[0];
+		dip_param->tuning_data.present = true;
+		dip_param->tuning_data.iova =
+			(uint32_t)dev_buf_tuning->isp_daddr[0];

Why are these casts needed?

This structure is shared between CPU and scp and the pa and iova is defined as 32bits fields.

struct tuning_addr {
	u32	present;
	u32	pa;	/* Used by CM4 access */
	u32	iova;	/* Used by IOMMU HW access */
} __attribute__ ((__packed__));
Quoted 14 lines
Quoted 14 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +13 -0
+	} else {
+		dev_dbg(&pdev->dev,
+			"No enqueued tuning buffer: scp_daddr(%llx),present(%llx),isp_daddr(%llx\n",
+			dip_param->tuning_data.pa,
+			dip_param->tuning_data.present,
+			dip_param->tuning_data.iova);
+	}
+
+	in_img_buf_idx = 0;
+
+	/* Raw-in buffer */
+	dev_buf_in =
+		pipe_job_info->buf_map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT];
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 702

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+	if (dev_buf_in) {
+		struct img_input *iin = &dip_param->inputs[in_img_buf_idx];
+
+		fill_input_ipi_param(pipe, iin, dev_buf_in, "RAW");
+		in_img_buf_idx++;
+	}

Is it possible that we don't have an input buffer?

No. It is guaranteed by .request_validate(). I will remove the check here.

Quoted 14 lines
Quoted 14 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +13 -0
+
+	/* Array of MDP buffers */
+	out_img_buf_idx = 0;
+
+	for (i = 0; i < ARRAY_SIZE(mdp_ids); i++) {
+		dev_buf_out =
+			pipe_job_info->buf_map[mdp_ids[i]];
+		if (dev_buf_out) {
+			struct img_output *iout =
+				&dip_param->outputs[out_img_buf_idx];
+
+			fill_output_ipi_param(pipe, iout, dev_buf_out,
+					      dev_buf_in, mdp_names[i]);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 721

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+			out_img_buf_idx++;
+		}
+	}
+
+	dip_param->num_outputs = out_img_buf_idx;
+	dip_param->num_inputs = in_img_buf_idx;

Wouldn't this be always 1?

I will add another 2 input nodes in the next patch to support advance 3A feature, for example, the shading.

Quoted 45 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 730

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+}
+
+void mtk_dip_pipe_try_enqueue(struct mtk_dip_pipe *pipe)
+{
+	struct mtk_dip_pipe_job_info *job_info;
+	struct mtk_dip_pipe_job_info *tmp_job_info;
+	struct list_head enqueue_job_list;
+
+	INIT_LIST_HEAD(&enqueue_job_list);

You can merge this with the declaration by using

Quoted 32 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +32 -0
+	if (!pipe->streaming)
+		return;
+
+	spin_lock(&pipe->job_lock);
+	list_for_each_entry_safe(job_info, tmp_job_info,
+				 &pipe->pipe_job_pending_list,
+				 list) {
+		list_del(&job_info->list);
+		pipe->num_pending_jobs--;
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: current num of pending jobs(%d)\n",
+			__func__, pipe->desc->name,
+			pipe->num_pending_jobs);
+		list_add_tail(&job_info->list,
+			      &enqueue_job_list);
+	}
+	spin_unlock(&pipe->job_lock);
+
+	list_for_each_entry_safe(job_info, tmp_job_info,
+				 &enqueue_job_list,
+				 list) {
+		struct mtk_dip_request *req =
+				mtk_dip_pipe_job_info_to_req(job_info);
+
+		list_del(&job_info->list);
+
+		spin_lock(&pipe->job_lock);
+		list_add_tail(&job_info->list,
+			      &pipe->pipe_job_running_list);
+			pipe->num_jobs++;
+			dev_dbg(&pipe->dip_dev->pdev->dev,
+				"%s:%s: current num of running jobs(%d)\n",
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 768

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +6 -0
+				__func__, pipe->desc->name,
+				pipe->num_jobs);
+		spin_unlock(&pipe->job_lock);
+
+		mtk_dip_hw_enqueue(&pipe->dip_dev->dip_hw, req);
+	}

Please check my comments to the P1 RFCv3 for a similar block of code.

I will change the code as following:

spin_lock(&pipe->job_lock);
list_for_each_entry_safe(job_info, tmp_job_info,

			 &pipe->pipe_job_pending_list, list) {
	struct mtk_dip_request *req;

	list_del(&job_info->list);
	pipe->num_pending_jobs--;
 	req = mtk_dip_pipe_job_info_to_req(job_info);
	mtk_dip_hw_enqueue(&pipe->dip_dev->dip_hw, req);
}

spin_unlock(&pipe->job_lock);

Quoted 64 lines
Quoted 51 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +1 -0
+}
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +43 -0
new file mode 100644
index 000000000000..e3372c291f9a
@@ -0,0 +1,337 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *
+ */
+
+#ifndef _MTK_DIP_DEV_H_
+#define _MTK_DIP_DEV_H_
+
+#include <linux/types.h>
+#include <linux/platform_device.h>
+#include <media/v4l2-ctrls.h>
+#include <media/v4l2-subdev.h>
+#include <media/v4l2-device.h>
+#include <linux/videodev2.h>
+#include <media/videobuf2-core.h>
+#include <media/videobuf2-v4l2.h>
+
+#include "mtk_dip-hw.h"
+
+#define MTK_DIP_PIPE_ID_PREVIEW				0
+#define MTK_DIP_PIPE_ID_CAPTURE				1
+#define MTK_DIP_PIPE_ID_REPROCESS			2
+#define MTK_DIP_PIPE_ID_TOTAL_NUM			3
+
+#define MTK_DIP_VIDEO_NODE_ID_RAW_OUT			0
+#define MTK_DIP_VIDEO_NODE_ID_TUNING_OUT		1
+#define MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM		2
+#define MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE		2
+#define MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE		3
+#define MTK_DIP_VIDEO_NODE_ID_CAPTURE_TOTAL_NUM		2
+#define MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM \
+	(MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM + \
+	MTK_DIP_VIDEO_NODE_ID_CAPTURE_TOTAL_NUM)
+
+#define MTK_DIP_VIDEO_NODE_ID_NO_MASTER			-1
+
+#define MTK_DIP_OUTPUT_MIN_WIDTH		2U
+#define MTK_DIP_OUTPUT_MIN_HEIGHT		2U
+#define MTK_DIP_OUTPUT_MAX_WIDTH		5376U
+#define MTK_DIP_OUTPUT_MAX_HEIGHT		4032U

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 53

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +10 -0
+#define MTK_DIP_CAPTURE_MIN_WIDTH		2U
+#define MTK_DIP_CAPTURE_MIN_HEIGHT		2U
+#define MTK_DIP_CAPTURE_MAX_WIDTH		5376U
+#define MTK_DIP_CAPTURE_MAX_HEIGHT		4032U
+
+#define MTK_DIP_DEV_DIP_MEDIA_MODEL_NAME	"MTK-ISP-DIP-V4L2"
+#define MTK_DIP_DEV_DIP_PREVIEW_NAME \
+	MTK_DIP_DEV_DIP_MEDIA_MODEL_NAME
+#define MTK_DIP_DEV_DIP_CAPTURE_NAME		"MTK-ISP-DIP-CAP-V4L2"
+#define MTK_DIP_DEV_DIP_REPROCESS_NAME		"MTK-ISP-DIP-REP-V4L2"

Could we have a bit more user friendly names here? For example:

Quoted 7 lines

Driver name: "mtk-cam-dip"
Preview pipe: "%s %s", dev_driver_string(), "preview" Capture pipe: "%s %s", dev_driver_string(), "capture" Preview pipe: "%s %s", dev_driver_string(), "reprocess"

(For reference, I suggested "mtk-cam-p1" for P1, so that would be consistent with the above.)

Yes, I will use mtk-cam-dip instead.

Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 58

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +5 -0
+
+#define MTK_DIP_DEV_META_BUF_DEFAULT_SIZE	(1024 * 128)
+#define MTK_DIP_DEV_META_BUF_POOL_MAX_SIZE	(1024 * 1024 * 6)
+
+#define V4L2_CID_MTK_DIP_MAX			100

Why 100? I think we just have 1 rotation control. Please just use 1 explicitly in the code, without this intermediate constant.

I got it. I will use only 1.

Quoted 11 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 66

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +8 -0
+
+enum mtk_dip_pixel_mode {
+	mtk_dip_pixel_mode_default = 0,
+	mtk_dip_pixel_mode_1,
+	mtk_dip_pixel_mode_2,
+	mtk_dip_pixel_mode_4,
+	mtk_dip_pixel_mode_num,
+};

This doesn't seem to be used anywhere.

I will remove them.

Quoted 17 lines
Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +4 -0
+
+struct mtk_dip_dev_format {
+	u32 format;
+	u32 mdp_color;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 80

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +10 -0
+	u32 colorspace;
+	u8 depth[VIDEO_MAX_PLANES];
+	u8 row_depth[VIDEO_MAX_PLANES];
+	u8 num_planes;
+	u8 walign;
+	u8 halign;
+	u8 salign;
+	u32 flags;
+	u32 buffer_size;
+};

Please document all the structures defined in the driver using kerneldoc.

I got it.

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 87

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +7 -0
+
+struct mtk_dip_pipe_job_info {
+	int id;
+	struct mtk_dip_dev_buffer*
+		buf_map[MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM];
+	struct list_head list;
+};

Is there any reason to separate this from mtk_dip_request?

I will move the content of mtk_dip_pipe_job_info to mtk_dip_request.

Quoted 10 lines
Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +9 -0
+
+struct mtk_dip_dev_buffer {
+	struct vb2_v4l2_buffer vbb;
+	struct v4l2_format fmt;
+	const struct mtk_dip_dev_format *dev_fmt;
+	int pipe_job_id;
+	dma_addr_t isp_daddr[VB2_MAX_PLANES];
+	dma_addr_t scp_daddr[VB2_MAX_PLANES];
+	unsigned int dma_port;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 102

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +6 -0
+	int rotation;
+	struct list_head list;
+};
+
+struct mtk_dip_pipe_desc {
+	char *name;

Shouldn't this be const char *?

I got it.

Quoted 14 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 113

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +11 -0
+	int master;
+	int id;
+	const struct mtk_dip_video_device_desc *output_queue_descs;
+	int total_output_queues;
+	const struct mtk_dip_video_device_desc *capture_queue_descs;
+	int total_capture_queues;
+};
+
+struct mtk_dip_video_device_desc {
+	int id;
+	char *name;

Shouldn't this be const char *?

I got it.

Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 119

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +6 -0
+	u32 buf_type;
+	u32 cap;
+	int smem_alloc;
+	const struct mtk_dip_dev_format *fmts;
+	int num_fmts;
+	char *description;

Shouldn't this be const char *?

I got it.

Quoted 56 lines
Quoted 56 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +55 -0
+	int default_width;
+	int default_height;
+	unsigned int dma_port;
+	const struct v4l2_frmsizeenum *frmsizeenum;
+	const struct v4l2_ioctl_ops *ops;
+	u32 flags;
+	int default_fmt_idx;
+};
+
+struct mtk_dip_dev_queue {
+	struct vb2_queue vbq;
+	/* Serializes vb2 queue and video device operations */
+	struct mutex lock;
+	const struct mtk_dip_dev_format *dev_fmt;
+	int rotation;
+};
+
+struct mtk_dip_video_device {
+	struct video_device vdev;
+	struct mtk_dip_dev_queue dev_q;
+	struct v4l2_format vdev_fmt;
+	struct media_pad vdev_pad;
+	struct v4l2_mbus_framefmt pad_fmt;
+	struct v4l2_ctrl_handler ctrl_handler;
+	u32 flags;
+	const struct mtk_dip_video_device_desc *desc;
+	atomic_t sequence;
+	struct list_head buf_list;
+	/* protect the in-device buffer list */
+	spinlock_t buf_list_lock;
+};
+
+struct mtk_dip_pipe {
+	struct mtk_dip_dev *dip_dev;
+	struct mtk_dip_video_device nodes[MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM];
+	int num_nodes;
+	atomic_t cnt_nodes_not_streaming;
+	int streaming;
+	struct media_pad *subdev_pads;
+	struct media_pipeline pipeline;
+	struct v4l2_subdev subdev;
+	struct v4l2_subdev_fh *fh;
+	atomic_t pipe_job_sequence;
+	struct list_head pipe_job_pending_list;
+	int num_pending_jobs;
+	struct list_head pipe_job_running_list;
+	int num_jobs;
+	/* Serializes pipe's stream on/off and buffers enqueue operations */
+	struct mutex lock;
+	spinlock_t job_lock; /* protect the pipe job list */
+	const struct mtk_dip_pipe_desc *desc;
+};
+
+struct mtk_dip_dev {
+	struct platform_device *pdev;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 178

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +4 -0
+	struct media_device mdev;
+	struct v4l2_device v4l2_dev;
+	struct mtk_dip_pipe dip_pipe[MTK_DIP_PIPE_ID_TOTAL_NUM];
+	struct mtk_dip_hw dip_hw;

nit: There isn't much benefit from having the separate mtk_dip_hw struct here. On the contrary it causes long dereference chains, which only clutter the code, e.g. "&pipe->dip_dev->dip_hw.scp_pdev->dev".

I will move the fields of mtk_dip_hw to struct mtk_dip_dev.

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 184

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +6 -0
+};
+
+struct mtk_dip_request {
+	struct media_request req;
+	struct mtk_dip_pipe *dip_pipe;
+	struct mtk_dip_pipe_job_info job_info;

Is there a need to have mtk_dip_pipe_job_info as a separate struct rather than just having the fields here?

I will move the fields of mtk_dip_pipe_job_info to struct mtk_dip_request.

Quoted 145 lines
Quoted 145 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +144 -0
+	struct img_frameparam img_fparam;
+	struct work_struct fw_work;
+	struct work_struct mdp_work;
+	/* It is used only in timeout handling flow */
+	struct work_struct mdpcb_work;
+	struct mtk_dip_hw_subframe *working_buf;
+	atomic_t buf_count;
+};
+
+int mtk_dip_dev_media_register(struct device *dev,
+			       struct media_device *media_dev,
+			       const char *model);
+
+void mtk_dip_dev_v4l2_release(struct mtk_dip_dev *dip_dev);
+
+int mtk_dip_dev_v4l2_register(struct device *dev,
+			      struct media_device *media_dev,
+			      struct v4l2_device *v4l2_dev);
+
+int mtk_dip_pipe_v4l2_register(struct mtk_dip_pipe *pipe,
+			       struct media_device *media_dev,
+			       struct v4l2_device *v4l2_dev);
+
+void mtk_dip_pipe_v4l2_unregister(struct mtk_dip_pipe *pipe);
+
+int mtk_dip_pipe_queue_buffers(struct media_request *req, int initial);
+
+int mtk_dip_pipe_init(struct mtk_dip_pipe *pipe,
+		      struct mtk_dip_dev *dip_dev,
+		      const struct mtk_dip_pipe_desc *setting,
+		      struct media_device *media_dev,
+		      struct v4l2_device *v4l2_dev);
+
+void mtk_dip_pipe_ipi_params_config(struct mtk_dip_request *req);
+
+int mtk_dip_pipe_release(struct mtk_dip_pipe *pipe);
+
+struct mtk_dip_pipe_job_info *
+mtk_dip_pipe_get_running_job_info(struct mtk_dip_pipe *pipe,
+				  int pipe_job_id);
+
+int mtk_dip_pipe_next_job_id(struct mtk_dip_pipe *pipe);
+
+void mtk_dip_pipe_debug_job(struct mtk_dip_pipe *pipe,
+			    struct mtk_dip_pipe_job_info *pipe_job_info);
+
+int mtk_dip_pipe_job_finish(struct mtk_dip_pipe *pipe,
+			    unsigned int pipe_job_info_id,
+			    enum vb2_buffer_state state);
+
+const struct mtk_dip_dev_format *
+mtk_dip_pipe_find_fmt(struct mtk_dip_pipe *pipe,
+		      struct mtk_dip_video_device *node,
+		      u32 format);
+
+void mtk_dip_pipe_set_img_fmt(struct mtk_dip_pipe *pipe,
+			      struct mtk_dip_video_device *node,
+			      struct v4l2_pix_format_mplane *mfmt_to_fill,
+			      const struct mtk_dip_dev_format *dev_fmt);
+
+void mtk_dip_pipe_load_default_fmt(struct mtk_dip_pipe *pipe,
+				   struct mtk_dip_video_device *node,
+				   struct v4l2_format *fmt_to_fill);
+
+void mtk_dip_pipe_try_enqueue(struct mtk_dip_pipe *pipe);
+
+void mtk_dip_hw_enqueue(struct mtk_dip_hw *dip_hw, struct mtk_dip_request *req);
+
+int mtk_dip_hw_streamoff(struct mtk_dip_pipe *pipe);
+
+int mtk_dip_hw_streamon(struct mtk_dip_pipe *pipe);
+
+static inline struct mtk_dip_pipe*
+mtk_dip_dev_get_pipe(struct mtk_dip_dev *dip_dev, unsigned int pipe_id)
+{
+	if (pipe_id < 0 && pipe_id >= MTK_DIP_PIPE_ID_TOTAL_NUM)
+		return NULL;
+
+	return &dip_dev->dip_pipe[pipe_id];
+}
+
+static inline struct mtk_dip_video_device*
+mtk_dip_file_to_node(struct file *file)
+{
+	return container_of(video_devdata(file),
+			    struct mtk_dip_video_device, vdev);
+}
+
+static inline struct mtk_dip_pipe*
+mtk_dip_subdev_to_pipe(struct v4l2_subdev *sd)
+{
+	return container_of(sd, struct mtk_dip_pipe, subdev);
+}
+
+static inline struct mtk_dip_dev*
+mtk_dip_mdev_to_dev(struct media_device *mdev)
+{
+	return container_of(mdev, struct mtk_dip_dev, mdev);
+}
+
+static inline struct mtk_dip_video_device*
+mtk_dip_vbq_to_node(struct vb2_queue *vq)
+{
+	return container_of(vq, struct mtk_dip_video_device, dev_q.vbq);
+}
+
+static inline struct mtk_dip_dev_buffer*
+mtk_dip_vb2_buf_to_dev_buf(struct vb2_buffer *vb)
+{
+	return container_of(vb, struct mtk_dip_dev_buffer, vbb.vb2_buf);
+}
+
+static inline struct mtk_dip_dev *mtk_dip_hw_to_dev(struct mtk_dip_hw *dip_hw)
+{
+	return container_of(dip_hw, struct mtk_dip_dev, dip_hw);
+}
+
+static inline struct mtk_dip_request*
+mtk_dip_pipe_job_info_to_req(struct mtk_dip_pipe_job_info *job_info)
+{
+	return container_of(job_info, struct mtk_dip_request, job_info);
+}
+
+static inline struct mtk_dip_request*
+mtk_dip_hw_fw_work_to_req(struct work_struct *fw_work)
+{
+	return container_of(fw_work, struct mtk_dip_request, fw_work);
+}
+
+static inline struct mtk_dip_request*
+mtk_dip_hw_mdp_work_to_req(struct work_struct *mdp_work)
+{
+	return container_of(mdp_work, struct mtk_dip_request, mdp_work);
+}
+
+static inline struct mtk_dip_request *
+mtk_dip_hw_mdpcb_work_to_req(struct work_struct *mdpcb_work)
+{
+	return container_of(mdpcb_work, struct mtk_dip_request, mdpcb_work);
+}
+
+static inline int mtk_dip_buf_is_meta(u32 type)
+{
+	return type == V4L2_BUF_TYPE_META_CAPTURE ||
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h line 334

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +6 -0
+		type == V4L2_BUF_TYPE_META_OUTPUT;
+}
+
+static inline int mtk_dip_pipe_get_pipe_from_job_id(int pipe_job_id)
+{
+	return (pipe_job_id >> 16) & 0x0000FFFF;

Please use lowercase for hex numbers.

I got it.

Quoted 20 lines
Quoted 20 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h new file +3 -0
+}
+
+#endif /* _MTK_DIP_DEV_H_ */
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +10 -0
new file mode 100644
index 000000000000..2dd4dae4336c
@@ -0,0 +1,155 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *         Holmes Chiou <holmes.chiou-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *
+ */
+
+#ifndef _MTK_DIP_HW_H_
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 16

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +6 -0
+#define _MTK_DIP_HW_H_
+
+#include <linux/clk.h>
+#include "mtk-img-ipi.h"
+
+#define DIP_COMPOSER_THREAD_TIMEOUT	16U

Unused.

I will remove it.

Quoted 7 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 19

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +3 -0
+#define DIP_COMPOSING_MAX_NUM		3
+#define DIP_MAX_ERR_COUNT		188U
+#define DIP_FLUSHING_WQ_TIMEOUT		(16U * DIP_MAX_ERR_COUNT)

Any rationale behind this particular numbers? Please add comments explaining them.

I would like to adjust the time out value to 1000 / 30 * (DIP_COMPOSING_MAX_NUM) * 3.

To wait 3 times of expected frame time (@30fps) in the worst case (max number of jobs in SCP).

Quoted 16 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 31

Quoted 13 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +12 -0
+
+#define DIP_FRM_SZ			(76 * 1024)
+#define DIP_SUB_FRM_SZ			(16 * 1024)
+#define DIP_TUNING_SZ			(32 * 1024)
+#define DIP_COMP_SZ			(24 * 1024)
+#define DIP_FRAMEPARAM_SZ		(4 * 1024)
+
+#define DIP_TUNING_OFFSET		DIP_SUB_FRM_SZ
+#define DIP_COMP_OFFSET			(DIP_TUNING_OFFSET + DIP_TUNING_SZ)
+#define DIP_FRAMEPARAM_OFFSET		(DIP_COMP_OFFSET + DIP_COMP_SZ)
+#define DIP_SUB_FRM_DATA_NUM		32
+#define DIP_SCP_WORKINGBUF_OFFSET	(5 * 1024 * 1024)

What is this offset? It's 5 MB, which is 2x bigger than the total frame data (32 * 76 * 1024).

I will remove the offset since there is no need now.

Quoted 5 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 32

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +1 -0
+#define DIP_V4l2_META_BUF_OFFSET	(DIP_SCP_WORKINGBUF_OFFSET + \

Please use only uppsercase in macro names. That said, this macro isn't used anywhere.

I got it.

Quoted 21 lines
Quoted 21 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +20 -0
+					 DIP_SUB_FRM_DATA_NUM * DIP_FRM_SZ)
+
+#define MTK_DIP_CLK_NUM 2
+
+enum STREAM_TYPE_ENUM {
+	STREAM_UNKNOWN,
+	STREAM_BITBLT,
+	STREAM_GPU_BITBLT,
+	STREAM_DUAL_BITBLT,
+	STREAM_2ND_BITBLT,
+	STREAM_ISP_IC,
+	STREAM_ISP_VR,
+	STREAM_ISP_ZSD,
+	STREAM_ISP_IP,
+	STREAM_ISP_VSS,
+	STREAM_ISP_ZSD_SLOW,
+	STREAM_WPE,
+	STREAM_WPE2,
+};
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 58

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +6 -0
+enum mtk_dip_hw_user_state {
+	DIP_STATE_INIT	= 0,
+	DIP_STATE_OPENED,
+	DIP_STATE_STREAMON,
+	DIP_STATE_STREAMOFF
+};

Are these 2 enums above a part of the firmware ABI?

enum STREAM_TYPE_ENUM is the firmware ABI. enum mtk_dip_hw_user_state was phased out in SCP firmware part and I will remove it.

Quoted 21 lines
Quoted 21 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +20 -0
+
+struct mtk_dip_hw_working_buf {
+	dma_addr_t scp_daddr;
+	void *vaddr;
+	dma_addr_t isp_daddr;
+};
+
+struct mtk_dip_hw_subframe {
+	struct mtk_dip_hw_working_buf buffer;
+	int size;
+	struct mtk_dip_hw_working_buf config_data;
+	struct mtk_dip_hw_working_buf tuning_buf;
+	struct mtk_dip_hw_working_buf frameparam;
+	struct list_head list_entry;
+};
+
+enum frame_state {
+	FRAME_STATE_INIT = 0,
+	FRAME_STATE_COMPOSING,
+	FRAME_STATE_RUNNING,
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 83

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +5 -0
+	FRAME_STATE_DONE,
+	FRAME_STATE_STREAMOFF,
+	FRAME_STATE_ERROR,
+	FRAME_STATE_HW_TIMEOUT
+};

Are these values a part of the firmware ABI? If so, they should be defined as macros, with explicit values assigned.

Yes, they are firmware ABI. I will use macros instead.

Quoted 43 lines
Quoted 43 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +42 -0
+
+struct mtk_dip_hw_working_buf_list {
+	struct list_head list;
+	u32 cnt;
+	spinlock_t lock; /* protect the list and cnt */
+
+};
+
+struct mtk_dip_hw {
+	struct clk_bulk_data clks[MTK_DIP_CLK_NUM];
+	struct workqueue_struct *composer_wq;
+	struct workqueue_struct *mdp_wq;
+	wait_queue_head_t working_buf_wq;
+	wait_queue_head_t flushing_wq;
+	wait_queue_head_t flushing_hw_wq;
+	atomic_t num_composing;	/* increase after ipi */
+	/* increase after calling MDP driver */
+	atomic_t num_running;
+	/*MDP/GCE callback workqueue */
+	struct workqueue_struct *mdpcb_workqueue;
+	/* for MDP driver  */
+	struct platform_device *mdp_pdev;
+	/* for SCP driver  */
+	struct platform_device *scp_pdev;
+	struct rproc *rproc_handle;
+	struct mtk_dip_hw_working_buf_list dip_freebufferlist;
+	struct mtk_dip_hw_working_buf_list dip_usedbufferlist;
+	dma_addr_t working_buf_mem_scp_daddr;
+	void *working_buf_mem_vaddr;
+	dma_addr_t working_buf_mem_isp_daddr;
+	int working_buf_mem_size;
+	struct mtk_dip_hw_subframe working_buf[DIP_SUB_FRM_DATA_NUM];
+	/* increase after enqueue */
+	atomic_t dip_enque_cnt;
+	/* increase after stream on, decrease when stream off */
+	atomic_t dip_stream_cnt;
+	/* To serialize request opertion to DIP co-procrosser and hadrware */
+	struct mutex hw_op_lock;
+	/* To restrict the max number of request be send to SCP */
+	struct semaphore sem;
+};
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 130

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +5 -0
+static inline void
+mtk_dip_wbuf_to_ipi_img_sw_addr(struct img_sw_addr *ipi_addr,
+				struct mtk_dip_hw_working_buf *wbuf)
+{
+	ipi_addr->va = (u64)wbuf->vaddr;

Why would IPI need VA? Actually, we shouldn't even pass kernel pointers to the firmware for security reasons.

I got it. I will remove the va from ipi_addr.

Quoted 133 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 138

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +8 -0
+	ipi_addr->pa = (u32)wbuf->scp_daddr;
+}
+
+static inline void
+mtk_dip_wbuf_to_ipi_img_addr(struct img_addr *ipi_addr,
+			     struct mtk_dip_hw_working_buf *wbuf)
+{
+	ipi_addr->va = (u64)wbuf->vaddr;

Ditto.

Quoted 121 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +17 -0
+	ipi_addr->pa = (u32)wbuf->scp_daddr;
+	ipi_addr->iova = (u32)wbuf->isp_daddr;
+}
+
+static inline void
+mtk_dip_wbuf_to_ipi_tuning_addr(struct tuning_addr *ipi_addr,
+				struct mtk_dip_hw_working_buf *wbuf)
+{
+	ipi_addr->pa = (u32)wbuf->scp_daddr;
+	ipi_addr->iova = (u32)wbuf->isp_daddr;
+}
+
+int mtk_dip_hw_working_buf_pool_init(struct mtk_dip_hw *dip_hw);
+void mtk_dip_hw_working_buf_pool_release(struct mtk_dip_hw *dip_hw);
+
+#endif /* _MTK_DIP_HW_H_ */
+
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +98 -0
new file mode 100644
index 000000000000..603be116b03f
@@ -0,0 +1,794 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *         Holmes Chiou <holmes.chiou-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *
+ */
+
+#include <linux/device.h>
+#include <linux/dma-iommu.h>
+#include <linux/freezer.h>
+#include <linux/platform_data/mtk_scp.h>
+#include <linux/pm_runtime.h>
+#include <linux/remoteproc.h>
+#include <linux/slab.h>
+#include <linux/spinlock.h>
+#include <linux/wait.h>
+#include "mtk-mdp3-cmdq.h"
+#include "mtk_dip-dev.h"
+#include "mtk_dip-hw.h"
+
+int mtk_dip_hw_working_buf_pool_init(struct mtk_dip_hw *dip_hw)
+{
+	int i;
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+	const int working_buf_size = round_up(DIP_FRM_SZ, PAGE_SIZE);
+	phys_addr_t working_buf_paddr;
+
+	INIT_LIST_HEAD(&dip_hw->dip_freebufferlist.list);
+	spin_lock_init(&dip_hw->dip_freebufferlist.lock);
+	dip_hw->dip_freebufferlist.cnt = 0;
+
+	INIT_LIST_HEAD(&dip_hw->dip_usedbufferlist.list);
+	spin_lock_init(&dip_hw->dip_usedbufferlist.lock);
+	dip_hw->dip_usedbufferlist.cnt = 0;
+
+	init_waitqueue_head(&dip_hw->working_buf_wq);
+
+	dip_hw->working_buf_mem_size = DIP_SUB_FRM_DATA_NUM * working_buf_size +
+		DIP_SCP_WORKINGBUF_OFFSET;
+	dip_hw->working_buf_mem_vaddr =
+		dma_alloc_coherent(&dip_hw->scp_pdev->dev,
+				   dip_hw->working_buf_mem_size,
+				   &dip_hw->working_buf_mem_scp_daddr,
+				   GFP_KERNEL);
+	if (!dip_hw->working_buf_mem_vaddr) {
+		dev_err(&dip_dev->pdev->dev,
+			"memory alloc size %ld failed\n",
+			dip_hw->working_buf_mem_size);
+		return -ENOMEM;
+	}
+
+	/*
+	 * We got the incorrect physical address mapped when
+	 * using dma_map_single() so I used dma_map_page_attrs()
+	 * directly to workaround here.
+	 *
+	 * When I use dma_map_single() to map the address, the
+	 * physical address retrieved back with iommu_get_domain_for_dev()
+	 * and iommu_iova_to_phys() was not equal to the
+	 * SCP dma address (it should be the same as the physical address
+	 * since we don't have iommu), and was shifted by 0x4000000.
+	 */
+	working_buf_paddr = dip_hw->working_buf_mem_scp_daddr;
+	dip_hw->working_buf_mem_isp_daddr =
+		dma_map_page_attrs(&dip_dev->pdev->dev,
+				   phys_to_page(working_buf_paddr),
+				   0, dip_hw->working_buf_mem_size,
+				   DMA_BIDIRECTIONAL,
+				   DMA_ATTR_SKIP_CPU_SYNC);
+	if (dma_mapping_error(&dip_dev->pdev->dev,
+			      dip_hw->working_buf_mem_isp_daddr)) {
+		dev_err(&dip_dev->pdev->dev,
+			"failed to map buffer: s_daddr(%pad)\n",
+			&dip_hw->working_buf_mem_scp_daddr);
+		dma_free_coherent(&dip_hw->scp_pdev->dev,
+				  dip_hw->working_buf_mem_size,
+				  dip_hw->working_buf_mem_vaddr,
+				  dip_hw->working_buf_mem_scp_daddr);
+
+		return -ENOMEM;
+	}
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: working_buf_mem: vaddr(%p), scp_daddr(%pad)\n",
+		__func__,
+		dip_hw->working_buf_mem_vaddr,
+		&dip_hw->working_buf_mem_scp_daddr);
+
+	for (i = 0; i < DIP_SUB_FRM_DATA_NUM; i++) {
+		struct mtk_dip_hw_subframe *buf = &dip_hw->working_buf[i];
+
+		/*
+		 * Total: 0 ~ 72 KB
+		 * SubFrame: 0 ~ 16 KB
+		 */
+		buf->buffer.scp_daddr = dip_hw->working_buf_mem_scp_daddr +
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 103

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+			DIP_SCP_WORKINGBUF_OFFSET + i * working_buf_size;
+		buf->buffer.vaddr = dip_hw->working_buf_mem_vaddr +
+			DIP_SCP_WORKINGBUF_OFFSET + i * working_buf_size;
+		buf->buffer.isp_daddr = dip_hw->working_buf_mem_isp_daddr +
+			DIP_SCP_WORKINGBUF_OFFSET + i * working_buf_size;

Could you move out the offset to a local variable so that we don't duplicate the same calculation 3 times?

Yes, I will do that.

Quoted 110 lines
Quoted 110 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +109 -0
+		buf->size = working_buf_size;
+
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: buf(%d), scp_daddr(%pad), isp_daddr(%pad)\n",
+			__func__, i, &buf->buffer.scp_daddr,
+			&buf->buffer.isp_daddr);
+
+		/* Tuning: 16 ~ 48 KB */
+		buf->tuning_buf.scp_daddr =
+			buf->buffer.scp_daddr + DIP_TUNING_OFFSET;
+		buf->tuning_buf.vaddr =
+			buf->buffer.vaddr + DIP_TUNING_OFFSET;
+		buf->tuning_buf.isp_daddr =
+			buf->buffer.isp_daddr + DIP_TUNING_OFFSET;
+
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: tuning_buf(%d), scp_daddr(%pad), isp_daddr(%pad)\n",
+			__func__, i, &buf->tuning_buf.scp_daddr,
+			&buf->tuning_buf.isp_daddr);
+
+		/* Config_data: 48 ~ 72 KB */
+		buf->config_data.scp_daddr =
+			buf->buffer.scp_daddr + DIP_COMP_OFFSET;
+		buf->config_data.vaddr = buf->buffer.vaddr + DIP_COMP_OFFSET;
+
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: config_data(%d), scp_daddr(%pad), vaddr(%p)\n",
+			__func__, i, &buf->config_data.scp_daddr,
+			buf->config_data.vaddr);
+
+		/* Frame parameters: 72 ~ 76 KB */
+		buf->frameparam.scp_daddr =
+			buf->buffer.scp_daddr + DIP_FRAMEPARAM_OFFSET;
+		buf->frameparam.vaddr =
+			buf->buffer.vaddr + DIP_FRAMEPARAM_OFFSET;
+
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: frameparam(%d), scp_daddr(%pad), vaddr(%p)\n",
+			__func__, i, &buf->frameparam.scp_daddr,
+			buf->frameparam.vaddr);
+
+		list_add_tail(&buf->list_entry,
+			      &dip_hw->dip_freebufferlist.list);
+		dip_hw->dip_freebufferlist.cnt++;
+	}
+
+	return 0;
+}
+
+void mtk_dip_hw_working_buf_pool_release(struct mtk_dip_hw *dip_hw)
+{
+	/* All the buffer should be in the freebufferlist when release */
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+	u32 i;
+
+	if (dip_hw->dip_usedbufferlist.cnt)
+		dev_warn(&dip_dev->pdev->dev,
+			 "%s: dip_usedbufferlist is not empty (%d/%d)\n",
+			__func__, dip_hw->dip_usedbufferlist.cnt, i);
+
+	dma_unmap_page_attrs(&dip_dev->pdev->dev,
+			     dip_hw->working_buf_mem_isp_daddr,
+			     dip_hw->working_buf_mem_size, DMA_BIDIRECTIONAL,
+			     DMA_ATTR_SKIP_CPU_SYNC);
+
+	dma_free_coherent(&dip_hw->scp_pdev->dev, dip_hw->working_buf_mem_size,
+			  dip_hw->working_buf_mem_vaddr,
+			  dip_hw->working_buf_mem_scp_daddr);
+}
+
+static void mtk_dip_hw_working_buf_free(struct mtk_dip_hw *dip_hw,
+					struct mtk_dip_hw_subframe *working_buf)
+{
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+
+	if (!working_buf)
+		return;
+
+	spin_lock(&dip_hw->dip_usedbufferlist.lock);
+	list_del(&working_buf->list_entry);
+			dip_hw->dip_usedbufferlist.cnt--;
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: Free used buffer(%pad)\n",
+		__func__, &working_buf->buffer.scp_daddr);
+	spin_unlock(&dip_hw->dip_usedbufferlist.lock);
+
+	spin_lock(&dip_hw->dip_freebufferlist.lock);
+	list_add_tail(&working_buf->list_entry,
+		      &dip_hw->dip_freebufferlist.list);
+	dip_hw->dip_freebufferlist.cnt++;
+	spin_unlock(&dip_hw->dip_freebufferlist.lock);
+}
+
+static struct mtk_dip_hw_subframe*
+mtk_dip_hw_working_buf_alloc(struct mtk_dip_hw *dip_hw)
+{
+	struct mtk_dip_hw_subframe *working_buf;
+
+	spin_lock(&dip_hw->dip_freebufferlist.lock);
+	if (list_empty(&dip_hw->dip_freebufferlist.list)) {
+		spin_unlock(&dip_hw->dip_freebufferlist.lock);
+		return NULL;
+	}
+
+	working_buf = list_first_entry(&dip_hw->dip_freebufferlist.list,
+				       struct mtk_dip_hw_subframe, list_entry);
+	list_del(&working_buf->list_entry);
+	dip_hw->dip_freebufferlist.cnt--;
+	spin_unlock(&dip_hw->dip_freebufferlist.lock);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 218

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +6 -0
+
+	spin_lock(&dip_hw->dip_usedbufferlist.lock);
+	list_add_tail(&working_buf->list_entry,
+		      &dip_hw->dip_usedbufferlist.list);
+	dip_hw->dip_usedbufferlist.cnt++;
+	spin_unlock(&dip_hw->dip_usedbufferlist.lock);

Do we really need this usedbufferlist?

We only need dip_freebufferlist and I will remove usedbufferlist.

Quoted 17 lines
Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +16 -0
+
+	return working_buf;
+}
+
+static void mtk_dip_notify(struct mtk_dip_request *req)
+{
+	struct mtk_dip_hw *dip_hw = &req->dip_pipe->dip_dev->dip_hw;
+	struct mtk_dip_dev *dip_dev = req->dip_pipe->dip_dev;
+	struct mtk_dip_pipe *pipe = req->dip_pipe;
+	struct img_ipi_frameparam *iparam = &req->img_fparam.frameparam;
+	enum vb2_buffer_state vbf_state;
+	int ret;
+
+	if (iparam->state != FRAME_STATE_HW_TIMEOUT)
+		vbf_state = VB2_BUF_STATE_DONE;
+	else
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 240

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +6 -0
+		vbf_state = VB2_BUF_STATE_ERROR;
+
+	ret = mtk_dip_pipe_job_finish(pipe, iparam->index, vbf_state);
+	if (ret)
+		dev_dbg(&dip_dev->pdev->dev, "%s: finish CB failed(%d)\n",
+			__func__, ret);

I can see that function only returns 0.

I will change mtk_dip_pipe_job_finish as a void function. I will also remove the check.

Quoted 3 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 242

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +2 -0
+
+	pm_runtime_put_autosuspend(&pipe->dip_dev->pdev->dev);

I will call pm_runtime_mask_last_busy() here.

Quoted 44 lines

It's necessary to call pm_runtime_mask_last_busy() before this for autosuspend to work in any useful way.

Quoted 27 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +27 -0
+
+	mtk_dip_hw_working_buf_free(dip_hw, req->working_buf);
+	req->working_buf = NULL;
+	wake_up(&dip_hw->working_buf_wq);
+	wake_up(&dip_hw->flushing_wq);
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s:%s: job id(%d), frame_no(%d) finished\n",
+		__func__, pipe->desc->name, iparam->index, iparam->frame_no);
+}
+
+static void mdp_cb_timeout_worker(struct work_struct *work)
+{
+	struct mtk_dip_request *req = mtk_dip_hw_mdpcb_work_to_req(work);
+	struct img_ipi_param ipi_param;
+
+	dev_dbg(&req->dip_pipe->dip_dev->pdev->dev,
+		"%s: send frame no(%d) HW timeout dbg IPI\n",
+		__func__, req->img_fparam.frameparam.frame_no);
+
+	ipi_param.usage = IMG_IPI_DEBUG;
+	scp_ipi_send(req->dip_pipe->dip_dev->dip_hw.scp_pdev, SCP_IPI_DIP,
+		     (void *)&ipi_param, sizeof(ipi_param), 0);
+	mtk_dip_notify(req);
+}
+
+/* Maybe in IRQ context of cmdq */

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 279

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+static void dip_mdp_cb_func(struct cmdq_cb_data data)
+{
+	struct mtk_dip_request *req;
+	struct mtk_dip_dev *dip_dev;
+
+	if (!data.data) {
+		pr_err("%s: data->data is NULL\n",
+		       __func__);
+		return;
+	}

I'd just make this:

Quoted 2 lines

if (WARN_ON(!data.data))

	return;

I got it. I will do that.

Quoted 6 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 281

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +2 -0
+
+	req = data.data;

We could just assign this in the declaration and also make the check above test for !req instead.

I got it.

Quoted 25 lines
Quoted 25 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +24 -0
+	dip_dev = req->dip_pipe->dip_dev;
+
+	dev_dbg(&dip_dev->pdev->dev, "%s: req(%p), idx(%d), no(%d), s(%d), n_in(%d), n_out(%d)\n",
+		__func__,
+		req,
+		req->img_fparam.frameparam.index,
+		req->img_fparam.frameparam.frame_no,
+		req->img_fparam.frameparam.state,
+		req->img_fparam.frameparam.num_inputs,
+		req->img_fparam.frameparam.num_outputs);
+
+	if (data.sta != CMDQ_CB_NORMAL) {
+		dev_err(&dip_dev->pdev->dev, "%s: frame no(%d) HW timeout\n",
+			__func__, req->img_fparam.frameparam.frame_no);
+		req->img_fparam.frameparam.state = FRAME_STATE_HW_TIMEOUT;
+		INIT_WORK(&req->mdpcb_work, mdp_cb_timeout_worker);
+		queue_work(req->dip_pipe->dip_dev->dip_hw.mdpcb_workqueue,
+			   &req->mdpcb_work);
+	} else {
+		mtk_dip_notify(req);
+	}
+}
+
+static void dip_runner_func(struct work_struct *work)
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 310

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+{
+	struct mtk_dip_request *req = mtk_dip_hw_mdp_work_to_req(work);
+	struct mtk_dip_dev *dip_dev = req->dip_pipe->dip_dev;
+	struct img_config *config_data =
+		(struct img_config *)req->img_fparam.frameparam.config_data.va;

Could we get a proper pointer from the driver (not IPI) structures? I think that should be req->working_buf->config_data?

Yes, I will do that.

Quoted 11 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 317

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +7 -0
+	u32 num;
+
+	/*
+	 * Call MDP/GCE API to do HW excecution
+	 * Pass the framejob to MDP driver
+	 */
+	req->img_fparam.frameparam.state = FRAME_STATE_COMPOSING;

Should this be really composing? I thought we just finished composing at this point.

The field frameparam.state is not used anymore. I would like to remove it.

Quoted 4 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 318

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +1 -0
+	num = atomic_inc_return(&dip_dev->dip_hw.num_running);

I don't see where this counter is decremented. Could we just remove it?

Yes, I will remove it.

Quoted 13 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 327

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s,MDP running num(%d)\n", __func__, num);
+	mdp_cmdq_sendtask(dip_dev->dip_hw.mdp_pdev,
+			  config_data,
+			  &req->img_fparam.frameparam,
+			  NULL,
+			  false,
+			  dip_mdp_cb_func,
+			  req);

It's not a regular convention in the kernel coding style to wrap the lines for each single argument.

I got it. I will change it as following:

	mdp_cmdq_sendtask(dip_dev->dip_hw.mdp_pdev, config_data,
			  &req->img_fparam.frameparam, NULL, false, 
			  dip_mdp_cb_func, req);
Quoted 16 lines
Quoted 16 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +15 -0
+}
+
+static void dip_scp_handler(void *data, unsigned int len, void *priv)
+{
+	struct mtk_dip_pipe_job_info *pipe_job_info;
+	struct mtk_dip_pipe *pipe;
+	int pipe_id;
+	struct mtk_dip_request *req;
+	struct img_ipi_frameparam *frameparam;
+	struct mtk_dip_dev *dip_dev = (struct mtk_dip_dev *)priv;
+	struct mtk_dip_hw *dip_hw = &dip_dev->dip_hw;
+	struct img_ipi_param *ipi_param;
+	u32 num;
+	int ret;
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 348

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +6 -0
+	if (WARN_ONCE(!data, "%s: failed due to NULL data\n", __func__))
+		return;
+
+	ipi_param = (struct img_ipi_param *)data;
+
+	if (ipi_param->usage != IMG_IPI_FRAME) {

Should we check len before dereferencing the pointer?

Yes, I will add the len check.

Quoted 7 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 351

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +3 -0
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: recevied SCP_IPI_DIP ACK, ipi_param.usage(%d)\n",
+			__func__, ipi_param->usage);

Is this an expected situation? If not, perhaps we should at least print a warning here?

If it is the ack of IMG_IPI_INIT message, it is an expected situation. I would like to change the check as following:

if (len != sizeof(*ipi_param)) {
	dev_warn(&dip_dev->pdev->dev,
		 "%s: recevied unknown data, len(%d)\n", __func__,
		 len);
	return;
}

ipi_param = (struct img_ipi_param *)data;
if (ipi_param->usage == IMG_IPI_INIT)
return

if (ipi_param->usage != IMG_IPI_FRAME) {
	dev_warn(&dip_dev->pdev->dev,
		 "%s: recevied unknown ipi_param, usage(%d)\n", __func__,
		 ipi_param->usage);
	return;
}
Quoted 11 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 355

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+		return;
+	}
+
+	frameparam = (struct img_ipi_frameparam *)ipi_param->frm_param.va;

Are we getting a kernel virtual address from the firmware here? That's a recipe for a disaster. What if there is a bug (or a security hole) there and the address ends up accidentally (or deliberately) pointing to some critical kernel data?

Quoted 3 lines

We should get some kind of job identifier from the firmware and then try to find a matching request in our request list. Then any buffer addresses should be retrieved from the request struct itself.

I got it. I will use the job identifier of DIP request instead of the CPU address in ipi message.

Quoted 7 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 358

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +3 -0
+	pipe_id = mtk_dip_pipe_get_pipe_from_job_id(frameparam->index);
+	pipe = mtk_dip_dev_get_pipe(dip_dev, pipe_id);
+

nit: The next line is directly related to previous, so no need for the blank line.

I got it.

Quoted 14 lines
Quoted 14 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +13 -0
+	if (!pipe) {
+		dev_warn(&dip_dev->pdev->dev,
+			 "%s: get invalid img_ipi_frameparam index(%d) from firmware\n",
+			 __func__, frameparam->frame_no);
+		return;
+	}
+
+	pipe_job_info =	mtk_dip_pipe_get_running_job_info(pipe,
+							  frameparam->index);
+
+	if (WARN_ONCE(!pipe_job_info, "%s: frame_no(%d) is lost\n",
+		      __func__, frameparam->frame_no))
+		return;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 377

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +6 -0
+
+	req = mtk_dip_pipe_job_info_to_req(pipe_job_info);
+	memcpy(&req->img_fparam.frameparam, frameparam,
+	       sizeof(req->img_fparam.frameparam));
+	num = atomic_dec_return(&dip_hw->num_composing);
+	down(&dip_hw->sem);

I think this should be up()?

I will correct it.

Quoted 10 lines
Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: frame_no(%d) is back, composing num(%d)\n",
+		__func__, frameparam->frame_no, num);
+
+	wake_up(&dip_dev->dip_hw.flushing_hw_wq);
+
+	INIT_WORK(&req->mdp_work, dip_runner_func);
+	ret = queue_work(dip_hw->mdp_wq, &req->mdp_work);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 391

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	if (!ret) {
+		dev_dbg(&dip_dev->pdev->dev,
+			"frame_no(%d) queue_work failed to mdp_wq: %d\n",
+			frameparam->frame_no, ret);
+	}

It shouldn't be possible for this to fail given that it's a new request and the work was just initialized above.

I will remove the unnecessary check here.

Quoted 14 lines
Quoted 14 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +13 -0
+}
+
+static bool
+mtk_dip_hw_is_working_buf_allocated(struct mtk_dip_request *req)
+{
+	req->working_buf =
+		mtk_dip_hw_working_buf_alloc(&req->dip_pipe->dip_dev->dip_hw);
+
+	if (!req->working_buf) {
+		dev_dbg(&req->dip_pipe->dip_dev->pdev->dev,
+			"%s:%s:req(%p): no free working buffer available\n",
+			__func__, req->dip_pipe->desc->name, req);
+		return false;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 410

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +6 -0
+	}
+
+	return true;
+}
+
+static void dip_submit_worker(struct work_struct *work)

Shouldn't this be called dip_composer_workfunc()?

Yes, I will rename it as dip_composer_workfunc().

Quoted 21 lines
Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +6 -0
+{
+	struct mtk_dip_request *req = mtk_dip_hw_fw_work_to_req(work);
+	struct mtk_dip_hw *dip_hw = &req->dip_pipe->dip_dev->dip_hw;
+	struct mtk_dip_dev *dip_dev = req->dip_pipe->dip_dev;
+	struct img_ipi_param ipi_param;
+	struct mtk_dip_hw_subframe *buf;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 426

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+	int ret;
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: to send frame_no(%d),num(%d)\n",
+		__func__, req->img_fparam.frameparam.frame_no,
+		atomic_read(&dip_hw->num_composing));
+
+	wait_event_freezable(dip_hw->working_buf_wq,
+			     mtk_dip_hw_is_working_buf_allocated(req));
+	up(&dip_hw->sem);

Shouldn't this be down_freezable()? The idea to use semaphores was to avoid such custom wait_event() calls like above.

Quoted 3 lines

Basically the semaphore should be initialized with the total number of composer buffers and once down() is called that number of times, any further down() would block until some up() is called.

I got it. I will use down_freezable() instead of the custom wait_event() calls.

Quoted 30 lines
Quoted 30 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +29 -0
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: wakeup frame_no(%d),num(%d)\n",
+		__func__, req->img_fparam.frameparam.frame_no,
+		atomic_read(&dip_hw->num_composing));
+
+	buf = req->working_buf;
+	mtk_dip_wbuf_to_ipi_img_addr(&req->img_fparam.frameparam.subfrm_data,
+				     &buf->buffer);
+	memset(buf->buffer.vaddr, 0, DIP_SUB_FRM_SZ);
+	mtk_dip_wbuf_to_ipi_img_sw_addr(&req->img_fparam.frameparam.config_data,
+					&buf->config_data);
+	memset(buf->config_data.vaddr, 0, DIP_COMP_SZ);
+
+	if (!req->img_fparam.frameparam.tuning_data.present) {
+		/*
+		 * When user enqueued without tuning buffer,
+		 * it would use driver internal buffer.
+		 */
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: frame_no(%d) has no tuning_data\n",
+			__func__, req->img_fparam.frameparam.frame_no);
+
+		mtk_dip_wbuf_to_ipi_tuning_addr
+				(&req->img_fparam.frameparam.tuning_data,
+				 &buf->tuning_buf);
+		memset(buf->tuning_buf.vaddr, 0, DIP_TUNING_SZ);
+	}
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 460

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	req->img_fparam.frameparam.state = FRAME_STATE_COMPOSING;
+	mtk_dip_wbuf_to_ipi_img_sw_addr(&req->img_fparam.frameparam.self_data,
+					&buf->frameparam);
+	memcpy(buf->frameparam.vaddr, &req->img_fparam.frameparam,
+	       sizeof(req->img_fparam.frameparam));

Is img_fparam really used at this stage? I can only see ipi_param passed to the IPI.

The content of img_fparam is passed to SCP.

The dip frame information is saved in req->img_fparam.frameparam (in mtk_dip_pipe_ipi_params_config()).

The content of req->img_fparam.frameparam is copied to buf->frameparam.vaddr.

Since we set ipi_param.frm_param.pa to the buf->frameparam.scp_daddr in mtk_dip_wbuf_to_ipi_img_sw_addr(), the content of img_fparam is pass to SCP through ipi_param.

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 467

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +7 -0
+
+	ipi_param.usage = IMG_IPI_FRAME;
+	mtk_dip_wbuf_to_ipi_img_sw_addr(&ipi_param.frm_param,
+					&buf->frameparam);
+
+	mutex_lock(&dip_hw->hw_op_lock);
+	atomic_inc(&dip_hw->num_composing);

Do we still need this num_composing counter once we have the semaphore?

No. I will remove it.

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 472

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	ret = scp_ipi_send(dip_hw->scp_pdev, SCP_IPI_DIP, &ipi_param,
+			   sizeof(ipi_param), 0);
+	if (ret)
+		dev_dbg(&dip_dev->pdev->dev, "%s: send SCP_IPI_DIP_FRAME failed %d\n",
+			__func__, ret);

This is an error, isn't it? We need to have proper error handling here, which at this stage would mean completing the request with buffers returned with ERROR state.

Yes, it is an error to be handling. I will return the buffer with ERROR as following:

if (ret) {
	dev_warn(&dip_dev->pdev->dev,
		 "%s: send SCP_IPI_DIP_FRAME failed %d\n",
		 __func__, ret);
	mtk_dip_pipe_job_finish(req->dip_pipe, iparam->index, 
				VB2_BUF_STATE_ERROR);
}
Quoted 57 lines
Quoted 57 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +56 -0
+	mutex_unlock(&dip_hw->hw_op_lock);
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: frame_no(%d),idx(0x%x), composing num(%d)\n",
+		__func__, req->img_fparam.frameparam.frame_no,
+		req->img_fparam.frameparam.index,
+		atomic_read(&dip_hw->num_composing));
+}
+
+static int mtk_dip_hw_res_init(struct mtk_dip_hw *dip_hw)
+{
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+	int ret;
+
+	dip_hw->mdp_pdev = mdp_get_plat_device(dip_dev->pdev);
+	if (!dip_hw->mdp_pdev) {
+		dev_dbg(&dip_dev->pdev->dev,
+			"%s: failed to get MDP device\n",
+			__func__);
+		return -EINVAL;
+	}
+
+	dip_hw->mdpcb_workqueue =
+		alloc_ordered_workqueue("%s",
+					__WQ_LEGACY | WQ_MEM_RECLAIM |
+					WQ_FREEZABLE,
+					"mdp_callback");
+	if (!dip_hw->mdpcb_workqueue) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s: unable to alloc mdpcb workqueue\n", __func__);
+		ret = -ENOMEM;
+		goto destroy_mdpcb_wq;
+	}
+
+	dip_hw->composer_wq =
+		alloc_ordered_workqueue("%s",
+					__WQ_LEGACY | WQ_MEM_RECLAIM |
+					WQ_FREEZABLE,
+					"dip_composer");
+	if (!dip_hw->composer_wq) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s: unable to alloc composer workqueue\n", __func__);
+		ret = -ENOMEM;
+		goto destroy_dip_composer_wq;
+	}
+
+	dip_hw->mdp_wq =
+		alloc_ordered_workqueue("%s",
+					__WQ_LEGACY | WQ_MEM_RECLAIM |
+					WQ_FREEZABLE,
+					"dip_runner");
+	if (!dip_hw->mdp_wq) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s: unable to alloc dip_runner\n", __func__);
+		ret = -ENOMEM;
+		goto destroy_dip_runner_wq;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 532

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+	}
+
+	init_waitqueue_head(&dip_hw->flushing_wq);
+	init_waitqueue_head(&dip_hw->flushing_hw_wq);

nit: To avoid confusing workqueues with waitqueues, I'd suggest using _waitq suffix, which seems to be quite common in the kernel code. (And _workq or _workqueue for workqueues are not common at all.)

I got it. I will rename the flushing_wq and flushing_hw_wq as flushing_waitq and flushing_hw_waitq.

Quoted 14 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 543

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +11 -0
+
+	return 0;
+
+destroy_dip_runner_wq:
+	destroy_workqueue(dip_hw->mdp_wq);
+
+destroy_dip_composer_wq:
+	destroy_workqueue(dip_hw->composer_wq);
+
+destroy_mdpcb_wq:
+	destroy_workqueue(dip_hw->mdpcb_workqueue);

Let's use consistent naming, i.e. mdpcb_wq.

I will use mdpcb_wq instead.

Quoted 26 lines
Quoted 26 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +25 -0
+
+	return ret;
+}
+
+static int mtk_dip_hw_res_release(struct mtk_dip_dev *dip_dev)
+{
+	flush_workqueue(dip_dev->dip_hw.mdp_wq);
+	destroy_workqueue(dip_dev->dip_hw.mdp_wq);
+	dip_dev->dip_hw.mdp_wq = NULL;
+
+	flush_workqueue(dip_dev->dip_hw.mdpcb_workqueue);
+	destroy_workqueue(dip_dev->dip_hw.mdpcb_workqueue);
+	dip_dev->dip_hw.mdpcb_workqueue = NULL;
+
+	flush_workqueue(dip_dev->dip_hw.composer_wq);
+	destroy_workqueue(dip_dev->dip_hw.composer_wq);
+	dip_dev->dip_hw.composer_wq = NULL;
+
+	atomic_set(&dip_dev->dip_hw.num_composing, 0);
+	atomic_set(&dip_dev->dip_hw.num_running, 0);
+	atomic_set(&dip_dev->dip_hw.dip_enque_cnt, 0);
+
+	return 0;
+}
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 573

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+static bool mtk_dip_pipe_running_job_list_empty(struct mtk_dip_pipe *pipe,
+						int *num)
+{
+	spin_lock(&pipe->job_lock);
+	*num = pipe->num_jobs;

We can just check list_empty(&pipe->pipe_job_running_list) here and remove pipe->num_jobs completely.

I will remove pipe->num_jobs completely.

Quoted 12 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 582

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+	spin_unlock(&pipe->job_lock);
+
+	return !(*num);
+}
+
+static int mtk_dip_hw_flush_pipe_jobs(struct mtk_dip_pipe *pipe)
+{
+	int num;
+	int ret = wait_event_freezable_timeout

nit: Could we avoid mixing non-trivial code with declarations?

I got it.

Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 585

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +3 -0
+		(pipe->dip_dev->dip_hw.flushing_wq,
+		 mtk_dip_pipe_running_job_list_empty(pipe, &num),
+		 msecs_to_jiffies(DIP_FLUSHING_WQ_TIMEOUT));

We shouldn't wait here for all the jobs to complete, just those that are already queued to hardware. The stop operation should be as instant as possible.

Quoted 4 lines

This should basically be done like this:
- remove any pending jobs not queued to the hardware yet,
- wait for the hardware to finish anything that can't be cancelled - possibly the same wait as done in mtk_dip_suspend().

The pending job removal codes are in mtk_dip_hw_streamoff(), I will move them here (mtk_dip_hw_flush_pipe_jobs).

Quoted 31 lines
Quoted 31 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +30 -0
+
+	if (!ret && num) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s: flushing is aborted, num(%d)\n",
+			__func__, num);
+		return -EINVAL;
+	}
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s: wakeup num(%d)\n", __func__, num);
+	return 0;
+}
+
+static int mtk_dip_hw_connect(struct mtk_dip_dev *dip_dev)
+{
+	int ret;
+	struct img_ipi_param ipi_param;
+
+	pm_runtime_get_sync(&dip_dev->pdev->dev);
+
+	scp_ipi_register(dip_dev->dip_hw.scp_pdev, SCP_IPI_DIP, dip_scp_handler,
+			 dip_dev);
+	memset(&ipi_param, 0, sizeof(ipi_param));
+	ipi_param.usage = IMG_IPI_INIT;
+	ret = scp_ipi_send(dip_dev->dip_hw.scp_pdev, SCP_IPI_DIP, &ipi_param,
+			   sizeof(ipi_param), 200);
+	if (ret) {
+		dev_dbg(&dip_dev->pdev->dev, "%s: send SCP_IPI_DIP_FRAME failed %d\n",
+			__func__, ret);
+		return -EBUSY;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 620

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	}
+
+	pm_runtime_put_autosuspend(&dip_dev->pdev->dev);
+
+	ret = mtk_dip_hw_res_init(&dip_dev->dip_hw);

There isn't anything in that function that couldn't be just done once in probe. Could we just move it there?

Yes, I will move it to probe.

Quoted 18 lines
Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+	if (ret) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s: mtk_dip_hw_res_init failed(%d)\n", __func__, ret);
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 634

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +10 -0
+		return -EBUSY;
+	}
+
+	return 0;
+}
+
+static void mtk_dip_hw_disconnect(struct mtk_dip_dev *dip_dev)
+{
+	int ret;
+

No need to send IMG_IPI_DEINIT?

Yes, I will send IMG_IPI_DEINIT here.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 639

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	ret = mtk_dip_hw_res_release(dip_dev);
+	if (ret)
+		dev_err(&dip_dev->pdev->dev,
+			"%s: mtk_dip_hw_res_release failed ret(%d)\n",
+			__func__, ret);

No need to call scp_ipi_unregister()?

Yes, I will call scp_ipi_unregister() here.

Quoted 12 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 648

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+}
+
+int mtk_dip_hw_streamon(struct mtk_dip_pipe *pipe)
+{
+	struct mtk_dip_dev *dip_dev = pipe->dip_dev;
+	int count, ret;
+
+	mutex_lock(&dip_dev->dip_hw.hw_op_lock);
+	count = atomic_read(&dip_dev->dip_hw.dip_stream_cnt);

No need to use atomics if this is already protected with a mutex.

I will use int instead.

Quoted 32 lines
Quoted 32 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +32 -0
+	if (!count) {
+		ret = mtk_dip_hw_connect(pipe->dip_dev);
+		if (ret) {
+			dev_err(&pipe->dip_dev->pdev->dev,
+				"%s:%s: pipe(%d) connect to dip_hw failed\n",
+				__func__, pipe->desc->name, pipe->desc->id);
+
+			mutex_unlock(&dip_dev->dip_hw.hw_op_lock);
+
+			return ret;
+		}
+
+		count = atomic_inc_return(&dip_dev->dip_hw.dip_stream_cnt);
+	}
+	mutex_unlock(&dip_dev->dip_hw.hw_op_lock);
+
+	mutex_lock(&pipe->lock);
+	pipe->streaming = 1;
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s: started stream, id(%d), stream cnt(%d)\n",
+		__func__, pipe->desc->name, pipe->desc->id, count);
+	mtk_dip_pipe_try_enqueue(pipe);
+	mutex_unlock(&pipe->lock);
+
+	return 0;
+}
+
+int mtk_dip_hw_streamoff(struct mtk_dip_pipe *pipe)
+{
+	struct mtk_dip_dev *dip_dev = pipe->dip_dev;
+	struct mtk_dip_pipe_job_info *job_info;
+	struct mtk_dip_pipe_job_info *tmp_job_info;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 684

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+	s32 count;
+	int ret;
+
+	mutex_lock(&pipe->lock);

Given that we end up calling this from mtk_dip_vb2_stop_streaming(), after the locking changes I suggested, this function will be called with this lock acquired already.

I will remove the lock acquiring codes here.

Quoted 11 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 689

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s:%s: streamoff, removing all running jobs\n",
+		__func__, pipe->desc->name);
+
+	spin_lock(&pipe->job_lock);

The loop below is quite heavy weight as for something that runs under a spinlock (that by definition should only protect short critical sections). Could we just splice the list into a local list_head under the spinlock and then just iterate over the local list after releasing the spinlock?

I will splice the list into a local list_head here.

Quoted 5 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 691

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +2 -0
+	list_for_each_entry_safe(job_info, tmp_job_info,
+				 &pipe->pipe_job_running_list, list) {

Don't we need to stop the hardware first?

Yes, I will call the mtk_dip_hw_flush_pipe_jobs() and stop hardware with IMG_IPI_DEINIT first.

Quoted 19 lines
Quoted 19 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +18 -0
+		struct mtk_dip_request *req =
+			mtk_dip_pipe_job_info_to_req(job_info);
+		int i;
+
+		for (i = 0; i < MTK_DIP_VIDEO_NODE_ID_TOTAL_NUM; i++) {
+			struct mtk_dip_dev_buffer *dev_buf =
+				job_info->buf_map[i];
+			struct mtk_dip_video_device *node;
+
+			if (!dev_buf)
+				continue;
+
+			node = mtk_dip_vbq_to_node
+				(dev_buf->vbb.vb2_buf.vb2_queue);
+			vb2_buffer_done(&dev_buf->vbb.vb2_buf,
+					VB2_BUF_STATE_ERROR);
+			dev_dbg(&dip_dev->pdev->dev,
+				"%s:%s: return buf, idx(%d), state(%d)\n",
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 713

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+				pipe->desc->name, node->desc->name,
+				dev_buf->vbb.vb2_buf.index,
+				VB2_BUF_STATE_ERROR);
+		}

I can see that there is an existing mtk_dip_return_all_buffers() function that would return all the buffers of given video node when it's being stopped. How does this code interfere with that code?

If all buffer are carried by media requests, I would like to keep the vb2_buffer_done here only.

Quoted 11 lines

Actually, I'm not fully sure anymore what's the expected behavior here. I've asked on #v4l and will let you know once we figure out.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 716

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +3 -0
+
+		pipe->num_jobs--;
+		list_del(&job_info->list);

We don't need to delete and decrement here. Just set to 0 and init list head after the loop. (The latter wouldn't be needed if we splice the list into a local list head.)

I got it.

Quoted 10 lines
Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +9 -0
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: not run job, id(%d), no(%d), state(%d), job cnt(%d)\n",
+			__func__, pipe->desc->name, job_info->id,
+			req->img_fparam.frameparam.frame_no,
+			VB2_BUF_STATE_ERROR, pipe->num_jobs);
+	}
+	spin_unlock(&pipe->job_lock);
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 731

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +6 -0
+	ret = mtk_dip_hw_flush_pipe_jobs(pipe);
+	if (WARN_ON(ret != 0)) {
+		dev_err(&dip_dev->pdev->dev,
+			"%s:%s: mtk_dip_hw_flush_pipe_jobs, ret(%d)\n",
+			__func__, pipe->desc->name, ret);
+	}

I suppose this should be the very first thing to do in this function.

I will do it first in this function.

Quoted 11 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 738

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +7 -0
+
+	pipe->streaming = 0;
+	mutex_unlock(&pipe->lock);
+
+	mutex_lock(&dip_dev->dip_hw.hw_op_lock);
+	count = atomic_read(&dip_dev->dip_hw.dip_stream_cnt);
+	if (count > 0 && atomic_dec_and_test(&dip_dev->dip_hw.dip_stream_cnt)) {

It shouldn't be possible for count to be <= 0 at this point. Are you seeing cases like that when running the code?

No. I will only keep atomic_dec_and_test(&dip_dev->dip_hw.dip_stream_cnt) here.

Quoted 36 lines
Quoted 36 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +35 -0
+		mtk_dip_hw_disconnect(dip_dev);
+
+		dev_dbg(&dip_dev->pdev->dev, "%s: dip_hw disconnected, stream cnt(%d)\n",
+			__func__, atomic_read(&dip_dev->dip_hw.dip_stream_cnt));
+	}
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s: stopped stream id(%d), stream cnt(%d)\n",
+		__func__, pipe->desc->name, pipe->desc->id, count);
+
+	mutex_unlock(&dip_dev->dip_hw.hw_op_lock);
+
+	return 0;
+}
+
+void mtk_dip_hw_enqueue(struct mtk_dip_hw *dip_hw,
+			struct mtk_dip_request *req)
+{
+	struct img_ipi_frameparam *frameparams = &req->img_fparam.frameparam;
+	struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
+	int ret;
+	struct mtk_dip_dev_buffer **map = req->job_info.buf_map;
+
+	/*
+	 * Workaround to pass v4l2 compliance test when it pass only one buffer
+	 * to DIP. The check is already done in request_validate().
+	 */
+	if (!map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT] ||
+	    (!map[MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE] &&
+	     !map[MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE])){
+		dev_dbg(&dip_dev->pdev->dev,
+			"won't trigger hw job: raw(%p), mdp0(%p), mdp1(%p)\n",
+			map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT],
+			map[MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE],
+			map[MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE]);
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 777

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+		mtk_dip_pipe_job_finish(req->dip_pipe, req->job_info.id,
+					VB2_BUF_STATE_DONE);
+		return;
+	}

Please remove the workarounds. There is no value in passing the test if there is a workaround for it. If it keeps failing we at least know that we need to fix something.

I got it.

Quoted 7 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 781

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +4 -0
+
+	mtk_dip_pipe_ipi_params_config(req);
+	frameparams->state = FRAME_STATE_INIT;
+	frameparams->frame_no = atomic_inc_return(&dip_hw->dip_enque_cnt);

typo: enqueue

I will fix it.

Quoted 11 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 788

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +7 -0
+
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s: hw job id(%d), frame_no(%d) into worklist\n",
+		__func__, frameparams->index, frameparams->frame_no);
+
+	INIT_WORK(&req->fw_work, dip_submit_worker);
+	pm_runtime_get_sync(&dip_dev->pdev->dev);

Aren't we still just only composing the job? Should we wait with this call until we actually queue the job to the ISP hardware?

I will move the pm_runtime_get_sync() call to dip_runner_func() before we call mdp_cmdq_sendtask(). The ISP hareware is triggered actually through mdp_cmdq_sendtask().

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 793

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+	ret = queue_work(dip_hw->composer_wq, &req->fw_work);
+	if (!ret)
+		dev_dbg(&dip_dev->pdev->dev,
+			"frame_no(%d) queue_work failed, already on a queue\n",
+			frameparams->frame_no, ret);

How is this possible? (I recall seeing this somewhere already. Was it the P1 driver?)

I will remove the chcek since the work is just init.

Quoted 34 lines
Quoted 34 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +1 -0
+}
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +26 -0
new file mode 100644
index 000000000000..7b454952566f
@@ -0,0 +1,1786 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ *
+ * Author: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>
+ *
+ */
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/platform_data/mtk_scp.h>
+#include <linux/pm_runtime.h>
+#include <linux/remoteproc.h>
+#include <linux/videodev2.h>
+#include <media/videobuf2-dma-contig.h>
+#include <media/v4l2-ioctl.h>
+#include <media/v4l2-subdev.h>
+#include <media/v4l2-event.h>
+#include "mtk_dip-dev.h"
+#include "mtk_dip-hw.h"
+#include "mtk-mdp3-regs.h"
+
+static int mtk_dip_subdev_open(struct v4l2_subdev *sd,
+			       struct v4l2_subdev_fh *fh)
+{
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 32

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+	struct mtk_dip_pipe *pipe = mtk_dip_subdev_to_pipe(sd);
+
+	dev_dbg(&pipe->dip_dev->pdev->dev, "%s:%s: pipe(%d) open\n",
+		__func__, pipe->desc->name, pipe->desc->id);
+
+	pipe->fh = fh;

What is this needed for?

The fh is not used. I will remove it.

Quoted 17 lines
Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+
+	return 0;
+}
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 46

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+static int mtk_dip_subdev_close(struct v4l2_subdev *sd,
+				struct v4l2_subdev_fh *fh)
+{
+	struct mtk_dip_pipe *pipe = mtk_dip_subdev_to_pipe(sd);
+
+	dev_dbg(&pipe->dip_dev->pdev->dev, "%s:%s: pipe(%d) close\n",
+		__func__, pipe->desc->name, pipe->desc->id);
+
+	return 0;
+}

Do we need to implement this?

No. I will remove mtk_dip_subdev_close().

Quoted 17 lines
Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+
+static int mtk_dip_subdev_s_stream(struct v4l2_subdev *sd,
+				   int enable)
+{

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 60

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	struct mtk_dip_pipe *pipe = mtk_dip_subdev_to_pipe(sd);
+	int ret;
+
+	if (enable) {
+		ret = mtk_dip_hw_streamon(pipe);
+		if (ret) {
+			dev_err(&pipe->dip_dev->pdev->dev,
+				"%s:%s: pipe(%d) streamon failed\n",
+				__func__, pipe->desc->name, pipe->desc->id);
+		}

CodingStyle: No brackets needed for only 1 statement.

I got it.

Quoted 7 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 63

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +3 -0
+
+		return ret;
+	}

nit: Since the 2 cases are symmetrical (as opposed to success and failure), I would put them in if/else.

I will use if/else here.

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 70

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +7 -0
+
+	ret = mtk_dip_hw_streamoff(pipe);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: pipe(%d) streamon off with errors\n",
+			__func__, pipe->desc->name, pipe->desc->id);
+	}

CodingStyle: No brackets needed for only 1 statement.

I got it.

Quoted 37 lines
Quoted 19 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +18 -0
+
+	return ret;
+}
+
+static int mtk_dip_link_setup(struct media_entity *entity,
+			      const struct media_pad *local,
+			      const struct media_pad *remote,
+			      u32 flags)
+{
+	struct mtk_dip_pipe *pipe =
+		container_of(entity, struct mtk_dip_pipe, subdev.entity);
+	u32 pad = local->index;
+	int count;
+
+	WARN_ON(entity->obj_type != MEDIA_ENTITY_TYPE_V4L2_SUBDEV);
+	WARN_ON(pad >= pipe->num_nodes);
+
+	mutex_lock(&pipe->lock);

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 98

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	if (!vb2_start_streaming_called(&pipe->nodes[pad].dev_q.vbq)) {
+		int enable = flags & MEDIA_LNK_FL_ENABLED;
+		int node_enabled =
+			pipe->nodes[pad].flags & MEDIA_LNK_FL_ENABLED;
+
+		if (enable && !node_enabled)
+			atomic_inc_return(&pipe->cnt_nodes_not_streaming);
+
+		if (!enable && node_enabled)
+			atomic_dec_return(&pipe->cnt_nodes_not_streaming);

Given that we need to acquire the big pipe mutex anyway, there is probably no need to be too smart here anyway.

I suggested this method with counter
with hope that we could simplify the locking, but apparently that didn't have such effect.

Quoted 6 lines

Let's just make this simple:
1) serialize full link_setup, start_streaming and stop_streaming with pipe->lock,
2) keep two bitmasks, pipe->nodes_streaming and pipe->nodes_enabled,
3) use media_pipeline_start/stop() to lock the enabled state, as suggested in my comment for mtk_dip_vb2_start_streaming(), so that we don't need to think about streaming state here in this function.

I would like to redesign the flow following your suggestion above.

Quoted 5 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 100

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +2 -0
+	}
+	pipe->nodes[pad].flags &= ~(MEDIA_LNK_FL_ENABLED);

No need for the parentheses.

I got it.

Quoted 4 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 101

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +1 -0
+	pipe->nodes[pad].flags |= MEDIA_LNK_FL_ENABLED & flags;

The typical convention is to have the constants on the right.

I will correct it.

Quoted 19 lines
Quoted 19 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +18 -0
+	count = atomic_read(&pipe->cnt_nodes_not_streaming);
+	mutex_unlock(&pipe->lock);
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s: link setup, flags(0x%x), (%s)%d -->(%s)%d, cnt_nodes_ns(%d)\n",
+		pipe->desc->name, flags, local->entity->name, local->index,
+		remote->entity->name, remote->index, count);
+
+	return 0;
+}
+
+static int mtk_dip_vb2_buf_prepare(struct vb2_buffer *vb)
+{
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vb->vb2_queue);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vb->vb2_queue);
+	struct device *dev = &pipe->dip_dev->pdev->dev;
+	const struct v4l2_format *fmt = &node->vdev_fmt;
+	unsigned int size;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 124

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0
+	int i;
+
+	if (vb->vb2_queue->type == V4L2_BUF_TYPE_META_CAPTURE ||
+	    vb->vb2_queue->type == V4L2_BUF_TYPE_META_OUTPUT){
+		if (vb->planes[0].length < fmt->fmt.meta.buffersize) {

For OUTPUT we need to check bytesused and also it must be equal to the metadata size in that case.

I will check bytesused for OUTPUT.

Quoted 12 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 132

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0
+			dev_dbg(dev,
+				"%s:%s:%s: size error(user:%d, required:%d)\n",
+				__func__, pipe->desc->name, node->desc->name,
+				vb->planes[0].length, fmt->fmt.meta.buffersize);
+			return -EINVAL;
+		} else {
+			return 0;
+		}

This comment will not apply anymore if we split to separate vb2 ops for meta queues, but normally one would put tis return 0 outside of the if block.

I will put the return 0 outside the if block.

Quoted 35 lines
Quoted 35 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +34 -0
+	}
+
+	for (i = 0; i < vb->num_planes; i++) {
+		size = fmt->fmt.pix_mp.plane_fmt[i].sizeimage;
+		if (vb->planes[i].length < size) {
+			dev_dbg(dev,
+				"%s:%s:%s: size error(user:%d, max:%d)\n",
+				__func__, pipe->desc->name, node->desc->name,
+				vb->planes[i].length, size);
+			return -EINVAL;
+		}
+	}
+
+	return 0;
+}
+
+static int mtk_dip_vb2_buf_out_validate(struct vb2_buffer *vb)
+{
+	struct vb2_v4l2_buffer *v4l2_buf = to_vb2_v4l2_buffer(vb);
+
+	if (v4l2_buf->field == V4L2_FIELD_ANY)
+		v4l2_buf->field = V4L2_FIELD_NONE;
+
+	if (v4l2_buf->field != V4L2_FIELD_NONE)
+		return -EINVAL;
+
+	return 0;
+}
+
+static int mtk_dip_vb2_queue_buf_init(struct vb2_buffer *vb)
+{
+	struct vb2_v4l2_buffer *b = to_vb2_v4l2_buffer(vb);
+	struct mtk_dip_dev_buffer *dev_buf = mtk_dip_vb2_buf_to_dev_buf(vb);
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vb->vb2_queue);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 171

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vb->vb2_queue);
+	int i;
+
+	for (i = 0; i < vb->num_planes; i++) {
+		if (node->desc->smem_alloc) {

Rather than having two completely different conditional blocks, could we have different vb2 ops for video and meta queues?

Yes, I will separate it into video and meta queues vb ops.

Quoted 16 lines
Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +3 -0
+			void *cpu_addr;
+			phys_addr_t buf_paddr;
+

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 184

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+			dev_buf->scp_daddr[i] =
+				vb2_dma_contig_plane_dma_addr(vb, i);
+			cpu_addr = vb2_plane_vaddr(vb, i);
+			if (!cpu_addr) {
+				dev_err(&pipe->dip_dev->pdev->dev,
+					"%s:%s: vb2_plane_vaddr NULL: s_daddr(%pad)\n",
+					pipe->desc->name, node->desc->name,
+					&dev_buf->scp_daddr[i]);
+				return -EINVAL;
+			}

Why do we need cpu_addr here? It's not used any further.

I will remove the cpu_addr here.

Quoted 17 lines
Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +3 -0
+
+			/*
+			 * We got the incorrect physical address mapped when

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 197

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+			 * using dma_map_single() so I used dma_map_page_attrs()
+			 * directly to workaround here. Please see the detail in
+			 * mtk_dip-sys.c
+			 */
+			buf_paddr = dev_buf->scp_daddr[i];
+			dev_buf->isp_daddr[i] =
+				dma_map_page_attrs(&pipe->dip_dev->pdev->dev,
+						   phys_to_page(buf_paddr),
+						   0, vb->planes[i].length,
+						   DMA_BIDIRECTIONAL,

Is it really bidirectional? I think this would depend on whether it's OUTPUT or CAPTURE.

I will set it to DMA_TO_DEVICE for video OUTPUT nodes, DMA_FROM_DEVICE for video CAPTURE node and DMA_BIDIRECTIONAL for the meta output node.

Quoted 32 lines
Quoted 32 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +31 -0
+						   DMA_ATTR_SKIP_CPU_SYNC);
+			if (dma_mapping_error(&pipe->dip_dev->pdev->dev,
+					      dev_buf->isp_daddr[i])) {
+				dev_err(&pipe->dip_dev->pdev->dev,
+					"%s:%s: failed to map buffer: s_daddr(%pad)\n",
+					pipe->desc->name, node->desc->name,
+					&dev_buf->scp_daddr[i]);
+				return -EINVAL;
+			}
+		} else {
+			dev_buf->scp_daddr[i] = 0;
+			dev_buf->isp_daddr[i] =
+				vb2_dma_contig_plane_dma_addr(vb, i);
+		}
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: buf type(%d), idx(%d), mem(%d), p(%d) i_daddr(%pad), s_daddr(%pad)\n",
+			pipe->desc->name, node->desc->name, b->vb2_buf.type,
+			b->vb2_buf.index, b->vb2_buf.memory, i,
+			&dev_buf->isp_daddr[i], &dev_buf->scp_daddr[i]);
+	}
+
+	return 0;
+}
+
+static void mtk_dip_vb2_queue_buf_cleanup(struct vb2_buffer *vb)
+{
+	struct mtk_dip_dev_buffer *dev_buf = mtk_dip_vb2_buf_to_dev_buf(vb);
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vb->vb2_queue);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vb->vb2_queue);
+	int i;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 234

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+
+	if (!node->desc->smem_alloc)
+		return;
+
+	for (i = 0; i < vb->num_planes; i++) {
+		if (node->desc->smem_alloc)

This was already checked few lines above.

I will remove the check here.

Quoted 18 lines
Quoted 18 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +17 -0
+			dma_unmap_page_attrs(&pipe->dip_dev->pdev->dev,
+					     dev_buf->isp_daddr[i],
+					     vb->planes[i].length,
+					     DMA_BIDIRECTIONAL,
+					     DMA_ATTR_SKIP_CPU_SYNC);
+	}
+}
+
+static void mtk_dip_vb2_buf_queue(struct vb2_buffer *vb)
+{
+	struct vb2_v4l2_buffer *b = to_vb2_v4l2_buffer(vb);
+	struct mtk_dip_dev_buffer *dev_buf = mtk_dip_vb2_buf_to_dev_buf(vb);
+	struct mtk_dip_request *req = (struct mtk_dip_request *)vb->request;
+	struct mtk_dip_video_device *node =
+		mtk_dip_vbq_to_node(vb->vb2_queue);
+	int buf_count;
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 257

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+	dev_buf->fmt = node->vdev_fmt;
+	dev_buf->dev_fmt = node->dev_q.dev_fmt;
+	dev_buf->dma_port = node->desc->dma_port;
+	dev_buf->rotation = node->dev_q.rotation;
+
+	dev_dbg(&req->dip_pipe->dip_dev->pdev->dev,

Sounds like it might be beneficial to have a local variable for dip_dev.

I got it.

Quoted 30 lines
Quoted 30 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +29 -0
+		"%s:%s: buf type(%d), idx(%d), mem(%d), i_daddr(%pad), s_daddr(%pad)\n",
+		req->dip_pipe->desc->name, node->desc->name, b->vb2_buf.type,
+		b->vb2_buf.index, b->vb2_buf.memory, &dev_buf->isp_daddr,
+		&dev_buf->scp_daddr);
+
+	spin_lock(&node->buf_list_lock);
+	list_add_tail(&dev_buf->list, &node->buf_list);
+	spin_unlock(&node->buf_list_lock);
+
+	buf_count = atomic_dec_return(&req->buf_count);
+	if (!buf_count) {
+		mutex_lock(&req->dip_pipe->lock);
+		mtk_dip_pipe_try_enqueue(req->dip_pipe);
+		mutex_unlock(&req->dip_pipe->lock);
+	}
+
+	dev_dbg(&req->dip_pipe->dip_dev->pdev->dev,
+		"%s:%s:%s:%s:buf_count(%d)\n",
+		__func__, req->dip_pipe->desc->name, node->desc->name,
+		req->req.debug_str, buf_count);
+}
+
+static int mtk_dip_vb2_queue_setup(struct vb2_queue *vq,
+				   unsigned int *num_buffers,
+				   unsigned int *num_planes,
+				   unsigned int sizes[],
+				   struct device *alloc_devs[])
+{
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vq);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 292

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vq);
+	const struct v4l2_format *fmt = &node->vdev_fmt;
+	unsigned int size;
+	int i;
+
+	vq->dma_attrs |= DMA_ATTR_NON_CONSISTENT;

Please keep this a downstream patch added on top of the driver patches.

I got it. I will use a separated patch and add it on the top of the driver patches.

Quoted 17 lines
Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +16 -0
+
+	if (!*num_planes) {
+		*num_planes = 1;
+		sizes[0] = fmt->fmt.pix_mp.plane_fmt[0].sizeimage;
+	}
+
+	if (node->desc->id == MTK_DIP_VIDEO_NODE_ID_TUNING_OUT) {
+		int max_meta_bufs_per_pipe;
+
+		size = fmt->fmt.meta.buffersize;
+		max_meta_bufs_per_pipe =
+			MTK_DIP_DEV_META_BUF_POOL_MAX_SIZE /
+			round_up(size, PAGE_SIZE) / MTK_DIP_PIPE_ID_TOTAL_NUM;
+		*num_buffers = clamp_val(*num_buffers, 1,
+					 max_meta_bufs_per_pipe);
+		sizes[0] = size;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 314

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s:%s: n_p(%d), n_b(%d), s[%d](%u)\n",
+			__func__, pipe->desc->name, node->desc->name,
+			*num_planes, *num_buffers, 0, sizes[0]);
+

nit: Stray blank line.

I will remove the line.

Quoted 16 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 324

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	} else {
+		for (i = 0; i < *num_planes; i++) {
+			if (sizes[i] < fmt->fmt.pix_mp.plane_fmt[i].sizeimage) {
+				dev_dbg(&pipe->dip_dev->pdev->dev,
+					"%s:%s:%s: invalid buf: %u < %u\n",
+					__func__, pipe->desc->name,
+					node->desc->name, sizes[0], size);
+					return -EINVAL;
+			}
+			sizes[i] = fmt->fmt.pix_mp.plane_fmt[i].sizeimage;

For VIDIOC_CREATEBUFS we also need to handle the case when *num_planes > 0 and then we need to honor the values already present in sizes[]. (Note that the code above overrides *num_planes to 1, so we lose the information. The code needs to be restructured to handle that.)

We overrides *num_planes when *num_planes is 0. Is the modification I need to do to keep the original value of size[]?

if (!*num_planes) {
	*num_planes = 1;
	sizes[0] = fmt->fmt.pix_mp.plane_fmt[0].sizeimage;
}
Quoted 17 lines
Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +16 -0
+			dev_dbg(&pipe->dip_dev->pdev->dev,
+				"%s:%s:%s: n_p(%d), n_b(%d), s[%d](%u)\n",
+				__func__, pipe->desc->name, node->desc->name,
+				*num_planes, *num_buffers, i, sizes[i]);
+		}
+	}
+
+	return 0;
+}
+
+static void mtk_dip_return_all_buffers(struct mtk_dip_pipe *pipe,
+				       struct mtk_dip_video_device *node,
+				       enum vb2_buffer_state state)
+{
+	struct mtk_dip_dev_buffer *b, *b0;
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 344

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+	spin_lock(&node->buf_list_lock);
+	list_for_each_entry_safe(b, b0, &node->buf_list, list) {
+		list_del(&b->list);
+		if (b->vbb.vb2_buf.state == VB2_BUF_STATE_ACTIVE)

Are you seeing some buffers with state other than ACTIVE here? If so, that's a bug somewhere else in the driver, which needs to be fixed. This check shouldn't be here.

No. I will remove the check here.

Quoted 23 lines
Quoted 23 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +22 -0
+			vb2_buffer_done(&b->vbb.vb2_buf, state);
+	}
+	spin_unlock(&node->buf_list_lock);
+}
+
+static int mtk_dip_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)
+{
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vq);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vq);
+	int cnt_node_ns;
+	int ret;
+
+	if (!(node->flags & MEDIA_LNK_FL_ENABLED)) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: stream on failed, node is not enabled\n",
+			pipe->desc->name, node->desc->name);
+
+		ret = -ENOLINK;
+		goto fail_return_bufs;
+	}
+
+	mutex_lock(&pipe->lock);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 368

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +2 -0
+	cnt_node_ns = atomic_dec_return(&pipe->cnt_nodes_not_streaming);
+	mutex_unlock(&pipe->lock);

This still isn't really synchronized. One could disable the link at this point. I believe that in the previous round of the review I suggested checking the enable state after calling media_pipeline_start(), because it locks the enable status for links that don't have the DYNAMIC flag. That would solve the problem.

I will check the enabling state after calling media_pipeline_start() as following:

mutex_lock(&pipe->lock);

if(!pipe->nodes_streaming) {
	ret = media_pipeline_start(&node->vdev.entity, &pipe->pipeline);
	/* ...... */
}

pipe->nodes_streaming |= node->desc->id;

if (pipe->nodes_streaming == pipe->nodes_enabled) {
	ret = v4l2_subdev_call(&pipe->subdev, video, s_stream, 1);
	/* ...... */
}

mutex_unlock(&pipe->lock);

Quoted 58 lines
Quoted 44 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +43 -0
+
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s:%s cnt_nodes_not_streaming(%d)\n",
+		__func__, pipe->desc->name, node->desc->name, cnt_node_ns);
+
+	if (cnt_node_ns)
+		return 0;
+
+	ret = media_pipeline_start(&node->vdev.entity, &pipe->pipeline);
+	if (ret < 0) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: media_pipeline_start failed(%d)\n",
+			pipe->desc->name, node->desc->name, ret);
+
+		goto fail_return_bufs;
+	}
+
+	/* Start streaming of the whole pipeline */
+	ret = v4l2_subdev_call(&pipe->subdev, video, s_stream, 1);
+	if (ret < 0) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s: sub dev s_stream(1) failed(%d)\n",
+			pipe->desc->name, node->desc->name, ret);
+
+		goto fail_stop_pipeline;
+	}
+
+	return 0;
+
+fail_stop_pipeline:
+	media_pipeline_stop(&node->vdev.entity);
+
+fail_return_bufs:
+	mtk_dip_return_all_buffers(pipe, node, VB2_BUF_STATE_QUEUED);
+
+	return ret;
+}
+
+static void mtk_dip_vb2_stop_streaming(struct vb2_queue *vq)
+{
+	struct mtk_dip_pipe *pipe = vb2_get_drv_priv(vq);
+	struct mtk_dip_video_device *node = mtk_dip_vbq_to_node(vq);
+	int ret;

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 421

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+	int count;
+	int is_pipe_streamon;
+
+	WARN_ON(!(node->flags & MEDIA_LNK_FL_ENABLED));
+
+	mutex_lock(&pipe->lock);
+	count = atomic_inc_return(&pipe->cnt_nodes_not_streaming);
+	is_pipe_streamon = pipe->streaming;
+	mutex_unlock(&pipe->lock);
+

We protect the access to pipe->streaming with the mutex above, but do we have any guarantee that after we release the mutex the value doesn't change?

Quoted 1 line

We should likely do the whole stop operation holding the pipe lock.

I will hold pipe->lock when doing the whole stop operation.

Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 427

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+	dev_dbg(&pipe->dip_dev->pdev->dev,
+		"%s:%s:%s cnt_nodes_not_streaming(%d), is_pipe_streamon(%d)\n",
+		__func__, pipe->desc->name, node->desc->name, count,
+		is_pipe_streamon);
+
+	if (count && is_pipe_streamon) {

For v4l2_subdev_call() shouldn't this be !count && is_pipe_streamon?

Do you mean that pipe->subdev's stop stream should be called after all video device are stream off, not the first video device's stream off?

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 433

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+		ret = v4l2_subdev_call(&pipe->subdev, video, s_stream, 0);
+		if (ret)
+			dev_err(&pipe->dip_dev->pdev->dev,
+				"%s:%s: sub dev s_stream(0) failed(%d)\n",
+				pipe->desc->name, node->desc->name, ret);
+		media_pipeline_stop(&node->vdev.entity);

We should do this one when the last node stops streaming to solve the enable state locking issue as described in my comment to _start_streaming().

I will do this when the last node stops streaming.

Quoted 17 lines
Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +16 -0
+	}
+
+	mtk_dip_return_all_buffers(pipe, node, VB2_BUF_STATE_ERROR);
+}
+
+static int mtk_dip_videoc_querycap(struct file *file, void *fh,
+				   struct v4l2_capability *cap)
+{
+	struct mtk_dip_pipe *pipe = video_drvdata(file);
+
+	strlcpy(cap->driver, pipe->desc->name,
+		sizeof(cap->driver));
+	strlcpy(cap->card, pipe->desc->name,
+		sizeof(cap->card));
+	snprintf(cap->bus_info, sizeof(cap->bus_info),
+		 "platform:%s", dev_name(pipe->dip_dev->mdev.dev));
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 455

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+
+	return 0;
+}
+
+static int mtk_dip_videoc_try_fmt(struct file *file, void *fh,
+				  struct v4l2_format *f)

I don't see this function returning any error codes. Please make it void.

mtk_dip_videoc_try_fmt() is used as vidioc_try_fmt_vid_out_mplane op. Using void seems to make it incompatible with vidioc_try_fmt_vid_out_mplane.

.vidioc_try_fmt_vid_out_mplane = mtk_dip_videoc_try_fmt,

int (*vidioc_try_fmt_vid_out_mplane)(struct file *file, void *fh,

				     struct v4l2_format *f);
Quoted 12 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 463

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0
+{
+	struct mtk_dip_pipe *pipe = video_drvdata(file);
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+	const struct mtk_dip_dev_format *dev_fmt;
+	struct v4l2_format try_fmt;
+
+	memset(&try_fmt, 0, sizeof(try_fmt));
+	try_fmt.type = node->dev_q.vbq.type;

This should come from f.type and should have been already validated by the core.

Quoted 1 line

Actually, why don't we use f directly?

I will use f directly.

Quoted 26 lines
Quoted 26 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +24 -0
+	dev_fmt = mtk_dip_pipe_find_fmt(pipe, node,
+					f->fmt.pix_mp.pixelformat);
+
+	if (!dev_fmt) {
+		dev_fmt = &node->desc->fmts[node->desc->default_fmt_idx];
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s:%s: dev_fmt(%d) not found, use default(%d)\n",
+			__func__, pipe->desc->name, node->desc->name,
+			f->fmt.pix_mp.pixelformat, dev_fmt->format);
+	}
+
+	if (V4L2_TYPE_IS_OUTPUT(node->desc->buf_type)) {
+		try_fmt.fmt.pix_mp.width = clamp_val(f->fmt.pix_mp.width,
+						     MTK_DIP_OUTPUT_MIN_WIDTH,
+						     MTK_DIP_OUTPUT_MAX_WIDTH);
+		try_fmt.fmt.pix_mp.height =
+			clamp_val(f->fmt.pix_mp.height,
+				  MTK_DIP_OUTPUT_MIN_HEIGHT,
+				  MTK_DIP_OUTPUT_MAX_HEIGHT);
+	} else {
+		try_fmt.fmt.pix_mp.width = clamp_val(f->fmt.pix_mp.width,
+						     MTK_DIP_CAPTURE_MIN_WIDTH,
+						     MTK_DIP_CAPTURE_MAX_WIDTH);
+		try_fmt.fmt.pix_mp.height =
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 491

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+			clamp_val(f->fmt.pix_mp.height,
+				  MTK_DIP_CAPTURE_MIN_HEIGHT,
+				  MTK_DIP_CAPTURE_MAX_HEIGHT);
+	}

We have these limits already as a part of the frmsizeenum field of the mtk_dip_video_device_desc struct. Could we just use that and remove the conditional handling?

I will use frmsizeenum field instead the conditional handling.

Quoted 5 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 493

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +2 -0
+
+	node->dev_q.dev_fmt = dev_fmt;

Why are we changing the format on the node inside TRY_FMT?

It is a bug. I will remove it.

Quoted 23 lines
Quoted 23 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +22 -0
+	try_fmt.fmt.pix_mp.field = V4L2_FIELD_NONE;
+	mtk_dip_pipe_set_img_fmt(pipe, node, &try_fmt.fmt.pix_mp, dev_fmt);
+
+	*f = try_fmt;
+
+	return 0;
+}
+
+static int mtk_dip_videoc_g_fmt(struct file *file, void *fh,
+				struct v4l2_format *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+
+	*f = node->vdev_fmt;
+
+	return 0;
+}
+
+static int mtk_dip_videoc_s_fmt(struct file *file, void *fh,
+				struct v4l2_format *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 520

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0
+	struct mtk_dip_pipe *pipe = video_drvdata(file);
+	int ret;
+
+	if (pipe->streaming)
+		return -EBUSY;

We should use vb2_is_busy() here, because it's not allowed to change formats after allocating buffers.

I will use vb2_is_busy here.

Quoted 87 lines
Quoted 87 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +86 -0
+
+	ret = mtk_dip_videoc_try_fmt(file, fh, f);
+	if (!ret)
+		node->vdev_fmt = *f;
+
+	return ret;
+}
+
+static int mtk_dip_videoc_enum_framesizes(struct file *file, void *priv,
+					  struct v4l2_frmsizeenum *sizes)
+{
+	struct mtk_dip_pipe *pipe = video_drvdata(file);
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+	const struct mtk_dip_dev_format *dev_fmt;
+
+	dev_fmt = mtk_dip_pipe_find_fmt(pipe, node, sizes->pixel_format);
+
+	if (!dev_fmt || sizes->index)
+		return -EINVAL;
+
+	sizes->type = node->desc->frmsizeenum->type;
+	sizes->stepwise.max_width =
+		node->desc->frmsizeenum->stepwise.max_width;
+	sizes->stepwise.min_width =
+		node->desc->frmsizeenum->stepwise.min_width;
+	sizes->stepwise.max_height =
+		node->desc->frmsizeenum->stepwise.max_height;
+	sizes->stepwise.min_height =
+		node->desc->frmsizeenum->stepwise.min_height;
+	sizes->stepwise.step_height =
+		node->desc->frmsizeenum->stepwise.step_height;
+	sizes->stepwise.step_width =
+		node->desc->frmsizeenum->stepwise.step_width;
+
+	return 0;
+}
+
+static int mtk_dip_videoc_enum_fmt(struct file *file, void *fh,
+				   struct v4l2_fmtdesc *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+
+	if (f->index >= node->desc->num_fmts)
+		return -EINVAL;
+
+	strscpy(f->description, node->desc->description,
+		sizeof(f->description));
+	f->pixelformat = node->desc->fmts[f->index].format;
+	f->flags = 0;
+
+	return 0;
+}
+
+static int mtk_dip_meta_enum_format(struct file *file, void *fh,
+				    struct v4l2_fmtdesc *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+
+	if (f->index > 0)
+		return -EINVAL;
+
+	strscpy(f->description, node->desc->description,
+		sizeof(f->description));
+
+	f->pixelformat = node->vdev_fmt.fmt.meta.dataformat;
+	f->flags = 0;
+
+	return 0;
+}
+
+static int mtk_dip_videoc_g_meta_fmt(struct file *file, void *fh,
+				     struct v4l2_format *f)
+{
+	struct mtk_dip_video_device *node = mtk_dip_file_to_node(file);
+	*f = node->vdev_fmt;
+
+	return 0;
+}
+
+static int handle_buf_rotate_config(struct v4l2_ctrl *ctrl)
+{
+	struct mtk_dip_video_device *node =
+		container_of(ctrl->handler, struct mtk_dip_video_device,
+			     ctrl_handler);
+
+	if (ctrl->val != 0 && ctrl->val != 90 &&
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 611

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0
+	    ctrl->val != 180 && ctrl->val != 270) {
+		pr_err("%s: Invalid buffer rotation %d", node->desc->name,
+		       ctrl->val);
+		return -EINVAL;
+	}

There is no need to check this here, because the framework already ensures the values are valid.

I will remove the checks.

Quoted 6 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 613

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +2 -0
+
+	node->dev_q.rotation = ctrl->val;

Given the above, this could be just put directly into mtk_dip_video_device_s_ctrl().

I will move the content of handle_buf_rotate_config to mtk_dip_video_device_s_ctrl().

Quoted 14 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 624

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0
+
+	return 0;
+}
+
+static int mtk_dip_video_device_s_ctrl(struct v4l2_ctrl *ctrl)
+{
+	int ret = 0;
+
+	switch (ctrl->id) {
+	case V4L2_CID_ROTATE:
+		ret = handle_buf_rotate_config(ctrl);

nit: We can just return directly from here.

I got it.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 627

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +3 -0
+		break;
+	default:
+		break;

There should be no need to handle default here, as the control framework will not call us with any settable controls we haven't explicitly registered.

I got it.

Quoted 25 lines
Quoted 25 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +24 -0
+	}
+
+	return ret;
+}
+
+/******************** function pointers ********************/
+
+static const struct v4l2_subdev_internal_ops mtk_dip_subdev_internal_ops = {
+	.open = mtk_dip_subdev_open,
+	.close = mtk_dip_subdev_close,
+};
+
+static const struct v4l2_subdev_video_ops mtk_dip_subdev_video_ops = {
+	.s_stream = mtk_dip_subdev_s_stream,
+};
+
+static const struct v4l2_subdev_ops mtk_dip_subdev_ops = {
+	.video = &mtk_dip_subdev_video_ops,
+};
+
+static const struct media_entity_operations mtk_dip_media_ops = {
+	.link_setup = mtk_dip_link_setup,
+	.link_validate = v4l2_subdev_link_validate,
+};
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 655

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+
+static struct media_request *mtk_dip_request_alloc(struct media_device *mdev)
+{
+	return kzalloc(sizeof(struct mtk_dip_request), GFP_KERNEL);

That's potentially error-prone. I'd add a properly typed local variable, let's say mtk_req, allocate with sizeof(*mtk_req) and then return &mtk_dev->req.

I got it. I will change the codes as following:

struct mtk_dip_request mtk_req;

mtk_req = kzalloc(sizeof(*mtk_req), GFP_KERNEL);
return &mtk_req->req;

Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 659

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+}
+
+static void mtk_dip_request_free(struct media_request *req)
+{

A similar comment her. Please retrieve mtk_dip_request pointer properly using a helper (with container_of() inside) to a local variable and then free it.

I got it.

Quoted 12 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 667

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0
+	kfree(req);
+}
+
+static int mtk_dip_vb2_request_validate(struct media_request *req)
+{
+	struct media_request_object *obj;
+	struct mtk_dip_dev *dip_dev = mtk_dip_mdev_to_dev(req->mdev);
+	struct mtk_dip_request *dip_req = (struct mtk_dip_request *)req;

Please avoid such direct casts and use properly typed helpers instead, using container_of() if needed.

I got it.

Quoted 19 lines
Quoted 19 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +18 -0
+	struct mtk_dip_pipe *pipe = NULL;
+	struct mtk_dip_pipe *pipe_prev = NULL;
+	struct mtk_dip_dev_buffer **map = dip_req->job_info.buf_map;
+	int buf_count = 0;
+
+	memset(map, 0, sizeof(dip_req->job_info.buf_map));
+
+	list_for_each_entry(obj, &req->objects, list) {
+		struct vb2_buffer *vb;
+		struct mtk_dip_dev_buffer *dev_buf;
+		struct mtk_dip_video_device *node;
+
+		if (!vb2_request_object_is_buffer(obj))
+			continue;
+
+		vb = container_of(obj, struct vb2_buffer, req_obj);
+		node = mtk_dip_vbq_to_node(vb->vb2_queue);
+		pipe = vb2_get_drv_priv(vb->vb2_queue);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 690

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0
+		if (pipe_prev && pipe != pipe_prev) {
+			dev_warn(&dip_dev->pdev->dev,
+				 "%s:%s:%s:found buf of different pipes(%p,%p)\n",
+				__func__, node->desc->name,
+				req->debug_str, pipe, pipe_prev);

Userspace misbehavior should not trigger kernel warnings. Please make this dev_dbg().

I got it.

Quoted 15 lines
Quoted 15 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +14 -0
+			return -EINVAL;
+		}
+
+		pipe_prev = pipe;
+		dev_buf = mtk_dip_vb2_buf_to_dev_buf(vb);
+		dip_req->job_info.buf_map[node->desc->id] = dev_buf;
+		buf_count++;
+
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: added buf(%p) to pipe-job(%p), buf_count(%d)\n",
+			pipe->desc->name, node->desc->name, dev_buf,
+			dip_req->job_info, buf_count);
+	}
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 710

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+	if (!pipe) {
+		dev_warn(&dip_dev->pdev->dev,
+			 "%s: no buffer in the request(%p)\n",
+			 req->debug_str, req);
+
+		return vb2_request_validate(req);

Shouldn't this be an error?

Yes. I will return -EINVAL here.

Quoted 23 lines
Quoted 23 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +22 -0
+	}
+
+	/*
+	 * Workaround to pass V4L2 comliance test since it can't know
+	 * which buffer is required and may enqueue only 1 buffer.
+	 * It seems that we should return an error here and let the
+	 * user to enqueue required buffer instead of showing a debug
+	 * message only.
+	 */
+	if (!map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT] ||
+	    (!map[MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE] &&
+	     !map[MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE]))
+		dev_dbg(&dip_dev->pdev->dev,
+			"won't trigger hw job: raw(%p), mdp0(%p), mdp1(%p)\n",
+			map[MTK_DIP_VIDEO_NODE_ID_RAW_OUT],
+			map[MTK_DIP_VIDEO_NODE_ID_MDP0_CAPTURE],
+			map[MTK_DIP_VIDEO_NODE_ID_MDP1_CAPTURE]);
+
+	atomic_set(&dip_req->buf_count, buf_count);
+	dip_req->job_info.id = mtk_dip_pipe_next_job_id(pipe);
+	dip_req->dip_pipe = pipe;
+	mtk_dip_pipe_debug_job(pipe, &dip_req->job_info);
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 736

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+
+	spin_lock(&pipe->job_lock);
+	list_add_tail(&dip_req->job_info.list, &pipe->pipe_job_pending_list);
+	pipe->num_pending_jobs++;

.req_validate() must not change any driver state (e.g. internal queues). It should only validate the request itself. The proper place do to this is .req_queue().

I will move the pending job adding codes to .req_queue().

Quoted 46 lines
Quoted 46 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +45 -0
+	dev_dbg(&dip_dev->pdev->dev,
+		"%s:%s: current num of pending jobs(%d)\n",
+		__func__, pipe->desc->name, pipe->num_pending_jobs);
+	spin_unlock(&pipe->job_lock);
+
+	return vb2_request_validate(req);
+}
+
+static const struct media_device_ops mtk_dip_media_req_ops = {
+	.req_validate = mtk_dip_vb2_request_validate,
+	.req_queue = vb2_request_queue,
+	.req_alloc = mtk_dip_request_alloc,
+	.req_free = mtk_dip_request_free,
+};
+
+static const struct v4l2_ctrl_ops mtk_dip_video_device_ctrl_ops = {
+	.s_ctrl = mtk_dip_video_device_s_ctrl,
+};
+
+static const struct vb2_ops mtk_dip_vb2_ops = {
+	.buf_queue = mtk_dip_vb2_buf_queue,
+	.queue_setup = mtk_dip_vb2_queue_setup,
+	.buf_init = mtk_dip_vb2_queue_buf_init,
+	.buf_prepare  = mtk_dip_vb2_buf_prepare,
+	.buf_out_validate = mtk_dip_vb2_buf_out_validate,
+	.buf_cleanup = mtk_dip_vb2_queue_buf_cleanup,
+	.start_streaming = mtk_dip_vb2_start_streaming,
+	.stop_streaming = mtk_dip_vb2_stop_streaming,
+	.wait_prepare = vb2_ops_wait_prepare,
+	.wait_finish = vb2_ops_wait_finish,
+};
+
+static const struct v4l2_file_operations mtk_dip_v4l2_fops = {
+	.unlocked_ioctl = video_ioctl2,
+	.open = v4l2_fh_open,
+	.release = vb2_fop_release,
+	.poll = vb2_fop_poll,
+	.mmap = vb2_fop_mmap,
+#ifdef CONFIG_COMPAT
+	.compat_ioctl32 = v4l2_compat_ioctl32,
+#endif
+};
+
+int mtk_dip_dev_media_register(struct device *dev,
+			       struct media_device *media_dev,
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 787

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+			       const char *model)
+{
+	int ret;
+
+	media_dev->dev = dev;
+	strlcpy(media_dev->model, model, sizeof(media_dev->model));

Could we just use dev_driver_string() instead?

I will use dev_driver_string() instead.

Quoted 15 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 798

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0
+	snprintf(media_dev->bus_info, sizeof(media_dev->bus_info),
+		 "platform:%s", dev_name(dev));
+	media_dev->hw_revision = 0;
+	media_dev->ops = &mtk_dip_media_req_ops;
+	media_device_init(media_dev);
+
+	ret = media_device_register(media_dev);
+	if (ret) {
+		dev_err(dev, "failed to register media device (%d)\n", ret);
+		media_device_unregister(media_dev);
+		media_device_cleanup(media_dev);

Please return from here to make it clear which code is for failure and which for success.

I got it.

Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 804

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+	}
+
+	dev_dbg(dev, "Registered media device: %s, %p", media_dev->model,
+		media_dev);
+
+	return ret;

And return 0 here.

I got it.

Quoted 18 lines
Quoted 18 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +17 -0
+}
+
+int mtk_dip_dev_v4l2_register(struct device *dev,
+			      struct media_device *media_dev,
+			      struct v4l2_device *v4l2_dev)
+{
+	int ret;
+
+	v4l2_dev->mdev = media_dev;
+	v4l2_dev->ctrl_handler = NULL;
+
+	ret = v4l2_device_register(dev, v4l2_dev);
+	if (ret) {
+		dev_err(dev, "failed to register V4L2 device (%d)\n", ret);
+		v4l2_device_unregister(v4l2_dev);
+	}
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 825

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+	dev_dbg(dev, "Registered v4l2 device: %p", v4l2_dev);
+
+	return ret;
+}

There is only 1 function call inside of this function, so there is not much point in having a separate function for this. Please just move back to the caller.

I got it.

Quoted 14 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 835

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+
+static int mtk_dip_video_device_v4l2_register(struct mtk_dip_pipe *pipe,
+					      struct mtk_dip_video_device *node)
+{
+	struct vb2_queue *vbq = &node->dev_q.vbq;
+	struct video_device *vdev = &node->vdev;
+	struct media_link *link;
+	int ret;
+
+	/* Initialize miscellaneous variables */

I'd remove comments like this, because this is obvious from reading the code alone.

I will remove the line.

Quoted 24 lines
Quoted 24 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +23 -0
+	mutex_init(&node->dev_q.lock);
+
+	/* Initialize formats to default values */
+	vdev->device_caps = node->desc->cap;
+	vdev->ioctl_ops = node->desc->ops;
+	node->vdev_fmt.type = node->desc->buf_type;
+	mtk_dip_pipe_load_default_fmt(pipe, node, &node->vdev_fmt);
+
+	/* Initialize media entities */
+	ret = media_entity_pads_init(&vdev->entity, 1, &node->vdev_pad);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"failed initialize media entity (%d)\n", ret);
+		goto err_mutex_destroy;
+	}
+
+	node->vdev_pad.flags = V4L2_TYPE_IS_OUTPUT(node->desc->buf_type) ?
+		MEDIA_PAD_FL_SOURCE : MEDIA_PAD_FL_SINK;
+
+	/* Initialize vbq */
+	vbq->type = node->vdev_fmt.type;
+	vbq->io_modes = VB2_MMAP | VB2_DMABUF;
+	vbq->ops = &mtk_dip_vb2_ops;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 862

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+	vbq->mem_ops = &vb2_dma_contig_memops;
+	vbq->supports_requests = true;
+	vbq->buf_struct_size = sizeof(struct mtk_dip_dev_buffer);
+	vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;

This is a memory to memory device so this should be TIMESTAMP_COPY and the driver should copy the time stamp from the input frame buffer to the output buffers.

I got it. I will use V4L2_BUF_FLAG_TIMESTAMP_COPY here.

Quoted 107 lines
Quoted 107 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +106 -0
+	vbq->min_buffers_needed = 0;
+	vbq->drv_priv = pipe;
+	vbq->lock = &node->dev_q.lock;
+
+	ret = vb2_queue_init(vbq);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"%s:%s:%s: failed to init vb2 queue(%d)\n",
+			__func__, pipe->desc->name, node->desc->name,
+			ret);
+		goto err_media_entity_cleanup;
+	}
+
+	/* Initialize vdev */
+	snprintf(vdev->name, sizeof(vdev->name), "%s %s", pipe->desc->name,
+		 node->desc->name);
+	vdev->entity.name = vdev->name;
+	vdev->entity.function = MEDIA_ENT_F_IO_V4L;
+	vdev->entity.ops = NULL;
+	vdev->release = video_device_release_empty;
+	vdev->fops = &mtk_dip_v4l2_fops;
+	vdev->lock = &node->dev_q.lock;
+	vdev->ctrl_handler = &node->ctrl_handler;
+	vdev->v4l2_dev = &pipe->dip_dev->v4l2_dev;
+	vdev->queue = &node->dev_q.vbq;
+	vdev->vfl_dir = V4L2_TYPE_IS_OUTPUT(node->desc->buf_type) ?
+		VFL_DIR_TX : VFL_DIR_RX;
+
+	if (node->desc->smem_alloc) {
+		vdev->queue->dev = &pipe->dip_dev->dip_hw.scp_pdev->dev;
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: select smem_vb2_alloc_ctx(%p)\n",
+			pipe->desc->name, node->desc->name,
+			vdev->queue->dev);
+	} else {
+		vdev->queue->dev = &pipe->dip_dev->pdev->dev;
+		dev_dbg(&pipe->dip_dev->pdev->dev,
+			"%s:%s: select default_vb2_alloc_ctx(%p)\n",
+			pipe->desc->name, node->desc->name,
+			&pipe->dip_dev->pdev->dev);
+	}
+
+	video_set_drvdata(vdev, pipe);
+
+	ret = video_register_device(vdev, VFL_TYPE_GRABBER, -1);
+	if (ret) {
+		dev_err(&pipe->dip_dev->pdev->dev,
+			"failed to register video device (%d)\n", ret);
+		goto err_vb2_queue_release;
+	}
+	dev_dbg(&pipe->dip_dev->pdev->dev, "registered vdev: %s\n",
[… more lines in the raw message]

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Do we need to init the handler for nodes that don't expose any controls?

No. I will init MDP 0 only (which support rotation ctrl).

Quoted 14 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Why defer here? Isn't this just a critical error?

I will return -EINVAL instead.

Quoted 6 lines

Also, the proper way to check for control registration error is to check the control handler error rather than the control pointer.

An example registration code:
https://elixir.bootlin.com/linux/v5.3-rc2/source/drivers/media/platform/qcom/venus/vdec_ctrls.c#L79

I will use ctrl_handler.error instead.

Quoted 60 lines
Quoted 60 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +59 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Isn't this the other way around?

I checked the document of MEDIA_PAD_FL_SINK and MEDIA_PAD_FL_SOURCE. It seems that the codes match the description.

RAW Ouput video device: MEDIA_PAD_FL_SOURCE --> DIP sub dev:
MEDIA_PAD_FL_SINK
DIP sub dev: MEDIA_PAD_FL_SOURCE --> MDP Capture video device:
MEDIA_PAD_FL_SINK

MEDIA_PAD_FL_SINK: Input pad, relative to the entity. Input pads sink data and are targets of links.
MEDIA_PAD_FL_SOURCE: Output pad, relative to the entity. Output pads source data and are origins of links.

Quoted 18 lines
Quoted 18 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +18 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

This should be only called once for the v4l2_dev, but the code here would end up calling this once per each pipe.

I got it. I would move to the v4l2_device_register_subdev_nodes() call to mtk_dip_dev_v4l2_init.

Quoted 37 lines
Quoted 37 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +36 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Wouldn't this end up unregistering the same v4l2_dev more than 1 time? Please make sure that the driver works when compiled as a module and then unloaded and reloaded again.

I will remove the duplicated v4l2_device_unregister(), media_device_unregister() and media_device_cleanup() here.

Quoted 12 lines
Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

No need for cap ioctls on an out node.

I will remove the caps ioctls here.

Quoted 28 lines
Quoted 28 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +27 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

No need for out ioctls on a cap node.

I will remove out caps ioctls here.

Quoted 62 lines
Quoted 62 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +61 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Is the color space tied to particular pixel format on hardware level?

No. We can remove the colorspace setting here since it doesn't tied to particular pixel format.

Quoted 46 lines
Quoted 46 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +45 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

What is depth and what is row_depth? They both seem to not match NV12, which should have 16 bits per sample in the CbCr plane.

Fow_depth is the bits of the pixel.
Depth means the bytes per pixel of the image foramt.

For example,
Image: 640 * 480
YV12: row_depth = 8, depth = 12
Bytes per line = width * row_depth / 8 = 640 * 8/ 8 = 640 Image size = Bytes per line * height * (depth/ row_depth)

	   = 640 * 480 * 1.5

Image: 640 * 480
Bytes per line(Y) = width * row_depth/ 8 = 640
Bytes per line(CbCr) = width * row_depth/ 8 = 640

Image size(Y) = Bytes per line * height * (depth/ row_depth)

	   = 640 * 480 * 8/8 = 640 * 480 * 1

Image size(CbCr) = Bytes per line * height * (depth/ row_depth)

	   = 640 * 480 * 4/8 = 640 * 480 * 0.5
Quoted 45 lines
Quoted 45 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +44 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Is this correct? The other entries above use MDP_YCBCR_PROFILE_ macros, while this and further entries use V4L2_COLORSPACE_.

I will remove colorspace here since it is not coupling with pixel format in DIP.

Quoted 11 lines
Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Why does NV12M have a different colorspace than NV12?

I will remove colorspace here since it is not coupling with pixel format in DIP.

Quoted 49 lines
Quoted 49 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +48 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Please still use ARRAY_SIZE() even if the array has just 1 entry.

I got it.

Quoted 49 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 45 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +44 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

The entries here seem to be almost the same to output_queues_setting[], the only difference seems to be default_fmt_idx and description.

Quoted 1 line

What's the difference between the capture and reprocess pipes?

The reprocess pipe is completely the same as capture one except the default format of the input.

Quoted 41 lines
Quoted 41 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +40 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

This string macro is only used here. Please just explicitly put the string here. Also, as per my other comment, this should probably be just a suffix that's added to dev_driver_string().

I will use "preview", "capture" and "reprocess" for the .name setting.

Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Why do we need this split into output and capture descriptors? They have the same type.

I will merge output and capture descs.

Quoted 31 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +3 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Ditto.

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +9 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Ditto.

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +12 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Do we need to store pdev in dip_dev? Wouldn't storing just dev there simplify things?

I would like to store dev instead.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 3 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +2 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Do we need to pass a constant to this function? Could we just use it directly from there?

Also, why not just pass dip_dev instead of the 2 first arguments?

I will pass dip_dev and use MTK_DIP_DEV_DIP_MEDIA_MODEL_NAME directly.

Quoted 26 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 21 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +20 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

nit: The usual convention is to pass the arguments from the "broadest" datastructures, e.g. the main driver structure - dip_dev, to the most specific ones, so dip_dev should be made the first argument.

Quoted 2 lines

There isn't much point in passing media_dev and v4l2_dev here, because we already have them in dip_dev.

I will correct the order and passing dip_dev and dip_pipe only.

Quoted 16 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 14 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +13 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

nit: The initial decrement could be just written as i--.

I got it.

Quoted 11 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +7 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Could we move this two into a function called mtk_dip_dev_media_unregister() to be consistent with the initialization?

Yes. I will add mtk_dip_dev_media_unregister().

Quoted 39 lines
Quoted 39 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +38 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

We shouldn't need this custom larb handling anymore.

I got it. I will remove larb_pdev.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Could we use ARRAY_SIZE(clks) instead?

I will use ARRAY_SIZE(clks).

Quoted 44 lines
Quoted 44 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +43 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Don't we need to clean up the buffer pool initialization if we fail here?

Yes, I will clean up the buffer pool initialization here.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 2 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +1 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

It's also necessary to initialize autosuspend here by calling pm_runtime_use_autosuspend() and pm_runtime_set_autosuspend_delay().

The delay should be something around 2-3 times the time it takes to suspend and resume the device.

I will add pm_runtime_set_autosuspend_delay() and
pm_runtime_use_autosuspend() here.

Quoted 15 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

There might be already something running at this point and we would free the buffers here. Generally the order of remove should be the opposite to the probe.

I will correct the order as the opposite to the probe:

pm_runtime_disable(&pdev->dev); mtk_dip_dev_v4l2_release(dip_dev); mtk_dip_hw_working_buf_pool_release(&dip_dev->dip_hw); mutex_destroy(&dip_dev->dip_hw.hw_op_lock);

Quoted 11 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Perhaps mtk_dip_runtime_suspend()?

I will rename it as mtk_dip_runtime_suspend().

Quoted 13 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

mtk_dip_runtime_resume()?

I will rename it as mtk_dip_runtime_resume().

Quoted 10 lines
Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +9 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

nit: Please return ret from here and keep the path below only for success.

I got it.

Quoted 20 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 15 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +14 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

It's not allowed to use sleeping operations in a wait_event condition, because the condition could be evaluated while the current process already enters the UNINTERRUPTIBLE state.

Quoted 3 lines

Given that this is already an atomic_t, there shouldn't be any special synchronization needed here. Please just use atomic_read() in the wait_event_timeout() call directly.

I got it.

Quoted 15 lines
Quoted 15 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +14 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Is 200 milliseconds a reasonable timeout here, i.e. for any potential use case it would always take less than 200 ms to wait for all the tasks running in the ISP?

I would like to adjust the time out value to 1000 / 30 * (DIP_COMPOSING_MAX_NUM) * 3.

To wait 3 times of expected frame time (@30fps) in worst case (max number of jobs in SCP).

Quoted 12 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +8 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

We should call pm_runtime_force_suspend() instead, so that it also handles any device dependencies or power domains.

I got it.

Quoted 14 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +11 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

pm_runtime_force_resume()

I got it.

Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +5 -0

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

I think you meant mtk_dip_pm_suspend/resume for the runtime PM ops?

I will use mtk_dip_runtime_suspend/mtk_dip_runtime_resume for PM ops.

Quoted 4 lines

Best regards,
Tomasz

Part of the diff is not shown here. View the raw message.

#11 lore raw

Re: [RFC PATCH V2 4/6] platform: mtk-isp: Add Mediatek DIP driver

Hi Frederic,

Quoted 6 lines · Frederic Chen

Dear Tomasz,

I appreciate your comment. I will collaborate more closely with Jungo to solve the common issues in DIP and Pass 1(CAM) drivers.

Thank you!

Also thanks for replying to all the comments, it's very helpful. Please check my replies inline. I've snipped out the parts that I don't have further comments on.

Quoted 5 lines · Tomasz Figa
Quoted 3 lines

Hi Frederic,

On Mon, Jul 08, 2019 at 07:04:58PM +0800, frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected] wrote:

[snip]

Quoted 21 lines
Quoted 12 lines
Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +11 -0
+                   dev_buf->vbb.vb2_buf.timestamp =
+                           in_buf->vbb.vb2_buf.timestamp;
+
+           vb2_buffer_done(&dev_buf->vbb.vb2_buf, vbf_state);
+
+           node = mtk_dip_vbq_to_node(dev_buf->vbb.vb2_buf.vb2_queue);
+           spin_lock(&node->buf_list_lock);
+           list_del(&dev_buf->list);
+           spin_unlock(&node->buf_list_lock);
+
+           dev_dbg(&pipe->dip_dev->pdev->dev,
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 175

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +4 -0
+                   "%s:%s: return buf, idx(%d), state(%d)\n",
+                   pipe->desc->name, node->desc->name,
+                   dev_buf->vbb.vb2_buf.index, vbf_state);
+   }

This looks almost the same as what's being done inside mtk_dip_hw_streamoff(). Could we just call this function from the loop there?

Quoted 4 lines

I would like to call the function from mtk_dip_hw_streamoff(). The only difference is mtk_dip_pipe_job_finish() also remove the buffer from the node's internal list.

Would anything wrong happen if we also remove the buffer from the node's internal list in mtk_dip_hw_streamoff()?

Actually, do we need that internal node list? If we have a list of requests and each request stores its buffer, wouldn't that be enough?

[snip]

Quoted 18 lines
Quoted 12 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 235

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+
+   width = ALIGN(width, 4);
+   stride = DIV_ROUND_UP(width * 3, 2);
+   stride = DIV_ROUND_UP(stride * pixel_byte, 8);
+
+   if (pix_fmt == V4L2_PIX_FMT_MTISP_F10)
+           stride =  ALIGN(stride, 4);
+   else
+           stride =  ALIGN(stride, 8);

Could you explain all the calculations done above?

If the buffer comes from mtk-cam-p1, the stride setting must be the same as p1. I would like to re-implement the codes following p1's design in v4 patch as following:

static u32

Quoted 10 lines
mtk_dip_pass1_cal_pack_stride(u32 width, u32 pix_fmt) {
        unsigned int bpl;
        unsigned int pixel_bits =
                get_pixel_byte_by_fmt(mp->pixelformat);

        /* Bayer encoding format, P1 HW needs 2 bytes alignment */
        bpl = ALIGN(DIV_ROUND_UP(width * pixel_bits, 8), 2);

        /* The setting also needs 4 bytes alignment for DIP HW */
        return ALIGN(bpl, 4);;

If we need 4 bytes alignment, wouldn't the bytes per line value end up different from P1 anyway? Perhaps we can just remove the ALIGN(..., 2) above and keep this one? It should be the userspace responsibility anyway to choose a format compatible with both consumer and producer.

By the way, double semicolon in the line above. :)

Quoted 18 lines

}

static __u32 mtk_dip_pass1_cal_main_stride(u32 width, u32 pix_fmt)

{
        unsigned int bpl, ppl;
        unsigned int pixel_bits =
                get_pixel_byte_by_fmt(mp->pixelformat);

        /*
         * The FULL-G encoding format
         * 1 G component per pixel
         * 1 R component per 4 pixel
         * 1 B component per 4 pixel
         * Total 4G/1R/1B in 4 pixel (pixel per line:ppl)
         */
        ppl = DIV_ROUND_UP(width * 6, 4);
Quoted 8 lines
        bpl = DIV_ROUND_UP(ppl * pixel_bits, 8);

        /* 4 bytes alignment for 10 bit & others are 8 bytes */
        if (pixel_bits == 10)
                bpl = ALIGN(bpl, 4);
        else
                bpl = ALIGN(bpl, 8);
        }

Spurious }.

Quoted 4 lines
        return bpl;
}

Looks good to me, thanks!

Quoted 81 lines
Quoted 69 lines
Quoted 69 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +67 -0
+
+   return stride;
+}
+
+static int is_stride_need_to_align(u32 format, u32 *need_aligned_fmts,
+                              int length)
+{
+   int i;
+
+   for (i = 0; i < length; i++) {
+           if (format == need_aligned_fmts[i])
+                   return true;
+   }
+
+   return false;
+}
+
+/* Stride that is accepted by MDP HW */
+static u32 dip_mdp_fmt_get_stride(struct v4l2_pix_format_mplane *mfmt,
+                             const struct mtk_dip_dev_format *fmt,
+                             unsigned int plane)
+{
+   enum mdp_color c = fmt->mdp_color;
+   u32 bytesperline = (mfmt->width * fmt->row_depth[plane]) / 8;
+   u32 stride = (bytesperline * MDP_COLOR_BITS_PER_PIXEL(c))
+           / fmt->row_depth[0];
+
+   if (plane == 0)
+           return stride;
+
+   if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+           if (MDP_COLOR_IS_BLOCK_MODE(c))
+                   stride = stride / 2;
+           return stride;
+   }
+
+   return 0;
+}
+
+/* Stride that is accepted by MDP HW of format with contiguous planes */
+static u32
+dip_mdp_fmt_get_stride_contig(const struct mtk_dip_dev_format *fmt,
+                         u32 pix_stride,
+                         unsigned int plane)
+{
+   enum mdp_color c = fmt->mdp_color;
+   u32 stride = pix_stride;
+
+   if (plane == 0)
+           return stride;
+
+   if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+           stride = stride >> MDP_COLOR_GET_H_SUBSAMPLE(c);
+           if (MDP_COLOR_IS_UV_COPLANE(c) && !MDP_COLOR_IS_BLOCK_MODE(c))
+                   stride = stride * 2;
+           return stride;
+   }
+
+   return 0;
+}
+
+/* Plane size that is accepted by MDP HW */
+static u32
+dip_mdp_fmt_get_plane_size(const struct mtk_dip_dev_format *fmt,
+                      u32 stride, u32 height,
+                      unsigned int plane)
+{
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 307

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+   enum mdp_color c = fmt->mdp_color;
+   u32 bytesperline;
+
+   bytesperline = (stride * fmt->row_depth[0])
+           / MDP_COLOR_BITS_PER_PIXEL(c);

Hmm, stride and bytesperline should be exactly the same thing. Could you explain what's happening here?

The stride here is specific for MDP hardware (which uses the same MDP stride setting for NV12 and NV12M):

Quoted 8 lines

bytesperline = width * row_depth / 8
MDP stride = width * MDP_COLOR_BITS_PER_PIXEL /8

Therfore,

bytesperline = MDP stride * row_depth / MDP_COLOR_BITS_PER_PIXEL
MDP stride = bytesperline * MDP_COLOR_BITS_PER_PIXEL/ row_depth

I'm sorry I'm still confused. Is there an intermediate buffer between DIP and MDP that has stride of |MDP stride| and then MDP writes to the final buffer that has the stride of |bytesperline|?

[snip]

Quoted 11 lines
Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 390

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +7 -0
+           u32 sizeimage;
+
+           if (bpl < min_bpl)
+                   bpl = min_bpl;
+
+           sizeimage = (bpl * mfmt_to_fill->height * dev_fmt->depth[i])
+                   / dev_fmt->row_depth[i];

Shouldn't this be bpl * fmt->height?

Quoted 6 lines

Row_depth is the bits of the pixel.
Depth means the bytes per pixel of the image format.

For example,
Image: 640 * 480
YV12: row_depth = 8, depth = 12

YV12 has 3 planes of 8 bits per pixel. Not sure where does this 12 come from.

Quoted 4 lines

Bytes per line = width * row_depth / 8 = 640 * 8/ 8 = 640 Image size = Bytes per line * height * (depth/ row_depth)

           = 640 * 480 * 1.5

I think we might be having some terminology issue here. "row" is normally the same as "line", which consists of |width| pixels + padding, which is |bytesperline| bytes in total.

Perhaps you want to store a bits_per_pixel[] and vertical and horizontal subsampling arrays for all planes of the formats in the format descriptor.

By the way, have you considered using the V4L2 format helpers [1]?

[1] https://elixir.bootlin.com/linux/v5.3-rc6/source/drivers/media/v4l2-core/v4l2-common.c#L561

Quoted 16 lines
Quoted 16 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 566

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+           dev_dbg(&pipe->dip_dev->pdev->dev,
+                   "Non-contiguous-mp-buf(%s),total-plane-size(%d),dma_port(%d)\n",
+                   buf_name,
+                   total_plane_size,
+                   b->usage);
+           return 0;
+   }
+
+   for (; i < MDP_COLOR_GET_PLANE_COUNT(b->format.colorformat); ++i) {

I don't see these MDP_ macros defined anywhere. Please don't use macros defined from other drivers. We can embed this information in the mtk_dip_dev_format struct. One would normally call it num_cplanes (color planes).

Quoted 6 lines
Quoted 2 lines

However, I would just make this driver support M formats only and forget about formats with only memory planes count != color planes count.

Since the non-M formats are still used by 8183's user lib now, may I add num_cplanes and support the both formats?

Okay, let's keep them for now.

[snip]

Quoted 17 lines
Quoted 15 lines
Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +4 -0
+
+   /* Tuning buffer */
+   dev_buf_tuning =
+           pipe_job_info->buf_map[MTK_DIP_VIDEO_NODE_ID_TUNING_OUT];

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 683

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+   if (dev_buf_tuning) {
+           dev_dbg(&pdev->dev,
+                   "Tuning buf queued: scp_daddr(%pad),isp_daddr(%pad)\n",
+                   &dev_buf_tuning->scp_daddr[0],
+                   &dev_buf_tuning->isp_daddr[0]);
+           dip_param->tuning_data.pa =
+                   (uint32_t)dev_buf_tuning->scp_daddr[0];
+           dip_param->tuning_data.present = true;
+           dip_param->tuning_data.iova =
+                   (uint32_t)dev_buf_tuning->isp_daddr[0];
Quoted 1 line

Why are these casts needed?

Quoted 9 lines

This structure is shared between CPU and scp and the pa and iova is defined as 32bits fields.

struct tuning_addr {

        u32     present;
        u32     pa;     /* Used by CM4 access */
        u32     iova;   /* Used by IOMMU HW access */

} __attribute__ ((__packed__));

I see, thanks.

[snip]

Quoted 8 lines
Quoted 7 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 19

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +3 -0
+#define DIP_COMPOSING_MAX_NUM              3
+#define DIP_MAX_ERR_COUNT          188U
+#define DIP_FLUSHING_WQ_TIMEOUT            (16U * DIP_MAX_ERR_COUNT)

Any rationale behind this particular numbers? Please add comments explaining them.

Quoted 6 lines

I would like to adjust the time out value to 1000 / 30 * (DIP_COMPOSING_MAX_NUM) * 3.

To wait 3 times of expected frame time (@30fps) in the worst case (max number of jobs in SCP).

With high system load it could be still possible to hit this. Since it should normally be impossible to hit this timeout on a system working correctly, how about just making this something really long like 1 second?

[snip]

Quoted 44 lines
Quoted 30 lines
Quoted 30 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +29 -0
+
+   dev_dbg(&dip_dev->pdev->dev,
+           "%s: wakeup frame_no(%d),num(%d)\n",
+           __func__, req->img_fparam.frameparam.frame_no,
+           atomic_read(&dip_hw->num_composing));
+
+   buf = req->working_buf;
+   mtk_dip_wbuf_to_ipi_img_addr(&req->img_fparam.frameparam.subfrm_data,
+                                &buf->buffer);
+   memset(buf->buffer.vaddr, 0, DIP_SUB_FRM_SZ);
+   mtk_dip_wbuf_to_ipi_img_sw_addr(&req->img_fparam.frameparam.config_data,
+                                   &buf->config_data);
+   memset(buf->config_data.vaddr, 0, DIP_COMP_SZ);
+
+   if (!req->img_fparam.frameparam.tuning_data.present) {
+           /*
+            * When user enqueued without tuning buffer,
+            * it would use driver internal buffer.
+            */
+           dev_dbg(&dip_dev->pdev->dev,
+                   "%s: frame_no(%d) has no tuning_data\n",
+                   __func__, req->img_fparam.frameparam.frame_no);
+
+           mtk_dip_wbuf_to_ipi_tuning_addr
+                           (&req->img_fparam.frameparam.tuning_data,
+                            &buf->tuning_buf);
+           memset(buf->tuning_buf.vaddr, 0, DIP_TUNING_SZ);
+   }
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 460

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+   req->img_fparam.frameparam.state = FRAME_STATE_COMPOSING;
+   mtk_dip_wbuf_to_ipi_img_sw_addr(&req->img_fparam.frameparam.self_data,
+                                   &buf->frameparam);
+   memcpy(buf->frameparam.vaddr, &req->img_fparam.frameparam,
+          sizeof(req->img_fparam.frameparam));

Is img_fparam really used at this stage? I can only see ipi_param passed to the IPI.

The content of img_fparam is passed to SCP.

The dip frame information is saved in req->img_fparam.frameparam (in mtk_dip_pipe_ipi_params_config()).

Quoted 6 lines

The content of req->img_fparam.frameparam is copied to buf->frameparam.vaddr.

Since we set ipi_param.frm_param.pa to the buf->frameparam.scp_daddr in mtk_dip_wbuf_to_ipi_img_sw_addr(), the content of img_fparam is pass to SCP through ipi_param.

Okay, I see. Thanks,

[snip]

Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+   } else {
+           for (i = 0; i < *num_planes; i++) {
+                   if (sizes[i] < fmt->fmt.pix_mp.plane_fmt[i].sizeimage) {
+                           dev_dbg(&pipe->dip_dev->pdev->dev,
+                                   "%s:%s:%s: invalid buf: %u < %u\n",
+                                   __func__, pipe->desc->name,
+                                   node->desc->name, sizes[0], size);
+                                   return -EINVAL;
+                   }
+                   sizes[i] = fmt->fmt.pix_mp.plane_fmt[i].sizeimage;
Quoted 7 lines
Quoted 4 lines

For VIDIOC_CREATEBUFS we also need to handle the case when *num_planes > 0 and then we need to honor the values already present in sizes[]. (Note that the code above overrides *num_planes to 1, so we lose the information. The code needs to be restructured to handle that.)

We overrides *num_planes when *num_planes is 0. Is the modification I need to do to keep the original value of size[]?

Yes.

Quoted 6 lines
if (!*num_planes) {
        *num_planes = 1;
        sizes[0] = fmt->fmt.pix_mp.plane_fmt[0].sizeimage;
}

[snip]

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+   dev_dbg(&pipe->dip_dev->pdev->dev,
+           "%s:%s:%s cnt_nodes_not_streaming(%d), is_pipe_streamon(%d)\n",
+           __func__, pipe->desc->name, node->desc->name, count,
+           is_pipe_streamon);
+
+   if (count && is_pipe_streamon) {
Quoted 5 lines
Quoted 1 line

For v4l2_subdev_call() shouldn't this be !count && is_pipe_streamon?

Do you mean that pipe->subdev's stop stream should be called after all video device are stream off, not the first video device's stream off?

Partially. See the comment below. We should stop the subdev when the first video node stops streaming, but the media pipeline only when all the nodes stopped.

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+           ret = v4l2_subdev_call(&pipe->subdev, video, s_stream, 0);
+           if (ret)
+                   dev_err(&pipe->dip_dev->pdev->dev,
+                           "%s:%s: sub dev s_stream(0) failed(%d)\n",
+                           pipe->desc->name, node->desc->name, ret);
+           media_pipeline_stop(&node->vdev.entity);
Quoted 5 lines
Quoted 2 lines

We should do this one when the last node stops streaming to solve the enable state locking issue as described in my comment to _start_streaming().

I will do this when the last node stops streaming.

Ack.

Quoted 26 lines
Quoted 17 lines
Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +16 -0
+   }
+
+   mtk_dip_return_all_buffers(pipe, node, VB2_BUF_STATE_ERROR);
+}
+
+static int mtk_dip_videoc_querycap(struct file *file, void *fh,
+                              struct v4l2_capability *cap)
+{
+   struct mtk_dip_pipe *pipe = video_drvdata(file);
+
+   strlcpy(cap->driver, pipe->desc->name,
+           sizeof(cap->driver));
+   strlcpy(cap->card, pipe->desc->name,
+           sizeof(cap->card));
+   snprintf(cap->bus_info, sizeof(cap->bus_info),
+            "platform:%s", dev_name(pipe->dip_dev->mdev.dev));
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 455

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+
+   return 0;
+}
+
+static int mtk_dip_videoc_try_fmt(struct file *file, void *fh,
+                             struct v4l2_format *f)

I don't see this function returning any error codes. Please make it void.

Quoted 9 lines

mtk_dip_videoc_try_fmt() is used as vidioc_try_fmt_vid_out_mplane op. Using void seems to make it incompatible with vidioc_try_fmt_vid_out_mplane.

.vidioc_try_fmt_vid_out_mplane = mtk_dip_videoc_try_fmt,

int (*vidioc_try_fmt_vid_out_mplane)(struct file *file, void *fh,

                                     struct v4l2_format *f);

Oops, sorry, I'm not sure why I suggested that.

[snip]

Quoted 26 lines
Quoted 9 lines
Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +9 -0
+   /* Initialize subdev */
+   v4l2_subdev_init(&pipe->subdev, &mtk_dip_subdev_ops);
+
+   pipe->subdev.entity.function =
+           MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER;
+   pipe->subdev.entity.ops = &mtk_dip_media_ops;
+   pipe->subdev.flags =
+           V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;
+   pipe->subdev.ctrl_handler = NULL;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 1050

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+   pipe->subdev.internal_ops = &mtk_dip_subdev_internal_ops;
+
+   for (i = 0; i < pipe->num_nodes; i++)
+           pipe->subdev_pads[i].flags =
+                   V4L2_TYPE_IS_OUTPUT(pipe->nodes[i].desc->buf_type) ?
+                   MEDIA_PAD_FL_SINK : MEDIA_PAD_FL_SOURCE;

Isn't this the other way around?

I checked the document of MEDIA_PAD_FL_SINK and MEDIA_PAD_FL_SOURCE. It seems that the codes match the description.

RAW Ouput video device: MEDIA_PAD_FL_SOURCE --> DIP sub dev:
MEDIA_PAD_FL_SINK
DIP sub dev: MEDIA_PAD_FL_SOURCE --> MDP Capture video device:
MEDIA_PAD_FL_SINK

Quoted 5 lines

MEDIA_PAD_FL_SINK: Input pad, relative to the entity. Input pads sink data and are targets of links.
MEDIA_PAD_FL_SOURCE: Output pad, relative to the entity. Output pads source data and are origins of links.

Ah, that's right, sorry for the noise.

[snip]

Quoted 11 lines
Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 1280

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+   {
+           .format = V4L2_PIX_FMT_NV12M,
+           .mdp_color      = MDP_COLOR_NV12,
+           .colorspace = V4L2_COLORSPACE_BT2020,
+           .depth          = { 8, 4 },
+           .row_depth      = { 8, 8 },

What is depth and what is row_depth? They both seem to not match NV12, which should have 16 bits per sample in the CbCr plane.

Fow_depth is the bits of the pixel.

Bits of a YCbCr plane pixel is 16 for NV12.

Quoted 13 lines

Depth means the bytes per pixel of the image foramt.

For example,
Image: 640 * 480
YV12: row_depth = 8, depth = 12
Bytes per line = width * row_depth / 8 = 640 * 8/ 8 = 640 Image size = Bytes per line * height * (depth/ row_depth)

           = 640 * 480 * 1.5

Image: 640 * 480
Bytes per line(Y) = width * row_depth/ 8 = 640
Bytes per line(CbCr) = width * row_depth/ 8 = 640

Quoted 6 lines

Image size(Y) = Bytes per line * height * (depth/ row_depth)

           = 640 * 480 * 8/8 = 640 * 480 * 1

Image size(CbCr) = Bytes per line * height * (depth/ row_depth)

           = 640 * 480 * 4/8 = 640 * 480 * 0.5

I'd suggest either using the V4L2 format helpers, as suggested in another comment above with a link OR adopting the typical convention of having the .depth mean the pixel value size, i.e. 16-bit for CbCr plane of NV12 and then use subsampling factors to calculate the plane bytesperline and sizeimage.

[snip]

Quoted 40 lines
Quoted 40 lines
Quoted 26 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +26 -0
+static const struct mtk_dip_video_device_desc
+reprocess_output_queues_setting[MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM] = {
+   {
+           .id = MTK_DIP_VIDEO_NODE_ID_RAW_OUT,
+           .name = "Raw Input",
+           .cap = V4L2_CAP_VIDEO_OUTPUT_MPLANE | V4L2_CAP_STREAMING,
+           .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+           .smem_alloc = 0,
+           .flags = MEDIA_LNK_FL_ENABLED,
+           .fmts = in_fmts,
+           .num_fmts = ARRAY_SIZE(in_fmts),
+           .default_fmt_idx = 5,
+           .default_width = MTK_DIP_OUTPUT_MAX_WIDTH,
+           .default_height = MTK_DIP_OUTPUT_MAX_HEIGHT,
+           .dma_port = 0,
+           .frmsizeenum = &in_frmsizeenum,
+           .ops = &mtk_dip_v4l2_video_out_ioctl_ops,
+           .description = "Source image to be process",
+
+   },
+   {
+           .id = MTK_DIP_VIDEO_NODE_ID_TUNING_OUT,
+           .name = "Tuning",
+           .cap = V4L2_CAP_META_OUTPUT | V4L2_CAP_STREAMING,
+           .buf_type = V4L2_BUF_TYPE_META_OUTPUT,
+           .smem_alloc = 1,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 1443

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+           .flags = 0,
+           .fmts = fw_param_fmts,
+           .num_fmts = 1,
+           .default_fmt_idx = 0,
+           .dma_port = 0,
+           .frmsizeenum = &in_frmsizeenum,
+           .ops = &mtk_dip_v4l2_meta_out_ioctl_ops,
+           .description = "Tuning data for image enhancement",
+   },
+};

The entries here seem to be almost the same to output_queues_setting[], the only difference seems to be default_fmt_idx and description.

Quoted 5 lines
Quoted 1 line

What's the difference between the capture and reprocess pipes?

The reprocess pipe is completely the same as capture one except the default format of the input.

Does the default format really matter here? The userspace should set its own desired format anyway. Then we could just unify the settings of both pipes.

[snip]

Quoted 24 lines
Quoted 15 lines
Quoted 15 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +14 -0
+
+   return num;
+}
+
+static int __maybe_unused mtk_dip_suspend(struct device *dev)
+{
+   struct mtk_dip_dev *dip_dev = dev_get_drvdata(dev);
+   int ret, num;
+
+   if (pm_runtime_suspended(dev)) {
+           dev_dbg(dev, "%s: pm_runtime_suspended is true, no action\n",
+                   __func__);
+           return 0;
+   }
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 1738

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+
+   ret = wait_event_timeout(dip_dev->dip_hw.flushing_hw_wq,
+                            !(num = mtk_dip_get_scp_job_num(dip_dev)),
+                            msecs_to_jiffies(200));

Is 200 milliseconds a reasonable timeout here, i.e. for any potential use case it would always take less than 200 ms to wait for all the tasks running in the ISP?

Quoted 6 lines

I would like to adjust the time out value to 1000 / 30 * (DIP_COMPOSING_MAX_NUM) * 3.

To wait 3 times of expected frame time (@30fps) in worst case (max number of jobs in SCP).

As I suggested in another comment above, the worst case for the hardware might be still better than the scheduling latency we could get for a heavy loaded system. While that wouldn't really apply here, because nothing else happening in parallel when the system is suspending, we could just stick to some really long time out anyway, e.g. 1 second. We shouldn't hit it anyway - it's just a safety guard to prevent the system hanging if something goes really bad.

Best regards,
Tomasz

#12 lore raw

Re: [RFC PATCH V2 4/6] platform: mtk-isp: Add Mediatek DIP driver

Hi Tomasz,

Thank you for your comments.

Quoted 51 lines · Tomasz Figa

Hi Frederic,

Quoted 6 lines · Frederic Chen

Dear Tomasz,

I appreciate your comment. I will collaborate more closely with Jungo to solve the common issues in DIP and Pass 1(CAM) drivers.

Thank you!

Also thanks for replying to all the comments, it's very helpful. Please check my replies inline. I've snipped out the parts that I don't have further comments on.

Quoted 5 lines · Tomasz Figa
Quoted 3 lines

Hi Frederic,

On Mon, Jul 08, 2019 at 07:04:58PM +0800, [email protected] wrote:

[snip]

Quoted 21 lines
Quoted 12 lines
Quoted 12 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +11 -0
+                   dev_buf->vbb.vb2_buf.timestamp =
+                           in_buf->vbb.vb2_buf.timestamp;
+
+           vb2_buffer_done(&dev_buf->vbb.vb2_buf, vbf_state);
+
+           node = mtk_dip_vbq_to_node(dev_buf->vbb.vb2_buf.vb2_queue);
+           spin_lock(&node->buf_list_lock);
+           list_del(&dev_buf->list);
+           spin_unlock(&node->buf_list_lock);
+
+           dev_dbg(&pipe->dip_dev->pdev->dev,
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 175

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +4 -0
+                   "%s:%s: return buf, idx(%d), state(%d)\n",
+                   pipe->desc->name, node->desc->name,
+                   dev_buf->vbb.vb2_buf.index, vbf_state);
+   }

This looks almost the same as what's being done inside mtk_dip_hw_streamoff(). Could we just call this function from the loop there?

Quoted 4 lines

I would like to call the function from mtk_dip_hw_streamoff(). The only difference is mtk_dip_pipe_job_finish() also remove the buffer from the node's internal list.

Quoted 6 lines

Would anything wrong happen if we also remove the buffer from the node's internal list in mtk_dip_hw_streamoff()?

Actually, do we need that internal node list? If we have a list of requests and each request stores its buffer, wouldn't that be enough?

We use the buffer list in the following cases:
1. media_pipeline_start() failed when streaming on video device
2. Video device stream off

If the some video device is streamed on ,but the entire pipe has not started streaming (for example, MDP 0 is streamed on, but RAW input has not been streamed on), we use the list to return the buffers.

Should we handle this cases? or we expect that the user will request buffers again to ensure all buffers are removed from the video device in this error case.

Quoted 31 lines

[snip]

Quoted 18 lines
Quoted 12 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 235

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+
+   width = ALIGN(width, 4);
+   stride = DIV_ROUND_UP(width * 3, 2);
+   stride = DIV_ROUND_UP(stride * pixel_byte, 8);
+
+   if (pix_fmt == V4L2_PIX_FMT_MTISP_F10)
+           stride =  ALIGN(stride, 4);
+   else
+           stride =  ALIGN(stride, 8);

Could you explain all the calculations done above?

If the buffer comes from mtk-cam-p1, the stride setting must be the same as p1. I would like to re-implement the codes following p1's design in v4 patch as following:

static u32

Quoted 10 lines
mtk_dip_pass1_cal_pack_stride(u32 width, u32 pix_fmt) {
        unsigned int bpl;
        unsigned int pixel_bits =
                get_pixel_byte_by_fmt(mp->pixelformat);

        /* Bayer encoding format, P1 HW needs 2 bytes alignment */
        bpl = ALIGN(DIV_ROUND_UP(width * pixel_bits, 8), 2);

        /* The setting also needs 4 bytes alignment for DIP HW */
        return ALIGN(bpl, 4);;
Quoted 7 lines

If we need 4 bytes alignment, wouldn't the bytes per line value end up different from P1 anyway? Perhaps we can just remove the ALIGN(..., 2) above and keep this one? It should be the userspace responsibility anyway to choose a format compatible with both consumer and producer.

By the way, double semicolon in the line above. :)

I would like to remove the ALIGN(..., 2).

Quoted 122 lines
Quoted 18 lines

}

static __u32 mtk_dip_pass1_cal_main_stride(u32 width, u32 pix_fmt)

{
        unsigned int bpl, ppl;
        unsigned int pixel_bits =
                get_pixel_byte_by_fmt(mp->pixelformat);

        /*
         * The FULL-G encoding format
         * 1 G component per pixel
         * 1 R component per 4 pixel
         * 1 B component per 4 pixel
         * Total 4G/1R/1B in 4 pixel (pixel per line:ppl)
         */
        ppl = DIV_ROUND_UP(width * 6, 4);
Quoted 8 lines
        bpl = DIV_ROUND_UP(ppl * pixel_bits, 8);

        /* 4 bytes alignment for 10 bit & others are 8 bytes */
        if (pixel_bits == 10)
                bpl = ALIGN(bpl, 4);
        else
                bpl = ALIGN(bpl, 8);
        }

Spurious }.

Quoted 4 lines
        return bpl;
}

Looks good to me, thanks!

Quoted 86 lines
Quoted 69 lines
Quoted 69 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +67 -0
+
+   return stride;
+}
+
+static int is_stride_need_to_align(u32 format, u32 *need_aligned_fmts,
+                              int length)
+{
+   int i;
+
+   for (i = 0; i < length; i++) {
+           if (format == need_aligned_fmts[i])
+                   return true;
+   }
+
+   return false;
+}
+
+/* Stride that is accepted by MDP HW */
+static u32 dip_mdp_fmt_get_stride(struct v4l2_pix_format_mplane *mfmt,
+                             const struct mtk_dip_dev_format *fmt,
+                             unsigned int plane)
+{
+   enum mdp_color c = fmt->mdp_color;
+   u32 bytesperline = (mfmt->width * fmt->row_depth[plane]) / 8;
+   u32 stride = (bytesperline * MDP_COLOR_BITS_PER_PIXEL(c))
+           / fmt->row_depth[0];
+
+   if (plane == 0)
+           return stride;
+
+   if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+           if (MDP_COLOR_IS_BLOCK_MODE(c))
+                   stride = stride / 2;
+           return stride;
+   }
+
+   return 0;
+}
+
+/* Stride that is accepted by MDP HW of format with contiguous planes */
+static u32
+dip_mdp_fmt_get_stride_contig(const struct mtk_dip_dev_format *fmt,
+                         u32 pix_stride,
+                         unsigned int plane)
+{
+   enum mdp_color c = fmt->mdp_color;
+   u32 stride = pix_stride;
+
+   if (plane == 0)
+           return stride;
+
+   if (plane < MDP_COLOR_GET_PLANE_COUNT(c)) {
+           stride = stride >> MDP_COLOR_GET_H_SUBSAMPLE(c);
+           if (MDP_COLOR_IS_UV_COPLANE(c) && !MDP_COLOR_IS_BLOCK_MODE(c))
+                   stride = stride * 2;
+           return stride;
+   }
+
+   return 0;
+}
+
+/* Plane size that is accepted by MDP HW */
+static u32
+dip_mdp_fmt_get_plane_size(const struct mtk_dip_dev_format *fmt,
+                      u32 stride, u32 height,
+                      unsigned int plane)
+{
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 307

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +5 -0
+   enum mdp_color c = fmt->mdp_color;
+   u32 bytesperline;
+
+   bytesperline = (stride * fmt->row_depth[0])
+           / MDP_COLOR_BITS_PER_PIXEL(c);

Hmm, stride and bytesperline should be exactly the same thing. Could you explain what's happening here?

The stride here is specific for MDP hardware (which uses the same MDP stride setting for NV12 and NV12M):

bytesperline = width * row_depth / 8
MDP stride = width * MDP_COLOR_BITS_PER_PIXEL /8

Therfore,

Quoted 8 lines
Quoted 3 lines

bytesperline = MDP stride * row_depth / MDP_COLOR_BITS_PER_PIXEL
MDP stride = bytesperline * MDP_COLOR_BITS_PER_PIXEL/ row_depth

I'm sorry I'm still confused. Is there an intermediate buffer between DIP and MDP that has stride of |MDP stride| and then MDP writes to the final buffer that has the stride of |bytesperline|?

No, there is no intermediate buffer between DIP and MDP that has stride of |MDP stride|. DIP connects to MDP in hardware level, so MDP writes the buffer with |MDP stride|.

As I know, V4L2's bytesperline means bytes per line of the first plane(*), but mdp hw needs y, u, v stride (it is different from V4L2). Therefore we calculate the |MDP stride| here.

*:
https://linuxtv.org/downloads/v4l-dvb-apis/uapi/v4l/pixfmt-v4l2.html#c.v4l2_pix_format
"When the image format is planar the bytesperline value applies to the first plane and is divided by the same factor as the width field for the other planes."

Quoted 13 lines

[snip]

Quoted 11 lines
Quoted 10 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 390

Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +7 -0
+           u32 sizeimage;
+
+           if (bpl < min_bpl)
+                   bpl = min_bpl;
+
+           sizeimage = (bpl * mfmt_to_fill->height * dev_fmt->depth[i])
+                   / dev_fmt->row_depth[i];

Shouldn't this be bpl * fmt->height?

Quoted 9 lines
Quoted 6 lines

Row_depth is the bits of the pixel.
Depth means the bytes per pixel of the image format.

For example,
Image: 640 * 480
YV12: row_depth = 8, depth = 12

YV12 has 3 planes of 8 bits per pixel. Not sure where does this 12 come from.

Let me elaborate more about the 12 depth.

depth: pixel bit number

For 420,

y = w * h
u = (w/2) * (h/2)
v = (w/2) * (h/2)

Therefore,

y = 8,
u = 8/2/2 = 2
v = 8/2/2 = 2

depth (y + u + v) = 8 + 2 + 2 = 12

Quoted 9 lines
Quoted 4 lines

Bytes per line = width * row_depth / 8 = 640 * 8/ 8 = 640 Image size = Bytes per line * height * (depth/ row_depth)

           = 640 * 480 * 1.5

I think we might be having some terminology issue here. "row" is normally the same as "line", which consists of |width| pixels + padding, which is |bytesperline| bytes in total.

Quoted 7 lines

Perhaps you want to store a bits_per_pixel[] and vertical and horizontal subsampling arrays for all planes of the formats in the format descriptor.

By the way, have you considered using the V4L2 format helpers [1]?

[1] https://elixir.bootlin.com/linux/v5.3-rc6/source/drivers/media/v4l2-core/v4l2-common.c#L561

Would it be possible to keep row_depth and depth? It is already used in MDP drivers.

https://elixir.bootlin.com/linux/v5.3-rc6/source/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c

Quoted 70 lines
Quoted 17 lines
Quoted 17 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 566

Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +9 -0
+           dev_dbg(&pipe->dip_dev->pdev->dev,
+                   "Non-contiguous-mp-buf(%s),total-plane-size(%d),dma_port(%d)\n",
+                   buf_name,
+                   total_plane_size,
+                   b->usage);
+           return 0;
+   }
+
+   for (; i < MDP_COLOR_GET_PLANE_COUNT(b->format.colorformat); ++i) {

I don't see these MDP_ macros defined anywhere. Please don't use macros defined from other drivers. We can embed this information in the mtk_dip_dev_format struct. One would normally call it num_cplanes (color planes).

Quoted 6 lines
Quoted 2 lines

However, I would just make this driver support M formats only and forget about formats with only memory planes count != color planes count.

Since the non-M formats are still used by 8183's user lib now, may I add num_cplanes and support the both formats?

Okay, let's keep them for now.

[snip]

Quoted 17 lines
Quoted 15 lines
Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +4 -0
+
+   /* Tuning buffer */
+   dev_buf_tuning =
+           pipe_job_info->buf_map[MTK_DIP_VIDEO_NODE_ID_TUNING_OUT];

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c line 683

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c new file +10 -0
+   if (dev_buf_tuning) {
+           dev_dbg(&pdev->dev,
+                   "Tuning buf queued: scp_daddr(%pad),isp_daddr(%pad)\n",
+                   &dev_buf_tuning->scp_daddr[0],
+                   &dev_buf_tuning->isp_daddr[0]);
+           dip_param->tuning_data.pa =
+                   (uint32_t)dev_buf_tuning->scp_daddr[0];
+           dip_param->tuning_data.present = true;
+           dip_param->tuning_data.iova =
+                   (uint32_t)dev_buf_tuning->isp_daddr[0];
Quoted 1 line

Why are these casts needed?

Quoted 9 lines

This structure is shared between CPU and scp and the pa and iova is defined as 32bits fields.

struct tuning_addr {

        u32     present;
        u32     pa;     /* Used by CM4 access */
        u32     iova;   /* Used by IOMMU HW access */

} __attribute__ ((__packed__));

I see, thanks.

[snip]

Quoted 11 lines
Quoted 7 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h line 19

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h new file +3 -0
+#define DIP_COMPOSING_MAX_NUM              3
+#define DIP_MAX_ERR_COUNT          188U
+#define DIP_FLUSHING_WQ_TIMEOUT            (16U * DIP_MAX_ERR_COUNT)

Any rationale behind this particular numbers? Please add comments explaining them.

I would like to adjust the time out value to 1000 / 30 * (DIP_COMPOSING_MAX_NUM) * 3.

Quoted 9 lines
Quoted 3 lines

To wait 3 times of expected frame time (@30fps) in the worst case (max number of jobs in SCP).

With high system load it could be still possible to hit this. Since it should normally be impossible to hit this timeout on a system working correctly, how about just making this something really long like 1 second?

I got it. I would like to use 1 second instead.

Quoted 98 lines

[snip]

Quoted 44 lines
Quoted 30 lines
Quoted 30 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +29 -0
+
+   dev_dbg(&dip_dev->pdev->dev,
+           "%s: wakeup frame_no(%d),num(%d)\n",
+           __func__, req->img_fparam.frameparam.frame_no,
+           atomic_read(&dip_hw->num_composing));
+
+   buf = req->working_buf;
+   mtk_dip_wbuf_to_ipi_img_addr(&req->img_fparam.frameparam.subfrm_data,
+                                &buf->buffer);
+   memset(buf->buffer.vaddr, 0, DIP_SUB_FRM_SZ);
+   mtk_dip_wbuf_to_ipi_img_sw_addr(&req->img_fparam.frameparam.config_data,
+                                   &buf->config_data);
+   memset(buf->config_data.vaddr, 0, DIP_COMP_SZ);
+
+   if (!req->img_fparam.frameparam.tuning_data.present) {
+           /*
+            * When user enqueued without tuning buffer,
+            * it would use driver internal buffer.
+            */
+           dev_dbg(&dip_dev->pdev->dev,
+                   "%s: frame_no(%d) has no tuning_data\n",
+                   __func__, req->img_fparam.frameparam.frame_no);
+
+           mtk_dip_wbuf_to_ipi_tuning_addr
+                           (&req->img_fparam.frameparam.tuning_data,
+                            &buf->tuning_buf);
+           memset(buf->tuning_buf.vaddr, 0, DIP_TUNING_SZ);
+   }
+
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c line 460

Quoted 5 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c new file +5 -0
+   req->img_fparam.frameparam.state = FRAME_STATE_COMPOSING;
+   mtk_dip_wbuf_to_ipi_img_sw_addr(&req->img_fparam.frameparam.self_data,
+                                   &buf->frameparam);
+   memcpy(buf->frameparam.vaddr, &req->img_fparam.frameparam,
+          sizeof(req->img_fparam.frameparam));

Is img_fparam really used at this stage? I can only see ipi_param passed to the IPI.

The content of img_fparam is passed to SCP.

The dip frame information is saved in req->img_fparam.frameparam (in mtk_dip_pipe_ipi_params_config()).

Quoted 6 lines

The content of req->img_fparam.frameparam is copied to buf->frameparam.vaddr.

Since we set ipi_param.frm_param.pa to the buf->frameparam.scp_daddr in mtk_dip_wbuf_to_ipi_img_sw_addr(), the content of img_fparam is pass to SCP through ipi_param.

Okay, I see. Thanks,

[snip]

Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+   } else {
+           for (i = 0; i < *num_planes; i++) {
+                   if (sizes[i] < fmt->fmt.pix_mp.plane_fmt[i].sizeimage) {
+                           dev_dbg(&pipe->dip_dev->pdev->dev,
+                                   "%s:%s:%s: invalid buf: %u < %u\n",
+                                   __func__, pipe->desc->name,
+                                   node->desc->name, sizes[0], size);
+                                   return -EINVAL;
+                   }
+                   sizes[i] = fmt->fmt.pix_mp.plane_fmt[i].sizeimage;
Quoted 7 lines
Quoted 4 lines

For VIDIOC_CREATEBUFS we also need to handle the case when *num_planes > 0 and then we need to honor the values already present in sizes[]. (Note that the code above overrides *num_planes to 1, so we lose the information. The code needs to be restructured to handle that.)

We overrides *num_planes when *num_planes is 0. Is the modification I need to do to keep the original value of size[]?

Yes.

Quoted 6 lines
if (!*num_planes) {
        *num_planes = 1;
        sizes[0] = fmt->fmt.pix_mp.plane_fmt[0].sizeimage;
}

[snip]

Quoted 10 lines
Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 427

Quoted 7 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+   dev_dbg(&pipe->dip_dev->pdev->dev,
+           "%s:%s:%s cnt_nodes_not_streaming(%d), is_pipe_streamon(%d)\n",
+           __func__, pipe->desc->name, node->desc->name, count,
+           is_pipe_streamon);
+
+   if (count && is_pipe_streamon) {

For v4l2_subdev_call() shouldn't this be !count && is_pipe_streamon?

Quoted 7 lines
Quoted 3 lines

Do you mean that pipe->subdev's stop stream should be called after all video device are stream off, not the first video device's stream off?

Partially. See the comment below. We should stop the subdev when the first video node stops streaming, but the media pipeline only when all the nodes stopped.

I got it.

Quoted 177 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+           ret = v4l2_subdev_call(&pipe->subdev, video, s_stream, 0);
+           if (ret)
+                   dev_err(&pipe->dip_dev->pdev->dev,
+                           "%s:%s: sub dev s_stream(0) failed(%d)\n",
+                           pipe->desc->name, node->desc->name, ret);
+           media_pipeline_stop(&node->vdev.entity);
Quoted 5 lines
Quoted 2 lines

We should do this one when the last node stops streaming to solve the enable state locking issue as described in my comment to _start_streaming().

I will do this when the last node stops streaming.

Ack.

Quoted 26 lines
Quoted 17 lines
Quoted 17 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +16 -0
+   }
+
+   mtk_dip_return_all_buffers(pipe, node, VB2_BUF_STATE_ERROR);
+}
+
+static int mtk_dip_videoc_querycap(struct file *file, void *fh,
+                              struct v4l2_capability *cap)
+{
+   struct mtk_dip_pipe *pipe = video_drvdata(file);
+
+   strlcpy(cap->driver, pipe->desc->name,
+           sizeof(cap->driver));
+   strlcpy(cap->card, pipe->desc->name,
+           sizeof(cap->card));
+   snprintf(cap->bus_info, sizeof(cap->bus_info),
+            "platform:%s", dev_name(pipe->dip_dev->mdev.dev));
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 455

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+
+   return 0;
+}
+
+static int mtk_dip_videoc_try_fmt(struct file *file, void *fh,
+                             struct v4l2_format *f)

I don't see this function returning any error codes. Please make it void.

Quoted 9 lines

mtk_dip_videoc_try_fmt() is used as vidioc_try_fmt_vid_out_mplane op. Using void seems to make it incompatible with vidioc_try_fmt_vid_out_mplane.

.vidioc_try_fmt_vid_out_mplane = mtk_dip_videoc_try_fmt,

int (*vidioc_try_fmt_vid_out_mplane)(struct file *file, void *fh,

                                     struct v4l2_format *f);

Oops, sorry, I'm not sure why I suggested that.

[snip]

Quoted 26 lines
Quoted 9 lines
Quoted 9 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +9 -0
+   /* Initialize subdev */
+   v4l2_subdev_init(&pipe->subdev, &mtk_dip_subdev_ops);
+
+   pipe->subdev.entity.function =
+           MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER;
+   pipe->subdev.entity.ops = &mtk_dip_media_ops;
+   pipe->subdev.flags =
+           V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;
+   pipe->subdev.ctrl_handler = NULL;
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 1050

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+   pipe->subdev.internal_ops = &mtk_dip_subdev_internal_ops;
+
+   for (i = 0; i < pipe->num_nodes; i++)
+           pipe->subdev_pads[i].flags =
+                   V4L2_TYPE_IS_OUTPUT(pipe->nodes[i].desc->buf_type) ?
+                   MEDIA_PAD_FL_SINK : MEDIA_PAD_FL_SOURCE;

Isn't this the other way around?

I checked the document of MEDIA_PAD_FL_SINK and MEDIA_PAD_FL_SOURCE. It seems that the codes match the description.

RAW Ouput video device: MEDIA_PAD_FL_SOURCE --> DIP sub dev:
MEDIA_PAD_FL_SINK
DIP sub dev: MEDIA_PAD_FL_SOURCE --> MDP Capture video device:
MEDIA_PAD_FL_SINK

Quoted 5 lines

MEDIA_PAD_FL_SINK: Input pad, relative to the entity. Input pads sink data and are targets of links.
MEDIA_PAD_FL_SOURCE: Output pad, relative to the entity. Output pads source data and are origins of links.

Ah, that's right, sorry for the noise.

[snip]

Quoted 11 lines
Quoted 9 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 1280

Quoted 6 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +6 -0
+   {
+           .format = V4L2_PIX_FMT_NV12M,
+           .mdp_color      = MDP_COLOR_NV12,
+           .colorspace = V4L2_COLORSPACE_BT2020,
+           .depth          = { 8, 4 },
+           .row_depth      = { 8, 8 },

What is depth and what is row_depth? They both seem to not match NV12, which should have 16 bits per sample in the CbCr plane.

Fow_depth is the bits of the pixel.

Bits of a YCbCr plane pixel is 16 for NV12.

Quoted 13 lines

Depth means the bytes per pixel of the image foramt.

For example,
Image: 640 * 480
YV12: row_depth = 8, depth = 12
Bytes per line = width * row_depth / 8 = 640 * 8/ 8 = 640 Image size = Bytes per line * height * (depth/ row_depth)

           = 640 * 480 * 1.5

Image: 640 * 480
Bytes per line(Y) = width * row_depth/ 8 = 640
Bytes per line(CbCr) = width * row_depth/ 8 = 640

Quoted 6 lines

Image size(Y) = Bytes per line * height * (depth/ row_depth)

           = 640 * 480 * 8/8 = 640 * 480 * 1

Image size(CbCr) = Bytes per line * height * (depth/ row_depth)

           = 640 * 480 * 4/8 = 640 * 480 * 0.5

I'd suggest either using the V4L2 format helpers, as suggested in another comment above with a link OR adopting the typical convention of having the .depth mean the pixel value size, i.e. 16-bit for CbCr plane of NV12 and then use subsampling factors to calculate the plane bytesperline and sizeimage.

[snip]

Quoted 42 lines
Quoted 41 lines
Quoted 26 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +26 -0
+static const struct mtk_dip_video_device_desc
+reprocess_output_queues_setting[MTK_DIP_VIDEO_NODE_ID_OUT_TOTAL_NUM] = {
+   {
+           .id = MTK_DIP_VIDEO_NODE_ID_RAW_OUT,
+           .name = "Raw Input",
+           .cap = V4L2_CAP_VIDEO_OUTPUT_MPLANE | V4L2_CAP_STREAMING,
+           .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
+           .smem_alloc = 0,
+           .flags = MEDIA_LNK_FL_ENABLED,
+           .fmts = in_fmts,
+           .num_fmts = ARRAY_SIZE(in_fmts),
+           .default_fmt_idx = 5,
+           .default_width = MTK_DIP_OUTPUT_MAX_WIDTH,
+           .default_height = MTK_DIP_OUTPUT_MAX_HEIGHT,
+           .dma_port = 0,
+           .frmsizeenum = &in_frmsizeenum,
+           .ops = &mtk_dip_v4l2_video_out_ioctl_ops,
+           .description = "Source image to be process",
+
+   },
+   {
+           .id = MTK_DIP_VIDEO_NODE_ID_TUNING_OUT,
+           .name = "Tuning",
+           .cap = V4L2_CAP_META_OUTPUT | V4L2_CAP_STREAMING,
+           .buf_type = V4L2_BUF_TYPE_META_OUTPUT,
+           .smem_alloc = 1,

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 1443

Quoted 10 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +10 -0
+           .flags = 0,
+           .fmts = fw_param_fmts,
+           .num_fmts = 1,
+           .default_fmt_idx = 0,
+           .dma_port = 0,
+           .frmsizeenum = &in_frmsizeenum,
+           .ops = &mtk_dip_v4l2_meta_out_ioctl_ops,
+           .description = "Tuning data for image enhancement",
+   },
+};

The entries here seem to be almost the same to output_queues_setting[], the only difference seems to be default_fmt_idx and description.

What's the difference between the capture and reprocess pipes?

Quoted 8 lines
Quoted 3 lines

The reprocess pipe is completely the same as capture one except the default format of the input.

Does the default format really matter here? The userspace should set its own desired format anyway. Then we could just unify the settings of both pipes.

I would like to remove the reprocess_output_queues_setting.

Quoted 33 lines

[snip]

Quoted 24 lines
Quoted 15 lines
Quoted 15 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +14 -0
+
+   return num;
+}
+
+static int __maybe_unused mtk_dip_suspend(struct device *dev)
+{
+   struct mtk_dip_dev *dip_dev = dev_get_drvdata(dev);
+   int ret, num;
+
+   if (pm_runtime_suspended(dev)) {
+           dev_dbg(dev, "%s: pm_runtime_suspended is true, no action\n",
+                   __func__);
+           return 0;
+   }
Quoted 8 lines

drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c line 1738

Quoted 4 lines
drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c new file +4 -0
+
+   ret = wait_event_timeout(dip_dev->dip_hw.flushing_hw_wq,
+                            !(num = mtk_dip_get_scp_job_num(dip_dev)),
+                            msecs_to_jiffies(200));

Is 200 milliseconds a reasonable timeout here, i.e. for any potential use case it would always take less than 200 ms to wait for all the tasks running in the ISP?

Quoted 6 lines

I would like to adjust the time out value to 1000 / 30 * (DIP_COMPOSING_MAX_NUM) * 3.

To wait 3 times of expected frame time (@30fps) in worst case (max number of jobs in SCP).

Quoted 8 lines

As I suggested in another comment above, the worst case for the hardware might be still better than the scheduling latency we could get for a heavy loaded system. While that wouldn't really apply here, because nothing else happening in parallel when the system is suspending, we could just stick to some really long time out anyway, e.g. 1 second. We shouldn't hit it anyway - it's just a safety guard to prevent the system hanging if something goes really bad.

I got it. I will use 1 second as timeout setting.

Quoted 2 lines

Best regards,
Tomasz

Sincerely,

Frederic Chen

#13 lore raw

Re: [RFC PATCH V2 4/6] platform: mtk-isp: Add Mediatek DIP driver

Quoted 69 lines · Frederic Chen

Hi Tomasz,

Thank you for your comments.

Quoted 51 lines · Tomasz Figa

Hi Frederic,

Quoted 6 lines · Frederic Chen

Dear Tomasz,

I appreciate your comment. I will collaborate more closely with Jungo to solve the common issues in DIP and Pass 1(CAM) drivers.

Thank you!

Also thanks for replying to all the comments, it's very helpful. Please check my replies inline. I've snipped out the parts that I don't have further comments on.

Quoted 5 lines · Tomasz Figa
Quoted 3 lines

Hi Frederic,

On Mon, Jul 08, 2019 at 07:04:58PM +0800, [email protected] wrote:

[snip]

Quoted 21 lines
Quoted 12 lines
Quoted 12 lines
(quoted diff) +11 -0
+                   dev_buf->vbb.vb2_buf.timestamp =
+                           in_buf->vbb.vb2_buf.timestamp;
+
+           vb2_buffer_done(&dev_buf->vbb.vb2_buf, vbf_state);
+
+           node = mtk_dip_vbq_to_node(dev_buf->vbb.vb2_buf.vb2_queue);
+           spin_lock(&node->buf_list_lock);
+           list_del(&dev_buf->list);
+           spin_unlock(&node->buf_list_lock);
+
+           dev_dbg(&pipe->dip_dev->pdev->dev,
Quoted 8 lines

Review

Quoted 4 lines
(quoted diff) +4 -0
+                   "%s:%s: return buf, idx(%d), state(%d)\n",
+                   pipe->desc->name, node->desc->name,
+                   dev_buf->vbb.vb2_buf.index, vbf_state);
+   }

This looks almost the same as what's being done inside mtk_dip_hw_streamoff(). Could we just call this function from the loop there?

Quoted 4 lines

I would like to call the function from mtk_dip_hw_streamoff(). The only difference is mtk_dip_pipe_job_finish() also remove the buffer from the node's internal list.

Quoted 6 lines

Would anything wrong happen if we also remove the buffer from the node's internal list in mtk_dip_hw_streamoff()?

Actually, do we need that internal node list? If we have a list of requests and each request stores its buffer, wouldn't that be enough?

We use the buffer list in the following cases:
1. media_pipeline_start() failed when streaming on video device
2. Video device stream off

Quoted 8 lines

If the some video device is streamed on ,but the entire pipe has not started streaming (for example, MDP 0 is streamed on, but RAW input has not been streamed on), we use the list to return the buffers.

Should we handle this cases? or we expect that the user will request buffers again to ensure all buffers are removed from the video device in this error case.

However, if we only support the Request API, there wouldn't be any buffers outside of any request. For a request that isn't queued, the buffers are not passed to the driver, so it doesn't need to do anything. The only thing left to handle is when there are some requests queued and those requests already include the buffer request objects inside, so we can handle them without a separate internal buffer list.

Quoted 40 lines
Quoted 23 lines
Quoted 23 lines
Quoted 6 lines
Quoted 6 lines
(quoted diff) +6 -0
+/* Plane size that is accepted by MDP HW */
+static u32
+dip_mdp_fmt_get_plane_size(const struct mtk_dip_dev_format *fmt,
+                      u32 stride, u32 height,
+                      unsigned int plane)
+{
Quoted 8 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+   enum mdp_color c = fmt->mdp_color;
+   u32 bytesperline;
+
+   bytesperline = (stride * fmt->row_depth[0])
+           / MDP_COLOR_BITS_PER_PIXEL(c);

Hmm, stride and bytesperline should be exactly the same thing. Could you explain what's happening here?

The stride here is specific for MDP hardware (which uses the same MDP stride setting for NV12 and NV12M):

bytesperline = width * row_depth / 8
MDP stride = width * MDP_COLOR_BITS_PER_PIXEL /8

Therfore,

Quoted 8 lines
Quoted 3 lines

bytesperline = MDP stride * row_depth / MDP_COLOR_BITS_PER_PIXEL
MDP stride = bytesperline * MDP_COLOR_BITS_PER_PIXEL/ row_depth

I'm sorry I'm still confused. Is there an intermediate buffer between DIP and MDP that has stride of |MDP stride| and then MDP writes to the final buffer that has the stride of |bytesperline|?

No, there is no intermediate buffer between DIP and MDP that has stride of |MDP stride|. DIP connects to MDP in hardware level, so MDP writes the buffer with |MDP stride|.

As I know, V4L2's bytesperline means bytes per line of the first plane(*), but mdp hw needs y, u, v stride (it is different from V4L2). Therefore we calculate the |MDP stride| here.

Quoted 5 lines

*:
https://linuxtv.org/downloads/v4l-dvb-apis/uapi/v4l/pixfmt-v4l2.html#c.v4l2_pix_format
"When the image format is planar the bytesperline value applies to the first plane and is divided by the same factor as the width field for the other planes."

However, we're using v4l2_pix_fmt_mplane, not v4l2_pix_format. If the pixelformat is the M variant (e.g. V4L2_PIX_FMT_NV12M), the v4l2_pix_fmt_mplane::planes[] contains bytesperline and sizeimage for each plane separately. That's the reason I'm strongly suggesting abandoning the non-M formats and supporting only the M ones.

Quoted 34 lines
Quoted 14 lines

[snip]

Quoted 11 lines
Quoted 10 lines

Review

Quoted 8 lines
(quoted diff) +7 -0
+           u32 sizeimage;
+
+           if (bpl < min_bpl)
+                   bpl = min_bpl;
+
+           sizeimage = (bpl * mfmt_to_fill->height * dev_fmt->depth[i])
+                   / dev_fmt->row_depth[i];

Shouldn't this be bpl * fmt->height?

Quoted 9 lines
Quoted 6 lines

Row_depth is the bits of the pixel.
Depth means the bytes per pixel of the image format.

For example,
Image: 640 * 480
YV12: row_depth = 8, depth = 12

YV12 has 3 planes of 8 bits per pixel. Not sure where does this 12 come from.

Let me elaborate more about the 12 depth.

depth: pixel bit number

For 420,

y = w * h
u = (w/2) * (h/2)
v = (w/2) * (h/2)

Quoted 8 lines

Therefore,

y = 8,
u = 8/2/2 = 2
v = 8/2/2 = 2

depth (y + u + v) = 8 + 2 + 2 = 12

Yes, that's what I understood, but it is by no means associated with any physical depth. It's more like "total_bits_per_pixel". That's however a very error prone way to express pixel formats, as for example it can't handle the case when plane strides alignments are not proportional.

Please see the v4l2_format_info struct for the recommended way of describing pixel formats. Actually, the struct itself could be reused in this driver, even if we don't end up using the helpers for some reason.

Quoted 14 lines
Quoted 14 lines
Quoted 5 lines

Bytes per line = width * row_depth / 8 = 640 * 8/ 8 = 640 Image size = Bytes per line * height * (depth/ row_depth)

           = 640 * 480 * 1.5

I think we might be having some terminology issue here. "row" is normally the same as "line", which consists of |width| pixels + padding, which is |bytesperline| bytes in total.

Perhaps you want to store a bits_per_pixel[] and vertical and horizontal subsampling arrays for all planes of the formats in the format descriptor.

Quoted 9 lines
Quoted 3 lines

By the way, have you considered using the V4L2 format helpers [1]?

[1] https://elixir.bootlin.com/linux/v5.3-rc6/source/drivers/media/v4l2-core/v4l2-common.c#L561

Would it be possible to keep row_depth and depth? It is already used in MDP drivers.

https://elixir.bootlin.com/linux/v5.3-rc6/source/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c

I'd suggest cleaning up the MDP driver instead. :) (Could be done as a follow up later, of course.)

Best regards,
Tomasz

#14 lore raw
In reply to a message not in the archive

Hi Hans,

Quoted 8 lines · On Mon, Jul 8, 2019 at 8:05 PM <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]…

Hello,

This RFC patch series added Digital Image Processing (DIP) driver on Mediatek mt8183 SoC. It belongs to the Mediatek's ISP driver series based on V4L2 and media controller framework. I posted the main part of the DIP driver as RFC to discuss first and would like some review comments.

Quoted 8 lines

I appreciate the helpful comment of Tomasz, Rob and Shik in RFC V1. The RFC V2 patch addressed on the review issues in V1. There are 2 V4L2 compliance test issues still under discussion and I will do the corresponding modification in the next patch after we come to the conclusion.

1. Request API test doesn't know which buffers of the video devices are required so we got failed in testRequests()

Perhaps the test should check the media topology and infer the video devices required from there?

Quoted 3 lines

2. V4L2 compliance test check if the driver return error when passing an invalid image size, but in vb2_create_bufs() case, we don't know if the size check is required or not.

In current VB2 API, we don't get the format given to CREATE_BUFS anymore, we just get the requested sizeimage. How do we validate if the sizeimage is big enough for the format? Should we implement that check in the .vidioc_create_bufs op before calling vb2_create_bufs()?

Quoted 4 lines

Please see the following URL for the detail.
http://lists.infradead.org/pipermail/linux-mediatek/2019-June/020884.html

Would you be able to help us with the above 2 issues? They are worked around in the driver, so the tests pass below, but we don't want such workarounds in driver code.

Best regards,
Tomasz

Quoted 3,147 lines

==============
Introduction
==============

Digital Image Processing (DIP) unit can accept the tuning parameters and adjust the image content in Mediatek ISP system. Furthermore, it performs demosaicing and noise reduction on the image to support the advanced camera features of the application. The DIP driver also support image format conversion, resizing and rotation with its hardware path.

The driver is implemented with V4L2 and media controller framework. We have the following entities describing the DIP path. Since a DIP frame has multiple buffers, the driver uses Request API to control the multiple buffer's enqueue flow.

1. Meta (output video device): connects to DIP sub device. It accepts the input tuning buffer from userspace. The metadata interface used currently is only a temporary solution to kick off driver development and is not ready for reviewed yet.

2. RAW (output video device): connects to DIP sub device. It accepts input image buffer from userspace.

3. DIP (sub device): connects to MDP-0 and MDP-1. When processing an image, DIP hardware support multiple output images with different size and format so it needs two capture video devices to return the streaming data to the user.

4. MDP-0 (capture video device): return the processed image data.

5. MDP-1 (capture video device): return the processed image data, the image size and format can be different from the ones of MDP-0.

The overall file structure of the DIP driver is as following:

* mtk_dip-v4l2.c: implements DIP platform driver, V4L2 and vb2 operations.

* mtk_dip-sys.c: implements the hardware job handling flow including the part of interaction with the SCP and MDP.

* mtk_dip-dev.c: implements dip pipe utilities. DIP driver supports 3 software pipes (preview, capture and reprocessing) at the same time. All the pipes share the same DIP hardware to process the images.

==================
Changes in v2
==================
* mtk_dip-smem.c
1. Removed mtk_dip-smem.c and the custom code of SCP and DIP's share memory operation, and uses SCP device as the allocation device instead. (SCP creates the shared DMA pool of DMA buffers and can hook to DMA mapping APIs)

* mtk_dip-ctrl.c
1. Merged mtk_dip-ctrl.c into mtk_dip-v4l2.c since we only have a HW ctrl. (V4L2_CID_ROTATE)

* mtk_dip-sys.c:
1. Removed struct mtk_dip_hw_work, mtk_dip_hw_submit_work and the related memory management flow (use mtk_dip_request instead)

2. Uses workqueue mdp_wq instead of dip_runner_thread kthread to simplify the design

3. Removed dip_gcejoblist and use mtk_dip_job_info list instead

4. Removed framejob and mtk_dip_hw_mdpcb_work and the related alloc and free since it already embedded in the new struct mtk_dip_request

5. Integrated struct mtk_dip_hw_user_id and struct with mtk_dip_pipe, and removed dip_hw->dip_useridlist

6. Pass mtk_dip_request to mdp_cmdq_sendtask() as cb data

7. Use spinlock instead of mutex as struct mtk_dip_hw_queue's queuelock so that we can use direct function call instead of mdpcb_workqueue works

8. Removed dip_send() and use scp_ipi_send() directly

9. Removed composing_wq and the related macro, we use semaphore instead

10. Use array to keep constant number of working buffer pointers in dip_hw instead a list

11. Allocates the SCP working buffer before scheduling the job into SCP. When there is no free buffer, we hold the job until there are any working buffers available.

12. Re-designed the request handling flow. We implement mtk_dip_vb2_request_validate() to collect the job data including buffers and check if we got minimum required buffers. mtk_dip_pipe_try_enqueue() is added to simplify the job scheduling flow in both streamon() case with buffers already in queues and .buf_queue() during streaming. In streamon() function, we call mtk_dip_pipe_try_enqueue() to execute as many as jobs in the pending list

13. Fixed the issue about passing the kernel pointer to SCP

14. Re-designed mtk_dip_hw_flush_by_id() to remove the unnecessary loop and interrupt abort

15. Added codes to wait for pending jobs already in SCP during suspend flow. In mtk_dip_suspend() and dip_submit_worker(), we get mutex hw_op_lock before read and update the SCP job number to avoid the race condition when system suspend happens and DIP driver is sending ipi command to trigger the firmware job.

16. Removed struct mtk_dip_hw's dip_user_cnt and dip_state, and uses dip_stream_cnt instead

17. Uses dma_alloc_coherent() instead of scp_get_reserve_mem_phys()/ scp_get_reserve_mem_size() to allocate DIP working buffers

* mtk_dip-v4l2.c:
1. Call mtk_dip_hw_stream{on, off} in mtk_dip_subdev_s_stream() directly instead mtk_dip_pipe_stream_on and mtk_dip_pipe_stream_off

2. Removed buf usage HW ctrl and uses dma port configured in node's description instead

3. Moved platform driver ops to mtk_dip-v4l2.c (which includes the V4L2/media ops implementation)

4. Moved hardware related operation in sub-device open/close to streamon()/streamoff() ops

5. Uses dip_pipe->lock to synchronize streamon, streamoff and link setup flow

6. Added a counter dip_pipe->cnt_nodes_not_streaming to check if the pipe can be streamon or not (instead of the mtk_dip_all_nodes_streaming())

7. Moved the buffer size checking code from .queue_setup() to .buf_prepare()

8. Added multiple-plane formats support

9. Created interfaces and interface links for input and output video nodes

10. Added error handling and improved the cleanup codes in mtk_dip_dev_v4l2_init() and mtk_dip_pipe_v4l2_register()

11. Added mtk_dip_video_device_v4l2_register() to simplify mtk_dip_pipe_v4l2_register()'s implementation

12. Added mtk_dip_video_device.flags instead of enable, dynamic and immutable fields in struct mtk_dip_video_device.

13. Added a list to mtk_dip_video_device to hold queued buffers instead of accessing vbq.bufs directly.

14. Merged struct mtk_dip_dev_meta_format and struct mtk_dip_dev_mdp_format into struct mtk_dip_dev_format

15. Changed the try_fmt() implementation. If the pixelformat is not supported, we use the default one but keep the valid fields.

16. Moved the mtk_dip_hw_connect()/mtk_dip_hw_disconnect() call from mtk_dip_subdev_s_stream() to mtk_dip_hw_streamon()/mtk_dip_hw_streamoff() and removed some redundant check about stream count.

17. Re-implemented dev_pm_ops

* mtk_dip-dev.c:
1. Added mtk_dip_request extending media_request and embedded pipe_job_info in it.

2. Removed mtk_dip_pipe_stream{on, off} and move the content to mtk_dip_hw_stream{on, off}

3. Removed fill_ipi_img_param() and extends fill_ipi_img_param_mp() so that it can support both multiple non-contiguous and multiple contiguous planes buffers.

4. Added mtk_dip_pipe_get_stride() to reduce redundant codes.

5. Removed call_mtk_dip_pipe_finish() and merged its content into its callers

6. Removed unused ctrl handler from struct mtk_dip_pipe.

==================
Changes in v1
==================
1. Uses Request API instead of DIP's buffer collection design

2. Removed unnecessary abstraction structurally, including mtk_dip_ctx and related ops

3. Removed the dip_smem node from device tree

4. Improved the dip_work list's management flow

5. Fixed the common issues Tomasz commented on Mediatek ISP Pass 1's RFC v0 patch series

==================
Dependent patch
==================

DIP driver depends on MDP 3 driver and SCP driver. The patches are as following:

[1]. support mdp3 on mt8183 platform
https://patchwork.kernel.org/cover/10945585/

[2]. Add support for mt8183 SCP
https://patchwork.kernel.org/cover/11027245/

==================
Compliance test
==================

* Test command: v4l2-compliance -m /dev/media0
* test output:

v4l2-compliance SHA: not available, 32 bits

Compliance test for camera-dip device /dev/media0:

Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Required ioctls:
test MEDIA_IOC_DEVICE_INFO: OK

Allow for multiple opens:
test second /dev/media0 open: OK
test MEDIA_IOC_DEVICE_INFO: OK
test for unlimited opens: OK

Media Controller ioctls:
test MEDIA_IOC_G_TOPOLOGY: OK
Entities: 15 Interfaces: 27 Pads: 24 Links: 39 test MEDIA_IOC_ENUM_ENTITIES/LINKS: OK test MEDIA_IOC_SETUP_LINK: OK

Total for camera-dip device /dev/media0: 7, Succeeded: 7, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for camera-dip device /dev/v4l-subdev0:

Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000006
Type : V4L Sub-Device
Entity Info:

        ID               : 0x00000001 (1)
        Name             : MTK-ISP-DIP-V4L2
        Function         : Video Pixel Formatter
        Pad 0x01000002   : 0: Sink
          Link 0x0200000c: from remote pad 0x1000009 of entity 'MTK-ISP-DIP-V4L2 Raw Input': Data, Enabled
        Pad 0x01000003   : 1: Sink
          Link 0x02000014: from remote pad 0x1000011 of entity 'MTK-ISP-DIP-V4L2 Tuning': Data
        Pad 0x01000004   : 2: Source
          Link 0x0200001c: to remote pad 0x1000019 of entity 'MTK-ISP-DIP-V4L2 MDP0': Data, Enabled, Dynamic
        Pad 0x01000005   : 3: Source
          Link 0x02000024: to remote pad 0x1000021 of entity 'MTK-ISP-DIP-V4L2 MDP1': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK

Allow for multiple opens:
test second /dev/v4l-subdev0 open: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Sub-Device ioctls (Sink Pad 0):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Sink Pad 1):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 2):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 3):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) test VIDIOC_QUERYCTRL: OK (Not Supported)
test VIDIOC_G/S_CTRL: OK (Not Supported)
test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported) test VIDIOC_G/S_PARM: OK (Not Supported)
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK (Not Supported)
test VIDIOC_TRY_FMT: OK (Not Supported)
test VIDIOC_S_FMT: OK (Not Supported)
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported) test VIDIOC_EXPBUF: OK (Not Supported)
test Requests: OK (Not Supported)

Total for camera-dip device /dev/v4l-subdev0: 69, Succeeded: 69, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video0:

Driver Info:

        Driver name      : MTK-ISP-DIP-V4L
        Card type        : MTK-ISP-DIP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x0300000a
Type : V4L Video
Entity Info:

        ID               : 0x00000008 (8)
        Name             : MTK-ISP-DIP-V4L2 Raw Input
        Function         : V4L2 I/O
        Pad 0x01000009   : 0: Source
          Link 0x0200000c: to remote pad 0x1000002 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video0 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video0:

Driver Info:

        Driver name      : MTK-ISP-DIP-V4L
        Card type        : MTK-ISP-DIP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x0300000a
Type : V4L Video
Entity Info:

        ID               : 0x00000008 (8)
        Name             : MTK-ISP-DIP-V4L2 Raw Input
        Function         : V4L2 I/O
        Pad 0x01000009   : 0: Source
          Link 0x0200000c: to remote pad 0x1000002 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video0 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video1:

Driver Info:

        Driver name      : MTK-ISP-DIP-V4L
        Card type        : MTK-ISP-DIP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000012
Type : V4L Video
Entity Info:

        ID               : 0x00000010 (16)
        Name             : MTK-ISP-DIP-V4L2 Tuning
        Function         : V4L2 I/O
        Pad 0x01000011   : 0: Source
          Link 0x02000014: to remote pad 0x1000003 of entity 'MTK-ISP-DIP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video1 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video1: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video1:

Driver Info:

        Driver name      : MTK-ISP-DIP-V4L
        Card type        : MTK-ISP-DIP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000012
Type : V4L Video
Entity Info:

        ID               : 0x00000010 (16)
        Name             : MTK-ISP-DIP-V4L2 Tuning
        Function         : V4L2 I/O
        Pad 0x01000011   : 0: Source
          Link 0x02000014: to remote pad 0x1000003 of entity 'MTK-ISP-DIP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video1 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video1: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video2:

Driver Info:

        Driver name      : MTK-ISP-DIP-V4L
        Card type        : MTK-ISP-DIP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x0300001a
Type : V4L Video
Entity Info:

        ID               : 0x00000018 (24)
        Name             : MTK-ISP-DIP-V4L2 MDP0
        Function         : V4L2 I/O
        Pad 0x01000019   : 0: Sink
          Link 0x0200001c: from remote pad 0x1000004 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video2 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video2: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video2:

Driver Info:

        Driver name      : MTK-ISP-DIP-V4L
        Card type        : MTK-ISP-DIP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x0300001a
Type : V4L Video
Entity Info:

        ID               : 0x00000018 (24)
        Name             : MTK-ISP-DIP-V4L2 MDP0
        Function         : V4L2 I/O
        Pad 0x01000019   : 0: Sink
          Link 0x0200001c: from remote pad 0x1000004 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video2 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video2: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video3:

Driver Info:

        Driver name      : MTK-ISP-DIP-V4L
        Card type        : MTK-ISP-DIP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000022
Type : V4L Video
Entity Info:

        ID               : 0x00000020 (32)
        Name             : MTK-ISP-DIP-V4L2 MDP1
        Function         : V4L2 I/O
        Pad 0x01000021   : 0: Sink
          Link 0x02000024: from remote pad 0x1000005 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video3 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video3: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-V4L device /dev/video3:

Driver Info:

        Driver name      : MTK-ISP-DIP-V4L
        Card type        : MTK-ISP-DIP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000022
Type : V4L Video
Entity Info:

        ID               : 0x00000020 (32)
        Name             : MTK-ISP-DIP-V4L2 MDP1
        Function         : V4L2 I/O
        Pad 0x01000021   : 0: Sink
          Link 0x02000024: from remote pad 0x1000005 of entity 'MTK-ISP-DIP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video3 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-V4L device /dev/video3: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for camera-dip device /dev/v4l-subdev1:

Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x0300002d
Type : V4L Sub-Device
Entity Info:

        ID               : 0x00000028 (40)
        Name             : MTK-ISP-DIP-CAP-V4L2
        Function         : Video Pixel Formatter
        Pad 0x01000029   : 0: Sink
          Link 0x02000033: from remote pad 0x1000030 of entity 'MTK-ISP-DIP-CAP-V4L2 Raw Input': Data, Enabled
        Pad 0x0100002a   : 1: Sink
          Link 0x0200003b: from remote pad 0x1000038 of entity 'MTK-ISP-DIP-CAP-V4L2 Tuning': Data
        Pad 0x0100002b   : 2: Source
          Link 0x02000043: to remote pad 0x1000040 of entity 'MTK-ISP-DIP-CAP-V4L2 MDP0': Data, Enabled, Dynamic
        Pad 0x0100002c   : 3: Source
          Link 0x0200004b: to remote pad 0x1000048 of entity 'MTK-ISP-DIP-CAP-V4L2 MDP1': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK

Allow for multiple opens:
test second /dev/v4l-subdev1 open: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Sub-Device ioctls (Sink Pad 0):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Sink Pad 1):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 2):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 3):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) test VIDIOC_QUERYCTRL: OK (Not Supported)
test VIDIOC_G/S_CTRL: OK (Not Supported)
test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported) test VIDIOC_G/S_PARM: OK (Not Supported)
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK (Not Supported)
test VIDIOC_TRY_FMT: OK (Not Supported)
test VIDIOC_S_FMT: OK (Not Supported)
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported) test VIDIOC_EXPBUF: OK (Not Supported)
test Requests: OK (Not Supported)

Total for camera-dip device /dev/v4l-subdev1: 69, Succeeded: 69, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video4:

Driver Info:

        Driver name      : MTK-ISP-DIP-CAP
        Card type        : MTK-ISP-DIP-CAP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000031
Type : V4L Video
Entity Info:

        ID               : 0x0000002f (47)
        Name             : MTK-ISP-DIP-CAP-V4L2 Raw Input
        Function         : V4L2 I/O
        Pad 0x01000030   : 0: Source
          Link 0x02000033: to remote pad 0x1000029 of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video4 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video4: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video4:

Driver Info:

        Driver name      : MTK-ISP-DIP-CAP
        Card type        : MTK-ISP-DIP-CAP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000031
Type : V4L Video
Entity Info:

        ID               : 0x0000002f (47)
        Name             : MTK-ISP-DIP-CAP-V4L2 Raw Input
        Function         : V4L2 I/O
        Pad 0x01000030   : 0: Source
          Link 0x02000033: to remote pad 0x1000029 of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video4 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video4: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video5:

Driver Info:

        Driver name      : MTK-ISP-DIP-CAP
        Card type        : MTK-ISP-DIP-CAP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000039
Type : V4L Video
Entity Info:

        ID               : 0x00000037 (55)
        Name             : MTK-ISP-DIP-CAP-V4L2 Tuning
        Function         : V4L2 I/O
        Pad 0x01000038   : 0: Source
          Link 0x0200003b: to remote pad 0x100002a of entity 'MTK-ISP-DIP-CAP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video5 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video5: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video5:

Driver Info:

        Driver name      : MTK-ISP-DIP-CAP
        Card type        : MTK-ISP-DIP-CAP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000039
Type : V4L Video
Entity Info:

        ID               : 0x00000037 (55)
        Name             : MTK-ISP-DIP-CAP-V4L2 Tuning
        Function         : V4L2 I/O
        Pad 0x01000038   : 0: Source
          Link 0x0200003b: to remote pad 0x100002a of entity 'MTK-ISP-DIP-CAP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video5 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video5: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video6:

Driver Info:

        Driver name      : MTK-ISP-DIP-CAP
        Card type        : MTK-ISP-DIP-CAP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000041
Type : V4L Video
Entity Info:

        ID               : 0x0000003f (63)
        Name             : MTK-ISP-DIP-CAP-V4L2 MDP0
        Function         : V4L2 I/O
        Pad 0x01000040   : 0: Sink
          Link 0x02000043: from remote pad 0x100002b of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video6 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video6: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video6:

Driver Info:

        Driver name      : MTK-ISP-DIP-CAP
        Card type        : MTK-ISP-DIP-CAP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000041
Type : V4L Video
Entity Info:

        ID               : 0x0000003f (63)
        Name             : MTK-ISP-DIP-CAP-V4L2 MDP0
        Function         : V4L2 I/O
        Pad 0x01000040   : 0: Sink
          Link 0x02000043: from remote pad 0x100002b of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video6 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video6: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video7:

Driver Info:

        Driver name      : MTK-ISP-DIP-CAP
        Card type        : MTK-ISP-DIP-CAP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000049
Type : V4L Video
Entity Info:

        ID               : 0x00000047 (71)
        Name             : MTK-ISP-DIP-CAP-V4L2 MDP1
        Function         : V4L2 I/O
        Pad 0x01000048   : 0: Sink
          Link 0x0200004b: from remote pad 0x100002c of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video7 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video7: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-CAP device /dev/video7:

Driver Info:

        Driver name      : MTK-ISP-DIP-CAP
        Card type        : MTK-ISP-DIP-CAP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000049
Type : V4L Video
Entity Info:

        ID               : 0x00000047 (71)
        Name             : MTK-ISP-DIP-CAP-V4L2 MDP1
        Function         : V4L2 I/O
        Pad 0x01000048   : 0: Sink
          Link 0x0200004b: from remote pad 0x100002c of entity 'MTK-ISP-DIP-CAP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video7 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-CAP device /dev/video7: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for camera-dip device /dev/v4l-subdev2:

Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000054
Type : V4L Sub-Device
Entity Info:

        ID               : 0x0000004f (79)
        Name             : MTK-ISP-DIP-REP-V4L2
        Function         : Video Pixel Formatter
        Pad 0x01000050   : 0: Sink
          Link 0x0200005a: from remote pad 0x1000057 of entity 'MTK-ISP-DIP-REP-V4L2 Raw Input': Data, Enabled
        Pad 0x01000051   : 1: Sink
          Link 0x02000062: from remote pad 0x100005f of entity 'MTK-ISP-DIP-REP-V4L2 Tuning': Data
        Pad 0x01000052   : 2: Source
          Link 0x0200006a: to remote pad 0x1000067 of entity 'MTK-ISP-DIP-REP-V4L2 MDP0': Data, Enabled, Dynamic
        Pad 0x01000053   : 3: Source
          Link 0x02000072: to remote pad 0x100006f of entity 'MTK-ISP-DIP-REP-V4L2 MDP1': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK

Allow for multiple opens:
test second /dev/v4l-subdev2 open: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Sub-Device ioctls (Sink Pad 0):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Sink Pad 1):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 2):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Sub-Device ioctls (Source Pad 3):
test Try VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Try VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Try VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test Active VIDIOC_SUBDEV_ENUM_MBUS_CODE/FRAME_SIZE/FRAME_INTERVAL: OK (Not Supported) test Active VIDIOC_SUBDEV_G/S_FMT: OK (Not Supported)
test Active VIDIOC_SUBDEV_G/S_SELECTION/CROP: OK (Not Supported)
test VIDIOC_SUBDEV_G/S_FRAME_INTERVAL: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK (Not Supported) test VIDIOC_QUERYCTRL: OK (Not Supported)
test VIDIOC_G/S_CTRL: OK (Not Supported)
test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported) test VIDIOC_G/S_PARM: OK (Not Supported)
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK (Not Supported)
test VIDIOC_TRY_FMT: OK (Not Supported)
test VIDIOC_S_FMT: OK (Not Supported)
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported) test VIDIOC_EXPBUF: OK (Not Supported)
test Requests: OK (Not Supported)

Total for camera-dip device /dev/v4l-subdev2: 69, Succeeded: 69, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video8:

Driver Info:

        Driver name      : MTK-ISP-DIP-REP
        Card type        : MTK-ISP-DIP-REP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000058
Type : V4L Video
Entity Info:

        ID               : 0x00000056 (86)
        Name             : MTK-ISP-DIP-REP-V4L2 Raw Input
        Function         : V4L2 I/O
        Pad 0x01000057   : 0: Source
          Link 0x0200005a: to remote pad 0x1000050 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video8 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video8: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video8:

Driver Info:

        Driver name      : MTK-ISP-DIP-REP
        Card type        : MTK-ISP-DIP-REP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84202000

Video Output Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04202000
Video Output Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000058
Type : V4L Video
Entity Info:

        ID               : 0x00000056 (86)
        Name             : MTK-ISP-DIP-REP-V4L2 Raw Input
        Function         : V4L2 I/O
        Pad 0x01000057   : 0: Source
          Link 0x0200005a: to remote pad 0x1000050 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video8 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video8: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video9:

Driver Info:

        Driver name      : MTK-ISP-DIP-REP
        Card type        : MTK-ISP-DIP-REP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000060
Type : V4L Video
Entity Info:

        ID               : 0x0000005e (94)
        Name             : MTK-ISP-DIP-REP-V4L2 Tuning
        Function         : V4L2 I/O
        Pad 0x0100005f   : 0: Source
          Link 0x02000062: to remote pad 0x1000051 of entity 'MTK-ISP-DIP-REP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video9 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video9: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video9:

Driver Info:

        Driver name      : MTK-ISP-DIP-REP
        Card type        : MTK-ISP-DIP-REP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x8c200000

Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x0c200000
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000060
Type : V4L Video
Entity Info:

        ID               : 0x0000005e (94)
        Name             : MTK-ISP-DIP-REP-V4L2 Tuning
        Function         : V4L2 I/O
        Pad 0x0100005f   : 0: Source
          Link 0x02000062: to remote pad 0x1000051 of entity 'MTK-ISP-DIP-REP-V4L2': Data

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video9 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video9: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video10:

Driver Info:

        Driver name      : MTK-ISP-DIP-REP
        Card type        : MTK-ISP-DIP-REP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000068
Type : V4L Video
Entity Info:

        ID               : 0x00000066 (102)
        Name             : MTK-ISP-DIP-REP-V4L2 MDP0
        Function         : V4L2 I/O
        Pad 0x01000067   : 0: Sink
          Link 0x0200006a: from remote pad 0x1000052 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video10 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video10: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video10:

Driver Info:

        Driver name      : MTK-ISP-DIP-REP
        Card type        : MTK-ISP-DIP-REP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000068
Type : V4L Video
Entity Info:

        ID               : 0x00000066 (102)
        Name             : MTK-ISP-DIP-REP-V4L2 MDP0
        Function         : V4L2 I/O
        Pad 0x01000067   : 0: Sink
          Link 0x0200006a: from remote pad 0x1000052 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video10 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 2 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video10: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video11:

Driver Info:

        Driver name      : MTK-ISP-DIP-REP
        Card type        : MTK-ISP-DIP-REP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000070
Type : V4L Video
Entity Info:

        ID               : 0x0000006e (110)
        Name             : MTK-ISP-DIP-REP-V4L2 MDP1
        Function         : V4L2 I/O
        Pad 0x0100006f   : 0: Sink
          Link 0x02000072: from remote pad 0x1000053 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video11 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video11: 45, Succeeded: 45, Failed: 0, Warnings: 0
--------------------------------------------------------------------------------
Compliance test for MTK-ISP-DIP-REP device /dev/video11:

Driver Info:

        Driver name      : MTK-ISP-DIP-REP
        Card type        : MTK-ISP-DIP-REP-V4L2
        Bus info         : platform:15022000.dip
        Driver version   : 4.19.56
        Capabilities     : 0x84201000

Video Capture Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04201000
Video Capture Multiplanar
Streaming
Extended Pix Format
Media Driver Info:

        Driver name      : camera-dip
        Model            : MTK-ISP-DIP-V4L2
        Serial           :
        Bus info         : platform:15022000.dip
        Media version    : 4.19.56
        Hardware revision: 0x00000000 (0)
        Driver version   : 4.19.56

Interface Info:
ID : 0x03000070
Type : V4L Video
Entity Info:

        ID               : 0x0000006e (110)
        Name             : MTK-ISP-DIP-REP-V4L2 MDP1
        Function         : V4L2 I/O
        Pad 0x0100006f   : 0: Sink
          Link 0x02000072: from remote pad 0x1000053 of entity 'MTK-ISP-DIP-REP-V4L2': Data, Enabled, Dynamic

Required ioctls:
test MC information (see 'Media Driver Info' above): OK test VIDIOC_QUERYCAP: OK

Allow for multiple opens:
test second /dev/video11 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK
test Requests: OK

Total for MTK-ISP-DIP-REP device /dev/video11: 45, Succeeded: 45, Failed: 0, Warnings: 0

Grand Total for camera-dip device /dev/media0: 1294, Succeeded: 1294, Failed: 0, Warnings: 0

Frederic Chen (6):
dt-bindings: mt8183: Added DIP dt-bindings
dts: arm64: mt8183: Add DIP nodes
media: platform: Add Mediatek DIP driver KConfig
platform: mtk-isp: Add Mediatek DIP driver remoteproc/mediatek: add SCP's shared dma pool support for mt8183
media: platform: mtk-mdp3: Added struct tuning_addr

 .../bindings/media/mediatek,mt8183-dip.txt    |   40 +
 arch/arm64/boot/dts/mediatek/mt8183.dtsi      |   16 +
 drivers/media/platform/Kconfig                |    2 +
 drivers/media/platform/mtk-isp/Kconfig        |   21 +
 drivers/media/platform/mtk-isp/Makefile       |   18 +
 .../media/platform/mtk-isp/isp_50/Makefile    |    4 +
 .../platform/mtk-isp/isp_50/dip/Makefile      |   18 +
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.c |  769 +++++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-dev.h |  337 ++++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-hw.h  |  155 ++
 .../platform/mtk-isp/isp_50/dip/mtk_dip-sys.c |  794 ++++++++
 .../mtk-isp/isp_50/dip/mtk_dip-v4l2.c         | 1786 +++++++++++++++++
 drivers/media/platform/mtk-mdp3/mtk-img-ipi.h |    8 +-
 drivers/remoteproc/mtk_scp.c                  |   54 +-
 14 files changed, 4000 insertions(+), 22 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt
 create mode 100644 drivers/media/platform/mtk-isp/Kconfig
 create mode 100644 drivers/media/platform/mtk-isp/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/Makefile
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-dev.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-hw.h
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c
 create mode 100644 drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-v4l2.c

--
2.18.0

#15 lore raw

RFC PATCH v2 5/6 remoteproc/mediatek: add SCP's shared dma pool support for mt8183

In reply to frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]

From: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>

This patch uses of_reserved_mem_device_init_by_idx() to hook the scp device to DMA mapping API to provide a shared dma pool of SCP DMA buffers for SCP's client such as DIP and ISP Pass 1 drivers.

---
 drivers/remoteproc/mtk_scp.c | 54 ++++++++++++++++++++++--------------
 1 file changed, 33 insertions(+), 21 deletions(-)
drivers/remoteproc/mtk_scp.c +33 -21
index 4c093dec52b9..0cffe4b63dba 100644
@@ -4,12 +4,14 @@
 
 #include <asm/barrier.h>
 #include <linux/clk.h>
+#include <linux/dma-mapping.h>
 #include <linux/err.h>
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/of_address.h>
 #include <linux/of_platform.h>
+#include <linux/of_reserved_mem.h>
 #include <linux/platform_data/mtk_scp.h>
 #include <linux/platform_device.h>
 #include <linux/remoteproc.h>
@@ -487,29 +489,29 @@ EXPORT_SYMBOL_GPL(scp_get_reserve_mem_size);
 
 static int scp_map_memory_region(struct mtk_scp *scp)
 {
-	struct device_node *node;
-	struct resource r;
-	int ret;
+	int ret, id;
 
-	node = of_parse_phandle(scp->dev->of_node, "memory-region", 0);
-	if (!node) {
-		dev_err(scp->dev, "no memory-region specified\n");
-		return -EINVAL;
+	ret = of_reserved_mem_device_init_by_idx(scp->dev, scp->dev->of_node,
+						 0);
+	if (ret) {
+		dev_err(scp->dev,
+			"%s:of_reserved_mem_device_init_by_idx(0) failed:(%d)",
+			__func__, ret);
+		return -ENOMEM;
 	}
 
-	ret = of_address_to_resource(node, 0, &r);
-	if (ret)
-		return ret;
+	/* Pre-allocate the working buffers */
+	scp->dram_size = MAX_CODE_SIZE;
+	for (id = 0; id < SCP_NUMS_MEM_ID; id++)
+		scp->dram_size += scp_reserve_mblock[id].size;
 
-	scp->phys_addr = r.start;
-	scp->dram_size = resource_size(&r);
-	scp->cpu_addr =
-		devm_ioremap_wc(scp->dev, scp->phys_addr, scp->dram_size);
+	scp->cpu_addr = dma_alloc_coherent(scp->dev, scp->dram_size,
+					   &scp->phys_addr, GFP_KERNEL);
 
 	if (!scp->cpu_addr) {
-		dev_err(scp->dev, "unable to map memory region: %pa+%zx\n",
-			&r.start, scp->dram_size);
-		return -EBUSY;
+		dev_err(scp->dev, "unable to pre-allocate memory for SCP: %zx\n",
+			scp->dram_size);
+		return -ENOMEM;
 	}
 
 #if SCP_RESERVED_MEM
@@ -519,6 +521,13 @@ static int scp_map_memory_region(struct mtk_scp *scp)
 	return 0;
 }
 
+static void scp_unmap_memory_region(struct mtk_scp *scp)
+{
+	dma_free_coherent(scp->dev, scp->dram_size, scp->cpu_addr,
+			  scp->phys_addr);
+	of_reserved_mem_device_release(scp->dev);
+}
+
 static struct mtk_rpmsg_info mtk_scp_rpmsg_info = {
 	.send_ipi = scp_ipi_send,
 	.register_ipi = scp_ipi_register,
@@ -594,20 +603,20 @@ static int scp_probe(struct platform_device *pdev)
 	if (IS_ERR(scp->clk)) {
 		dev_err(dev, "Failed to get clock\n");
 		ret = PTR_ERR(scp->clk);
-		goto free_rproc;
+		goto release_dev_mem;
 	}
 
 	ret = clk_prepare_enable(scp->clk);
 	if (ret) {
 		dev_err(dev, "failed to enable clocks\n");
-		goto free_rproc;
+		goto release_dev_mem;
 	}
 
 	ret = scp_ipi_init(scp);
 	clk_disable_unprepare(scp->clk);
 	if (ret) {
 		dev_err(dev, "Failed to init ipi\n");
-		goto free_rproc;
+		goto release_dev_mem;
 	}
 
 	/* register SCP initialization IPI */
@@ -617,7 +626,7 @@ static int scp_probe(struct platform_device *pdev)
 			       scp);
 	if (ret) {
 		dev_err(dev, "Failed to register IPI_SCP_INIT\n");
-		goto free_rproc;
+		goto release_dev_mem;
 	}
 
 	mutex_init(&scp->lock);
@@ -645,6 +654,8 @@ static int scp_probe(struct platform_device *pdev)
 remove_subdev:
 	scp_remove_rpmsg_subdev(scp);
 	mutex_destroy(&scp->lock);
+release_dev_mem:
+	scp_unmap_memory_region(scp);
 free_rproc:
 	rproc_free(rproc);
 
@@ -658,6 +669,7 @@ static int scp_remove(struct platform_device *pdev)
 	scp_remove_rpmsg_subdev(scp);
 	rproc_del(scp->rproc);
 	rproc_free(scp->rproc);
+	scp_unmap_memory_region(scp);
 
 	return 0;
 }
Signature · 1 line
2.18.0
#16 lore raw

RFC PATCH v2 6/6 media: platform: mtk-mdp3: Add struct tuning_addr to identify user tuning data

In reply to frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]

From: Frederic Chen <frederic.chen-NuS5LvNUpcJWk0Htik3J/[email protected]>

We added a struct tuning_addr which contains a field "present" so that the driver can tell the firmware if we have user tuning dataor not.

---
 drivers/media/platform/mtk-mdp3/mtk-img-ipi.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/media/platform/mtk-mdp3/mtk-img-ipi.h +7 -1
index 9fabe7e8b71d..0944fe911d97 100644
@@ -38,6 +38,12 @@ struct img_addr {
 	u32	iova;	/* Used by IOMMU HW access */
 } __attribute__ ((__packed__));
 
+struct tuning_addr {
+	u32	present;
+	u32	pa;	/* Used by CM4 access */
+	u32	iova;	/* Used by IOMMU HW access */
+} __attribute__ ((__packed__));
+
 struct img_sw_addr {
 	u64	va;	/* Used by APMCU access */
 	u32	pa;	/* Used by CM4 access */
@@ -105,7 +111,7 @@ struct img_ipi_frameparam {
 	u64		drv_data;
 	struct img_input	inputs[IMG_MAX_HW_INPUTS];
 	struct img_output	outputs[IMG_MAX_HW_OUTPUTS];
-	struct img_addr		tuning_data;
+	struct tuning_addr	tuning_data;
 	struct img_addr		subfrm_data;
 	struct img_sw_addr	config_data;
 	struct img_sw_addr  self_data;
Signature · 1 line
2.18.0