ath10k: fix latency issue for QCA988x
PATCH 1/1 ath10k: fix latency issue for QCA988x
Bad latency is found on QCA988x, the issue was introduced by commit 4504f0e5b571 ("ath10k: sdio: workaround firmware UART pin configuration bug"). If uart_pin_workaround is false, this change will set uart pin even if uart_print is false.
Tested HW: QCA9880
Tested FW: 10.2.4-1.0-00037
--- drivers/net/wireless/ath/ath10k/core.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/net/wireless/ath/ath10k/core.c +9 -6
@@ -2118,12 +2118,15 @@ static int ath10k_init_uart(struct ath10k *ar)return ret; } -if (!uart_print && ar->hw_params.uart_pin_workaround) { - ret =ath10k_bmi_write32 (ar, hi_dbg_uart_txpin, - ar->hw_params.uart_pin); -if (ret) { -ath10k_warn (ar,"failed to set UART TX pin: %d" , ret); -return ret; +if (!uart_print) { +if (ar->hw_params.uart_pin_workaround) { + ret =ath10k_bmi_write32 (ar, hi_dbg_uart_txpin, + ar->hw_params.uart_pin); +if (ret) { +ath10k_warn (ar,"failed to set UART TX pin: %d" , + ret); +return ret; + } }return 0 ;
Signature · 7 lines
1.9.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 11 lines · Miaoqing Pan
Bad latency is found on QCA988x, the issue was introduced by commit
4504f0e5b571("ath10k: sdio: workaround firmware UART pin configuration bug"). Ifuart_pin_workaroundis false, this change will set uart pin even ifuart_printis false.Tested HW: QCA9880
Tested FW: 10.2.4-1.0-00037Fixes 4504f0e5b571 ("ath10k: sdio: workaround firmware UART pin configuration bug")Signed-off-by Miaoqing Pan <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
1340cc631bd0 ath10k: fix latency issue for QCA988x
Signature · 9 lines
https://patchwork.kernel.org/patch/11122193/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 11 lines · Miaoqing Pan
Bad latency is found on QCA988x, the issue was introduced by commit
4504f0e5b571("ath10k: sdio: workaround firmware UART pin configuration bug"). Ifuart_pin_workaroundis false, this change will set uart pin even ifuart_printis false.Tested HW: QCA9880
Tested FW: 10.2.4-1.0-00037Fixes 4504f0e5b571 ("ath10k: sdio: workaround firmware UART pin configuration bug")Signed-off-by Miaoqing Pan <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
1340cc631bd0 ath10k: fix latency issue for QCA988x
Signature · 3 lines
https://patchwork.kernel.org/patch/11122193/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches