Runtime PM support for MT8183 mcucfg clock provider
Subsystems (3)
cover Runtime PM support for MT8183 mcucfg clock provider
This series is based on v5.3-rc1 and Mediatek MT8183 scpsys support v7[1]. Since Runtime PM is supported in Common Clock Framework which keeps clock controller's power domain enabled to ensure clock status accessing correctly.
[1] https://patchwork.kernel.org/cover/11118371/
---
Weiyi Lu (3):
clk: mediatek: Register clock gate with device
clk: mediatek: Runtime PM support for MT8183 mcucfg clock provider
arm64: dts: Add power-domains properity to mfgcfg
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + drivers/clk/mediatek/clk-gate.c | 5 +++-- drivers/clk/mediatek/clk-gate.h | 3 ++- drivers/clk/mediatek/clk-mt8183-mfgcfg.c | 7 +++++-- drivers/clk/mediatek/clk-mtk.c | 16 +++++++++++++--- drivers/clk/mediatek/clk-mtk.h | 5 +++++ 6 files changed, 29 insertions(+), 8 deletions(-)
PATCH RESEND 1/3 clk: mediatek: Register clock gate with device
Allow those clocks under a power domain to do the runtime pm operation by forwarding the struct device pointer from clock provider.
--- drivers/clk/mediatek/clk-gate.c | 5 +++-- drivers/clk/mediatek/clk-gate.h | 3 ++- drivers/clk/mediatek/clk-mtk.c | 16 +++++++++++++--- drivers/clk/mediatek/clk-mtk.h | 5 +++++ 4 files changed, 23 insertions(+), 6 deletions(-)
drivers/clk/mediatek/clk-gate.c +3 -2
@@ -150,7 +150,8 @@ struct clk *mtk_clk_register_gate(int sta_ofs, u8 bit, const struct clk_ops *ops, - unsigned long flags) + unsigned long flags, + struct device *dev) { struct mtk_clk_gate *cg;struct clk *clk;
@@ -174,7 +175,7 @@ struct clk *mtk_clk_register_gate( cg->hw.init = &init; - clk =clk_register (NULL , &cg->hw); + clk =clk_register (dev, &cg->hw);if (IS_ERR (clk))kfree (cg);
drivers/clk/mediatek/clk-gate.h +2 -1
@@ -40,7 +40,8 @@ struct clk *mtk_clk_register_gate(int sta_ofs, u8 bit, const struct clk_ops *ops, - unsigned long flags); + unsigned long flags, + struct device *dev);#define GATE_MTK_FLAGS (_id, _name, _parent, _regs, _shift, \ _ops, _flags) { \
drivers/clk/mediatek/clk-mtk.c +13 -3
@@ -12,6 +12,7 @@#include <linux/delay.h> #include <linux/clkdev.h> #include <linux/mfd/syscon.h> +#include <linux/device.h> #include "clk-mtk.h" #include "clk-gate.h"
@@ -93,9 +94,10 @@ void mtk_clk_register_factors(const struct mtk_fixed_factor *clks, } } -int mtk_clk_register_gates (struct device_node *node, +int mtk_clk_register_gates_with_dev (struct device_node *node,const struct mtk_gate *clks, -int num,struct clk_onecell_data *clk_data) +int num,struct clk_onecell_data *clk_data, +struct device *dev) {int i;struct clk *clk;
@@ -122,7 +124,7 @@ int mtk_clk_register_gates(struct device_node *node, gate->regs->set_ofs, gate->regs->clr_ofs, gate->regs->sta_ofs, - gate->shift, gate->ops, gate->flags); + gate->shift, gate->ops, gate->flags, dev);if (IS_ERR (clk)) { pr_err("Failed to register clk %s: %ld\n",
@@ -136,6 +138,14 @@ int mtk_clk_register_gates(struct device_node *node,return 0 ; } +int mtk_clk_register_gates (struct device_node *node, +const struct mtk_gate *clks, +int num,struct clk_onecell_data *clk_data) +{ +return mtk_clk_register_gates_with_dev (node, + clks, num, clk_data,NULL ); +} +struct clk *mtk_clk_register_composite (const struct mtk_composite *mc,void __iomem *base,spinlock_t *lock) {
drivers/clk/mediatek/clk-mtk.h +5 -0
@@ -169,6 +169,11 @@ int mtk_clk_register_gates(struct device_node *node, const struct mtk_gate *clks, int num, struct clk_onecell_data *clk_data); +int mtk_clk_register_gates_with_dev (struct device_node *node, +const struct mtk_gate *clks, +int num,struct clk_onecell_data *clk_data, +struct device *dev); +struct mtk_clk_divider {int id;const char *name;
Signature · 1 line
1.8.1.1.dirty
Re: [RESEND PATCH v1 1/3] clk: mediatek: Register clock gate with device
Quoting Weiyi Lu (2019-09-02 02:00:57)
Quoted 5 lines
Allow those clocks under a power domain to do the runtime pm operation by forwarding the struct device pointer from clock provider.
Signed-off-by Weiyi Lu <[email protected]>---
Applied to clk-next
PATCH RESEND 2/3 clk: mediatek: Runtime PM support for MT8183 mcucfg clock provider
In reply to Weiyi LuEnable the runtime PM support and forward the struct device pointer for registration of MT8183 mcucfg clocks.
--- drivers/clk/mediatek/clk-mt8183-mfgcfg.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/clk/mediatek/clk-mt8183-mfgcfg.c +5 -2
@@ -5,6 +5,7 @@#include <linux/clk-provider.h> #include <linux/platform_device.h> +#include <linux/pm_runtime.h> #include "clk-mtk.h" #include "clk-gate.h"
@@ -30,10 +31,12 @@ static int clk_mt8183_mfg_probe(struct platform_device *pdev)struct clk_onecell_data *clk_data;struct device_node *node = pdev->dev.of_node; +pm_runtime_enable (&pdev->dev); + clk_data =mtk_alloc_clk_data (CLK_MFG_NR_CLK ); -mtk_clk_register_gates (node, mfg_clks,ARRAY_SIZE (mfg_clks), - clk_data); +mtk_clk_register_gates_with_dev (node, mfg_clks,ARRAY_SIZE (mfg_clks), + clk_data, &pdev->dev);return of_clk_add_provider (node, of_clk_src_onecell_get, clk_data); }
Signature · 1 line
1.8.1.1.dirty
Re: [RESEND PATCH v1 2/3] clk: mediatek: Runtime PM support for MT8183 mcucfg clock provider
Quoting Weiyi Lu (2019-09-02 02:00:58)
Quoted 5 lines
Enable the runtime PM support and forward the struct device pointer for registration of MT8183 mcucfg clocks.
Signed-off-by Weiyi Lu <[email protected]>---
Applied to clk-next
PATCH RESEND 3/3 arm64: dts: Add power-domains properity to mfgcfg
In reply to Weiyi Lumfgcfg clock is under MFG_ASYNC power domain
--- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/mediatek/mt8183.dtsi +1 -0
@@ -388,6 +388,7 @@ compatible = "mediatek,mt8183-mfgcfg", "syscon"; reg = <0 0x13000000 0 0x1000>; #clock-cells = <1>; + power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>; }; mmsys: syscon@14000000 {
Signature · 1 line
1.8.1.1.dirty