Skip to contentSkip to conversation

FAILED: patch "[PATCH] drm/i915/dp: Fix DSC enable code to use cpu_transcoder" failed to apply to 5.2-stable tree

PATCH [email protected] 2 participants 2 messages Sep 3, 2019

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.2-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 5b6eefd667847ca6bd6925f7bd1afcecc457c889 Mon Sep 17 00:00:00 2001
From: Manasi Navare <[email protected]>
Date: Wed, 21 Aug 2019 14:59:50 -0700
Subject: [PATCH] drm/i915/dp: Fix DSC enable code to use cpu_transcoder
instead of encoder->type

This patch fixes the intel_configure_pps_for_dsc_encoder() function to use cpu_transcoder instead of encoder->type to select the correct DSC registers that was wrongly used in the original patch for one DSC register isntance.

Fixes 7182414e2530 ("drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling")
Cc Ville Syrjala <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Jani Nikula <[email protected]>
Cc <[email protected]> # v5.0+
(cherry picked from commit d4c61c4a16decd8ace8660f22c81609a539fccba)
drivers/gpu/drm/i915/display/intel_vdsc.c +1 -1
index ffec807b8960..f413904a3e96 100644
@@ -541,7 +541,7 @@ static void intel_configure_pps_for_dsc_encoder(struct intel_encoder *encoder,
 	pps_val |= DSC_PIC_HEIGHT(vdsc_cfg->pic_height) |
 		DSC_PIC_WIDTH(vdsc_cfg->pic_width / num_vdsc_instances);
 	DRM_INFO("PPS2 = 0x%08x\n", pps_val);
-	if (encoder->type == INTEL_OUTPUT_EDP) {
+	if (cpu_transcoder == TRANSCODER_EDP) {
 		I915_WRITE(DSCA_PICTURE_PARAMETER_SET_2, pps_val);
 		/*
 		 * If 2 VDSC instances are needed, configure PPS for second
maintainer
#1 lore raw
Quoted 4 lines · On Tue, Sep 03, 2019 at 09:03:12PM +0200, [email protected] wrote:

The patch below does not apply to the 5.2-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

drivers/gpu/drm/i915/intel_vdsc.c was renamed to drivers/gpu/drm/i915/display/intel_vdsc.c; I've fixed it up and queued it for 5.2, it's not needed on older kernels.

--
Thanks,
Sasha