ARM: dts: remove dwmmc nodes from exynos5 common dts file.
Subsystems (3)
PATCH v2 1/2 ARM: dts: remove dwmmc nodes from exynos5 common dts file.
From: Yuvaraj Kumar C D <[email protected]>
Exynos5 series SOC's 5250 and 5420 have different versions of DWMMC controller.So there is a new compatible string to distinguish between them.So these nodes should be moved out of Exynos5 series common device tree source.
Changes since V1: none
--- arch/arm/boot/dts/exynos5.dtsi | 21 --------------------- 1 file changed, 21 deletions(-)
arch/arm/boot/dts/exynos5.dtsi +0 -21
@@ -50,27 +50,6 @@ interrupts = <1 9 0xf04>; }; - dwmmc_0: dwmmc0@12200000 { - compatible = "samsung,exynos5250-dw-mshc"; - interrupts = <0 75 0>; - #address-cells = <1>; - #size-cells = <0>; - }; - - dwmmc_1: dwmmc1@12210000 { - compatible = "samsung,exynos5250-dw-mshc"; - interrupts = <0 76 0>; - #address-cells = <1>; - #size-cells = <0>; - }; - - dwmmc_2: dwmmc2@12220000 { - compatible = "samsung,exynos5250-dw-mshc"; - interrupts = <0 77 0>; - #address-cells = <1>; - #size-cells = <0>; - }; - serial@12C00000 { compatible = "samsung,exynos4210-uart"; reg = <0x12C00000 0x100>;
Signature · 1 line
1.7.9.5
Hi Yuvaraj,
Quoted 6 lines · On Wednesday 21 of August 2013 12:07:38 [email protected] wrote:
From: Yuvaraj Kumar C D <[email protected]>
Exynos5 series SOC's 5250 and 5420 have different versions of DWMMC controller.So there is a new compatible string to distinguish between them.So these nodes should be moved out of Exynos5 series common device tree source.
This series should be split in a different way, because patch 1/2 breaks dwmmc on Exynos5250 and only patch 2/2 fixes this, so bisection is broken.
Also patch 2/2 contains two logically separate changes - moving dwmmc nodes and making status disabled by default. Those should be in separate patches.
Best regards,
Tomasz
Quoted 5 lines · Tomasz Figa
Hi Yuvaraj,
Quoted 2 lines · On Wednesday 21 of August 2013 12:07:38 [email protected] wrote:
From: Yuvaraj Kumar C D <[email protected]>
Quoted 7 lines
Quoted 4 lines
Exynos5 series SOC's 5250 and 5420 have different versions of DWMMC controller.So there is a new compatible string to distinguish between them.So these nodes should be moved out of Exynos5 series common device tree source.
This series should be split in a different way, because patch 1/2 breaks dwmmc on Exynos5250 and only patch 2/2 fixes this, so bisection is broken.
will make a single patch and resend.
Quoted 3 lines
Also patch 2/2 contains two logically separate changes - moving dwmmc nodes and making status disabled by default. Those should be in separate patches.
will separate patch2/2 and resend.
Quoted 4 lines
Best regards,
Tomasz