hv_sock: Add the support of hibernation
Subsystems (5)
Dexuan Cui
maintainerPATCH 1/1 hv_sock: Add the support of hibernation
Add the necessary dummy callbacks for hibernation.
---
This patch is basically a pure Hyper-V specific change and it has a build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for hibernation"), which is on Sasha Levin's Hyper-V tree's hyperv-next branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/log/?h=hyperv-next
I request this patch should go through Sasha's tree rather than the net-next tree.
net/vmw_vsock/hyperv_transport.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
net/vmw_vsock/hyperv_transport.c +20 -0
@@ -930,6 +930,24 @@ static int hvs_remove(struct hv_device *hdev)return 0 ; } +/* hv_sock connections can not persist across hibernation, and all the hv_sock +* channels are forceed to be rescinded before hibernation: see +* vmbus_bus_suspend(). Here the dummy hvs_suspend() and hvs_resume() +* are only needed because hibernation requires that every device's driver +* should have a .suspend and .resume callback: see vmbus_suspend(). +*/ +static int hvs_suspend (struct hv_device *hv_dev) +{ +/* Dummy */ +return 0 ; +} + +static int hvs_resume (struct hv_device *dev) +{ +/* Dummy */ +return 0 ; +} +/* This isn't really used. See vmbus_match() and vmbus_probe() */ static const struct hv_vmbus_device_id id_table[] = { {},
@@ -941,6 +959,8 @@ static int hvs_remove(struct hv_device *hdev) .id_table = id_table, .probe = hvs_probe, .remove = hvs_remove, + .suspend = hvs_suspend, + .resume = hvs_resume, };static int __init hvs_init (void )
Signature · 1 line
1.8.3.1
From: Dexuan Cui <[email protected]>
Date: Wed, 11 Sep 2019 23:37:27 +0000
Quoted 10 lines
Add the necessary dummy callbacks for hibernation.
Signed-off-by Dexuan Cui <[email protected]>---
This patch is basically a pure Hyper-V specific change and it has a build dependency on the commit271b2224d42f("Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for hibernation"), which is on Sasha Levin's Hyper-V tree's hyperv-next branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/log/?h=hyperv-next
Quoted 2 lines
I request this patch should go through Sasha's tree rather than the net-next tree.
That's fine:
Dexuan Cui
maintainerQuoted 11 lines
From: David Miller <[email protected]>
Sent: Friday, September 13, 2019 1:04 PMFrom: Dexuan Cui <[email protected]>
Date: Wed, 11 Sep 2019 23:37:27 +0000Quoted 2 lines
I request this patch should go through Sasha's tree rather than the net-next tree.
That's fine:
Acked-by David S. Miller <[email protected]>
Thanks, David!
@Sasha: I found a few typos in my comment below. I'll post a v2.
Quoted 2 lines
Quoted 2 lines
+/*
hv_sockconnections can not persist across hibernation, and all thehv_sock
+ * channels are forceed to be rescinded before hibernation: see
forceed -> forced
Quoted 1 line
Quoted 1 line
+ * are only needed because hibernation requires that every device's driver
every device's driver -> every vmbus device's driver
Thanks,
-- Dexuan