app/testpmd: introduce QinQ and Rx offloads argument
PATCH 1/1 app/testpmd: introduce QinQ and Rx offloads argument
From: Vivek Sharma <[email protected]>
Introduce boot time argument for configuring QinQ strip offload and for configuring all rx offloads.Fix port info display to distinguish between qinq strip and extend offloads.
--- app/test-pmd/config.c | 9 +++++++-- app/test-pmd/parameters.c | 22 +++++++++++++++++++++- doc/guides/testpmd_app_ug/run_app.rst | 9 +++++++++ 3 files changed, 37 insertions(+), 3 deletions(-)
app/test-pmd/config.c +7 -2
@@ -530,9 +530,14 @@ port_infos_display(portid_t port_id)printf (" filter off \n" );if (vlan_offload Ð_VLAN_EXTEND_OFFLOAD ) -printf (" qinq(extend) on \n" ); +printf (" extend on\n" );else -printf (" qinq(extend) off \n" ); +printf (" extend off\n" ); + +if (vlan_offload Ð_QINQ_STRIP_OFFLOAD ) +printf (" qinq strip on\n" ); +else +printf (" qinq strip off\n" ); }if (dev_info.hash_key_size >0 )
app/test-pmd/parameters.c +21 -1
@@ -68,7 +68,8 @@ usage(char* progname)"--rss-ip | --rss-udp | " "--rxpt= | --rxht= | --rxwt= | --rxfreet= | " "--txpt= | --txht= | --txwt= | --txfreet= | " -"--txrst= | --tx-offloads= | --vxlan-gpe-port= ]\n" , +"--txrst= | --tx-offloads= | | --rx-offloads= | " +"--vxlan-gpe-port= ]\n" , progname);#ifdef RTE_LIBRTE_CMDLINE printf (" --interactive: run in interactive mode.\n" );
@@ -135,6 +136,7 @@ usage(char* progname)printf (" --enable-hw-vlan-filter: enable hardware vlan filter.\n" );printf (" --enable-hw-vlan-strip: enable hardware vlan strip.\n" );printf (" --enable-hw-vlan-extend: enable hardware vlan extend.\n" ); +printf (" --enable-hw-qinq-strip: enable hardware qinq strip.\n" );printf (" --enable-drop-en: enable per queue packet drop.\n" );printf (" --disable-rss: disable rss.\n" ); printf(" --port-topology=N: set port topology (N: paired (default) or "
@@ -186,6 +188,7 @@ usage(char* progname)printf (" --flow-isolate-all: " "requests flow API isolated mode on all ports at initialization time.\n" );printf (" --tx-offloads=0xXXXXXXXX: hexadecimal bitmask of TX queue offloads\n" ); +printf (" --rx-offloads=0xXXXXXXXX: hexadecimal bitmask of RX queue offloads\n" );printf (" --hot-plug: enable hot plug for device.\n" );printf (" --vxlan-gpe-port=N: UPD port of tunnel VXLAN-GPE\n" );printf (" --mlockall: lock all memory\n" );
@@ -607,6 +610,7 @@ launch_args_parse(int argc, char** argv) { "enable-hw-vlan-filter", 0, 0, 0 }, { "enable-hw-vlan-strip", 0, 0, 0 }, { "enable-hw-vlan-extend", 0, 0, 0 }, + { "enable-hw-qinq-strip", 0, 0, 0 }, { "enable-drop-en", 0, 0, 0 }, { "disable-rss", 0, 0, 0 }, { "port-topology", 1, 0, 0 },
@@ -641,6 +645,7 @@ launch_args_parse(int argc, char** argv) { "print-event", 1, 0, 0 }, { "mask-event", 1, 0, 0 }, { "tx-offloads", 1, 0, 0 }, + { "rx-offloads", 1, 0, 0 }, { "hot-plug", 0, 0, 0 }, { "vxlan-gpe-port", 1, 0, 0 }, { "mlockall", 0, 0, 0 },
@@ -994,6 +999,10 @@ launch_args_parse(int argc, char** argv) "enable-hw-vlan-extend")) rx_offloads |=DEV_RX_OFFLOAD_VLAN_EXTEND ; +if (!strcmp (lgopts[opt_idx].name, +"enable-hw-qinq-strip" )) + rx_offloads |=DEV_RX_OFFLOAD_QINQ_STRIP ; +if (!strcmp (lgopts[opt_idx].name,"enable-drop-en" )) rx_drop_en =1 ;
@@ -1215,6 +1224,17 @@ launch_args_parse(int argc, char** argv)rte_exit (EXIT_FAILURE ,"tx-offloads must be >= 0\n" ); } + +if (!strcmp (lgopts[opt_idx].name,"rx-offloads" )) { +char *end =NULL ; + n =strtoull (optarg, &end,16 ); +if (n >=0 ) + rx_offloads = (uint64_t )n; +else +rte_exit (EXIT_FAILURE , +"rx-offloads must be >= 0\n" ); + } +if (!strcmp (lgopts[opt_idx].name,"vxlan-gpe-port" )) { n =atoi (optarg);if (n >=0 )
doc/guides/testpmd_app_ug/run_app.rst +9 -0
@@ -198,6 +198,10 @@ The command line options are: Enable hardware VLAN extend. +* ``--enable-hw-qinq-strip`` + + Enable hardware QINQ strip. + * ``--enable-drop-en`` Enable per-queue packet drop for packets with no descriptors.
@@ -385,6 +389,11 @@ The command line options are: Set the hexadecimal bitmask of TX queue offloads. The default value is 0. +* ``--rx-offloads=0xXXXXXXXX`` + + Set the hexadecimal bitmask of RX queue offloads. + The default value is 0. + * ``--hot-plug`` Enable device event monitor mechanism for hotplug.
Signature · 1 line
2.7.4
Ping!
Thanks,
Vivek
________________________________________
From: [email protected] <[email protected]>
Sent: 13 September 2019 17:44
To: [email protected]
Cc: [email protected]; [email protected]; Vivek Kumar Sharma
Subject: [PATCH] app/testpmd: introduce QinQ and Rx offloads argument
From: Vivek Sharma <[email protected]>
Introduce boot time argument for configuring QinQ strip offload and for configuring all rx offloads.Fix port info display to distinguish between qinq strip and extend offloads.
--- app/test-pmd/config.c | 9 +++++++-- app/test-pmd/parameters.c | 22 +++++++++++++++++++++- doc/guides/testpmd_app_ug/run_app.rst | 9 +++++++++ 3 files changed, 37 insertions(+), 3 deletions(-)
app/test-pmd/config.c +7 -2
@@ -530,9 +530,14 @@ port_infos_display(portid_t port_id)printf (" filter off \n" );if (vlan_offload Ð_VLAN_EXTEND_OFFLOAD ) -printf (" qinq(extend) on \n" ); +printf (" extend on\n" );else -printf (" qinq(extend) off \n" ); +printf (" extend off\n" ); + +if (vlan_offload Ð_QINQ_STRIP_OFFLOAD ) +printf (" qinq strip on\n" ); +else +printf (" qinq strip off\n" ); }if (dev_info.hash_key_size >0 )
app/test-pmd/parameters.c +21 -1
@@ -68,7 +68,8 @@ usage(char* progname)"--rss-ip | --rss-udp | " "--rxpt= | --rxht= | --rxwt= | --rxfreet= | " "--txpt= | --txht= | --txwt= | --txfreet= | " -"--txrst= | --tx-offloads= | --vxlan-gpe-port= ]\n" , +"--txrst= | --tx-offloads= | | --rx-offloads= | " +"--vxlan-gpe-port= ]\n" , progname);#ifdef RTE_LIBRTE_CMDLINE printf (" --interactive: run in interactive mode.\n" );
@@ -135,6 +136,7 @@ usage(char* progname)printf (" --enable-hw-vlan-filter: enable hardware vlan filter.\n" );printf (" --enable-hw-vlan-strip: enable hardware vlan strip.\n" );printf (" --enable-hw-vlan-extend: enable hardware vlan extend.\n" ); +printf (" --enable-hw-qinq-strip: enable hardware qinq strip.\n" );printf (" --enable-drop-en: enable per queue packet drop.\n" );printf (" --disable-rss: disable rss.\n" ); printf(" --port-topology=N: set port topology (N: paired (default) or "
@@ -186,6 +188,7 @@ usage(char* progname)printf (" --flow-isolate-all: " "requests flow API isolated mode on all ports at initialization time.\n" );printf (" --tx-offloads=0xXXXXXXXX: hexadecimal bitmask of TX queue offloads\n" ); +printf (" --rx-offloads=0xXXXXXXXX: hexadecimal bitmask of RX queue offloads\n" );printf (" --hot-plug: enable hot plug for device.\n" );printf (" --vxlan-gpe-port=N: UPD port of tunnel VXLAN-GPE\n" );printf (" --mlockall: lock all memory\n" );
@@ -607,6 +610,7 @@ launch_args_parse(int argc, char** argv) { "enable-hw-vlan-filter", 0, 0, 0 }, { "enable-hw-vlan-strip", 0, 0, 0 }, { "enable-hw-vlan-extend", 0, 0, 0 }, + { "enable-hw-qinq-strip", 0, 0, 0 }, { "enable-drop-en", 0, 0, 0 }, { "disable-rss", 0, 0, 0 }, { "port-topology", 1, 0, 0 },
@@ -641,6 +645,7 @@ launch_args_parse(int argc, char** argv) { "print-event", 1, 0, 0 }, { "mask-event", 1, 0, 0 }, { "tx-offloads", 1, 0, 0 }, + { "rx-offloads", 1, 0, 0 }, { "hot-plug", 0, 0, 0 }, { "vxlan-gpe-port", 1, 0, 0 }, { "mlockall", 0, 0, 0 },
@@ -994,6 +999,10 @@ launch_args_parse(int argc, char** argv) "enable-hw-vlan-extend")) rx_offloads |=DEV_RX_OFFLOAD_VLAN_EXTEND ; +if (!strcmp (lgopts[opt_idx].name, +"enable-hw-qinq-strip" )) + rx_offloads |=DEV_RX_OFFLOAD_QINQ_STRIP ; +if (!strcmp (lgopts[opt_idx].name,"enable-drop-en" )) rx_drop_en =1 ;
@@ -1215,6 +1224,17 @@ launch_args_parse(int argc, char** argv)rte_exit (EXIT_FAILURE ,"tx-offloads must be >= 0\n" ); } + +if (!strcmp (lgopts[opt_idx].name,"rx-offloads" )) { +char *end =NULL ; + n =strtoull (optarg, &end,16 ); +if (n >=0 ) + rx_offloads = (uint64_t )n; +else +rte_exit (EXIT_FAILURE , +"rx-offloads must be >= 0\n" ); + } +if (!strcmp (lgopts[opt_idx].name,"vxlan-gpe-port" )) { n =atoi (optarg);if (n >=0 )
doc/guides/testpmd_app_ug/run_app.rst +9 -0
@@ -198,6 +198,10 @@ The command line options are: Enable hardware VLAN extend. +* ``--enable-hw-qinq-strip`` + + Enable hardware QINQ strip. + * ``--enable-drop-en`` Enable per-queue packet drop for packets with no descriptors.
@@ -385,6 +389,11 @@ The command line options are: Set the hexadecimal bitmask of TX queue offloads. The default value is 0. +* ``--rx-offloads=0xXXXXXXXX`` + + Set the hexadecimal bitmask of RX queue offloads. + The default value is 0. + * ``--hot-plug`` Enable device event monitor mechanism for hotplug.
--
2.7.4
Quoted 7 lines · On 9/13/2019 1:14 PM, [email protected] wrote:
From: Vivek Sharma <[email protected]>
Introduce boot time argument for configuring QinQ strip offload and for configuring all rx offloads.Fix port info display to distinguish between qinq strip and extend offloads.
Signed-off-by Vivek Sharma <[email protected]>
<...>
Quoted 14 lines
doc/guides/testpmd_app_ug/run_app.rst +4
-0@@ -198,6 +198,10 @@ The command line options are: Enable hardware VLAN extend. +* ``--enable-hw-qinq-strip`` + + Enable hardware QINQ strip. + * ``--enable-drop-en`` Enable per-queue packet drop for packets with no descriptors.@@ -385,6 +389,11 @@ The command line options are: Set the hexadecimal bitmask of TX queue offloads.
doc/guides/testpmd_app_ug/run_app.rst The command line options are: · line 399
Quoted 10 lines
doc/guides/testpmd_app_ug/run_app.rst +5
-0The default value is 0. +* ``--rx-offloads=0xXXXXXXXX`` + + Set the hexadecimal bitmask of RX queue offloads. + The default value is 0. + * ``--hot-plug`` Enable device event monitor mechanism for hotplug.
+1 to both arguments, but they are independent/unrelated, can you please make this two patches?
Thanks,
ferruh