drm/amdgpu: Enable gfx cache probing on HDP write for arcturus
Subsystems (2)
PATCH 1/1 drm/amdgpu: Enable gfx cache probing on HDP write for arcturus
This allows gfx cache to be probed and invalidated (for none-dirty cache lines) on a HDP write (from either another GPU or CPU). This should work only for the memory mapped as RW memory type newly added for arcturus, to achieve some cache coherence b/t multiple memory clients.
--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3 -0
@@ -1272,6 +1272,9 @@ static int gmc_v9_0_gart_enable(struct amdgpu_device *adev)/* TODO for renoir */ mmhub_v1_0_update_power_gating (adev, true);break ; +case CHIP_ARCTURUS : +WREG32_FIELD15 (HDP ,0 ,HDP_MMHUB_CNTL ,HDP_MMHUB_GCC ,1 ); +break ;default :break ; }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1568927828-17593-1-git-send-email-Oak.Zeng-5C7GfCeVMHo@public.gmane.org
Ping...
Regards,
Oak
-----Original Message-----
From: Zeng, Oak <[email protected]>
Sent: Thursday, September 19, 2019 5:17 PM
To: [email protected]
Cc: Kuehling, Felix <[email protected]>; Koenig, Christian <[email protected]>; Zeng, Oak <[email protected]>
Subject: [PATCH] drm/amdgpu: Enable gfx cache probing on HDP write for arcturus
This allows gfx cache to be probed and invalidated (for none-dirty cache lines) on a HDP write (from either another GPU or CPU). This should work only for the memory mapped as RW memory type newly added for arcturus, to achieve some cache coherence b/t multiple memory clients.
--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3 -0
@@ -1272,6 +1272,9 @@ static int gmc_v9_0_gart_enable(struct amdgpu_device *adev)/* TODO for renoir */ mmhub_v1_0_update_power_gating (adev, true);break ; +case CHIP_ARCTURUS : +WREG32_FIELD15 (HDP ,0 ,HDP_MMHUB_CNTL ,HDP_MMHUB_GCC ,1 ); +break ;default :break ; }
--
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): BL0PR12MB2580DFF062B6AE6A61C3AFBC809E0-b4cIHhjg/p/[email protected]
I'm pretty sure the gart_enable function is not the right place for this. GART is for GPU access to system memory. HDP is for host access to GPU memory. Also, I would expect anything done in gart_enable to be undone in gart_disable. If that's not the intention, maybe this should go in gmc_v9_0_hw_init.
Regards,
Felix
Quoted 35 lines · Oak
Ping...
Regards,
Oak-----Original Message-----
From: Zeng, Oak <[email protected]>
Sent: Thursday, September 19, 2019 5:17 PM
To: [email protected]
Cc: Kuehling, Felix <[email protected]>; Koenig, Christian <[email protected]>; Zeng, Oak <[email protected]>
Subject: [PATCH] drm/amdgpu: Enable gfx cache probing on HDP write for arcturusThis allows gfx cache to be probed and invalidated (for none-dirty cache lines) on a HDP write (from either another GPU or CPU). This should work only for the memory mapped as RW memory type newly added for arcturus, to achieve some cache coherence b/t multiple memory clients.
Change-Id I0a69d0000e48706bb713235bfbc83fcc67774614Signed-off-by Oak Zeng <[email protected]>--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3
-1@@ -1272,6 +1272,9 @@ static int gmc_v9_0_gart_enable(struct amdgpu_device *adev)/* TODO for renoir */ mmhub_v1_0_update_power_gating (adev, true);break ; +case CHIP_ARCTURUS : +WREG32_FIELD15 (HDP ,0 ,HDP_MMHUB_CNTL ,HDP_MMHUB_GCC ,1 ); +break ;default :break ; } --
Quoted 2 lines
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 79b8aa8b-1e0c-643e-266f-45239592b6b1-5C7GfCeVMHo@public.gmane.org
Agreed. I will move none gart logic from gmc_v9_0_gart_enable to gmc_v9_0_hw_init
Regards,
Oak
-----Original Message-----
From: Kuehling, Felix <[email protected]>
Sent: Friday, October 4, 2019 11:03 AM
To: Zeng, Oak <[email protected]>; [email protected]
Cc: Koenig, Christian <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: Enable gfx cache probing on HDP write for arcturus
I'm pretty sure the gart_enable function is not the right place for this. GART is for GPU access to system memory. HDP is for host access to GPU memory. Also, I would expect anything done in gart_enable to be undone in gart_disable. If that's not the intention, maybe this should go in gmc_v9_0_hw_init.
Regards,
Felix
Quoted 38 lines · Oak
Ping...
Regards,
Oak-----Original Message-----
From: Zeng, Oak <[email protected]>
Sent: Thursday, September 19, 2019 5:17 PM
To: [email protected]
Cc: Kuehling, Felix <[email protected]>; Koenig, Christian <[email protected]>; Zeng, Oak <[email protected]>
Subject: [PATCH] drm/amdgpu: Enable gfx cache probing on HDP write for arcturusThis allows gfx cache to be probed and invalidated (for none-dirty cache lines) on a HDP write (from either another GPU or CPU). This should work only for the memory mapped as RW memory type newly added for arcturus, to achieve some cache coherence b/t multiple memory clients.
Change-Id I0a69d0000e48706bb713235bfbc83fcc67774614Signed-off-by Oak Zeng <[email protected]>--- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3
-1@@ -1272,6 +1272,9 @@ static int gmc_v9_0_gart_enable(struct amdgpu_device *adev)/* TODO for renoir */ mmhub_v1_0_update_power_gating (adev, true);break ; +case CHIP_ARCTURUS : +WREG32_FIELD15 (HDP ,0 ,HDP_MMHUB_CNTL ,HDP_MMHUB_GCC ,1 ); +break ;default :break ; } --
Quoted 2 lines
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx