mtd: ubi: Max out wear-leveling threshold
Subsystems (2)
PATCH v2 1/1 mtd: ubi: Max out wear-leveling threshold
Due to the recursive ubi_thread implementation in the barebox, a large amount of wear-leveling can lead to a stack overflow.
This was observed during extensive ubi stress tests with the linux kernel and periodic power cycles. We found that if the wear-leveling threshold is exceeded and a large amount of erase blocks need wear-leveling the stack can overflow.
The hardware used to observe this was a phyCORE-i.MX 6 with 1GB NAND flash.
As the kernel is perfectly capable of handling wear-leveling we can disable wear-leveling in the barebox by maxing out the threshold and removing its Kconfig option.
---
Changes in v2:
- Remove threshold config completely instead of just maxing out the default
--- drivers/mtd/ubi/Kconfig | 17 ----------------- drivers/mtd/ubi/build.c | 2 +- drivers/mtd/ubi/ubi.h | 11 +++++++++++ drivers/mtd/ubi/wl.c | 8 -------- 4 files changed, 12 insertions(+), 26 deletions(-)
drivers/mtd/ubi/Kconfig +0 -17
@@ -10,23 +10,6 @@ menuconfig MTD_UBI if MTD_UBI -config MTD_UBI_WL_THRESHOLD - int "UBI wear-leveling threshold" - default 4096 - range 2 65536 - help - This parameter defines the maximum difference between the highest - erase counter value and the lowest erase counter value of eraseblocks - of UBI devices. When this threshold is exceeded, UBI starts performing - wear leveling by means of moving data from eraseblock with low erase - counter to eraseblocks with high erase counter. - - The default value should be OK for SLC NAND flashes, NOR flashes and - other flashes which have eraseblock life-cycle 100000 or more. - However, in case of MLC NAND flashes which typically have eraseblock - life-cycle less than 10000, the threshold should be lessened (e.g., - to 128 or 256, although it does not have to be power of 2). - config MTD_UBI_BEB_LIMIT int "Maximum expected bad eraseblock count per 1024 eraseblocks" default 20
drivers/mtd/ubi/build.c +1 -1
@@ -655,7 +655,7 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num, ubi->vol_count -UBI_INT_VOL_COUNT ,UBI_INT_VOL_COUNT , ubi->vtbl_slots);ubi_msg (ubi,"max/mean erase counter: %d/%d, WL threshold: %d, image sequence number: %u" , - ubi->max_ec, ubi->mean_ec,CONFIG_MTD_UBI_WL_THRESHOLD , + ubi->max_ec, ubi->mean_ec,UBI_WL_THRESHOLD , ubi->image_seq);ubi_msg (ubi,"available PEBs: %d, total reserved PEBs: %d, PEBs reserved for bad PEB handling: %d" , ubi->avail_pebs, ubi->rsvd_pebs, ubi->beb_rsvd_pebs);
drivers/mtd/ubi/ubi.h +11 -0
@@ -69,6 +69,17 @@*/ #define UBI_PROT_QUEUE_LEN 10 +/* +* Maximum difference between two erase counters. If this threshold is +* exceeded, the WL sub-system starts moving data from used physical +* eraseblocks with low erase counter to free physical eraseblocks with high +* erase counter. +* Extensive wear-leveling in the barebox can lead to stack overflows. Thus +* disable it by setting the threshold to the OS's max configurable value and +* leave wear-leveling to the OS. +*/ +#define UBI_WL_THRESHOLD 65536 +/* The volume ID/LEB number/erase counter is unknown */ #define UBI_UNKNOWN -1
drivers/mtd/ubi/wl.c +0 -8
@@ -101,14 +101,6 @@#define WL_RESERVED_PEBS 1/* -* Maximum difference between two erase counters. If this threshold is -* exceeded, the WL sub-system starts moving data from used physical -* eraseblocks with low erase counter to free physical eraseblocks with high -* erase counter. -*/ -#define UBI_WL_THRESHOLD CONFIG_MTD_UBI_WL_THRESHOLD - -/* * When a physical eraseblock is moved, the WL sub-system has to pick the target * physical eraseblock to move to. The simplest way would be just to pick the * one with the highest erase counter. But in certain workloads this could lead
Signature · 7 lines
2.7.4 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Sascha Hauer
AppliedQuoted 14 lines · Stefan Riedmueller
Due to the recursive
ubi_threadimplementation in the barebox, a large amount of wear-leveling can lead to a stack overflow.This was observed during extensive ubi stress tests with the linux kernel and periodic power cycles. We found that if the wear-leveling threshold is exceeded and a large amount of erase blocks need wear-leveling the stack can overflow.
The hardware used to observe this was a phyCORE-i.MX 6 with 1GB NAND flash.
As the kernel is perfectly capable of handling wear-leveling we can disable wear-leveling in the barebox by maxing out the threshold and removing its
Kconfigoption.
Quoted 5 lines
Signed-off-by Stefan Riedmueller <[email protected]>---
Changes in v2:
- Remove threshold config completely instead of just maxing out the default
---
Applied, thanks
Sascha
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox