drm/amdgpu: add command id in psp response failure message
Subsystems (2)
PATCH 1/2 drm/amdgpu: add command id in psp response failure message
From: Hawking Zhang <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +3 -2
@@ -168,8 +168,9 @@ psp_cmd_submit_buf(struct psp_context *psp,if (ucode)DRM_WARN ("failed to load ucode id (%d) " , ucode->ucode_id); -DRM_WARN ("psp command failed and response status is (0x%X)\n" , - psp->cmd_buf_mem->resp.status &GFX_CMD_STATUS_MASK ); +DRM_WARN ("psp command (0x%X) failed and response status is (0x%X)\n" , + psp->cmd_buf_mem->cmd_id, + psp->cmd_buf_mem->resp.status &GFX_CMD_STATUS_MASK );if (!timeout) {mutex_unlock (&psp->mutex);return -EINVAL ;
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1569245443-27318-1-git-send-email-le.ma-5C7GfCeVMHo@public.gmane.org
PATCH 2/2 drm/amdgpu: correct condition check for psp rlc autoload
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -1
@@ -1080,7 +1080,8 @@ static int psp_np_fw_load(struct psp_context *psp)return ret;/* Start rlc autoload after psp recieved all the gfx firmware */ -if (ucode->ucode_id ==AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM ) { +if (psp->autoload_supported && ucode->ucode_id == +AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM ) { ret =psp_rlc_autoload (psp);if (ret) {DRM_ERROR ("Failed to start rlc autoload\n" );
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1569245443-27318-2-git-send-email-le.ma-5C7GfCeVMHo@public.gmane.org
RE: [PATCH 2/2] drm/amdgpu: correct condition check for psp rlc autoload
Please help to add simple description for both patches. with that fixed,
Series is Reviewed-by: Hawking Zhang <[email protected]>
Regards,
Hawking
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Le Ma
Sent: 2019年9月23日 21:31
To: [email protected]
Cc: Ma, Le <[email protected]>
Subject: [PATCH 2/2] drm/amdgpu: correct condition check for psp rlc autoload
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -1
@@ -1080,7 +1080,8 @@ static int psp_np_fw_load(struct psp_context *psp)return ret;/* Start rlc autoload after psp recieved all the gfx firmware */ -if (ucode->ucode_id ==AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM ) { +if (psp->autoload_supported && ucode->ucode_id == +AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM ) { ret =psp_rlc_autoload (psp);if (ret) {DRM_ERROR ("Failed to start rlc autoload\n" );
Signature · 10 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): DM5PR12MB1418F78B0374568673ED5EC7FC850-2J9CzHegvk81aAVlcVN8UQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
RE: [PATCH 2/2] drm/amdgpu: correct condition check for psp rlc autoload
Sorry that I missed to add Reviewed-by when push this patch.
Regards,
Ma Le
-----Original Message-----
From: Zhang, Hawking <[email protected]>
Sent: Monday, September 23, 2019 9:58 PM
To: Ma, Le <[email protected]>; [email protected]
Cc: Ma, Le <[email protected]>
Subject: RE: [PATCH 2/2] drm/amdgpu: correct condition check for psp rlc autoload
Please help to add simple description for both patches. with that fixed,
Series is Reviewed-by: Hawking Zhang <[email protected]>
Regards,
Hawking
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Le Ma
Sent: 2019年9月23日 21:31
To: [email protected]
Cc: Ma, Le <[email protected]>
Subject: [PATCH 2/2] drm/amdgpu: correct condition check for psp rlc autoload
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -1
@@ -1080,7 +1080,8 @@ static int psp_np_fw_load(struct psp_context *psp)return ret;/* Start rlc autoload after psp recieved all the gfx firmware */ -if (ucode->ucode_id ==AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM ) { +if (psp->autoload_supported && ucode->ucode_id == +AMDGPU_UCODE_ID_RLC_RESTORE_LIST_SRM_MEM ) { ret =psp_rlc_autoload (psp);if (ret) {DRM_ERROR ("Failed to start rlc autoload\n" );
Signature · 10 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx