Skip to contentSkip to conversation

drm/amdgpu/psp: silence response status warning

PATCH In review S, Shirish 2 participants 2 messages Sep 24, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

S, Shirish

author
#0 lore raw

PATCH 1/1 drm/amdgpu/psp: silence response status warning

log the response status related error to the driver's debug log since psp response status is not 0 even though there was no problem while the command was submitted.

This warning misleads, hence this change.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +1 -1
index 76c59d5..37ffed5 100644
@@ -170,7 +170,7 @@ psp_cmd_submit_buf(struct psp_context *psp,
 		if (ucode)
 			DRM_WARN("failed to load ucode id (%d) ",
 				  ucode->ucode_id);
-		DRM_WARN("psp command (0x%X) failed and response status is (0x%X)\n",
+		DRM_DEBUG_DRIVER("psp command (0x%X) failed and response status is (0x%X)\n",
 			 psp->cmd_buf_mem->cmd_id,
 			 psp->cmd_buf_mem->resp.status & GFX_CMD_STATUS_MASK);
 		if (!timeout) {
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1569316680-12374-1-git-send-email-shirish.s-5C7GfCeVMHo@public.gmane.org

Reviewed-by Feifei Xu
#2 lore raw

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of S, Shirish
Sent: Tuesday, September 24, 2019 5:18 PM
To: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Huang, Ray <[email protected]>; Zhang, Hawking <[email protected]>
Cc: [email protected]; S, Shirish <[email protected]>
Subject: [PATCH] drm/amdgpu/psp: silence response status warning

log the response status related error to the driver's debug log since psp response status is not 0 even though there was no problem while the command was submitted.

This warning misleads, hence this change.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -1
index 76c59d5..37ffed5 100644
@@ -170,7 +170,7 @@ psp_cmd_submit_buf(struct psp_context *psp,
 		if (ucode)
 			DRM_WARN("failed to load ucode id (%d) ",
 				  ucode->ucode_id);
-		DRM_WARN("psp command (0x%X) failed and response status is (0x%X)\n",
+		DRM_DEBUG_DRIVER("psp command (0x%X) failed and response status is 
+(0x%X)\n",
 			 psp->cmd_buf_mem->cmd_id,
 			 psp->cmd_buf_mem->resp.status & GFX_CMD_STATUS_MASK);

if (!timeout) {
--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx