Skip to contentSkip to conversation

Bluetooth: btusb: print FW version after FW download

PATCH In review Amit K Bag 2 participants 3 messages Sep 25, 2019 – Sep 27, 2019 Bluetooth drivers

lore
Share & tools
lore

Amit K Bag

author
#0 lore raw

PATCH 1/1 Bluetooth: btusb: print FW version after FW download

After FW download there is no print to confirm the current FW version. Add print to check FW version incase of FW download.

---
 drivers/bluetooth/btusb.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/bluetooth/btusb.c +8 -0
index a9c35ebb30f8..f6c033b5042c 100644
@@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
 	 */
 	btintel_set_event_mask(hdev, false);
 
+	/* Read the Intel version information after loading the FW  */
+	err = btintel_read_version(hdev, &ver);
+	if (err)
+		return err;
+
+	btintel_version_info(hdev, &ver);
+	bt_dev_info(hdev, "Setup complete");
+
 	return 0;
 }
 
Signature · 1 line
2.7.4
maintainer
#1 lore raw

Hi Amit,

Quoted 14 lines

After FW download there is no print to confirm the current FW version. Add print to check FW version incase of FW download.

---
drivers/bluetooth/btusb.c | 8 ++++++++

1 file changed, 8 insertions(+)
drivers/bluetooth/btusb.c +0 -0
index a9c35ebb30f8..f6c033b5042c 100644
@@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
 	 */

drivers/bluetooth/btusb.c static int btusb_setup_intel_new(struct hci_dev *hdev) · line 2442

Quoted 10 lines
drivers/bluetooth/btusb.c +8 -0
 	btintel_set_event_mask(hdev, false);
 
+	/* Read the Intel version information after loading the FW  */
+	err = btintel_read_version(hdev, &ver);
+	if (err)
+		return err;
+
+	btintel_version_info(hdev, &ver);
+	bt_dev_info(hdev, "Setup complete");
+

I rather not add an extra Setup complete since that is rather noisy. We can add the extra version information if that adds value.

Regards

Marcel

#2 lore raw
Quoted 18 lines

Hi Amit,

Quoted 16 lines

After FW download there is no print to confirm the current FW version. Add print to check FW version incase of FW download.

---
drivers/bluetooth/btusb.c | 8 ++++++++

1 file changed, 8 insertions(+)
drivers/bluetooth/btusb.c +0 -0
index a9c35ebb30f8..f6c033b5042c 100644
@@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
 	 */
 	btintel_set_event_mask(hdev, false);
 
Quoted 11 lines

drivers/bluetooth/btusb.c static int btusb_setup_intel_new(struct hci_dev *hdev) · line 2442

Quoted 8 lines
drivers/bluetooth/btusb.c +8 -0
+	/* Read the Intel version information after loading the FW  */
+	err = btintel_read_version(hdev, &ver);
+	if (err)
+		return err;
+
+	btintel_version_info(hdev, &ver);
+	bt_dev_info(hdev, "Setup complete");
+

I rather not add an extra Setup complete since that is rather noisy. We can add the extra version information if that adds value.

I will remove this message and post the revised patch.