of: reserved_mem: add missing of_node_put() for proper ref-counting
Subsystems (2)
PATCH 1/1 of: reserved_mem: add missing of_node_put() for proper ref-counting
Commit d698a388146c ("of: reserved-memory: ignore disabled memory-region nodes") added an early return in of_reserved_mem_device_init_by_idx(), but didn't call of_node_put() on a device_node whose ref-count was incremented in the call to of_parse_phandle() preceding the early exit.
Fixes d698a388146c ("of: reserved-memory: ignore disabled memory-region nodes")
Signed-off-by Chris Goldsworthy <[email protected]>
To: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- drivers/of/of_reserved_mem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/of/of_reserved_mem.c +3 -1
@@ -324,8 +324,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,if (!target)return -ENODEV ; -if (!of_device_is_available (target)) +if (!of_device_is_available (target)) { +of_node_put (target);return 0 ; + } rmem =__find_rmem (target);of_node_put (target);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project