Skip to contentSkip to conversation

Revert "drm/amdgpu: disable stutter mode for renoir"

PATCH In review Liu, Aaron 2 participants 2 messages Sep 27, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

Liu, Aaron

author
#0 lore raw

PATCH 1/1 Revert "drm/amdgpu: disable stutter mode for renoir"

This reverts commit c512e6fdfd2da917b5b6792902e7224f58a77f94.

Since SBIOS WCD9925N, NMI printing disappeared. Hence enable stutter mode.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -2
index bdab3f7..9d8d7e8 100644
@@ -2466,8 +2466,6 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
 
 	if (adev->asic_type != CHIP_CARRIZO && adev->asic_type != CHIP_STONEY)
 		dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask & PP_STUTTER_MODE ? false : true;
-	if (adev->asic_type == CHIP_RENOIR)
-		dm->dc->debug.disable_stutter = true;
 
 	return 0;
 fail:
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1569554593-18302-1-git-send-email-aaron.liu-5C7GfCeVMHo@public.gmane.org

Reviewed-by Huang Rui
#2 lore raw
Quoted 7 lines

-----Original Message-----
From: Liu, Aaron <[email protected]>
Sent: Friday, September 27, 2019 11:23 AM
To: [email protected]
Cc: Huang, Ray <[email protected]>; Liu, Aaron <[email protected]>
Subject: [PATCH] Revert "drm/amdgpu: disable stutter mode for renoir"

Quoted 6 lines

This reverts commit c512e6fdfd2da917b5b6792902e7224f58a77f94.

Since SBIOS WCD9925N, NMI printing disappeared. Hence enable stutter mode.

Try to do more tests with this SBIOS and make sure the result. After that, patch is

Quoted 19 lines
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -2
index bdab3f7..9d8d7e8 100644
@@ -2466,8 +2466,6 @@ static int amdgpu_dm_initialize_drm_device(struct
 amdgpu_device *adev)
 
 	if (adev->asic_type != CHIP_CARRIZO && adev->asic_type !=
 CHIP_STONEY)
 		dm->dc->debug.disable_stutter =
 amdgpu_pp_feature_mask & PP_STUTTER_MODE ? false : true;
-	if (adev->asic_type == CHIP_RENOIR)
-		dm->dc->debug.disable_stutter = true;
Quoted 4 lines

return 0;
fail:
--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx