Skip to contentSkip to conversation

iommu/arm: Remove arch_iommu_populate_page_table() completely

PATCH In review Oleksandr Tyshchenko 4 participants 7 messages Sep 30, 2019 – Oct 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu/arm: Remove arch_iommu_populate_page_table() completely

From: Oleksandr Tyshchenko <[email protected]>

The Arm realization should have been removed in the following commit as redundant:
f89f555 remove late (on-demand) construction of IOMMU page tables

So, remove unused function completely.

---
 xen/drivers/passthrough/arm/iommu.c | 6 ------
 1 file changed, 6 deletions(-)
xen/drivers/passthrough/arm/iommu.c +0 -6
index 76e1152..db3b07a 100644
@@ -132,12 +132,6 @@ void arch_iommu_domain_destroy(struct domain *d)
 {
 }
 
-int arch_iommu_populate_page_table(struct domain *d)
-{
-    /* The IOMMU shares the p2m with the CPU */
-    return -ENOSYS;
-}
-
 void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
 {
 }
Signature · 7 lines
2.7.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: Oleksandr Tyshchenko <[email protected]>
Sent: 30 September 2019 11:35
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Paul Durrant <[email protected]>; Oleksandr Tyshchenko <[email protected]>
Subject: [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely

Quoted 7 lines

From: Oleksandr Tyshchenko <[email protected]>

The Arm realization should have been removed in the following commit as redundant:
f89f555 remove late (on-demand) construction of IOMMU page tables

So, remove unused function completely.

Good catch.

Quoted 24 lines
---
 xen/drivers/passthrough/arm/iommu.c | 6 ------
 1 file changed, 6 deletions(-)
xen/drivers/passthrough/arm/iommu.c +0 -7
index 76e1152..db3b07a 100644
@@ -132,12 +132,6 @@ void arch_iommu_domain_destroy(struct domain *d)
 {
 }
 
-int arch_iommu_populate_page_table(struct domain *d)
-{
-    /* The IOMMU shares the p2m with the CPU */
-    return -ENOSYS;
-}
-
 void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
 {
 }
--
Quoted 1 line

2.7.4

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Acked-by on v1 1/1
#2 lore raw
In reply to Oleksandr Tyshchenko

Hi Oleksandr,

Quoted 9 lines · Oleksandr Tyshchenko

From: Oleksandr Tyshchenko <[email protected]>

The Arm realization should have been removed in the following commit as redundant:
f89f555 remove late (on-demand) construction of IOMMU page tables

So, remove unused function completely.

Cheers,

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#3 lore raw
In reply to Oleksandr Tyshchenko
Quoted 9 lines · Oleksandr Tyshchenko

From: Oleksandr Tyshchenko <[email protected]>

The Arm realization should have been removed in the following commit as redundant:
f89f555 remove late (on-demand) construction of IOMMU page tables

So, remove unused function completely.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author
#4 lore raw

Hi

Quoted 7 lines · Jürgen Groß
Quoted 6 lines · Oleksandr Tyshchenko

From: Oleksandr Tyshchenko <[email protected]>

The Arm realization should have been removed in the following commit as redundant:
f89f555 remove late (on-demand) construction of IOMMU page tables

Quoted 5 lines
Quoted 3 lines

So, remove unused function completely.

Thank you all.

Signature · 9 lines
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
author
#5 lore raw

Hi, all

Gentle reminder...

Signature · 9 lines
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#6 lore raw
Quoted 2 lines · Oleksandr

Hi, all

Hi,

Quoted 2 lines

Gentle reminder...

Sorry this fell through the cracks. I have now committed it.

Cheers,

Quoted 1 line
Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel