Skip to contentSkip to conversation

dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l

PATCH In review Kiran Gunda 4 participants 5 messages Oct 4, 2019 – Oct 16, 2019

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: pinctrl: qcom-pmic-gpio: Add support for pm6150/pm6150l

Add support for the PM6150 and PM6150L GPIO support to the Qualcomm PMIC GPIO binding.

---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c                     | 2 ++
 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +4 -0
index c32bf32..2f48cca 100644
@@ -23,6 +23,8 @@ PMIC's from Qualcomm.
 		    "qcom,pms405-gpio"
 		    "qcom,pm8150-gpio"
 		    "qcom,pm8150b-gpio"
+		    "qcom,pm6150-gpio"
+		    "qcom,pm6150l-gpio"
 
 		    And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
 		    if the device is on an spmi bus or an ssbi bus respectively
@@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
 					     and gpio8)
 		    gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
 		    gpio1-gpio12 for pm8150l (hole on gpio7)
+		    gpio1-gpio10 for pm6150
+		    gpio1-gpio12 for pm6150l
 
 - function:
 	Usage: required
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +2 -0
index f1fece5..387917c 100644
@@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct platform_device *pdev)
 	{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
 	/* pm8150l has 12 GPIOs with holes on 7 */
 	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
+	{ .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
 	{ },
 };
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
 a Linux Foundation Collaborative Project
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Kiran Gunda

Add support for the PM6150 and PM6150L GPIO support to the Qualcomm PMIC GPIO binding.

Quoted 44 lines
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c                     | 2 ++
 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +4 -0
index c32bf32..2f48cca 100644
@@ -23,6 +23,8 @@ PMIC's from Qualcomm.
 		    "qcom,pms405-gpio"
 		    "qcom,pm8150-gpio"
 		    "qcom,pm8150b-gpio"
+		    "qcom,pm6150-gpio"
+		    "qcom,pm6150l-gpio"
 
 		    And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
 		    if the device is on an spmi bus or an ssbi bus respectively
@@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
 					     and gpio8)
 		    gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
 		    gpio1-gpio12 for pm8150l (hole on gpio7)
+		    gpio1-gpio10 for pm6150
+		    gpio1-gpio12 for pm6150l
 
 - function:
 	Usage: required
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +2 -0
index f1fece5..387917c 100644
@@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct platform_device *pdev)
 	{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
 	/* pm8150l has 12 GPIOs with holes on 7 */
 	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
+	{ .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
 	{ },
 };
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
 a Linux Foundation Collaborative Project
Reviewed-by on v1 1/1
#3 lore raw
In reply to Kiran Gunda
Quoted 23 lines · Kiran Gunda

Add support for the PM6150 and PM6150L GPIO support to the Qualcomm PMIC GPIO binding.

---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c                     | 2 ++
 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +2 -0
index c32bf32..2f48cca 100644
@@ -23,6 +23,8 @@ PMIC's from Qualcomm.
 		    "qcom,pms405-gpio"
 		    "qcom,pm8150-gpio"
 		    "qcom,pm8150b-gpio"
+		    "qcom,pm6150-gpio"
+		    "qcom,pm6150l-gpio"
 
 		    And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
 		    if the device is on an spmi bus or an ssbi bus respectively

Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt to specify in a pin configuration subnode: · line 106

Quoted 5 lines
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +2 -0
@@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
 					     and gpio8)
 		    gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
 		    gpio1-gpio12 for pm8150l (hole on gpio7)
+		    gpio1-gpio10 for pm6150
+		    gpio1-gpio12 for pm6150l

No holes on these?

Other than this:

Quoted 19 lines
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +0 -0
 - function:
 	Usage: required
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +2 -0
index f1fece5..387917c 100644
@@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct platform_device *pdev)
 	{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
 	/* pm8150l has 12 GPIOs with holes on 7 */
 	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
+	{ .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
 	{ },
 };
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
 a Linux Foundation Collaborative Project
Signature · 1 line
~Vinod
#4 lore raw
Quoted 21 lines · Vinod Koul
Quoted 20 lines · Kiran Gunda

Add support for the PM6150 and PM6150L GPIO support to the Qualcomm PMIC GPIO binding.

---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c                     | 2 ++
 2 files changed, 6 insertions(+)
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +2 -0
index c32bf32..2f48cca 100644
@@ -23,6 +23,8 @@ PMIC's from Qualcomm.
 		    "qcom,pms405-gpio"
 		    "qcom,pm8150-gpio"
 		    "qcom,pm8150b-gpio"
+		    "qcom,pm6150-gpio"
+		    "qcom,pm6150l-gpio"
 
Quoted 11 lines

Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt to specify in a pin configuration subnode: · line 106

Quoted 8 lines
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +2 -0
 		    And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
 		    if the device is on an spmi bus or an ssbi bus respectively
@@ -100,6 +102,8 @@ to specify in a pin configuration subnode:
 					     and gpio8)
 		    gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7)
 		    gpio1-gpio12 for pm8150l (hole on gpio7)
+		    gpio1-gpio10 for pm6150
+		    gpio1-gpio12 for pm6150l

No holes on these?

Yes. No holes.

Quoted 24 lines

Other than this:

Quoted 20 lines
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +0 -0
 - function:
 	Usage: required
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +2 -1
index f1fece5..387917c 100644
@@ -1121,6 +1121,8 @@ static int pmic_gpio_remove(struct 
 platform_device *pdev)
 	{ .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 },
 	/* pm8150l has 12 GPIOs with holes on 7 */
 	{ .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 },
+	{ .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
+	{ .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
 	{ },
 };
 
--

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project