patch "USB: legousbtower: fix slab info leak at probe" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: legousbtower: fix slab info leak at probe
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 1d427be4a39defadda6dd8f4659bc17f7591740f Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Thu, 19 Sep 2019 10:30:36 +0200
Subject: USB: legousbtower: fix slab info leak at probe
Make sure to check for short transfers when retrieving the version information at probe to avoid leaking uninitialised slab data when logging it.
--- drivers/usb/misc/legousbtower.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/misc/legousbtower.c +4 -2
@@ -891,8 +891,10 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device get_version_reply,sizeof (*get_version_reply), 1000); -if (result <0 ) { -dev_err (idev,"LEGO USB Tower get version control request failed\n" ); +if (result <sizeof (*get_version_reply)) { +if (result >=0 ) + result = -EIO ; +dev_err (idev,"get version request failed: %d\n" , result); retval = result; goto error; }
Signature · 1 line
2.23.0