patch "USB: usblp: fix runtime PM after driver unbind" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: usblp: fix runtime PM after driver unbind
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 9a31535859bfd8d1c3ed391f5e9247cd87bb7909 Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Tue, 1 Oct 2019 10:49:06 +0200
Subject: USB: usblp: fix runtime PM after driver unbind
Since commit c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") USB drivers must always balance their runtime PM gets and puts, including when the driver has already been unbound from the interface.
Leaving the interface with a positive PM usage counter would prevent a later bound driver from suspending the device.
--- drivers/usb/class/usblp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/usb/class/usblp.c +5 -3
@@ -461,10 +461,12 @@ static int usblp_release(struct inode *inode, struct file *file)mutex_lock (&usblp_mutex); usblp->used =0 ; -if (usblp->present) { +if (usblp->present)usblp_unlink_urbs (usblp); -usb_autopm_put_interface (usblp->intf); - }else /* finish cleanup from disconnect */ + +usb_autopm_put_interface (usblp->intf); + +if (!usblp->present)/* finish cleanup from disconnect */ usblp_cleanup (usblp);mutex_unlock (&usblp_mutex);return 0 ;
Signature · 1 line
2.23.0