Skip to contentSkip to conversation

convert xfs to use ERR_CAST

PATCH In review Eric Sandeen 4 participants 5 messages Apr 23, 2008 – Jul 24, 2008 XFS filesystem

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 convert xfs to use ERR_CAST

Looks like somehow xfs got missed in the conversion that
took place in e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f,
"Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f>"

Signed-off-by Eric Sandeen <[email protected]>

---

ndex: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
===================================================================

fs/xfs/linux-2.6/xfs_export.c +2 -2
@@ -167,7 +167,7 @@ xfs_fs_fh_to_dentry(struct super_block *
 	if (!inode)
 		return NULL;
 	if (IS_ERR(inode))
-		return ERR_PTR(PTR_ERR(inode));
+		return ERR_CAST(inode);
 	result = d_alloc_anon(inode);
 	if (!result) {
 		iput(inode);

@@ -198,7 +198,7 @@ xfs_fs_fh_to_parent(struct super_block *
 	if (!inode)
 		return NULL;
 	if (IS_ERR(inode))
-		return ERR_PTR(PTR_ERR(inode));
+		return ERR_CAST(inode);
 	result = d_alloc_anon(inode);
 	if (!result) {
 		iput(inode);
Acked-by on v1 1/1
#2 lore raw
In reply to Eric Sandeen
Quoted 5 lines · Eric Sandeen

Looks like somehow xfs got missed in the conversion that
took place in e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f,
"Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f>"

Signed-off-by Eric Sandeen <[email protected]>
Acked-by David Howells <[email protected]>
author
#3 lore raw
In reply to Eric Sandeen
Quoted 6 lines · Eric Sandeen

Looks like somehow xfs got missed in the conversion that
took place in e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f,
"Convert ERR_PTR(PTR_ERR(p)) instances to ERR_CAST(p) <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e231c2ee64eb1c5cd3c63c31da9dac7d888dcf7f>"

Signed-off-by Eric Sandeen <[email protected]>

---

ping.

This one's really, really, really easy :)

-Eric

Quoted 25 lines

ndex: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_export.c
===================================================================

fs/xfs/linux-2.6/xfs_export.c +2 -2
@@ -167,7 +167,7 @@ xfs_fs_fh_to_dentry(struct super_block *
 	if (!inode)
 		return NULL;
 	if (IS_ERR(inode))
-		return ERR_PTR(PTR_ERR(inode));
+		return ERR_CAST(inode);
 	result = d_alloc_anon(inode);
 	if (!result) {
 		iput(inode);

@@ -198,7 +198,7 @@ xfs_fs_fh_to_parent(struct super_block *
 	if (!inode)
 		return NULL;
 	if (IS_ERR(inode))
-		return ERR_PTR(PTR_ERR(inode));
+		return ERR_CAST(inode);
 	result = d_alloc_anon(inode);
 	if (!result) {
 		iput(inode);