Skip to contentSkip to conversation

net: usb: ax88179_178a: write mac to hardware in get_mac_addr

PATCH Applied Peter Fink 2 participants 2 messages Oct 10, 2019 – Oct 12, 2019

Subsystems (3)
lore
Share & tools
lore

Peter Fink

author
#0 lore raw

PATCH v2 1/1 net: usb: ax88179_178a: write mac to hardware in get_mac_addr

From: Peter Fink <[email protected]>

When the MAC address is supplied via device tree or a random MAC is generated it has to be written to the asix chip in order to receive any data.

Previously in 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree") this line was omitted because it seemed to work perfectly fine without it.

But it was simply not detected because the chip keeps the mac stored even beyond a reset and it was tested on a hardware with an integrated UPS where the asix chip was permanently powered on even throughout power cycles.

Fixes 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree")

---
v1->v2: fix citation style and add 'fixes' tag

 drivers/net/usb/ax88179_178a.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/usb/ax88179_178a.c +3 -0
index 5a58766..c5a6e75 100644
@@ -1235,6 +1235,9 @@ static void ax88179_get_mac_addr(struct usbnet *dev)
 		netdev_info(dev->net, "invalid MAC address, using random\n");
 		eth_hw_addr_random(dev->net);
 	}
+
+	ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN,
+			  dev->net->dev_addr);
 }
 
 static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

From: Peter Fink <[email protected]>
Date: Thu, 10 Oct 2019 15:00:22 +0200

Quoted 10 lines

From: Peter Fink <[email protected]>

When the MAC address is supplied via device tree or a random MAC is generated it has to be written to the asix chip in order to receive any data.

Previously in 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree") this line was omitted because it seemed to work perfectly fine without it.

Quoted 7 lines

But it was simply not detected because the chip keeps the mac stored even beyond a reset and it was tested on a hardware with an integrated UPS where the asix chip was permanently powered on even throughout power cycles.

Fixes 9fb137aef34e ("net: usb: ax88179_178a: allow optionally getting mac address from device tree")

Applied, thank you.