patch "USB: legousbtower: fix memleak on disconnect" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: legousbtower: fix memleak on disconnect
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2 Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Thu, 10 Oct 2019 14:58:35 +0200
Subject: USB: legousbtower: fix memleak on disconnect
If disconnect() races with release() after a process has been interrupted, release() could end up returning early and the driver would fail to free its driver data.
--- drivers/usb/misc/legousbtower.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/usb/misc/legousbtower.c +1 -4
@@ -419,10 +419,7 @@ static int tower_release (struct inode *inode, struct file *file) goto exit; } -if (mutex_lock_interruptible (&dev->lock)) { - retval = -ERESTARTSYS ; - goto exit; - } +mutex_lock (&dev->lock);if (dev->open_count !=1 ) { dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n",
Signature · 1 line
2.23.0