Skip to contentSkip to conversation

ARM: dts: imx6ul-14x14-evk.dtsi: configure USBOTG1 ID pinctrl

PATCH In review Peter Chen 2 participants 2 messages Oct 16, 2019 – Oct 26, 2019

Subsystems (2)
lore
Share & tools
lore

Peter Chen

author
#0 lore raw

PATCH 1/1 ARM: dts: imx6ul-14x14-evk.dtsi: configure USBOTG1 ID pinctrl

Without configuring this pinctrl, the ID value can't be got correctly, then, the dual-role switch can't work well.

---
 arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi +8 -0
index c2a9dd57e56a..ed3d993c25f7 100644
@@ -266,6 +266,8 @@
 
 &usbotg1 {
 	dr_mode = "otg";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usb_otg1>;
 	status = "okay";
 };
 
@@ -499,6 +501,12 @@
 		>;
 	};
 
+	pinctrl_usb_otg1: usbotg1grp {
+		fsl,pins = <
+			MX6UL_PAD_GPIO1_IO00__ANATOP_OTG1_ID	0x17059
+		>;
+	};
+
 	pinctrl_usdhc1: usdhc1grp {
 		fsl,pins = <
 			MX6UL_PAD_SD1_CMD__USDHC1_CMD     	0x17059
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 5 lines · Peter Chen

Without configuring this pinctrl, the ID value can't be got correctly, then, the dual-role switch can't work well.

Reviewed-by should generally go after Signed-off-by, as you create patch first and then people review it.

I flipped the order and applied the patch.

Shawn

Quoted 33 lines
---
 arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi +8 -0
index c2a9dd57e56a..ed3d993c25f7 100644
@@ -266,6 +266,8 @@
 
 &usbotg1 {
 	dr_mode = "otg";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_usb_otg1>;
 	status = "okay";
 };
 
@@ -499,6 +501,12 @@
 		>;
 	};
 
+	pinctrl_usb_otg1: usbotg1grp {
+		fsl,pins = <
+			MX6UL_PAD_GPIO1_IO00__ANATOP_OTG1_ID	0x17059
+		>;
+	};
+
 	pinctrl_usdhc1: usdhc1grp {
 		fsl,pins = <
 			MX6UL_PAD_SD1_CMD__USDHC1_CMD     	0x17059
Signature · 1 line
2.17.1