Skip to contentSkip to conversation

net/ice: fix queue index for switch filter

PATCH Applied Wei Zhao 2 participants 4 messages Oct 22, 2019 Network drivers

lore
Share & tools
lore

Wei Zhao

author
#0 lore raw

PATCH 1/1 net/ice: fix queue index for switch filter

When calculate queue index for queue action in
switch filter, vsi base queue should be included.

Fixes 24dc00c30907 ("net/ice: enable switch filter")
---
 drivers/net/ice/ice_switch_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_switch_filter.c +1 -1
index 6c96b6f..e1eaf91 100644
@@ -926,7 +926,7 @@ ice_switch_parse_action(struct ice_pf *pf,
 	uint16_t valid_qgrop_number[MAX_QGRP_NUM_TYPE] = {
 		 2, 4, 8, 16, 32, 64, 128};
 
-	base_queue = pf->base_queue;
+	base_queue = pf->base_queue + vsi->base_queue;
 	for (action = actions; action->type !=
 			RTE_FLOW_ACTION_TYPE_END; action++) {
 		action_type = action->type;
Signature · 1 line
2.7.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Wei Zhao

When calculate queue index for queue action in
switch filter, vsi base queue should be included.

Fixes 24dc00c30907 ("net/ice: enable switch filter")

Should be:

Fixes 57c4f2693588 ("net/ice: enable switch filter")
Quoted 22 lines

---
drivers/net/ice/ice_switch_filter.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_switch_filter.c +1 -1
index 6c96b6f..e1eaf91 100644
@@ -926,7 +926,7 @@ ice_switch_parse_action(struct ice_pf *pf,
 	uint16_t valid_qgrop_number[MAX_QGRP_NUM_TYPE] = {
 		 2, 4, 8, 16, 32, 64, 128};
 
-	base_queue = pf->base_queue;
+	base_queue = pf->base_queue + vsi->base_queue;
 	for (action = actions; action->type !=
 			RTE_FLOW_ACTION_TYPE_END; action++) {
 		action_type = action->type;
Signature · 1 line
2.7.5
Applied
#2 lore raw
In reply to Wei Zhao
Quoted 27 lines · Wei Zhao

When calculate queue index for queue action in
switch filter, vsi base queue should be included.

Fixes 24dc00c30907 ("net/ice: enable switch filter")

---
drivers/net/ice/ice_switch_filter.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_switch_filter.c +1 -1
index 6c96b6f..e1eaf91 100644
@@ -926,7 +926,7 @@ ice_switch_parse_action(struct ice_pf *pf,
 	uint16_t valid_qgrop_number[MAX_QGRP_NUM_TYPE] = {
 		 2, 4, 8, 16, 32, 64, 128};
 
-	base_queue = pf->base_queue;
+	base_queue = pf->base_queue + vsi->base_queue;
 	for (action = actions; action->type !=
 			RTE_FLOW_ACTION_TYPE_END; action++) {
 		action_type = action->type;
Signature · 1 line
2.7.5

Applied to dpdk-next-net-intel.

author
#3 lore raw

PATCH v2 1/1 net/ice: fix queue index for switch filter

In reply to Wei Zhao

When calculate queue index for queue action in
switch filter, vsi base queue should be included.

Fixes 57c4f2693588 ("net/ice: enable switch filter")
---
 drivers/net/ice/ice_switch_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/ice_switch_filter.c +1 -1
index 6c96b6f..e1eaf91 100644
@@ -926,7 +926,7 @@ ice_switch_parse_action(struct ice_pf *pf,
 	uint16_t valid_qgrop_number[MAX_QGRP_NUM_TYPE] = {
 		 2, 4, 8, 16, 32, 64, 128};
 
-	base_queue = pf->base_queue;
+	base_queue = pf->base_queue + vsi->base_queue;
 	for (action = actions; action->type !=
 			RTE_FLOW_ACTION_TYPE_END; action++) {
 		action_type = action->type;
Signature · 1 line
2.7.5