Skip to contentSkip to conversation

xsk: Enable AF_XDP by default.

PATCH In review William Tu 3 participants 3 messages Oct 22, 2019 – Oct 24, 2019

Subsystems (3)
lore
Share & tools
lore

William Tu

author
#0 lore raw

PATCH 1/1 xsk: Enable AF_XDP by default.

The patch enables XDP_SOCKETS and XDP_SOCKETS_DIAG used by AF_XDP, and its dependency on BPF_SYSCALL.

---
 init/Kconfig    | 2 +-
 net/xdp/Kconfig | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
init/Kconfig +1 -1
index b4daad2bac23..229eceeb93d4 100644
@@ -1631,7 +1631,7 @@ config BPF_SYSCALL
 	bool "Enable bpf() system call"
 	select BPF
 	select IRQ_WORK
-	default n
+	default y
 	help
 	  Enable the bpf() system call that allows to manipulate eBPF
 	  programs and maps via file descriptors.
net/xdp/Kconfig +2 -2
index 71af2febe72a..77fd51d6a5d7 100644
@@ -2,7 +2,7 @@
 config XDP_SOCKETS
 	bool "XDP sockets"
 	depends on BPF_SYSCALL
-	default n
+	default y
 	help
 	  XDP sockets allows a channel between XDP programs and
 	  userspace applications.
@@ -10,7 +10,7 @@ config XDP_SOCKETS
 config XDP_SOCKETS_DIAG
 	tristate "XDP sockets: monitoring interface"
 	depends on XDP_SOCKETS
-	default n
+	default y
 	help
 	  Support for PF_XDP sockets monitoring interface used by the ss tool.
 	  If unsure, say Y.
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Tue, 22 Oct 2019 16:58:31 -0700 William Tu <[email protected]> wrote:

The patch enables XDP_SOCKETS and XDP_SOCKETS_DIAG used by AF_XDP, and its dependency on BPF_SYSCALL.

Signature · 4 lines
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer
maintainer
#2 lore raw
In reply to William Tu

From: William Tu <[email protected]>
Date: Tue, 22 Oct 2019 16:58:31 -0700

Quoted 4 lines

The patch enables XDP_SOCKETS and XDP_SOCKETS_DIAG used by AF_XDP, and its dependency on BPF_SYSCALL.

I don't know about this, it's a big change.

The consumers who care will enable these things, and all of our test cases have appropriate config snippets to make sure they are enabled too.

I'm not applying this.