Skip to contentSkip to conversation

ASoC: rt5677: Make rt5677_spi_pcm_page static

PATCH In review zhong jiang 2 participants 6 messages Oct 24, 2019 – Oct 31, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rt5677: Make rt5677_spi_pcm_page static

The GCC complains the following warning.

sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?

---
 sound/soc/codecs/rt5677-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/rt5677-spi.c +1 -1
index 36c02d2..b412371 100644
@@ -362,7 +362,7 @@ static void rt5677_spi_copy_work(struct work_struct *work)
 	mutex_unlock(&rt5677_dsp->dma_lock);
 }
 
-struct page *rt5677_spi_pcm_page(
+static struct page *rt5677_spi_pcm_page(
 		struct snd_soc_component *component,
 		struct snd_pcm_substream *substream,
 		unsigned long offset)
Signature · 1 line
1.7.12.4
#1 lore raw

ping.

Quoted 22 lines · zhong jiang

The GCC complains the following warning.

sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?

---
 sound/soc/codecs/rt5677-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/rt5677-spi.c +1 -1
index 36c02d2..b412371 100644
@@ -362,7 +362,7 @@ static void rt5677_spi_copy_work(struct work_struct *work)
 	mutex_unlock(&rt5677_dsp->dma_lock);
 }
 
-struct page *rt5677_spi_pcm_page(
+static struct page *rt5677_spi_pcm_page(
 		struct snd_soc_component *component,
 		struct snd_pcm_substream *substream,
 		unsigned long offset)
maintainer
#2 lore raw
Quoted 2 lines · zhong jiang

ping.
On 2019/10/24 20:15, zhong jiang wrote:

Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.

A message that is not in the archive (sent off-list or not yet received): [email protected]

maintainer
#4 lore raw
Quoted 6 lines · zhong jiang

On 2019/10/29 20:24, Mark Brown wrote:

I send the patch, but alway receive the following responses.

This message is from the Forcepoint email protection system, Forcepoint Email Security at host huawei.com.

Quoted 8 lines

The attached email could not be delivered to one or more recipients.

For assistance, please contact your email system administrator and include the following problem report:

<[email protected]>: host rtits1.realtek.com[211.75.126.71] said: 553 5.7.1 <[email protected]>: host rtits1.realtek.com[211.75.126.71] said: 553

Do the mails fails to send the receivers ? The mails is empty content. I have no ideas about that.

Bard left Realtek and I think Oder did too though I'm not 100% sure which is why mail to them is bouncing - but looking back I didn't get your original patch either though so you had some problem it seems (also you've not sent it to alsa-devel). As I said in the mail you're replying to probably best to resend.

maintainer
#5 lore raw
In reply to zhong jiang
Quoted 3 lines · zhong jiang

The GCC complains the following warning.

sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?

It looks like this has been fixed already in the latest code.

#6 lore raw
Quoted 5 lines · Mark Brown
Quoted 3 lines · zhong jiang

The GCC complains the following warning.

sound/soc/codecs/rt5677-spi.c:365:13: warning: symbol 'rt5677_spi_pcm_page' was not declared. Should it be static?

It looks like this has been fixed already in the latest code.

Yes, I has noticed that.

Thanks,
zhong jiang