Amazon's Annapurna Labs POS Driver
Subsystems (2)
v7 cover Amazon's Annapurna Labs POS Driver
Amazon's Annapurna Labs SoCs include a Point of Serialization error logging unit that reports an error when a write error occurs (e.g. attempt to write to a read only register).This error shall be reported via the EDAC subsystem as uncorrectable-error.
This patch series introduces the support for this unit.
Changes since v6:
=================
- reworked the commit message for the driver patch
- dt-bindings: added -only to GPL-2.0
- fixed filename in MAINTAINERS
- added driver managed unwind
Changes since v5:
=================
- added missing include to dt binding
Changes since v4:
================
- fixed dt binding according to new dt scheme
- added back the use of _relaxed accessors
Changes since v3:
=================
- ported to be edac device
- converted dt-bindings to new scheme
- added unit address to dt example
Changes since v2:
=================
- squashed left shifting fix to the driver
Changes since v1:
=================
- move MODULE_ to the end of the file
- simplified resource remapping devm_platform_ioremap_resource()
- use platform_get_irq() instead of irq_of_parse_and_map()
- removed the use of _relaxed accessor in favor to the regular ones
- removed driver selected based on arch
- added casting to u64 before left shifting (reported by kbuild test robot)
Talel Shenhar (2):
dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS
soc: amazon: al-pos-edac: Introduce Amazon's Annapurna Labs POS EDAC
driver
.../bindings/edac/amazon,al-pos-edac.yaml | 41 +++++ MAINTAINERS | 7 + drivers/edac/Kconfig | 6 + drivers/edac/Makefile | 1 + drivers/edac/al_pos_edac.c | 174 +++++++++++++++++++++ 5 files changed, 229 insertions(+) create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml create mode 100644 drivers/edac/al_pos_edac.c
Signature · 1 line
2.7.4
PATCH v7 1/2 dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS
Document Amazon's Annapurna Labs POS SoC binding.
--- .../bindings/edac/amazon,al-pos-edac.yaml | 41 ++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml
Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml new file +41 -0
@@ -0,0 +1,41 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/edac/amazon,al-pos-edac.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amazon's Annapurna Labs POS + +maintainers: + - Talel Shenhar <[email protected]> + - Talel Shenhar <[email protected]> + +description: | + POS node is defined to describe the Point Of Serialization (POS) error + detection capability. + +properties: + + compatible: + const: "amazon,al-pos-edac" + + reg: + maxItems: 1 + + interrupts: + description: Interrupt for the error event. + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + edac@f0070084 { + compatible = "amazon,al-pos-edac"; + reg = <0x0 0xf0070084 0x0 0x00000008>; + interrupt-parent = <&amazon_system_fabric>; + interrupts = <24 IRQ_TYPE_LEVEL_HIGH>; + };
Signature · 1 line
2.7.4
PATCH v7 2/2 soc: amazon: al-pos-edac: Introduce Amazon's Annapurna Labs POS EDAC driver
In reply to Talel ShenharAmazon's Annapurna Labs SoCs include a Point of Serialization error logging unit that reports an error when a write error occurs (e.g. attempt to write to a read only register).
This error shall be reported via the EDAC subsystem as uncorrectable-error.
--- MAINTAINERS | 7 ++ drivers/edac/Kconfig | 6 ++ drivers/edac/Makefile | 1 + drivers/edac/al_pos_edac.c | 174 +++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 188 insertions(+) create mode 100644 drivers/edac/al_pos_edac.c
MAINTAINERS +7 -0
@@ -757,6 +757,13 @@ F: drivers/tty/serial/altera_jtaguart.c F: include/linux/altera_uart.h F: include/linux/altera_jtaguart.h +AMAZON ANNAPURNA LABS POS EDAC DRIVER +M: Talel Shenhar <[email protected]> +M: Talel Shenhar <[email protected]> +S: Maintained +F: Documentation/devicetree/bindings/edac/amazon,al-pos-edac.yaml +F: drivers/edac/al_pos_edac.c + AMAZON ANNAPURNA LABS THERMAL MMIO DRIVER M: Talel Shenhar <[email protected]> S: Maintained
drivers/edac/Kconfig +6 -0
@@ -100,6 +100,12 @@ config EDAC_AMD64_ERROR_INJECTION In addition, there are two control files, inject_read and inject_write, which trigger the DRAM ECC Read and Write respectively. +config EDAC_AL_POS + tristate "Amazon's Annapurna Labs POS EDAC driver" + depends on (ARCH_ALPINE || COMPILE_TEST) + help + Include support for the SoC POS EDAC error capability. + config EDAC_AMD76X tristate "AMD 76x (760, 762, 768)" depends on PCI && X86_32
drivers/edac/Makefile +1 -0
@@ -22,6 +22,7 @@ obj-$(CONFIG_EDAC_GHES) += ghes_edac.o edac_mce_amd-y := mce_amd.o obj-$(CONFIG_EDAC_DECODE_MCE) += edac_mce_amd.o +obj-$(CONFIG_EDAC_AL_POS) += al_pos_edac.o obj-$(CONFIG_EDAC_AMD76X) += amd76x_edac.o obj-$(CONFIG_EDAC_CPC925) += cpc925_edac.o obj-$(CONFIG_EDAC_I5000) += i5000_edac.o
drivers/edac/al_pos_edac.c new file +174 -0
174 lines not on this page · raw message
Signature · 1 line
2.7.4