ath11k: Fix target crash due to WBM_IDLE_LINK ring desc shortage
PATCH 1/1 ath11k: Fix target crash due to WBM_IDLE_LINK ring desc shortage
Make sure the number of WBM_IDLE_LINK ring descriptors is power of 2. This increases the number of descriptors to 32k from the current ~18k to fix the target assert because of the shortage in the descriptors in WBM_IDLE_LINK ring. Remove unnecessary power of 2 calculation in ath11k_dp_link_desc_setup() as it is not required after this change.
--- drivers/net/wireless/ath/ath11k/dp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath11k/dp.c +3 -3
@@ -478,6 +478,9 @@ static int ath11k_wbm_idle_ring_setup(struct ath11k_base *ab, u32 *n_link_desc) *n_link_desc = n_mpdu_link_desc + n_mpdu_queue_desc + n_tx_msdu_link_desc + n_rx_msdu_link_desc; +if (*n_link_desc & (*n_link_desc -1 )) + *n_link_desc =1 <<fls (*n_link_desc); + ret =ath11k_dp_srng_setup (ab, &dp->wbm_idle_ring,HAL_WBM_IDLE_LINK ,0 ,0 , *n_link_desc);if (ret) {
@@ -499,9 +502,6 @@ int ath11k_dp_link_desc_setup(struct ath11k_base *ab,u32 *desc;int i, ret; -if (n_link_desc & (n_link_desc -1 )) - n_link_desc =1 <<fls (n_link_desc); - tot_mem_sz = n_link_desc *HAL_LINK_DESC_SIZE ; tot_mem_sz +=HAL_LINK_DESC_ALIGN ;
Signature · 7 lines
2.7.4 _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 9 lines · Vasanthakumar Thiagarajan
Make sure the number of
WBM_IDLE_LINKring descriptors is power of 2. This increases the number of descriptors to 32k from the current ~18k to fix the target assert because of the shortage in the descriptors inWBM_IDLE_LINKring. Remove unnecessary power of 2 calculation inath11k_dp_link_desc_setup()as it is not required after this change.Signed-off-by Vasanthakumar Thiagarajan <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath11k-post-bringup branch of ath.git, thanks.
1415d842e71a ath11k: Fix target crash due to WBM_IDLE_LINK ring desc shortage
Signature · 9 lines
https://patchwork.kernel.org/patch/11216961/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k