Skip to contentSkip to conversation

drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic

PATCH In review allen 2 participants 4 messages Nov 4, 2019 – Nov 11, 2019

Subsystems (2)
lore
Share & tools
lore

allen

author
#0 lore raw

PATCH 1/1 drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic

According to VESA ENHANCED EXTENDED DISPLAY IDENTIFICATION DATA STANDARD (Defines EDID Structure Version 1, Revision 4) page: 39
How to determine whether the monitor support RB timing or not? EDID 1.4
First: read detailed timing descriptor and make sure byte0 = 0,

	byte1 = 0, byte2 = 0 and byte3 = 0xFD

Second: read detailed timing descriptor byte10 = 0x04 and
EDID byte18h bit0 = 1
Third: if EDID byte18h bit0 == 1 && byte10 == 0x04,
then we can check byte15, if byte15 bit4 =1 is support RB if EDID byte18h bit0 != 1 || byte10 != 0x04, then byte15 can not be used

The linux code is_rb function not follow the VESA's rule

EDID 1.3
LCD flat panels do not require long blanking intervals as a retrace period so default support reduced-blanking timings.

---
 drivers/gpu/drm/drm_edid.c | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)
drivers/gpu/drm/drm_edid.c +21 -7
index e5e7e65..9b67b80 100644
@@ -93,6 +93,11 @@ struct detailed_mode_closure {
 	int modes;
 };
 
+struct edid_support_rb_closure {
+	struct edid *edid;
+	s8 support_rb;
+};
+
 #define LEVEL_DMT	0
 #define LEVEL_GTF	1
 #define LEVEL_GTF2	2
@@ -2018,22 +2023,31 @@ struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev,
 is_rb(struct detailed_timing *t, void *data)
 {
 	u8 *r = (u8 *)t;
-	if (r[3] == EDID_DETAIL_MONITOR_RANGE)
-		if (r[15] & 0x10)
-			*(bool *)data = true;
+	struct edid_support_rb_closure *closure = data;
+	struct edid *edid = closure->edid;
+
+	if (!r[0] && !r[1] && !r[2] && r[3] == EDID_DETAIL_MONITOR_RANGE) {
+		if (edid->features & BIT(0) && r[10] == BIT(2))
+			closure->support_rb = (r[15] & 0x10) ? 1 : 0;
+	}
 }
 
 /* EDID 1.4 defines this explicitly.  For EDID 1.3, we guess, badly. */
 static bool
 drm_monitor_supports_rb(struct edid *edid)
 {
+	struct edid_support_rb_closure closure = {
+		.edid = edid,
+		.support_rb = -1,
+	};
+
 	if (edid->revision >= 4) {
-		bool ret = false;
-		drm_for_each_detailed_block((u8 *)edid, is_rb, &ret);
-		return ret;
+		drm_for_each_detailed_block((u8 *)edid, is_rb, &closure);
+		if (closure.support_rb >= 0)
+			return closure.support_rb;
 	}
 
-	return ((edid->input & DRM_EDID_INPUT_DIGITAL) != 0);
+	return true;
 }
 
 static void
Signature · 1 line
1.9.1
#1 lore raw
Quoted 6 lines · allen

According to VESA ENHANCED EXTENDED DISPLAY IDENTIFICATION DATA STANDARD (Defines EDID Structure Version 1, Revision 4) page: 39
How to determine whether the monitor support RB timing or not? EDID 1.4
First: read detailed timing descriptor and make sure byte0 = 0,

	byte1 = 0, byte2 = 0 and byte3 = 0xFD

That should probably be some new function:
bool is_display_descriptor(const u8 *desc, u8 tag); is_display_descriptor(EDID_DETAIL_MONITOR_RANGE) or something along those lines

We don't seem to check that in most places so should be rolled out all over. The usage of struct detailed_timing all over also makes everything rather confusing.

Quoted 2 lines

Second: read detailed timing descriptor byte10 = 0x04 and
EDID byte18h bit0 = 1

Indicates CVT support. Should give these things real names so one wouldn't have to decode by hand.

Quoted 22 lines

Third: if EDID byte18h bit0 == 1 && byte10 == 0x04,
then we can check byte15, if byte15 bit4 =1 is support RB if EDID byte18h bit0 != 1 || byte10 != 0x04, then byte15 can not be used

The linux code is_rb function not follow the VESA's rule

EDID 1.3
LCD flat panels do not require long blanking intervals as a retrace period so default support reduced-blanking timings.

---
 drivers/gpu/drm/drm_edid.c | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)
drivers/gpu/drm/drm_edid.c +0 -0
index e5e7e65..9b67b80 100644

drivers/gpu/drm/drm_edid.c struct detailed_mode_closure { · line 98

Quoted 6 lines
drivers/gpu/drm/drm_edid.c +3 -0
@@ -93,6 +93,11 @@ struct detailed_mode_closure {
 	int modes;
 };
 
+struct edid_support_rb_closure {
+	struct edid *edid;
+	s8 support_rb;

bool

Quoted 8 lines
drivers/gpu/drm/drm_edid.c +2 -0
+};
+
 #define LEVEL_DMT	0
 #define LEVEL_GTF	1
 #define LEVEL_GTF2	2
@@ -2018,22 +2023,31 @@ struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev,
 is_rb(struct detailed_timing *t, void *data)
 {

drivers/gpu/drm/drm_edid.c struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev, · line 2031

Quoted 10 lines
drivers/gpu/drm/drm_edid.c +6 -3
 	u8 *r = (u8 *)t;
-	if (r[3] == EDID_DETAIL_MONITOR_RANGE)
-		if (r[15] & 0x10)
-			*(bool *)data = true;
+	struct edid_support_rb_closure *closure = data;
+	struct edid *edid = closure->edid;
+
+	if (!r[0] && !r[1] && !r[2] && r[3] == EDID_DETAIL_MONITOR_RANGE) {
+		if (edid->features & BIT(0) && r[10] == BIT(2))
+			closure->support_rb = (r[15] & 0x10) ? 1 : 0;

With the bool the ternary operator is not needed. Also should maybe be |= in case we have multiple range descriptors? Not sure that is legal.

Quoted 13 lines
drivers/gpu/drm/drm_edid.c +6 -0
+	}
 }
 
 /* EDID 1.4 defines this explicitly.  For EDID 1.3, we guess, badly. */
 static bool
 drm_monitor_supports_rb(struct edid *edid)
 {
+	struct edid_support_rb_closure closure = {
+		.edid = edid,
+		.support_rb = -1,
+	};
+
 	if (edid->revision >= 4) {

drivers/gpu/drm/drm_edid.c struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev, · line 2050

Quoted 10 lines
drivers/gpu/drm/drm_edid.c +4 -4
-		bool ret = false;
-		drm_for_each_detailed_block((u8 *)edid, is_rb, &ret);
-		return ret;
+		drm_for_each_detailed_block((u8 *)edid, is_rb, &closure);
+		if (closure.support_rb >= 0)
+			return closure.support_rb;
 	}
 
-	return ((edid->input & DRM_EDID_INPUT_DIGITAL) != 0);
+	return true;

Why are we now assuming rb for all pre 1.4 EDIDs?

Quoted 10 lines
drivers/gpu/drm/drm_edid.c +0 -0
 }
 
 static void
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 2 lines
Ville Syrjälä
Intel
#2 lore raw

Hi Ville Syrjälä

Thanks for your suggestion and I have replied two comments below.

From: Ville Syrjälä [mailto:[email protected]]
Sent: Thursday, November 07, 2019 11:42 PM
To: Allen Chen (陳柏宇)
Cc: Jau-Chih Tseng (曾昭智); Maxime Ripard; open list; open list:DRM DRIVERS; David Airlie; Pi-Hsun Shih; Sean Paul
Subject: Re: [PATCH] drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic

Quoted 6 lines · allen

According to VESA ENHANCED EXTENDED DISPLAY IDENTIFICATION DATA STANDARD (Defines EDID Structure Version 1, Revision 4) page: 39
How to determine whether the monitor support RB timing or not? EDID 1.4
First: read detailed timing descriptor and make sure byte0 = 0,

	byte1 = 0, byte2 = 0 and byte3 = 0xFD

That should probably be some new function:
bool is_display_descriptor(const u8 *desc, u8 tag); is_display_descriptor(EDID_DETAIL_MONITOR_RANGE) or something along those lines

We don't seem to check that in most places so should be rolled out all over. The usage of struct detailed_timing all over also makes everything rather confusing.

Quoted 2 lines

Second: read detailed timing descriptor byte10 = 0x04 and
EDID byte18h bit0 = 1

Indicates CVT support. Should give these things real names so one wouldn't have to decode by hand.

Quoted 22 lines

Third: if EDID byte18h bit0 == 1 && byte10 == 0x04,
then we can check byte15, if byte15 bit4 =1 is support RB if EDID byte18h bit0 != 1 || byte10 != 0x04, then byte15 can not be used

The linux code is_rb function not follow the VESA's rule

EDID 1.3
LCD flat panels do not require long blanking intervals as a retrace period so default support reduced-blanking timings.

---
 drivers/gpu/drm/drm_edid.c | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)
drivers/gpu/drm/drm_edid.c +0 -0
index e5e7e65..9b67b80 100644

drivers/gpu/drm/drm_edid.c struct detailed_mode_closure { · line 98

Quoted 6 lines
drivers/gpu/drm/drm_edid.c +3 -0
@@ -93,6 +93,11 @@ struct detailed_mode_closure {
 	int modes;
 };
 
+struct edid_support_rb_closure {
+	struct edid *edid;
+	s8 support_rb;

bool

==> ITE: If use bool, we could not return EDID1.3 when EDID1.4 logic can not be applied

Quoted 8 lines
drivers/gpu/drm/drm_edid.c +2 -0
+};
+
 #define LEVEL_DMT	0
 #define LEVEL_GTF	1
 #define LEVEL_GTF2	2
@@ -2018,22 +2023,31 @@ struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev,
 is_rb(struct detailed_timing *t, void *data)
 {

drivers/gpu/drm/drm_edid.c struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev, · line 2031

Quoted 10 lines
drivers/gpu/drm/drm_edid.c +6 -3
 	u8 *r = (u8 *)t;
-	if (r[3] == EDID_DETAIL_MONITOR_RANGE)
-		if (r[15] & 0x10)
-			*(bool *)data = true;
+	struct edid_support_rb_closure *closure = data;
+	struct edid *edid = closure->edid;
+
+	if (!r[0] && !r[1] && !r[2] && r[3] == EDID_DETAIL_MONITOR_RANGE) {
+		if (edid->features & BIT(0) && r[10] == BIT(2))
+			closure->support_rb = (r[15] & 0x10) ? 1 : 0;

With the bool the ternary operator is not needed. Also should maybe be |= in case we have multiple range descriptors? Not sure that is legal.

Quoted 13 lines
drivers/gpu/drm/drm_edid.c +6 -0
+	}
 }
 
 /* EDID 1.4 defines this explicitly.  For EDID 1.3, we guess, badly. */
 static bool
 drm_monitor_supports_rb(struct edid *edid)
 {
+	struct edid_support_rb_closure closure = {
+		.edid = edid,
+		.support_rb = -1,
+	};
+
 	if (edid->revision >= 4) {

drivers/gpu/drm/drm_edid.c struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev, · line 2050

Quoted 10 lines
drivers/gpu/drm/drm_edid.c +4 -4
-		bool ret = false;
-		drm_for_each_detailed_block((u8 *)edid, is_rb, &ret);
-		return ret;
+		drm_for_each_detailed_block((u8 *)edid, is_rb, &closure);
+		if (closure.support_rb >= 0)
+			return closure.support_rb;
 	}
 
-	return ((edid->input & DRM_EDID_INPUT_DIGITAL) != 0);
+	return true;

Why are we now assuming rb for all pre 1.4 EDIDs?

==> ITE: Today, most of the monitor are LCD and LCD monitor do not require long blanking intervals as a retrace period so default support reduced-blanking timings.

Quoted 10 lines
drivers/gpu/drm/drm_edid.c +0 -0
 }
 
 static void
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 2 lines
Ville Syrjälä
Intel
#3 lore raw
Quoted 58 lines · On Mon, Nov 11, 2019 at 01:43:52AM +0000, [email protected] wrote:

Hi Ville Syrjälä

Thanks for your suggestion and I have replied two comments below.

From: Ville Syrjälä [mailto:[email protected]]
Sent: Thursday, November 07, 2019 11:42 PM
To: Allen Chen (陳柏宇)
Cc: Jau-Chih Tseng (曾昭智); Maxime Ripard; open list; open list:DRM DRIVERS; David Airlie; Pi-Hsun Shih; Sean Paul
Subject: Re: [PATCH] drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic

Quoted 6 lines · allen

According to VESA ENHANCED EXTENDED DISPLAY IDENTIFICATION DATA STANDARD (Defines EDID Structure Version 1, Revision 4) page: 39
How to determine whether the monitor support RB timing or not? EDID 1.4
First: read detailed timing descriptor and make sure byte0 = 0,

	byte1 = 0, byte2 = 0 and byte3 = 0xFD

That should probably be some new function:
bool is_display_descriptor(const u8 *desc, u8 tag); is_display_descriptor(EDID_DETAIL_MONITOR_RANGE) or something along those lines

We don't seem to check that in most places so should be rolled out all over. The usage of struct detailed_timing all over also makes everything rather confusing.

Quoted 2 lines

Second: read detailed timing descriptor byte10 = 0x04 and
EDID byte18h bit0 = 1

Indicates CVT support. Should give these things real names so one wouldn't have to decode by hand.

Quoted 25 lines

Third: if EDID byte18h bit0 == 1 && byte10 == 0x04,
then we can check byte15, if byte15 bit4 =1 is support RB if EDID byte18h bit0 != 1 || byte10 != 0x04, then byte15 can not be used

The linux code is_rb function not follow the VESA's rule

EDID 1.3
LCD flat panels do not require long blanking intervals as a retrace period so default support reduced-blanking timings.

---
 drivers/gpu/drm/drm_edid.c | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)
drivers/gpu/drm/drm_edid.c +0 -0
index e5e7e65..9b67b80 100644
@@ -93,6 +93,11 @@ struct detailed_mode_closure {
 	int modes;
 };
 
Quoted 7 lines

drivers/gpu/drm/drm_edid.c struct detailed_mode_closure { · line 98

Quoted 3 lines
drivers/gpu/drm/drm_edid.c +3 -0
+struct edid_support_rb_closure {
+	struct edid *edid;
+	s8 support_rb;

bool

==> ITE: If use bool, we could not return EDID1.3 when EDID1.4 logic can not be applied

Hmm. Could use two bools then.

Quoted 44 lines
Quoted 8 lines
drivers/gpu/drm/drm_edid.c +2 -0
+};
+
 #define LEVEL_DMT	0
 #define LEVEL_GTF	1
 #define LEVEL_GTF2	2
@@ -2018,22 +2023,31 @@ struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev,
 is_rb(struct detailed_timing *t, void *data)
 {

drivers/gpu/drm/drm_edid.c struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev, · line 2031

Quoted 10 lines
drivers/gpu/drm/drm_edid.c +6 -3
 	u8 *r = (u8 *)t;
-	if (r[3] == EDID_DETAIL_MONITOR_RANGE)
-		if (r[15] & 0x10)
-			*(bool *)data = true;
+	struct edid_support_rb_closure *closure = data;
+	struct edid *edid = closure->edid;
+
+	if (!r[0] && !r[1] && !r[2] && r[3] == EDID_DETAIL_MONITOR_RANGE) {
+		if (edid->features & BIT(0) && r[10] == BIT(2))
+			closure->support_rb = (r[15] & 0x10) ? 1 : 0;

With the bool the ternary operator is not needed. Also should maybe be |= in case we have multiple range descriptors? Not sure that is legal.

Quoted 21 lines
drivers/gpu/drm/drm_edid.c +9 -3
+	}
 }
 
 /* EDID 1.4 defines this explicitly.  For EDID 1.3, we guess, badly. */
 static bool
 drm_monitor_supports_rb(struct edid *edid)
 {
+	struct edid_support_rb_closure closure = {
+		.edid = edid,
+		.support_rb = -1,
+	};
+
 	if (edid->revision >= 4) {
-		bool ret = false;
-		drm_for_each_detailed_block((u8 *)edid, is_rb, &ret);
-		return ret;
+		drm_for_each_detailed_block((u8 *)edid, is_rb, &closure);
+		if (closure.support_rb >= 0)
+			return closure.support_rb;
 	}
 
Quoted 6 lines

drivers/gpu/drm/drm_edid.c struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev, · line 2050

Quoted 2 lines
drivers/gpu/drm/drm_edid.c +1 -1
-	return ((edid->input & DRM_EDID_INPUT_DIGITAL) != 0);
+	return true;

Why are we now assuming rb for all pre 1.4 EDIDs?

==> ITE: Today, most of the monitor are LCD and LCD monitor do not require long blanking intervals as a retrace period so default support reduced-blanking timings.

You can't assume such things. Someone out there is surely still using something that doesn't do reduced blanking.

Quoted 15 lines
Quoted 11 lines
drivers/gpu/drm/drm_edid.c +0 -0
 }
 
 static void
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 2 lines
Ville Syrjälä
Intel
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel