net: qualcomm: rmnet: Fix potential UAF when unregistering
Subsystems (3)
PATCH v2 1/1 net: qualcomm: rmnet: Fix potential UAF when unregistering
During the exit/unregistration process of the RmNet driver, the function rmnet_unregister_real_device() is called to handle freeing the driver's internal state and removing the RX handler on the underlying physical device. However, the order of operations this function performs is wrong and can lead to a use after free of the rmnet_port structure.
Before calling netdev_rx_handler_unregister(), this port structure is freed with kfree(). If packets are received on any RmNet devices before synchronize_net() completes, they will attempt to use this already-freed port structure when processing the packet. As such, before cleaning up any other internal state, the RX handler must be unregistered in order to guarantee that no further packets will arrive on the device.
---
v1 -> v2: Added missing Fixes tag
drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c +2 -2
@@ -57,10 +57,10 @@ static int rmnet_unregister_real_device(struct net_device *real_dev,if (port->nr_rmnet_devs)return -EINVAL ; -kfree (port); -netdev_rx_handler_unregister (real_dev); +kfree (port); +/* release reference on real_dev */ dev_put (real_dev);
Signature · 1 line
1.9.1
David Miller
maintainerFrom: Sean Tranchetti <[email protected]>
Date: Mon, 4 Nov 2019 17:54:22 -0700
Quoted 13 lines
During the exit/unregistration process of the RmNet driver, the function
rmnet_unregister_real_device()is called to handle freeing the driver's internal state and removing the RX handler on the underlying physical device. However, the order of operations this function performs is wrong and can lead to a use after free of thermnet_portstructure.Before calling
netdev_rx_handler_unregister(), this port structure is freed withkfree(). If packets are received on any RmNet devices beforesynchronize_net()completes, they will attempt to use this already-freed port structure when processing the packet. As such, before cleaning up any other internal state, the RX handler must be unregistered in order to guarantee that no further packets will arrive on the device.
Quoted 2 lines
Fixes ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")Signed-off-by Sean Tranchetti <[email protected]>
Applied and queued up for -stable, thanks.