NFC: fdp: fix incorrect free object
Subsystems (3)
PATCH 1/1 NFC: fdp: fix incorrect free object
The address of fw_vsc_cfg is on stack. Releasing it with devm_kfree() is incorrect, which may result in a system crash or other security impacts. The expected object to free is *fw_vsc_cfg.
Signed-off-by Pan Bian <[email protected]>
--- drivers/nfc/fdp/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nfc/fdp/i2c.c +1 -1
@@ -259,7 +259,7 @@ static void fdp_nci_i2c_read_device_properties(struct device *dev, *fw_vsc_cfg, len);if (r) { -devm_kfree (dev, fw_vsc_cfg); +devm_kfree (dev, *fw_vsc_cfg); goto vsc_read_err; } }else {
Signature · 1 line
2.7.4
David Miller
maintainerFrom: Pan Bian <[email protected]>
Date: Tue, 5 Nov 2019 16:34:07 +0800
Quoted 5 lines
The address of
fw_vsc_cfgis on stack. Releasing it withdevm_kfree()is incorrect, which may result in a system crash or other security impacts. The expected object to free is*fw_vsc_cfg.Signed-off-by Pan Bian <[email protected]>
Applied and queued up for -stable, thanks.