mm: rmap: use VM_BUG_ON_PAGE() in __page_check_anon_rmap()
Subsystems (2)
PATCH v2 1/1 mm: rmap: use VM_BUG_ON_PAGE() in __page_check_anon_rmap()
The __page_check_anon_rmap() just calls two BUG_ON()s protected by CONFIG_DEBUG_VM, the #ifdef could be eliminated by using VM_BUG_ON_PAGE().
Cc Kirill A. Shutemov <[email protected]>
Signed-off-by Yang Shi <[email protected]>
---
v2: Use VM_BUG_ON_PAGE() per Kirill and update the subject accordingly.
mm/rmap.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
mm/rmap.c +3 -4
@@ -1055,7 +1055,6 @@ static void __page_set_anon_rmap(struct page *page,static void __page_check_anon_rmap (struct page *page,struct vm_area_struct *vma,unsigned long address) { -#ifdef CONFIG_DEBUG_VM /* * The page's anon-rmap details (mapping and index) are guaranteed to * be set up correctly at this point.
@@ -1068,9 +1067,9 @@ static void __page_check_anon_rmap(struct page *page,* are initially only visible via the pagetables, and the pte is locked * over the call to page_add_new_anon_rmap. */ -BUG_ON (page_anon_vma (page)->root != vma->anon_vma->root); -BUG_ON (page_to_pgoff (page) !=linear_page_index (vma, address)); -#endif +VM_BUG_ON_PAGE (page_anon_vma (page)->root != vma->anon_vma->root, page); +VM_BUG_ON_PAGE (page_to_pgoff (page) !=linear_page_index (vma, address), + page); }/**
Signature · 1 line
1.8.3.1
Quoted 5 lines · Yang Shi
The
__page_check_anon_rmap()just calls two BUG_ON()s protected byCONFIG_DEBUG_VM, the #ifdef could be eliminated by usingVM_BUG_ON_PAGE().Cc Kirill A. Shutemov <[email protected]>Signed-off-by Yang Shi <[email protected]>
Signature · 1 line
Kirill A. Shutemov