media: rockchip/rga: fix potential use after free
PATCH v2 1/1 media: rockchip/rga: fix potential use after free
The variable vga->vfd is an alias for vfd. Therefore, releasing vfd and then unregister vga->vfd will lead to a use after free bug. In fact, the free operation and the unregister operation are reversed.
---
v2: update the goto label names consistently
--- drivers/media/platform/rockchip/rga/rga.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/media/platform/rockchip/rga/rga.c +4 -4
@@ -863,7 +863,7 @@ static int rga_probe(struct platform_device *pdev)if (IS_ERR (rga->m2m_dev)) {v4l2_err (&rga->v4l2_dev,"Failed to init mem2mem device\n" ); ret =PTR_ERR (rga->m2m_dev); - goto unreg_video_dev; + goto rel_vdev; }pm_runtime_get_sync (rga->dev);
@@ -892,7 +892,7 @@ static int rga_probe(struct platform_device *pdev) ret =video_register_device (vfd,VFL_TYPE_GRABBER ,-1 );if (ret) {v4l2_err (&rga->v4l2_dev,"Failed to register video device\n" ); - goto rel_vdev; + goto unreg_dev; } v4l2_info(&rga->v4l2_dev, "Registered %s as /dev/%s\n",
@@ -900,10 +900,10 @@ static int rga_probe(struct platform_device *pdev)return 0 ; +unreg_dev: +video_unregister_device (rga->vfd); rel_vdev:video_device_release (vfd); -unreg_video_dev: -video_unregister_device (rga->vfd); unreg_v4l2_dev:v4l2_device_unregister (&rga->v4l2_dev); err_put_clk:
Signature · 1 line
2.7.4
Hi Pan Bian,
Thanks for the patch.
Quoted 4 lines · Pan Bian
The variable
vga->vfdis an alias for vfd. Therefore, releasing vfd and then unregistervga->vfdwill lead to a use after free bug. In fact, the free operation and the unregister operation are reversed.
Out of curiosity, how did you find this potential bug?
Regards,
Ezequiel
Quoted 34 lines · Pan Bian
The variable
vga->vfdis an alias for vfd. Therefore, releasing vfd and then unregistervga->vfdwill lead to a use after free bug. In fact, the free operation and the unregister operation are reversed.Signed-off-by Pan Bian <[email protected]>---
v2: update the goto label names consistently--- drivers/media/platform/rockchip/rga/rga.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/media/platform/rockchip/rga/rga.c +2
-2@@ -863,7 +863,7 @@ static int rga_probe(struct platform_device *pdev)if (IS_ERR (rga->m2m_dev)) {v4l2_err (&rga->v4l2_dev,"Failed to init mem2mem device\n" ); ret =PTR_ERR (rga->m2m_dev); - goto unreg_video_dev; + goto rel_vdev; }pm_runtime_get_sync (rga->dev);@@ -892,7 +892,7 @@ static int rga_probe(struct platform_device *pdev) ret =video_register_device (vfd,VFL_TYPE_GRABBER ,-1 );if (ret) {v4l2_err (&rga->v4l2_dev,"Failed to register video device\n" ); - goto rel_vdev; + goto unreg_dev; } v4l2_info(&rga->v4l2_dev, "Registered %s as /dev/%s\n",
drivers/media/platform/rockchip/rga/rga.c static int rga_probe(struct platform_device *pdev) · line 904
Quoted 5 lines
drivers/media/platform/rockchip/rga/rga.c +2
-0@@ -900,10 +900,10 @@ static int rga_probe(struct platform_device *pdev)return 0 ; +unreg_dev: +video_unregister_device (rga->vfd);
This is wrong. If video_register_device fails, then you call video_device_release, not video_unregister_device. The unreg_video_dev case is bogus and should be removed.
Instead you need a v4l2_m2m_release() call to clean up the v4l2_m2m_init() result if there is an error.
Regards,
Hans
Quoted 8 lines
drivers/media/platform/rockchip/rga/rga.c +0
-2rel_vdev:video_device_release (vfd); -unreg_video_dev: -video_unregister_device (rga->vfd); unreg_v4l2_dev:v4l2_device_unregister (&rga->v4l2_dev); err_put_clk: