Skip to contentSkip to conversation

clk: tegra: clk-dfll: Fix to remove pm_runtime_irq_safe

PATCH In review Sowjanya Komatineni 3 participants 4 messages Nov 12, 2019 – Nov 13, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: tegra: clk-dfll: Fix to remove pm_runtime_irq_safe

This patch includes fix to remove pm_runtime_irq_safe which was added mistakenly during dfll suspend and resume implementation as a part of Tegra210 SC7 suspend and resume patch series.

This patch removes pm_runtime_irq_safe and also has minor description update for argument of dfll_suspend in comments.

Some of the patch series are applied so sending this fix as incremental fix to latest linux-next.

Sowjanya Komatineni (1):
clk: tegra: clk-dfll: Fix to remove pm_runtime_irq_safe

 drivers/clk/tegra/clk-dfll.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 clk: tegra: clk-dfll: Fix to remove pm_runtime_irq_safe

pm_runtime_irq_safe is not needed as interrupts are allowed during suspend and resume. This was added mistakenly during dfll suspend and resume support patch.

This patch includes fix to remove pm_runtime_irq_safe.

Also updated description of dfll_suspend argument.

---
 drivers/clk/tegra/clk-dfll.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/tegra/clk-dfll.c +1 -2
index c051d92c2bbf..cfbaa90c7adb 100644
@@ -1487,7 +1487,6 @@ static int dfll_init(struct tegra_dfll *td)
 	td->last_unrounded_rate = 0;
 
 	pm_runtime_enable(td->dev);
-	pm_runtime_irq_safe(td->dev);
 	pm_runtime_get_sync(td->dev);
 
 	dfll_set_mode(td, DFLL_DISABLED);
@@ -1516,7 +1515,7 @@ static int dfll_init(struct tegra_dfll *td)
 
 /**
  * tegra_dfll_suspend - check DFLL is disabled
- * @dev: DFLL device *
+ * @dev: DFLL instance
  *
  * DFLL clock should be disabled by the CPUFreq driver. So, make
  * sure it is disabled and disable all clocks needed by the DFLL.
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#2 lore raw

12.11.2019 19:17, Sowjanya Komatineni пишет:

Quoted 27 lines

pm_runtime_irq_safe is not needed as interrupts are allowed during suspend and resume. This was added mistakenly during dfll suspend and resume support patch.

This patch includes fix to remove pm_runtime_irq_safe.

Also updated description of dfll_suspend argument.

---
 drivers/clk/tegra/clk-dfll.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/tegra/clk-dfll.c +0 -1
index c051d92c2bbf..cfbaa90c7adb 100644
@@ -1487,7 +1487,6 @@ static int dfll_init(struct tegra_dfll *td)
 	td->last_unrounded_rate = 0;
 
 	pm_runtime_enable(td->dev);
-	pm_runtime_irq_safe(td->dev);
 	pm_runtime_get_sync(td->dev);
 
 	dfll_set_mode(td, DFLL_DISABLED);

drivers/clk/tegra/clk-dfll.c static int dfll_init(struct tegra_dfll *td) · line 1521

Quoted 8 lines
drivers/clk/tegra/clk-dfll.c +1 -1
@@ -1516,7 +1515,7 @@ static int dfll_init(struct tegra_dfll *td)
 
 /**
  * tegra_dfll_suspend - check DFLL is disabled
- * @dev: DFLL device *
+ * @dev: DFLL instance
  *
  * DFLL clock should be disabled by the CPUFreq driver. So, make
  * sure it is disabled and disable all clocks needed by the DFLL.

Hello Sowjanya,

It should be better to have the commit's title saying something more generic like "Clean up code" or to have two separate patches because this patch does two things that are unrelated to each other in accordance to the title and this is a bit confusing at first glance. Although, that's not a big deal for a trivial patch like this and it should be fine as is (IMO). Please take into account in the future patches that both commit's title and description should be accurate.

maintainer
#3 lore raw
In reply to Sowjanya Komatineni

Quoting Sowjanya Komatineni (2019-11-12 08:17:05)

Quoted 9 lines

This patch includes fix to remove pm_runtime_irq_safe which was added mistakenly during dfll suspend and resume implementation as a part of Tegra210 SC7 suspend and resume patch series.

This patch removes pm_runtime_irq_safe and also has minor description update for argument of dfll_suspend in comments.

Some of the patch series are applied so sending this fix as incremental fix to latest linux-next.

Please don't send cover letters for single patches. The value add is minimal vs. just putting extra text next to the diffstat in the single patch.

Quoted 6 lines

Sowjanya Komatineni (1):
clk: tegra: clk-dfll: Fix to remove pm_runtime_irq_safe

 drivers/clk/tegra/clk-dfll.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)