Skip to contentSkip to conversation

Add USB related nodes for SC7180

PATCH Superseded Sandeep Maheswaram 2 participants 4 messages Nov 14, 2019 – Nov 15, 2019

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add USB related nodes for SC7180

Add nodes for DWC3 USB controller, QMP and QUSB PHYs and enable them in idp device

This patch has dependency on below series

https://lkml.org/lkml/2019/11/8/149

changes in v2:
* Addressed Stephen's comments on sorting the include file and alignment issues.

Sandeep Maheswaram (1):
arm64: dts: qcom: sc7180: Add USB related nodes

 arch/arm64/boot/dts/qcom/sc7180-idp.dts |  25 ++++++++
 arch/arm64/boot/dts/qcom/sc7180.dtsi    | 105 ++++++++++++++++++++++++++++++++
 2 files changed, 130 insertions(+)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw

PATCH v2 1/1 arm64: dts: qcom: sc7180: Add USB related nodes

Add nodes for DWC3 USB controller, QMP and QUSB PHYs.

---
 arch/arm64/boot/dts/qcom/sc7180-idp.dts |  25 ++++++++
 arch/arm64/boot/dts/qcom/sc7180.dtsi    | 105 ++++++++++++++++++++++++++++++++
 2 files changed, 130 insertions(+)
arch/arm64/boot/dts/qcom/sc7180-idp.dts +25 -0
index 189254f..282d33e 100644
@@ -400,3 +400,28 @@
 			bias-pull-up;
 		};
 };
+
+&usb_1 {
+	status = "okay";
+};
+
+&usb_1_dwc3 {
+	dr_mode = "host";
+};
+
+&usb_1_hsphy {
+	status = "okay";
+	vdd-supply = <&vreg_l4a_0p8>;
+	vdda-pll-supply = <&vreg_l11a_1p8>;
+	vdda-phy-dpdm-supply = <&vreg_l17a_3p0>;
+	qcom,imp-res-offset-value = <8>;
+	qcom,hstx-trim-value = <QUSB2_V2_HSTX_TRIM_21_6_MA>;
+	qcom,preemphasis-level = <QUSB2_V2_PREEMPHASIS_5_PERCENT>;
+	qcom,preemphasis-width = <QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT>;
+};
+
+&usb_1_qmpphy {
+	status = "okay";
+	vdda-phy-supply = <&vreg_l3c_1p2>;
+	vdda-pll-supply = <&vreg_l4a_0p8>;
+};
arch/arm64/boot/dts/qcom/sc7180.dtsi +105 -0

123 lines not on this page · raw message

Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v2 1/1
#2 lore raw

Re: [PATCH v2 1/1] arm64: dts: qcom: sc7180: Add USB related nodes

Quoting Sandeep Maheswaram (2019-11-14 04:12:49)

Quoted 3 lines

Add nodes for DWC3 USB controller, QMP and QUSB PHYs.

One minor nit below.

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index 666e9b9..82f0b3a 100644
@@ -911,6 +924,98 @@
                        status = "disabled";

arch/arm64/boot/dts/qcom/sc7180.dtsi line 934

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +8 -0
                };
 
+               usb_1_hsphy: phy@88e3000 {
+                       compatible = "qcom,sc7180-qusb2-phy";
+                       reg = <0 0x088e3000 0 0x400>;
+                       status = "disabled";
+                       #phy-cells = <0>;
+                       clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>,
+                                <&rpmhcc RPMH_CXO_CLK>;
+                       clock-names = "cfg_ahb","ref";

Add a space after that comma please.

Quoted 5 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +5 -0
+                       resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
+
+                       nvmem-cells = <&qusb2p_hstx_trim>;
+               };
+
#3 lore raw

Re: [PATCH v2 1/1] arm64: dts: qcom: sc7180: Add USB related nodes

Quoted 16 lines · Stephen Boyd

Quoting Sandeep Maheswaram (2019-11-14 04:12:49)

Quoted 3 lines

Add nodes for DWC3 USB controller, QMP and QUSB PHYs.

One minor nit below.

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index 666e9b9..82f0b3a 100644
@@ -911,6 +924,98 @@
                         status = "disabled";
                 };
 
Quoted 9 lines

arch/arm64/boot/dts/qcom/sc7180.dtsi line 934

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +8 -0
+               usb_1_hsphy: phy@88e3000 {
+                       compatible = "qcom,sc7180-qusb2-phy";
+                       reg = <0 0x088e3000 0 0x400>;
+                       status = "disabled";
+                       #phy-cells = <0>;
+                       clocks = <&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>,
+                                <&rpmhcc RPMH_CXO_CLK>;
+                       clock-names = "cfg_ahb","ref";

Add a space after that comma please.

OK. Will do in next version.

Quoted 6 lines
Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +5 -0
+                       resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>;
+
+                       nvmem-cells = <&qusb2p_hstx_trim>;
+               };
+
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation