board: cm_fx6: Enable DM support for video, fix build error
PATCH 1/2 board: cm_fx6: Enable DM support for video, fix build error
From: Suniel Mahesh <[email protected]>
Enable driver model for Video to remove the following compile warning on CM-FX6 SOM based target:
===================== WARNING ====================== This board does not use CONFIG_DM_VIDEO Please update the board to use CONFIG_DM_VIDEO before the v2019.07 release.
====================================================
This change introduced build error as shown:
LD u-bootdrivers/built-in.o: In function ipu_displays_init' arm-linux-ld.bfd: BFD (GNU Binutils) 2.29.1 assertion fail elf32-arm.c:9509 Makefile:1621: recipe for target 'u-boot' failed
make: *** [u-boot] Error 1
The DM converted video driver calls ipu_displays_init in its probe, which inturn calls relevant board_video_skip. Defining ipu_displays_init in the board file fixes build error. Target was compile tested, build was clean.
--- board/compulab/cm_fx6/cm_fx6.c | 5 +++++ configs/cm_fx6_defconfig | 1 + 2 files changed, 6 insertions(+)
board/compulab/cm_fx6/cm_fx6.c +5 -0
@@ -146,6 +146,11 @@ int board_video_skip(void)static inline void cm_fx6_setup_display (void ) {}#endif /* CONFIG_VIDEO_IPUV3 */ +int ipu_displays_init (void ) +{ +return board_video_skip (); +} +#ifdef CONFIG_DWC_AHSATA static int cm_fx6_issd_gpios[] = { /* The order of the GPIOs in the array is important! */
configs/cm_fx6_defconfig +1 -0
@@ -86,4 +86,5 @@ CONFIG_USB_KEYBOARD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y CONFIG_VIDEO_IPUV3=y CONFIG_VIDEO=y +CONFIG_DM_VIDEO=y CONFIG_FDT_FIXUP_PARTITIONS=y
Signature · 1 line
2.7.4
PATCH 2/2 board: cm_fx6: Enable CONFIG_DM_ETH
From: Suniel Mahesh <[email protected]>
Enable CONFIG_DM_ETH to remove compile warning on CM-FX6 SOM based target:
===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release.
====================================================
--- configs/cm_fx6_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/cm_fx6_defconfig +1 -0
@@ -80,6 +80,7 @@ CONFIG_DM_REGULATOR=y CONFIG_SPI=y CONFIG_DM_SPI=y CONFIG_MXC_SPI=y +CONFIG_DM_ETH=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_KEYBOARD=y
Signature · 1 line
2.7.4
PATCH 2/2 board: cm_fx6: Enable CONFIG_DM_ETH
Quoted 9 lines
From: Suniel Mahesh <[email protected]> Enable
CONFIG_DM_ETHto remove compile warning on CM-FX6 SOM based target:
===================== WARNING ====================== This board does not useCONFIG_DM_ETH(Driver Model for Ethernet drivers). Please update the board to useCONFIG_DM_ETHbefore the v2020.07 release.
====================================================Signed-off-by Suniel Mahesh <[email protected]>
Applied to u-boot-imx, -next, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/2 board: cm_fx6: Enable DM support for video, fix build error
In reply to sunil.m at techveda.orgQuoted 17 lines
From: Suniel Mahesh <[email protected]>
Enable driver model for Video to remove the following
compile warning on CM-FX6 SOM based target:
===================== WARNING ======================
This board does not useCONFIG_DM_VIDEOPlease update
the board to useCONFIG_DM_VIDEObefore the v2019.07 release.
====================================================
This change introduced build error as shown:
LD u-bootdrivers/built-in.o: In functionipu_displays_init' arm-linux-ld.bfd: BFD (GNU Binutils) 2.29.1 assertion fail elf32-arm.c:9509 Makefile:1621: recipe for target 'u-boot' failed
make: *** [u-boot] Error 1
The DM converted video driver callsipu_displays_init
in its probe, which inturn calls relevantboard_video_skip. Definingipu_displays_initin the board file fixes build error. Target was compile tested, build was clean.
Quoted 1 line
Signed-off-by Suniel Mahesh <[email protected]>
Applied to u-boot-imx, -next, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================