Skip to contentSkip to conversation

net: dsa: ocelot: fix "should it be static?" warnings

PATCH In review Chen Wandun 3 participants 3 messages Nov 22, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: ocelot: fix "should it be static?" warnings

Fix following sparse warnings:
drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?

---
 drivers/net/dsa/ocelot/felix.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/dsa/ocelot/felix.c +2 -2
index 167e415..b7f9246 100644
@@ -348,8 +348,8 @@ static bool felix_rxtstamp(struct dsa_switch *ds, int port,
 	return false;
 }
 
-bool felix_txtstamp(struct dsa_switch *ds, int port,
-		    struct sk_buff *clone, unsigned int type)
+static bool felix_txtstamp(struct dsa_switch *ds, int port,
+			   struct sk_buff *clone, unsigned int type)
 {
 	struct ocelot *ocelot = ds->priv;
 	struct ocelot_port *ocelot_port = ocelot->ports[port];
Signature · 1 line
2.7.4
maintainer
#2 lore raw
In reply to Chen Wandun

From: Chen Wandun <[email protected]>
Date: Fri, 22 Nov 2019 20:32:45 +0800

Quoted 4 lines

Fix following sparse warnings:
drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?

Next time please indicate _explicitly_ which tree your patch is targetting, because especially in this case the change is only relevant for "net-next"

Also, please provide a proper Fixes: tag.