Skip to contentSkip to conversation

drivers:staging: sources for ST core

PATCH Pavan Savoy 2 participants 4 messages Mar 30, 2010 – Mar 31, 2010

lore
Share & tools
lore
#0 lore raw
Quoted 41 lines · Pavan Savoy

From: Pavan Savoy <[email protected]>
Subject: Re: [PATCH] drivers:staging: sources for ST core
To: [email protected]
Cc: "Marcel Holtmann" <[email protected]>, [email protected]
Date: Wednesday, 31 March, 2010, 4:11 AM
--- On Wed, 31/3/10, Pavan Savoy
<[email protected]>

Quoted 2 lines · wrote:

From: Pavan Savoy <[email protected]>
Subject: Re: [PATCH] drivers:staging: sources for ST

core

Quoted 1 line

To: "[email protected]"

<[email protected]>

Quoted 7 lines

Date: Wednesday, 31 March, 2010, 4:06 AM

Quoted 6 lines

From: Greg KH [[email protected]]
Sent: Wednesday, March 31, 2010 3:17 AM
To: Savoy, Pavan
Cc: Alan Cox; [email protected];
[email protected]
Subject: Re: [PATCH] drivers:staging: sources for

ST

Quoted 3 lines

core

Quoted 2 lines

On Wed, Mar 31, 2010 at 02:35:55AM +0530, Pavan

Savoy

Quoted 5 lines
Quoted 2 lines
Quoted 1 line · wrote:

So, something like the below is ok, I have

defined my

Quoted 2 lines

own pr_fmt,

Quoted 1 line

however default log level on my board is 7,

and

Quoted 9 lines

hence

Quoted 4 lines

pr_info is a bit

Quoted 1 line

more annoying than usual.

No, a driver should use dev_dbg() and other

dev_printk()

Quoted 3 lines

calls, not
pr_debug() or anything like that.

Quoted 11 lines
Quoted 1 line
Quoted 1 line

Please don't roll your own formats, use the ones

that

Quoted 3 lines

are

Quoted 2 lines

well defined
and uniquely describe your driver and device in

a

Quoted 4 lines

format

Quoted 2 lines

that the whole
kernel uses.

forgot lkml the last time..

Nope, I couldn't find any instance of struct device at all, I need that to use dev_dbg right ? - None of the tty_* structure accessible by ldiscs seems to have a reference to it.
Also I happened to look at other line discipline driver, if they have a smarter way of doing this, Nope - n_tty, n_hdlc, n_slip all seem to use plain old printks.

Any clues ??

Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

thanks,

greg k-h

Quoted 8 lines
Quoted 3 lines

      Your Mail works best with the New
Yahoo Optimized IE8. Get it NOW! http://downloads.yahoo.com/in/internetexplorer/

      Your Mail works best with the New
Yahoo Optimized IE8. Get it NOW! http://downloads.yahoo.com/in/internetexplorer/

Your Mail works best with the New Yahoo Optimized IE8. Get it NOW! http://downloads.yahoo.com/in/internetexplorer/

#1 lore raw
Quoted 66 lines · Pavan Savoy
Quoted 41 lines · Pavan Savoy

From: Pavan Savoy <[email protected]>
Subject: Re: [PATCH] drivers:staging: sources for ST core
To: [email protected]
Cc: "Marcel Holtmann" <[email protected]>, [email protected]
Date: Wednesday, 31 March, 2010, 4:11 AM
--- On Wed, 31/3/10, Pavan Savoy
<[email protected]>

Quoted 2 lines · wrote:

From: Pavan Savoy <[email protected]>
Subject: Re: [PATCH] drivers:staging: sources for ST

core

Quoted 1 line

To: "[email protected]"

<[email protected]>

Quoted 7 lines

Date: Wednesday, 31 March, 2010, 4:06 AM

Quoted 6 lines

From: Greg KH [[email protected]]
Sent: Wednesday, March 31, 2010 3:17 AM
To: Savoy, Pavan
Cc: Alan Cox; [email protected];
[email protected]
Subject: Re: [PATCH] drivers:staging: sources for

ST

Quoted 3 lines

core

Quoted 2 lines

On Wed, Mar 31, 2010 at 02:35:55AM +0530, Pavan

Savoy

Quoted 5 lines
Quoted 2 lines
Quoted 1 line · wrote:

So, something like the below is ok, I have

defined my

Quoted 2 lines

own pr_fmt,

Quoted 1 line

however default log level on my board is 7,

and

Quoted 9 lines

hence

Quoted 4 lines

pr_info is a bit

Quoted 1 line

more annoying than usual.

No, a driver should use dev_dbg() and other

dev_printk()

Quoted 3 lines

calls, not
pr_debug() or anything like that.

Quoted 11 lines
Quoted 1 line
Quoted 1 line

Please don't roll your own formats, use the ones

that

Quoted 3 lines

are

Quoted 2 lines

well defined
and uniquely describe your driver and device in

a

Quoted 4 lines

format

Quoted 2 lines

that the whole
kernel uses.

forgot lkml the last time..

Nope, I couldn't find any instance of struct device at all, I need that to use dev_dbg right ? - None of the tty_* structure accessible by ldiscs seems to have a reference to it.
Also I happened to look at other line discipline driver, if they have a smarter way of doing this, Nope - n_tty, n_hdlc, n_slip all seem to use plain old printks.

Quoted 1 line

Any clues ??

Sorry, you are correct, we only have a struct kref right now for tty core objects, not a struct device. So nevermind, this should be fine.

thanks,

greg k-h

#2 lore raw
Quoted 88 lines · Greg KH

From: Greg KH <[email protected]>
Subject: Re: [PATCH] drivers:staging: sources for ST core
To: "Pavan Savoy" <[email protected]>
Cc: "Marcel Holtmann" <[email protected]>, [email protected], [email protected]
Date: Wednesday, 31 March, 2010, 11:00 PM

Quoted 2 lines · Pavan Savoy

--- On Wed, 31/3/10, Pavan Savoy <[email protected]>

Quoted 3 lines · wrote:
Quoted 3 lines

From: Pavan Savoy <[email protected]>
Subject: Re: [PATCH] drivers:staging: sources for

ST core

Quoted 2 lines
Quoted 2 lines

To: [email protected]
Cc: "Marcel Holtmann" <[email protected]>,

[email protected]

Quoted 7 lines
Quoted 7 lines

Date: Wednesday, 31 March, 2010, 4:11 AM
--- On Wed, 31/3/10, Pavan Savoy
<[email protected]>

Quoted 2 lines · wrote:

From: Pavan Savoy <[email protected]>
Subject: Re: [PATCH] drivers:staging:

sources for ST

Quoted 6 lines
Quoted 6 lines

core

Quoted 1 line

To: "[email protected]"

<[email protected]>

Quoted 3 lines

Date: Wednesday, 31 March, 2010, 4:06 AM

Quoted 2 lines

From: Greg KH [[email protected]]
Sent: Wednesday, March 31, 2010 3:17

AM

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

To: Savoy, Pavan
Cc: Alan Cox; [email protected];
[email protected]
Subject: Re: [PATCH] drivers:staging:

sources for

Quoted 4 lines
Quoted 4 lines

ST

Quoted 3 lines

core

Quoted 2 lines

On Wed, Mar 31, 2010 at 02:35:55AM

+0530, Pavan

Quoted 3 lines
Quoted 3 lines

Savoy

Quoted 2 lines
Quoted 2 lines
Quoted 1 line · wrote:

So, something like the below is

ok, I have

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

defined my

Quoted 2 lines

own pr_fmt,

Quoted 1 line

however default log level on my

board is 7,

Quoted 6 lines
Quoted 6 lines

and

Quoted 5 lines

hence

Quoted 4 lines

pr_info is a bit

Quoted 1 line

more annoying than usual.

No, a driver should use dev_dbg() and

other

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

dev_printk()

Quoted 4 lines

calls, not
pr_debug() or anything like that.

Please don't roll your own formats, use

the ones

Quoted 4 lines
Quoted 4 lines

that

Quoted 3 lines

are

Quoted 2 lines

well defined
and uniquely describe your driver and

device in

Quoted 10 lines
Quoted 6 lines

a

Quoted 4 lines

format

Quoted 2 lines

that the whole
kernel uses.

forgot lkml the last time..

Nope, I couldn't find any instance of struct device at

all,

Quoted 1 line

I need that to use dev_dbg right ? - None of the

tty_*

Quoted 1 line

structure accessible by ldiscs seems to have a

reference to

Quoted 2 lines

it.
Also I happened to look at other line discipline

driver, if

Quoted 1 line

they have a smarter way of doing this, Nope - n_tty,

n_hdlc,

Quoted 8 lines
Quoted 3 lines

n_slip all seem to use plain old printks.

Any clues ??

Sorry, you are correct, we only have a struct kref right now for tty
core objects, not a struct device.  So nevermind, this should be fine.

Oh cool. Thanks, So that leaves me with 1 pending item from Alan which is to tie these 3 modules (KIM/Core/LL) up onto a TTY device specific context, and avoid all global ptrs.

So without that is it good to go in ?

Quoted 10 lines

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Your Mail works best with the New Yahoo Optimized IE8. Get it NOW! http://downloads.yahoo.com/in/internetexplorer/

#3 lore raw
Quoted 94 lines · Pavan Savoy
Quoted 92 lines · Greg KH

From: Greg KH <[email protected]>
Subject: Re: [PATCH] drivers:staging: sources for ST core
To: "Pavan Savoy" <[email protected]>
Cc: "Marcel Holtmann" <[email protected]>, [email protected], [email protected]
Date: Wednesday, 31 March, 2010, 11:00 PM

Quoted 2 lines · Pavan Savoy

--- On Wed, 31/3/10, Pavan Savoy <[email protected]>

Quoted 3 lines · wrote:
Quoted 3 lines

From: Pavan Savoy <[email protected]>
Subject: Re: [PATCH] drivers:staging: sources for

ST core

Quoted 2 lines
Quoted 2 lines

To: [email protected]
Cc: "Marcel Holtmann" <[email protected]>,

[email protected]

Quoted 7 lines
Quoted 7 lines

Date: Wednesday, 31 March, 2010, 4:11 AM
--- On Wed, 31/3/10, Pavan Savoy
<[email protected]>

Quoted 2 lines · wrote:

From: Pavan Savoy <[email protected]>
Subject: Re: [PATCH] drivers:staging:

sources for ST

Quoted 6 lines
Quoted 6 lines

core

Quoted 1 line

To: "[email protected]"

<[email protected]>

Quoted 3 lines

Date: Wednesday, 31 March, 2010, 4:06 AM

Quoted 2 lines

From: Greg KH [[email protected]]
Sent: Wednesday, March 31, 2010 3:17

AM

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

To: Savoy, Pavan
Cc: Alan Cox; [email protected];
[email protected]
Subject: Re: [PATCH] drivers:staging:

sources for

Quoted 4 lines
Quoted 4 lines

ST

Quoted 3 lines

core

Quoted 2 lines

On Wed, Mar 31, 2010 at 02:35:55AM

+0530, Pavan

Quoted 3 lines
Quoted 3 lines

Savoy

Quoted 2 lines
Quoted 2 lines
Quoted 1 line · wrote:

So, something like the below is

ok, I have

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

defined my

Quoted 2 lines

own pr_fmt,

Quoted 1 line

however default log level on my

board is 7,

Quoted 6 lines
Quoted 6 lines

and

Quoted 5 lines

hence

Quoted 4 lines

pr_info is a bit

Quoted 1 line

more annoying than usual.

No, a driver should use dev_dbg() and

other

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

dev_printk()

Quoted 4 lines

calls, not
pr_debug() or anything like that.

Please don't roll your own formats, use

the ones

Quoted 4 lines
Quoted 4 lines

that

Quoted 3 lines

are

Quoted 2 lines

well defined
and uniquely describe your driver and

device in

Quoted 10 lines
Quoted 6 lines

a

Quoted 4 lines

format

Quoted 2 lines

that the whole
kernel uses.

forgot lkml the last time..

Nope, I couldn't find any instance of struct device at

all,

Quoted 1 line

I need that to use dev_dbg right ? - None of the

tty_*

Quoted 1 line

structure accessible by ldiscs seems to have a

reference to

Quoted 2 lines

it.
Also I happened to look at other line discipline

driver, if

Quoted 1 line

they have a smarter way of doing this, Nope - n_tty,

n_hdlc,

Quoted 3 lines

n_slip all seem to use plain old printks.
?
Any clues ??

Quoted 8 lines
Quoted 4 lines

Sorry, you are correct, we only have a struct kref right now for tty
core objects, not a struct device.? So nevermind, this should be fine.

Oh cool. Thanks, So that leaves me with 1 pending item from Alan which is to tie these 3 modules (KIM/Core/LL) up onto a TTY device specific context, and avoid all global ptrs.

So without that is it good to go in ?

Yes, care to do that and resubmit?

thanks,

greg k-h