Skip to contentSkip to conversation

drm/amdgpu: should stop GFX ring in hw_fini

PATCH In review Monk Liu 2 participants 3 messages Nov 29, 2019

Subsystems (2)
lore
Share & tools
lore

Monk Liu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: should stop GFX ring in hw_fini

To align with the scheme from gfx9

disabling GFX ring after VM shutdown could avoid
garbage data be fetched to GFX RB which may lead
to unnecessary screw up on GFX

---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +1 -0
index 230e8af..882cf1f 100644
@@ -3809,6 +3809,7 @@ static int gfx_v10_0_hw_fini(void *handle)
 	if (amdgpu_gfx_disable_kcq(adev))
 		DRM_ERROR("KCQ disable failed\n");
 	if (amdgpu_sriov_vf(adev)) {
+		gfx_v10_0_cp_gfx_enable(adev, false);
 		pr_debug("For SRIOV client, shouldn't do anything.\n");
 		return 0;
 	}
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

The debug message after gfx disablement actually makes me confusing, would you mind to drop that. Other than that, the patch is

Regards,
Hawking
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Monk Liu
Sent: 2019年11月29日 16:28
To: [email protected]
Cc: Liu, Monk <[email protected]>
Subject: [PATCH] drm/amdgpu: should stop GFX ring in hw_fini

To align with the scheme from gfx9

disabling GFX ring after VM shutdown could avoid garbage data be fetched to GFX RB which may lead to unnecessary screw up on GFX

---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +1 -0
index 230e8af..882cf1f 100644
@@ -3809,6 +3809,7 @@ static int gfx_v10_0_hw_fini(void *handle)
 	if (amdgpu_gfx_disable_kcq(adev))
 		DRM_ERROR("KCQ disable failed\n");
 	if (amdgpu_sriov_vf(adev)) {
+		gfx_v10_0_cp_gfx_enable(adev, false);
 		pr_debug("For SRIOV client, shouldn't do anything.\n");
 		return 0;
 	}

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Chawking.zhang%40amd.com%7C5a80986d2a044f870b8708d774a5ffb9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637106128690538948&amp;sdata=Vl6AvsBF2nA7sc3eYDj0gVy2JkfhHgV2Jo78LwmgSSM%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

author Reviewed-by Hawking Zhang
#2 lore raw

okay

_____________________________________
Monk Liu|GPU Virtualization Team |AMD

-----Original Message-----
From: Zhang, Hawking <[email protected]>
Sent: Friday, November 29, 2019 5:10 PM
To: Liu, Monk <[email protected]>; [email protected]
Cc: Liu, Monk <[email protected]>
Subject: RE: [PATCH] drm/amdgpu: should stop GFX ring in hw_fini

[AMD Official Use Only - Internal Distribution Only]

The debug message after gfx disablement actually makes me confusing, would you mind to drop that. Other than that, the patch is

Regards,
Hawking
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Monk Liu
Sent: 2019年11月29日 16:28
To: [email protected]
Cc: Liu, Monk <[email protected]>
Subject: [PATCH] drm/amdgpu: should stop GFX ring in hw_fini

To align with the scheme from gfx9

disabling GFX ring after VM shutdown could avoid garbage data be fetched to GFX RB which may lead to unnecessary screw up on GFX

---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +1 -0
index 230e8af..882cf1f 100644
@@ -3809,6 +3809,7 @@ static int gfx_v10_0_hw_fini(void *handle)
 	if (amdgpu_gfx_disable_kcq(adev))
 		DRM_ERROR("KCQ disable failed\n");
 	if (amdgpu_sriov_vf(adev)) {
+		gfx_v10_0_cp_gfx_enable(adev, false);
 		pr_debug("For SRIOV client, shouldn't do anything.\n");
 		return 0;
 	}

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Chawking.zhang%40amd.com%7C5a80986d2a044f870b8708d774a5ffb9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637106128690538948&amp;sdata=Vl6AvsBF2nA7sc3eYDj0gVy2JkfhHgV2Jo78LwmgSSM%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx