Skip to contentSkip to conversation

ARM: dts: imx7s: Add power domain for imx7d HSIC

PATCH RESEND Applied Peter Chen 3 participants 3 messages Dec 3, 2019 – Feb 11, 2020

Subsystems (2)
lore
Share & tools
lore

Peter Chen

author
#0 lore raw

PATCH RESEND 1/1 ARM: dts: imx7s: Add power domain for imx7d HSIC

Otherwise, the system will hang if USB driver try to access portsc register.

Cc André Draszik <[email protected]>
---
 arch/arm/boot/dts/imx7s.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/imx7s.dtsi +7 -0
index c1a4fff5ceda..a5b380f530f8 100644
@@ -658,6 +658,12 @@
 						reg = <1>;
 						power-supply = <&reg_1p0d>;
 					};
+
+					pgc_hsic_phy: power-domain@2 {
+						#power-domain-cells = <0>;
+						reg = <2>;
+						power-supply = <&reg_1p2>;
+					};
 				};
 			};
 		};
@@ -1101,6 +1107,7 @@
 				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
 				reg = <0x30b30000 0x200>;
 				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
+				power-domains = <&pgc_hsic_phy>;
 				clocks = <&clks IMX7D_USB_CTRL_CLK>;
 				fsl,usbphy = <&usbphynop3>;
 				fsl,usbmisc = <&usbmisc3 0>;
Signature · 1 line
2.17.1
Tested-by on v1 1/1
#2 lore raw
In reply to Peter Chen
Quoted 27 lines · Peter Chen

Otherwise, the system will hang if USB driver try to access portsc register.

Cc André Draszik <[email protected]>
---
 arch/arm/boot/dts/imx7s.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/imx7s.dtsi +6 -0
index c1a4fff5ceda..a5b380f530f8 100644
@@ -658,6 +658,12 @@
 						reg = <1>;
 						power-supply = <&reg_1p0d>;
 					};
+
+					pgc_hsic_phy: power-domain@2 {
+						#power-domain-cells = <0>;
+						reg = <2>;
+						power-supply = <&reg_1p2>;
+					};
 				};
 			};
 		};

arch/arm/boot/dts/imx7s.dtsi line 1113

Quoted 7 lines
arch/arm/boot/dts/imx7s.dtsi +1 -0
@@ -1101,6 +1107,7 @@
 				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
 				reg = <0x30b30000 0x200>;
 				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
+				power-domains = <&pgc_hsic_phy>;
 				clocks = <&clks IMX7D_USB_CTRL_CLK>;
 				fsl,usbphy = <&usbphynop3>;
 				fsl,usbmisc = <&usbmisc3 0>;

It's a bit late now, but for completeness, with this patch applied the HSIC port works fine on my iMX7d board now.

Thanks Peter.

Cheers,
Andre'