Skip to contentSkip to conversation

glibc: fix ldconfig packaging issue

PATCH In review [email protected] 2 participants 4 messages Dec 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 glibc: fix ldconfig packaging issue

From: Ming Liu <[email protected]>

ldconfig should be prior to glibc-utils in PACKAGES variable, or else ldconfig binary would not be split to its own package, hence will lead to runtime issues for the packages that depending on ldconfig, like systemd.

---
 meta/recipes-core/glibc/glibc-package.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc-package.inc +1 -1
index 9dd5a0d..ede9e9b 100644
@@ -1,6 +1,6 @@
 INHIBIT_SYSROOT_STRIP = "1"
 
-PACKAGES = "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc ldconfig"
+PACKAGES = "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"
 
 # The ld.so in this glibc supports the GNU_HASH
 RPROVIDES_${PN} = "eglibc rtld(GNU_HASH)"
Signature · 1 line
2.7.4
#1 lore raw
Quoted 7 lines · On Tue, Dec 3, 2019 at 10:45 AM <[email protected]> wrote:

From: Ming Liu <[email protected]>

ldconfig should be prior to glibc-utils in PACKAGES variable, or else ldconfig binary would not be split to its own package, hence will lead to runtime issues for the packages that depending on ldconfig, like systemd.

hmmm perhaps FILES_ldconfig =+ would help ?

Quoted 26 lines
---
 meta/recipes-core/glibc/glibc-package.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/glibc/glibc-package.inc +1 -2
index 9dd5a0d..ede9e9b 100644
@@ -1,6 +1,6 @@
 INHIBIT_SYSROOT_STRIP = "1"
 
-PACKAGES = "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc ldconfig"
+PACKAGES = "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"
 
 # The ld.so in this glibc supports the GNU_HASH
 RPROVIDES_${PN} = "eglibc rtld(GNU_HASH)"
--

2.7.4

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#2 lore raw

Hi, Khem:

I don't think so, the problem is the package names in PACKAGES are being handled in package task in order, if ldconfig is after glibc-utils, and they both contains /sbin (or /usr/sbin for usermerge) path, then /sbin/ldconfig (or /usr/sbin/usermerge) would be split into glibc-utils.

It could be reproduced by enabling usermerge distro feature.

//Ming Liu

Khem Raj <[email protected]> 於 2019年12月3日 週二 下午9:16寫道:

Quoted 45 lines · On Tue, Dec 3, 2019 at 10:45 AM <[email protected]> wrote:
Quoted 7 lines

From: Ming Liu <[email protected]>

ldconfig should be prior to glibc-utils in PACKAGES variable, or else ldconfig binary would not be split to its own package, hence will lead to runtime issues for the packages that depending on ldconfig, like systemd.

hmmm perhaps FILES_ldconfig =+ would help ?

Review

Quoted 7 lines
---
 meta/recipes-core/glibc/glibc-package.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-core/glibc/glibc-package.inc

meta/recipes-core/glibc/glibc-package.inc line 3

Quoted 7 lines

index 9dd5a0d..ede9e9b 100644

meta/recipes-core/glibc/glibc-package.inc +0 -1
@@ -1,6 +1,6 @@
 INHIBIT_SYSROOT_STRIP = "1"
 
-PACKAGES = "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thread-db

${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc ldconfig"

meta/recipes-core/glibc/glibc-package.inc line 3

Quoted 1 line
meta/recipes-core/glibc/glibc-package.inc +1 -0
+PACKAGES = "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode

glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"

Quoted 11 lines
meta/recipes-core/glibc/glibc-package.inc +0 -1
 # The ld.so in this glibc supports the GNU_HASH
 RPROVIDES_${PN} = "eglibc rtld(GNU_HASH)"
--

2.7.4

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 9 lines · Ming Liu

Hi, Khem:

I don't think so, the problem is the package names in PACKAGES are being handled in package task in order, if ldconfig is after glibc-utils, and they both contains /sbin (or /usr/sbin for usermerge) path, then /sbin/ldconfig (or /usr/sbin/usermerge) would be split into glibc-utils.

It could be reproduced by enabling usermerge distro feature.

Yes no worries I see that we are defining PACKAGES variable there so this change is ok

Quoted 50 lines

//Ming Liu

Khem Raj <[email protected]> 於 2019年12月3日 週二 下午9:16寫道:

Quoted 45 lines · On Tue, Dec 3, 2019 at 10:45 AM <[email protected]> wrote:
Quoted 7 lines

From: Ming Liu <[email protected]>

ldconfig should be prior to glibc-utils in PACKAGES variable, or else ldconfig binary would not be split to its own package, hence will lead to runtime issues for the packages that depending on ldconfig, like systemd.

hmmm perhaps FILES_ldconfig =+ would help ?

Review

Quoted 7 lines
---
 meta/recipes-core/glibc/glibc-package.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-core/glibc/glibc-package.inc

meta/recipes-core/glibc/glibc-package.inc line 3

Quoted 7 lines

index 9dd5a0d..ede9e9b 100644

meta/recipes-core/glibc/glibc-package.inc +0 -1
@@ -1,6 +1,6 @@
 INHIBIT_SYSROOT_STRIP = "1"
 
-PACKAGES = "${PN}-dbg catchsegv sln nscd ldd tzcode glibc-thread-db

${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc ldconfig"

meta/recipes-core/glibc/glibc-package.inc line 3

Quoted 1 line
meta/recipes-core/glibc/glibc-package.inc +1 -0
+PACKAGES = "${PN}-dbg catchsegv sln nscd ldconfig ldd tzcode

glibc-thread-db ${PN}-pic libcidn libmemusage libnss-db libsegfault ${PN}-pcprofile libsotruss ${PN} ${PN}-utils glibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"

Quoted 11 lines
meta/recipes-core/glibc/glibc-package.inc +0 -1
 # The ld.so in this glibc supports the GNU_HASH
 RPROVIDES_${PN} = "eglibc rtld(GNU_HASH)"
--

2.7.4

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core