Skip to contentSkip to conversation

u-boot-fw-utils: Add capability of building from out-of-tree

PATCH Superseded Daisuke Yamane 3 participants 6 messages Dec 6, 2019 – Dec 10, 2019

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 u-boot-fw-utils: Add capability of building from out-of-tree

This patch also helps to build with EXTERNALSRC.

---
 meta/recipes-bsp/u-boot/u-boot-fw-utils_2020.01.bb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta/recipes-bsp/u-boot/u-boot-fw-utils_2020.01.bb +6 -6
index 04321b7..7de91ff 100644
@@ -12,22 +12,22 @@ EXTRA_OEMAKE_class-cross = 'HOSTCC="${CC} ${CFLAGS} ${LDFLAGS}" V=1'
 inherit uboot-config
 
 do_compile () {
-	oe_runmake ${UBOOT_MACHINE}
-	oe_runmake envtools
+	oe_runmake -C ${S} ${UBOOT_MACHINE} O=${B}
+	oe_runmake -C ${S} envtools         O=${B}
 }
 
 do_install () {
 	install -d ${D}${base_sbindir}
 	install -d ${D}${sysconfdir}
-	install -m 755 ${S}/tools/env/fw_printenv ${D}${base_sbindir}/fw_printenv
-	install -m 755 ${S}/tools/env/fw_printenv ${D}${base_sbindir}/fw_setenv
+	install -m 755 ${B}/tools/env/fw_printenv ${D}${base_sbindir}/fw_printenv
+	install -m 755 ${B}/tools/env/fw_printenv ${D}${base_sbindir}/fw_setenv
 	install -m 0644 ${S}/tools/env/fw_env.config ${D}${sysconfdir}/fw_env.config
 }
 
 do_install_class-cross () {
 	install -d ${D}${bindir_cross}
-	install -m 755 ${S}/tools/env/fw_printenv ${D}${bindir_cross}/fw_printenv
-	install -m 755 ${S}/tools/env/fw_printenv ${D}${bindir_cross}/fw_setenv
+	install -m 755 ${B}/tools/env/fw_printenv ${D}${bindir_cross}/fw_printenv
+	install -m 755 ${B}/tools/env/fw_printenv ${D}${bindir_cross}/fw_setenv
 }
 
 SYSROOT_DIRS_append_class-cross = " ${bindir_cross}"
Signature · 1 line
2.7.4
#2 lore raw
In reply to Daisuke Yamane
Quoted 1 line · Daisuke Yamane

This patch also helps to build with EXTERNALSRC.

As this doesn't actually set B, will you be sending a follow-up patch to set B so out-of-tree builds actually work?

Ross

#3 lore raw

2019年12月9日(月) 19:43 Ross Burton <[email protected]>:

Quoted 6 lines · Daisuke Yamane
Quoted 1 line

This patch also helps to build with EXTERNALSRC.

As this doesn't actually set B, will you be sending a follow-up patch to set B so out-of-tree builds actually work?

As there is EXTERNALSRC_BUILD in externalsrc.bbclass, I don't think the follow-up patch is necessary.

Quoted 7 lines

Ross
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw
Quoted 9 lines · 山根大典

2019年12月9日(月) 19:43 Ross Burton <[email protected]>:

Quoted 6 lines · Daisuke Yamane
Quoted 1 line

This patch also helps to build with EXTERNALSRC.

As this doesn't actually set B, will you be sending a follow-up patch to set B so out-of-tree builds actually work?

As there is EXTERNALSRC_BUILD in externalsrc.bbclass, I don't think the follow-up patch is necessary.

I mean in the general case, not specifically externalsrc.

Out-of-tree builds are fundamentally better than in-tree.

Ross

#5 lore raw

2019年12月10日(火) 19:39 Ross Burton <[email protected]>:

Quoted 7 lines · 山根大典
Quoted 5 lines

2019年12月9日(月) 19:43 Ross Burton <[email protected]>:

Quoted 4 lines · Daisuke Yamane
Quoted 1 line

This patch also helps to build with EXTERNALSRC.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

As this doesn't actually set B, will you be sending a follow-up patch to set B so out-of-tree builds actually work?

As there is EXTERNALSRC_BUILD in externalsrc.bbclass, I don't think the follow-up patch is necessary.

I mean in the general case, not specifically externalsrc.

Out-of-tree builds are fundamentally better than in-tree.

I got it what you mean!
OK, I'll send the patch.

Thank you for pointing it out.