soc: mediatek: cmdq: delete not used define
PATCH 1/1 soc: mediatek: cmdq: delete not used define
From: Matthias Brugger <[email protected]>
Define CMDQ_EOC_CMD was actually never used. Delete it.
Signed-off-by Matthias Brugger <[email protected]>
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 -- 1 file changed, 2 deletions(-)
drivers/soc/mediatek/mtk-cmdq-helper.c +0 -2
@@ -12,8 +12,6 @@#define CMDQ_ARG_A_WRITE_MASK 0xffff#define CMDQ_WRITE_ENABLE_MASK BIT(0)#define CMDQ_EOC_IRQ_EN BIT(0) -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \ - << 32 | CMDQ_EOC_IRQ_EN)static void cmdq_client_timeout (struct timer_list *t) {
Signature · 1 line
2.24.0
Quoted 5 lines · On Wed, 2019-12-11 at 19:59 +0100, [email protected] wrote:
From: Matthias Brugger <[email protected]>
Define
CMDQ_EOC_CMDwas actually never used. Delete it.Signed-off-by Matthias Brugger <[email protected]>
Thanks. :D
Reviewed-by Bibby Hsieh <[email protected]>
Quoted 19 lines
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 -- 1 file changed, 2 deletions(-)drivers/soc/mediatek/mtk-cmdq-helper.c +0
-2@@ -12,8 +12,6 @@#define CMDQ_ARG_A_WRITE_MASK 0xffff#define CMDQ_WRITE_ENABLE_MASK BIT(0)#define CMDQ_EOC_IRQ_EN BIT(0) -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \ - << 32 | CMDQ_EOC_IRQ_EN)static void cmdq_client_timeout (struct timer_list *t) {
Hi, Matthias:
Quoted 4 lines · On Wed, 2019-12-11 at 19:59 +0100, [email protected] wrote:
From: Matthias Brugger <[email protected]>
Define
CMDQ_EOC_CMDwas actually never used. Delete it.
Reviewed-by CK Hu <[email protected]>
Quoted 12 lines
Signed-off-by Matthias Brugger <[email protected]>---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 -- 1 file changed, 2 deletions(-)drivers/soc/mediatek/mtk-cmdq-helper.c +0
-0
drivers/soc/mediatek/mtk-cmdq-helper.c line 17
Quoted 8 lines
drivers/soc/mediatek/mtk-cmdq-helper.c +0
-2@@ -12,8 +12,6 @@#define CMDQ_ARG_A_WRITE_MASK 0xffff#define CMDQ_WRITE_ENABLE_MASK BIT(0)#define CMDQ_EOC_IRQ_EN BIT(0) -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \ - << 32 | CMDQ_EOC_IRQ_EN)static void cmdq_client_timeout (struct timer_list *t) {
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 6 lines · On 11/12/2019 19:59, [email protected] wrote:
From: Matthias Brugger <[email protected]>
Define
CMDQ_EOC_CMDwas actually never used. Delete it.Signed-off-by Matthias Brugger <[email protected]>
Applied to v5.5-next/soc
Thanks for the reviews!
Quoted 19 lines
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 -- 1 file changed, 2 deletions(-)drivers/soc/mediatek/mtk-cmdq-helper.c +0
-2@@ -12,8 +12,6 @@#define CMDQ_ARG_A_WRITE_MASK 0xffff#define CMDQ_WRITE_ENABLE_MASK BIT(0)#define CMDQ_EOC_IRQ_EN BIT(0) -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \ - << 32 | CMDQ_EOC_IRQ_EN)static void cmdq_client_timeout (struct timer_list *t) {