Skip to contentSkip to conversation

soc: mediatek: cmdq: delete not used define

PATCH Applied [email protected] 4 participants 4 messages Dec 11, 2019 – Dec 14, 2019 Arm MediaTek

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: mediatek: cmdq: delete not used define

From: Matthias Brugger <[email protected]>

Define CMDQ_EOC_CMD was actually never used. Delete it.

---

 drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
 1 file changed, 2 deletions(-)
drivers/soc/mediatek/mtk-cmdq-helper.c +0 -2
index 3c82de5f9417..1127c19c4e91 100644
@@ -12,8 +12,6 @@
 #define CMDQ_ARG_A_WRITE_MASK	0xffff
 #define CMDQ_WRITE_ENABLE_MASK	BIT(0)
 #define CMDQ_EOC_IRQ_EN		BIT(0)
-#define CMDQ_EOC_CMD		((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
-				<< 32 | CMDQ_EOC_IRQ_EN)
 
 static void cmdq_client_timeout(struct timer_list *t)
 {
Signature · 1 line
2.24.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Wed, 2019-12-11 at 19:59 +0100, [email protected] wrote:

From: Matthias Brugger <[email protected]>

Define CMDQ_EOC_CMD was actually never used. Delete it.

Thanks. :D

Quoted 19 lines

---

 drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
 1 file changed, 2 deletions(-)
drivers/soc/mediatek/mtk-cmdq-helper.c +0 -2
index 3c82de5f9417..1127c19c4e91 100644
@@ -12,8 +12,6 @@
 #define CMDQ_ARG_A_WRITE_MASK	0xffff
 #define CMDQ_WRITE_ENABLE_MASK	BIT(0)
 #define CMDQ_EOC_IRQ_EN		BIT(0)
-#define CMDQ_EOC_CMD		((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
-				<< 32 | CMDQ_EOC_IRQ_EN)
 
 static void cmdq_client_timeout(struct timer_list *t)
 {
Reviewed-by on v1 1/1
#2 lore raw
In reply to [email protected]

Hi, Matthias:

Quoted 4 lines · On Wed, 2019-12-11 at 19:59 +0100, [email protected] wrote:

From: Matthias Brugger <[email protected]>

Define CMDQ_EOC_CMD was actually never used. Delete it.

Quoted 12 lines

---

 drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
 1 file changed, 2 deletions(-)
drivers/soc/mediatek/mtk-cmdq-helper.c +0 -0
index 3c82de5f9417..1127c19c4e91 100644

drivers/soc/mediatek/mtk-cmdq-helper.c line 17

Quoted 8 lines
drivers/soc/mediatek/mtk-cmdq-helper.c +0 -2
@@ -12,8 +12,6 @@
 #define CMDQ_ARG_A_WRITE_MASK	0xffff
 #define CMDQ_WRITE_ENABLE_MASK	BIT(0)
 #define CMDQ_EOC_IRQ_EN		BIT(0)
-#define CMDQ_EOC_CMD		((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
-				<< 32 | CMDQ_EOC_IRQ_EN)
 
 static void cmdq_client_timeout(struct timer_list *t)
 {

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

maintainer Applied
#3 lore raw
In reply to [email protected]
Quoted 6 lines · On 11/12/2019 19:59, [email protected] wrote:

From: Matthias Brugger <[email protected]>

Define CMDQ_EOC_CMD was actually never used. Delete it.

Applied to v5.5-next/soc

Thanks for the reviews!

Quoted 19 lines

---

 drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
 1 file changed, 2 deletions(-)
drivers/soc/mediatek/mtk-cmdq-helper.c +0 -2
index 3c82de5f9417..1127c19c4e91 100644
@@ -12,8 +12,6 @@
 #define CMDQ_ARG_A_WRITE_MASK	0xffff
 #define CMDQ_WRITE_ENABLE_MASK	BIT(0)
 #define CMDQ_EOC_IRQ_EN		BIT(0)
-#define CMDQ_EOC_CMD		((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
-				<< 32 | CMDQ_EOC_IRQ_EN)
 
 static void cmdq_client_timeout(struct timer_list *t)
 {