pinctrl: samsung: Fix missing OF and GPIOLIB dependency on S3C24xx and S3C64xx
Subsystems (4)
Krzysztof Kozlowski
maintainerPATCH 1/1 pinctrl: samsung: Fix missing OF and GPIOLIB dependency on S3C24xx and S3C64xx
All Samsung pinctrl drivers select common part - PINCTRL_SAMSUNG which uses both OF and GPIOLIB inside. However only Exynos drivers depend on these, therefore after enabling COMPILE_TEST, on x86_64 build of S3C64xx driver failed:
drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpiolib_register’:
drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: ‘struct gpio_chip’ has no member named ‘of_node’
gc->of_node = bank->of_node;
^
Rework the dependencies so all Samsung drivers and common PINCTRL_SAMSUNG part depend on OF_GPIO (which is default yes if GPIOLIB and OF are enabled).
--- drivers/pinctrl/samsung/Kconfig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/pinctrl/samsung/Kconfig +4 -2
@@ -4,12 +4,13 @@ # config PINCTRL_SAMSUNG bool + depends on OF_GPIO select PINMUX select PINCONF config PINCTRL_EXYNOS bool "Pinctrl common driver part for Samsung Exynos SoCs" - depends on OF && GPIOLIB + depends on OF_GPIO depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST select PINCTRL_SAMSUNG select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210)
@@ -25,11 +26,12 @@ config PINCTRL_EXYNOS_ARM64 config PINCTRL_S3C24XX bool "Samsung S3C24XX SoC pinctrl driver" - depends on OF + depends on OF_GPIO depends on ARCH_S3C24XX || COMPILE_TEST select PINCTRL_SAMSUNG config PINCTRL_S3C64XX bool "Samsung S3C64XX SoC pinctrl driver" + depends on OF_GPIO depends on ARCH_S3C64XX || COMPILE_TEST select PINCTRL_SAMSUNG
Signature · 1 line
2.7.4
Quoted 10 lines · Krzysztof Kozlowski
All Samsung pinctrl drivers select common part -
PINCTRL_SAMSUNGwhich uses both OF and GPIOLIB inside. However only Exynos drivers depend on these, therefore after enablingCOMPILE_TEST, onx86_64build of S3C64xx driver failed:
drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpiolib_register’:
drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: ‘struct gpio_chip’ has no member named ‘of_node’
gc->of_node=bank->of_node;
^
Quoted 6 lines
Rework the dependencies so all Samsung drivers and common
PINCTRL_SAMSUNGpart depend onOF_GPIO(which is default yes if GPIOLIB and OF are enabled).Reported-by Chen Zhou <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
What should this be applied on? It doesn't apply to my fixes branch which is close to v5.5-rc1. Please rebase and resend if this was not based on that.
Should this have a Fixes: tag?
Yours,
Linus Walleij
Quoted 10 lines · Krzysztof Kozlowski
All Samsung pinctrl drivers select common part -
PINCTRL_SAMSUNGwhich uses both OF and GPIOLIB inside. However only Exynos drivers depend on these, therefore after enablingCOMPILE_TEST, onx86_64build of S3C64xx driver failed:
drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpiolib_register’:
drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: ‘struct gpio_chip’ has no member named ‘of_node’
gc->of_node=bank->of_node;
^
Quoted 8 lines
Rework the dependencies so all Samsung drivers and common
PINCTRL_SAMSUNGpart depend onOF_GPIO(which is default yes if GPIOLIB and OF are enabled).Reported-by Chen Zhou <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/pinctrl/samsung/Kconfig | 6 ++++--
Applied.
Best regards,
Krzysztof