Skip to contentSkip to conversation

arm64: dts: sc7180: Enable video node

PATCH In review Dikshita Agarwal 2 participants 3 messages Dec 17, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: sc7180: Enable video node

This is a preparation gerrit to enable video node for sc7180. This change depends on patch series Venus new features.

---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +28 -0
index 52a5861..ccf9ef5 100644
@@ -1297,6 +1297,34 @@
 
 			#freq-domain-cells = <1>;
 		};
+
+		venus: video-codec@aa00000 {
+			compatible = "qcom,sc7180-venus";
+			reg = <0 0x0aa00000 0 0xff000>;
+			interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+			power-domains = <&videocc VENUS_GDSC>,
+					<&videocc VCODEC0_GDSC>;
+
+			power-domain-names = "venus", "vcodec0";
+			clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
+				<&videocc VIDEO_CC_VENUS_AHB_CLK>,
+				<&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>,
+				<&videocc VIDEO_CC_VCODEC0_CORE_CLK>,
+				<&videocc VIDEO_CC_VCODEC0_AXI_CLK>;
+			clock-names = "core", "iface", "bus",
+					"vcodec0_core", "vcodec0_bus";
+			iommus = <&apps_smmu 0x0C00 0x60>;
+			memory-region = <&venus_mem>;
+			video-core0 {
+					compatible = "venus-decoder";
+			};
+			video-core1 {
+					compatible = "venus-encoder";
+			};
+			video-firmware {
+					iommus = <&apps_smmu 0x0C42 0x0>;
+			};
+		};
 	};
 
 	thermal-zones {
Signature · 1 line
1.9.1
#1 lore raw

Hi

Quoted 1 line · Dikshita Agarwal

This is a preparation gerrit to enable video node for sc7180.

gerrit is a code review tool, please change to something like "Add venus video codec node for sc7180"

Quoted 1 line

This change depends on patch series Venus new features.

Notes like this should not be part of the commit message, but put below '---'. It would also be good to include a link to the series, I suppose it's
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=213439

Quoted 10 lines
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index 52a5861..ccf9ef5 100644

arch/arm64/boot/dts/qcom/sc7180.dtsi line 1302

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +3 -0
@@ -1297,6 +1297,34 @@
 
 			#freq-domain-cells = <1>;
 		};
+
+		venus: video-codec@aa00000 {
+			compatible = "qcom,sc7180-venus";

This compatible string is not listed in the bindings (Documentation/devicetree/bindings/media/qcom,venus.txt), nor in the driver.

#2 lore raw
In reply to Dikshita Agarwal
Quoted 13 lines · Dikshita Agarwal

This is a preparation gerrit to enable video node for sc7180. This change depends on patch series Venus new features.

---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index 52a5861..ccf9ef5 100644

arch/arm64/boot/dts/qcom/sc7180.dtsi line 1301

Quoted 5 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +2 -0
@@ -1297,6 +1297,34 @@
 
 			#freq-domain-cells = <1>;
 		};
+
+		venus: video-codec@aa00000 {

Per convention nodes should be sorted by address, so this one should be between system-cache-controller@9200000 and thermal-sensor@c263000. If new nodes are always added to the end conflicts are virtually guaranteed, especially in the early phase of adding support for a SoC.