Skip to contentSkip to conversation

watchdog: cadence: Skip printing pointer value

PATCH In review Srinivas Neeli 2 participants 3 messages Dec 20, 2019 – Jan 4, 2020 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: cadence: Skip printing pointer value

"%p" is not printing the pointer value.
In driver, printing pointer value is not useful so avoiding print.

---
 drivers/watchdog/cadence_wdt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/watchdog/cadence_wdt.c +2 -3
index 06bd4e1a5923..672b184da875 100644
@@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev)
 		return ret;
 	platform_set_drvdata(pdev, wdt);
 
-	dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
-		 wdt->regs, cdns_wdt_device->timeout,
-		 nowayout ? ", nowayout" : "");
+	dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n",
+		 cdns_wdt_device->timeout, nowayout ? ", nowayout" : "");
 
 	return 0;
 }
Signature · 1 line
2.7.4
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Srinivas Neeli

"%p" is not printing the pointer value.
In driver, printing pointer value is not useful so avoiding print.

Quoted 23 lines
---
 drivers/watchdog/cadence_wdt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/watchdog/cadence_wdt.c +2 -3
index 06bd4e1a5923..672b184da875 100644
@@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev)
 		return ret;
 	platform_set_drvdata(pdev, wdt);
 
-	dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
-		 wdt->regs, cdns_wdt_device->timeout,
-		 nowayout ? ", nowayout" : "");
+	dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n",
+		 cdns_wdt_device->timeout, nowayout ? ", nowayout" : "");
 
 	return 0;
 }
Signature · 1 line
2.7.4
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Srinivas Neeli
Quoted 4 lines · Srinivas Neeli

"%p" is not printing the pointer value.
In driver, printing pointer value is not useful so avoiding print.

Quoted 21 lines
---
  drivers/watchdog/cadence_wdt.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/watchdog/cadence_wdt.c +2 -3
index 06bd4e1a5923..672b184da875 100644
@@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev)
  		return ret;
  	platform_set_drvdata(pdev, wdt);
 
-	dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
-		 wdt->regs, cdns_wdt_device->timeout,
-		 nowayout ? ", nowayout" : "");
+	dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n",
+		 cdns_wdt_device->timeout, nowayout ? ", nowayout" : "");
 
  	return 0;
  }