Skip to contentSkip to conversation

ath11k: fix ZERO address in probe request

PATCH In review Carl Huang 2 participants 2 messages Dec 20, 2019 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore

Carl Huang

author
#0 lore raw

PATCH 1/1 ath11k: fix ZERO address in probe request

Host needs to pass at least on bssid with all 0xff to firmware in WMI_START_SCAN_CMDID, otherwise the bssid and receiver address in probe requeste are all ZEROs.

This also fixed some hidden AP connection issue because some AP doesn't respond to probe request which receiver address are all ZEROs.

---
 drivers/net/wireless/ath/ath11k/wmi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/wireless/ath/ath11k/wmi.c +3 -0
index 4375e59..1a78002 100644
@@ -1842,6 +1842,9 @@ void ath11k_wmi_start_scan_init(struct ath11k *ar,
 				  WMI_SCAN_EVENT_DEQUEUED;
 	arg->scan_flags |= WMI_SCAN_CHAN_STAT_EVENT;
 	arg->num_bssid = 1;
+	/* fill bssid_list[0] with 0xff */
+	ether_addr_copy(arg->bssid_list[0].addr, "\xFF\xFF\xFF\xFF\xFF\xFF");
+
 }
 
 static inline void
Signature · 6 lines
2.7.4

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 18 lines · Carl Huang

Host needs to pass at least on bssid with all 0xff to firmware in WMI_START_SCAN_CMDID, otherwise the bssid and receiver address in probe requeste are all ZEROs.

This also fixed some hidden AP connection issue because some AP doesn't respond to probe request which receiver address are all ZEROs.

---
 drivers/net/wireless/ath/ath11k/wmi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/wireless/ath/ath11k/wmi.c +0 -0
index 4375e59..1a78002 100644

drivers/net/wireless/ath/ath11k/wmi.c void ath11k_wmi_start_scan_init(struct ath11k *ar, · line 1846

Quoted 5 lines
drivers/net/wireless/ath/ath11k/wmi.c +2 -0
@@ -1842,6 +1842,9 @@ void ath11k_wmi_start_scan_init(struct ath11k *ar,
 				  WMI_SCAN_EVENT_DEQUEUED;
 	arg->scan_flags |= WMI_SCAN_CHAN_STAT_EVENT;
 	arg->num_bssid = 1;
+	/* fill bssid_list[0] with 0xff */
+	ether_addr_copy(arg->bssid_list[0].addr, "\xFF\xFF\xFF\xFF\xFF\xFF");

The comment should explain _why_ you are doing that. It's clear from looking at the code that we are filling the address with 0xff but the reason for this unclear just from looking at the code.

Signature · 6 lines
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k