Skip to contentSkip to conversation

net/ipn3ke: fix line side statistics register read

PATCH Applied Andy Pei 3 participants 3 messages Dec 31, 2019 – Jan 3, 2020 Network drivers

lore
Share & tools
lore

Andy Pei

author
#0 lore raw

PATCH 1/1 net/ipn3ke: fix line side statistics register read

To read line side statistics register, eth_group_sel args in function ipn3ke_indirect_mac_read should be 0. When eth_group_sel is 1, the nic side register is read.

Fixes 5a6d883878db ("net/ipn3ke: implement statistics")

---
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

 drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipn3ke/ipn3ke_representor.c +1 -1
index 8d9ebef..80122e3 100644
@@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats)
 		&tmp,
 		IPN3KE_25G_TX_STATISTICS_STATUS,
 		port_id,
-		1);
+		0);
 	if (tmp & IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
 		tmp = 0x00000000;
 		(*hw->f_mac_read)(hw,
Signature · 1 line
1.8.3.1
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 40 lines

-----Original Message-----
From: Pei, Andy <[email protected]>
Sent: Tuesday, December 31, 2019 14:54
To: [email protected]
Cc: Pei, Andy <[email protected]>; [email protected]; Yigit, Ferruh <[email protected]>; Xu, Rosen <[email protected]>; Ye, Xiaolong <[email protected]>
Subject: [PATCH] net/ipn3ke: fix line side statistics register read

To read line side statistics register, eth_group_sel args in function ipn3ke_indirect_mac_read should be 0.
When eth_group_sel is 1, the nic side register is read.

Fixes 5a6d883878db ("net/ipn3ke: implement statistics")

---
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

 drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipn3ke/ipn3ke_representor.c +1 -1
index 8d9ebef..80122e3 100644
@@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats)
 		&tmp,
 		IPN3KE_25G_TX_STATISTICS_STATUS,
 		port_id,
-		1);
+		0);
 	if (tmp &
 IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
 		tmp = 0x00000000;
Quoted 3 lines

(*hw->f_mac_read)(hw,
--
1.8.3.1

Applied
#2 lore raw
In reply to Andy Pei
Quoted 33 lines · Andy Pei

To read line side statistics register, eth_group_sel args in function ipn3ke_indirect_mac_read should be 0. When eth_group_sel is 1, the nic side register is read.

Fixes 5a6d883878db ("net/ipn3ke: implement statistics")

---
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipn3ke/ipn3ke_representor.c +1 -1
index 8d9ebef..80122e3 100644
@@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats)
 		&tmp,
 		IPN3KE_25G_TX_STATISTICS_STATUS,
 		port_id,
-		1);
+		0);
 	if (tmp & IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
 		tmp = 0x00000000;
 		(*hw->f_mac_read)(hw,
Signature · 1 line
1.8.3.1

Applied to dpdk-next-net-intel, Thanks.